All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Dufresne <nicolas@ndufresne.ca>
To: Ming Qian <ming.qian@nxp.com>,
	"mchehab@kernel.org" <mchehab@kernel.org>,
	 "shawnguo@kernel.org" <shawnguo@kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	 "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
Cc: "hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>,
	 "kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	 dl-linux-imx <linux-imx@nxp.com>,
	Aisheng Dong <aisheng.dong@nxp.com>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [EXT] Re: [PATCH v12 00/13] amphion video decoder/encoder driver
Date: Thu, 25 Nov 2021 10:36:17 -0500	[thread overview]
Message-ID: <0deb3fa15dd162d7c7b6dbe24821fdf9523dddd3.camel@ndufresne.ca> (raw)
In-Reply-To: <AM6PR04MB6341F599A97253C1BA812467E7629@AM6PR04MB6341.eurprd04.prod.outlook.com>

Le jeudi 25 novembre 2021 à 05:25 +0000, Ming Qian a écrit :
> For test [JCT-VC-HEVC_V1] (GStreamer-H.265-V4L2-Gst1.0) VPSSPSPPS_A_MainConcept_1,
> The vpu report an unsupported message to driver, so driver report pollerr to gstreamer.
> But this stream can be decoded using the amphion vpu when I test it using our unit test,
> I checked the difference, there are many vps, sps and pps at the beginning, 
> gstreamer will skip the first vpu and two pps, totally skip 56 bytes. It leds to vpu can't decode
> And our unit test won't skip anthing, so the vpu can decode the stream.

This specific test triggers a bug in GStreamer HEVC parser, I'm aware of this
one, and it is on my todo to fix (just not as trivial as it looks like, the VCL
nal detection code was implemented wrong and that ended up leaking into the rest
of the design). This specific test will of course be marked and skipped for CI
test that uses GStreamer.

regards,
Nicolas


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Dufresne <nicolas@ndufresne.ca>
To: Ming Qian <ming.qian@nxp.com>,
	"mchehab@kernel.org" <mchehab@kernel.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
Cc: "hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	Aisheng Dong <aisheng.dong@nxp.com>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [EXT] Re: [PATCH v12 00/13] amphion video decoder/encoder driver
Date: Thu, 25 Nov 2021 10:36:17 -0500	[thread overview]
Message-ID: <0deb3fa15dd162d7c7b6dbe24821fdf9523dddd3.camel@ndufresne.ca> (raw)
In-Reply-To: <AM6PR04MB6341F599A97253C1BA812467E7629@AM6PR04MB6341.eurprd04.prod.outlook.com>

Le jeudi 25 novembre 2021 à 05:25 +0000, Ming Qian a écrit :
> For test [JCT-VC-HEVC_V1] (GStreamer-H.265-V4L2-Gst1.0) VPSSPSPPS_A_MainConcept_1,
> The vpu report an unsupported message to driver, so driver report pollerr to gstreamer.
> But this stream can be decoded using the amphion vpu when I test it using our unit test,
> I checked the difference, there are many vps, sps and pps at the beginning, 
> gstreamer will skip the first vpu and two pps, totally skip 56 bytes. It leds to vpu can't decode
> And our unit test won't skip anthing, so the vpu can decode the stream.

This specific test triggers a bug in GStreamer HEVC parser, I'm aware of this
one, and it is on my todo to fix (just not as trivial as it looks like, the VCL
nal detection code was implemented wrong and that ended up leaking into the rest
of the design). This specific test will of course be marked and skipped for CI
test that uses GStreamer.

regards,
Nicolas


  reply	other threads:[~2021-11-25 15:40 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-09  9:08 [PATCH v12 00/13] amphion video decoder/encoder driver Ming Qian
2021-11-09  9:08 ` Ming Qian
2021-11-09  9:09 ` [PATCH v12 01/13] dt-bindings: media: amphion: add amphion video codec bindings Ming Qian
2021-11-09  9:09   ` Ming Qian
2021-11-09  9:09 ` [PATCH v12 02/13] media:Add nv12mt_8l128 and nv12mt_10be_8l128 video format Ming Qian
2021-11-09  9:09   ` Ming Qian
2021-11-09  9:09 ` [PATCH v12 03/13] media: amphion: add amphion vpu device driver Ming Qian
2021-11-09  9:09   ` Ming Qian
2021-11-09  9:09 ` [PATCH v12 04/13] media: amphion: add vpu core driver Ming Qian
2021-11-09  9:09   ` Ming Qian
2021-11-09  9:09 ` [PATCH v12 05/13] media: amphion: implement vpu core communication based on mailbox Ming Qian
2021-11-09  9:09   ` Ming Qian
2021-11-09  9:09 ` [PATCH v12 06/13] media: amphion: add vpu v4l2 m2m support Ming Qian
2021-11-09  9:09   ` Ming Qian
2021-11-09  9:09 ` [PATCH v12 07/13] media: amphion: add v4l2 m2m vpu encoder stateful driver Ming Qian
2021-11-09  9:09   ` Ming Qian
2021-11-09  9:09 ` [PATCH v12 08/13] media: amphion: add v4l2 m2m vpu decoder " Ming Qian
2021-11-09  9:09   ` Ming Qian
2021-11-09  9:09 ` [PATCH v12 09/13] media: amphion: implement windsor encoder rpc interface Ming Qian
2021-11-09  9:09   ` Ming Qian
2021-11-09  9:09 ` [PATCH v12 10/13] media: amphion: implement malone decoder " Ming Qian
2021-11-09  9:09   ` Ming Qian
2021-11-09  9:09 ` [PATCH v12 11/13] ARM64: dts: freescale: imx8q: add imx vpu codec entries Ming Qian
2021-11-09  9:09   ` Ming Qian
2021-11-09  9:09 ` [PATCH v12 12/13] firmware: imx: scu-pd: imx8q: add vpu mu resources Ming Qian
2021-11-09  9:09   ` Ming Qian
2021-11-09  9:09 ` [PATCH v12 13/13] MAINTAINERS: add AMPHION VPU CODEC V4L2 driver entry Ming Qian
2021-11-09  9:09   ` Ming Qian
2021-11-09 15:46 ` [PATCH v12 00/13] amphion video decoder/encoder driver Nicolas Dufresne
2021-11-09 15:46   ` Nicolas Dufresne
2021-11-23 19:22 ` Nicolas Dufresne
2021-11-23 19:22   ` Nicolas Dufresne
2021-11-24  9:00   ` [EXT] " Ming Qian
2021-11-24  9:00     ` Ming Qian
2021-11-24 14:57     ` Nicolas Dufresne
2021-11-24 14:57       ` Nicolas Dufresne
2021-11-25  5:25       ` Ming Qian
2021-11-25  5:25         ` Ming Qian
2021-11-25 15:36         ` Nicolas Dufresne [this message]
2021-11-25 15:36           ` Nicolas Dufresne
2021-11-26  6:31           ` Ming Qian
2021-11-26  6:31             ` Ming Qian
2021-12-03  4:09             ` Nicolas Dufresne
2021-12-03  4:09               ` Nicolas Dufresne
2021-12-03  5:20               ` Ming Qian
2021-12-03  5:20                 ` Ming Qian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0deb3fa15dd162d7c7b6dbe24821fdf9523dddd3.camel@ndufresne.ca \
    --to=nicolas@ndufresne.ca \
    --cc=aisheng.dong@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=ming.qian@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.