From: Johannes Berg <johannes@sipsolutions.net>
To: Wen Gong <quic_wgong@quicinc.com>,
linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [PATCH 04/15] mac80211: make channel context code MLO-aware
Date: Tue, 14 Feb 2023 09:04:41 +0100 [thread overview]
Message-ID: <0e889e3be774aced1813152b18d505c0616fc110.camel@sipsolutions.net> (raw)
In-Reply-To: <34121f87-4aa6-7f20-fb1e-4d5b02d06f28@quicinc.com>
On Tue, 2023-02-14 at 15:57 +0800, Wen Gong wrote:
>
> > void rate_control_rate_update(struct ieee80211_local *local,
> > - struct ieee80211_supported_band *sband,
> > - struct sta_info *sta, u32 changed)
> > + struct ieee80211_supported_band *sband,
> > + struct sta_info *sta, unsigned int link_id,
> > + u32 changed)
> > {
> > struct rate_control_ref *ref = local->rate_ctrl;
> > struct ieee80211_sta *ista = &sta->sta;
> > void *priv_sta = sta->rate_ctrl_priv;
> > struct ieee80211_chanctx_conf *chanctx_conf;
> >
> > + WARN_ON(link_id != 0);
> > +
> > if (ref && ref->ops->rate_update) {
> > rcu_read_lock();
> >
>
> Why link_id must = 0 here?
>
The whole software rate scaling hasn't been adjusted for MLO yet.
johannes
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Wen Gong <quic_wgong@quicinc.com>,
linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [PATCH 04/15] mac80211: make channel context code MLO-aware
Date: Tue, 14 Feb 2023 09:04:41 +0100 [thread overview]
Message-ID: <0e889e3be774aced1813152b18d505c0616fc110.camel@sipsolutions.net> (raw)
In-Reply-To: <34121f87-4aa6-7f20-fb1e-4d5b02d06f28@quicinc.com>
On Tue, 2023-02-14 at 15:57 +0800, Wen Gong wrote:
>
> > void rate_control_rate_update(struct ieee80211_local *local,
> > - struct ieee80211_supported_band *sband,
> > - struct sta_info *sta, u32 changed)
> > + struct ieee80211_supported_band *sband,
> > + struct sta_info *sta, unsigned int link_id,
> > + u32 changed)
> > {
> > struct rate_control_ref *ref = local->rate_ctrl;
> > struct ieee80211_sta *ista = &sta->sta;
> > void *priv_sta = sta->rate_ctrl_priv;
> > struct ieee80211_chanctx_conf *chanctx_conf;
> >
> > + WARN_ON(link_id != 0);
> > +
> > if (ref && ref->ops->rate_update) {
> > rcu_read_lock();
> >
>
> Why link_id must = 0 here?
>
The whole software rate scaling hasn't been adjusted for MLO yet.
johannes
next prev parent reply other threads:[~2023-02-14 8:04 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 7:39 [PATCH 00/15] mac80211 MLO updates Johannes Berg
2022-06-01 7:39 ` [PATCH 01/15] mac80211: split bss_info_changed method Johannes Berg
2022-06-01 19:31 ` Jeff Johnson
2022-06-01 19:39 ` Johannes Berg
2022-10-18 8:47 ` Wen Gong
2022-10-18 8:47 ` Wen Gong
2022-10-18 8:47 ` Wen Gong
2022-10-18 8:50 ` Johannes Berg
2022-10-18 8:50 ` Johannes Berg
2022-10-18 8:50 ` Johannes Berg
2022-10-18 8:52 ` Wen Gong
2022-10-18 8:52 ` Wen Gong
2022-10-18 8:52 ` Wen Gong
2022-10-18 8:53 ` Johannes Berg
2022-10-18 8:53 ` Johannes Berg
2022-10-18 8:53 ` Johannes Berg
2022-10-18 9:50 ` Wen Gong
2022-10-18 9:50 ` Wen Gong
2022-10-18 9:50 ` Wen Gong
2022-10-18 9:51 ` Johannes Berg
2022-10-18 9:51 ` Johannes Berg
2022-10-18 9:51 ` Johannes Berg
2022-10-18 10:10 ` Wen Gong
2022-10-18 10:10 ` Wen Gong
2022-10-18 10:10 ` Wen Gong
2022-10-19 4:32 ` Wen Gong
2022-10-19 4:32 ` Wen Gong
2022-10-19 4:32 ` Wen Gong
2022-12-15 15:04 ` Wen Gong
2022-12-15 15:04 ` Wen Gong
2022-12-15 15:04 ` Wen Gong
2022-06-01 7:39 ` [PATCH 02/15] mac80211: add per-link configuration pointer Johannes Berg
2022-06-01 7:39 ` [PATCH 03/15] mac80211: pass link ID where already present Johannes Berg
2022-06-01 7:39 ` [PATCH 04/15] mac80211: make channel context code MLO-aware Johannes Berg
2023-02-14 7:57 ` Wen Gong
2023-02-14 7:57 ` Wen Gong
2023-02-14 8:04 ` Johannes Berg [this message]
2023-02-14 8:04 ` Johannes Berg
2023-02-14 8:09 ` Wen Gong
2023-02-14 8:09 ` Wen Gong
2023-02-14 8:13 ` Johannes Berg
2023-02-14 8:13 ` Johannes Berg
2022-06-01 7:39 ` [PATCH 05/15] mac80211: remove sta_info_tx_streams() Johannes Berg
2022-06-01 7:39 ` [PATCH 06/15] mac80211: refactor some sta_info link handling Johannes Berg
2022-06-01 7:39 ` [PATCH 07/15] mac80211: use IEEE80211_MLD_MAX_NUM_LINKS Johannes Berg
2022-06-01 7:39 ` [PATCH 08/15] mac80211: validate some driver features for MLO Johannes Berg
2022-06-01 7:39 ` [PATCH 09/15] mac80211: refactor some link setup code Johannes Berg
2022-06-01 7:39 ` [PATCH 10/15] mac80211: add link_id to vht.c code for MLO Johannes Berg
2022-06-01 7:39 ` [PATCH 11/15] mac80211: add link_id to eht.c " Johannes Berg
2022-06-01 7:39 ` [PATCH 12/15] mac80211: HT: make ieee80211_ht_cap_ie_to_sta_ht_cap() MLO-aware Johannes Berg
2022-06-01 7:39 ` [PATCH 13/15] mac80211: make some SMPS code MLD-aware Johannes Berg
2022-06-01 7:39 ` [PATCH 14/15] mac80211: make ieee80211_he_cap_ie_to_sta_he_cap() MLO-aware Johannes Berg
2022-06-01 7:39 ` [PATCH 15/15] mac80211: correct link config data in tracing Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e889e3be774aced1813152b18d505c0616fc110.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_wgong@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.