From: "Valdis Klētnieks" <valdis.kletnieks@vt.edu> To: Ian Pilcher <arequipeno@gmail.com> Cc: linux-block@vger.kernel.org, linux-leds@vger.kernel.org, axboe@kernel.dk, pavel@ucw.cz, linux-kernel@vger.kernel.org, kernelnewbies@kernelnewbies.org Subject: Re: [RFC PATCH 1/8] docs: Add block device LED trigger documentation Date: Wed, 28 Jul 2021 23:09:15 -0400 [thread overview] Message-ID: <108629.1627528155@turing-police> (raw) In-Reply-To: <20210729015344.3366750-2-arequipeno@gmail.com> [-- Attachment #1: Type: text/plain, Size: 672 bytes --] On Wed, 28 Jul 2021 20:53:37 -0500, Ian Pilcher said: > +Create a new block device LED trigger:: > + > + # echo foo > /sys/class/block/led_trigger_new > + > +The name must be unique among all LED triggers (not just block device LED > +triggers). > + > +Create two more:: > + > + # echo bar baz > /sys/class/block/led_trigger_new > + # cat /sys/class/block/led_trigger_list > + baz: 0 > + bar: 0 > + foo: 0 This looks like an abuse of the "one entry one value" rule for sysfs. Perhaps this should be a directory /sys/class/block/defined_triggers/ and separate files under that for foo, bar, and baz? That would probably make reference counting a lot easier as well.... [-- Attachment #2: Type: application/pgp-signature, Size: 494 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Valdis Klētnieks" <valdis.kletnieks@vt.edu> To: Ian Pilcher <arequipeno@gmail.com> Cc: axboe@kernel.dk, kernelnewbies@kernelnewbies.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, pavel@ucw.cz, linux-leds@vger.kernel.org Subject: Re: [RFC PATCH 1/8] docs: Add block device LED trigger documentation Date: Wed, 28 Jul 2021 23:09:15 -0400 [thread overview] Message-ID: <108629.1627528155@turing-police> (raw) In-Reply-To: <20210729015344.3366750-2-arequipeno@gmail.com> [-- Attachment #1.1: Type: text/plain, Size: 672 bytes --] On Wed, 28 Jul 2021 20:53:37 -0500, Ian Pilcher said: > +Create a new block device LED trigger:: > + > + # echo foo > /sys/class/block/led_trigger_new > + > +The name must be unique among all LED triggers (not just block device LED > +triggers). > + > +Create two more:: > + > + # echo bar baz > /sys/class/block/led_trigger_new > + # cat /sys/class/block/led_trigger_list > + baz: 0 > + bar: 0 > + foo: 0 This looks like an abuse of the "one entry one value" rule for sysfs. Perhaps this should be a directory /sys/class/block/defined_triggers/ and separate files under that for foo, bar, and baz? That would probably make reference counting a lot easier as well.... [-- Attachment #1.2: Type: application/pgp-signature, Size: 494 bytes --] [-- Attachment #2: Type: text/plain, Size: 170 bytes --] _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
next prev parent reply other threads:[~2021-07-29 3:09 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-29 1:53 [RFC PATCH 0/8] Add configurable block device LED triggers Ian Pilcher 2021-07-29 1:53 ` Ian Pilcher 2021-07-29 1:53 ` [RFC PATCH 1/8] docs: Add block device LED trigger documentation Ian Pilcher 2021-07-29 1:53 ` Ian Pilcher 2021-07-29 3:09 ` Valdis Klētnieks [this message] 2021-07-29 3:09 ` Valdis Klētnieks 2021-07-29 15:52 ` Ian Pilcher 2021-07-29 15:52 ` Ian Pilcher 2021-07-30 5:22 ` Greg KH 2021-07-30 5:22 ` Greg KH 2021-07-29 5:53 ` Greg KH 2021-07-29 5:53 ` Greg KH 2021-07-29 11:59 ` Marek Behún 2021-07-29 11:59 ` Marek Behún 2021-07-29 18:03 ` Ian Pilcher 2021-07-29 18:03 ` Ian Pilcher 2021-07-29 1:53 ` [RFC PATCH 2/8] block: Add block device LED trigger list Ian Pilcher 2021-07-29 1:53 ` Ian Pilcher 2021-07-29 3:14 ` Valdis Klētnieks 2021-07-29 3:14 ` Valdis Klētnieks 2021-07-29 15:55 ` Ian Pilcher 2021-07-29 15:55 ` Ian Pilcher 2021-07-29 1:53 ` [RFC PATCH 3/8] block: Add kernel APIs to create & delete block device LED triggers Ian Pilcher 2021-07-29 1:53 ` Ian Pilcher 2021-07-29 3:45 ` Valdis Klētnieks 2021-07-29 3:45 ` Valdis Klētnieks 2021-07-29 16:16 ` Ian Pilcher 2021-07-29 16:16 ` Ian Pilcher 2021-07-29 5:52 ` Greg KH 2021-07-29 5:52 ` Greg KH 2021-07-29 1:53 ` [RFC PATCH 4/8] block: Add block class attributes to manage LED trigger list Ian Pilcher 2021-07-29 1:53 ` Ian Pilcher 2021-07-29 5:54 ` Greg KH 2021-07-29 5:54 ` Greg KH 2021-07-29 1:53 ` [RFC PATCH 5/8] block: Add block device LED trigger info to struct genhd Ian Pilcher 2021-07-29 1:53 ` Ian Pilcher 2021-07-29 1:53 ` [RFC PATCH 6/8] block: Add kernel APIs to set & clear per-block device LED triggers Ian Pilcher 2021-07-29 1:53 ` Ian Pilcher 2021-07-29 1:53 ` [RFC PATCH 7/8] block: Add block device attributes to set & clear " Ian Pilcher 2021-07-29 1:53 ` Ian Pilcher 2021-07-29 1:53 ` [RFC PATCH 8/8] block: Blink device LED when request is sent to low-level driver Ian Pilcher 2021-07-29 1:53 ` Ian Pilcher 2021-07-29 8:54 ` [RFC PATCH 0/8] Add configurable block device LED triggers Pavel Machek 2021-07-29 8:54 ` Pavel Machek 2021-07-29 17:03 ` Ian Pilcher 2021-07-29 17:03 ` Ian Pilcher 2021-07-29 18:35 ` Pavel Machek 2021-07-29 18:35 ` Pavel Machek 2021-07-29 19:14 ` Ian Pilcher 2021-07-29 19:14 ` Ian Pilcher
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=108629.1627528155@turing-police \ --to=valdis.kletnieks@vt.edu \ --cc=arequipeno@gmail.com \ --cc=axboe@kernel.dk \ --cc=kernelnewbies@kernelnewbies.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-leds@vger.kernel.org \ --cc=pavel@ucw.cz \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.