All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>,
	Mike Lothian <mike@fireburn.co.uk>,
	Agustin Gutierrez <agustin.gutierrez@amd.com>
Cc: amd-gfx@lists.freedesktop.org,
	Harry Wentland <Harry.Wentland@amd.com>,
	Sunpeng.Li@amd.com, Bhawanpreet.Lakha@amd.com,
	Rodrigo.Siqueira@amd.com, "Pillai,
	Aurabindo" <Aurabindo.Pillai@amd.com>,
	qingqing.zhuo@amd.com, "Lipski, Mikita" <mikita.lipski@amd.com>,
	Roman Li <roman.li@amd.com>,
	Anson.Jacob@amd.com, Wayne Lin <wayne.lin@amd.com>,
	stylon.wang@amd.com, solomon.chiu@amd.com, pavle.kotarac@amd.com,
	Eric Yang <Eric.Yang2@amd.com>
Subject: Re: [PATCH 16/27] drm/amd/display: increase Z9 latency to workaround underflow in Z9
Date: Tue, 19 Oct 2021 00:57:18 +0200	[thread overview]
Message-ID: <111325f7-3c66-3d0c-64b4-be092c65f074@molgen.mpg.de> (raw)
In-Reply-To: <3f1dee31-dfb0-3fb2-d647-9b6bf344a7e9@amd.com>

Dear Nicholas, dear Eric, dear Augustin,


Am 18.10.21 um 19:14 schrieb Kazlauskas, Nicholas:
> On 2021-10-15 7:53 p.m., Mike Lothian wrote:
>> This patch seems to change z8 - not that I know what z8 or z9 are
> 
> It's a little misleading but the patch and terminology is correct.
> 
> Z9 is the usecase for these watermarks even if the calculation is shared 
> with Z8/Z9.

It’d be great to have that in the commit message.


Kind regards,

Paul

>> On Fri, 15 Oct 2021 at 19:44, Agustin Gutierrez wrote:
>>>
>>> From: Eric Yang <Eric.Yang2@amd.com>
>>>
>>> [Why]
>>> Z9 latency is higher than when we originally tuned the watermark
>>> parameters, causing underflow. Increasing the value until the latency
>>> issues is resolved.
>>>
>>> Reviewed-by: Nicholas Kazlauskas <Nicholas.Kazlauskas@amd.com>
>>> Acked-by: Agustin Gutierrez Sanchez <agustin.gutierrez@amd.com>
>>> Signed-off-by: Eric Yang <Eric.Yang2@amd.com>
>>> ---
>>>   drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c 
>>> b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
>>> index c9d3d691f4c6..12ebd9f8912f 100644
>>> --- a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
>>> +++ b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
>>> @@ -222,8 +222,8 @@ struct _vcs_dpi_soc_bounding_box_st dcn3_1_soc = {
>>>          .num_states = 5,
>>>          .sr_exit_time_us = 9.0,
>>>          .sr_enter_plus_exit_time_us = 11.0,
>>> -       .sr_exit_z8_time_us = 402.0,
>>> -       .sr_enter_plus_exit_z8_time_us = 520.0,
>>> +       .sr_exit_z8_time_us = 442.0,
>>> +       .sr_enter_plus_exit_z8_time_us = 560.0,
>>>          .writeback_latency_us = 12.0,
>>>          .dram_channel_width_bytes = 4,
>>>          .round_trip_ping_latency_dcfclk_cycles = 106,
>>> -- 
>>> 2.25.1
>>>
> 

  reply	other threads:[~2021-10-18 22:57 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-15 18:43 [PATCH 00/27] DC Patchset for October 15 Agustin Gutierrez
2021-10-15 18:43 ` [PATCH 01/27] drm/amd/display: Disable dpp root clock when not being used Agustin Gutierrez
2021-10-15 18:43 ` [PATCH 02/27] drm/amd/display: Clear encoder assignment for copied streams Agustin Gutierrez
2021-10-15 18:43 ` [PATCH 03/27] drm/amd/display: Do not skip link training on DP quick hot plug Agustin Gutierrez
2021-10-15 18:43 ` [PATCH 04/27] drm/amd/display: add DP2.0 debug option to set MST_EN for SST stream Agustin Gutierrez
2021-10-15 18:43 ` [PATCH 05/27] drm/amd/display: Clean Up VPG Low Mem Power Agustin Gutierrez
2021-10-15 18:43 ` [PATCH 06/27] drm/amd/display: do not compare integers of different widths Agustin Gutierrez
2021-10-15 18:43 ` [PATCH 07/27] drm/amd/display: correct apg audio channel enable golden value Agustin Gutierrez
2021-10-15 18:43 ` [PATCH 08/27] drm/amd/display: Validate plane rects before use Agustin Gutierrez
2021-10-15 18:43 ` [PATCH 09/27] drm/amd/display: Removed power down on boot from DCN31 Agustin Gutierrez
2021-10-15 18:43 ` [PATCH 10/27] drm/amd/display: Limit display scaling to up to true 4k for DCN 3.1 Agustin Gutierrez
2021-10-15 18:43 ` [PATCH 11/27] drm/amd/display: Fix DP2 SE and LE SYMCLK selection for B0 PHY Agustin Gutierrez
2021-10-15 18:43 ` [PATCH 12/27] drm/amd/display: Fix prefetch bandwidth calculation for DCN3.1 Agustin Gutierrez
2021-10-15 18:43 ` [PATCH 13/27] drm/amd/display: Add missing PSR state Agustin Gutierrez
2021-10-15 18:43 ` [PATCH 14/27] drm/amd/display: Disable dsc root clock when not being used Agustin Gutierrez
2021-10-15 18:43 ` [PATCH 15/27] drm/amd/display: Require immediate flip support for DCN3.1 planes Agustin Gutierrez
2021-10-15 18:43 ` [PATCH 16/27] drm/amd/display: increase Z9 latency to workaround underflow in Z9 Agustin Gutierrez
2021-10-15 23:53   ` Mike Lothian
2021-10-18 17:14     ` Kazlauskas, Nicholas
2021-10-18 22:57       ` Paul Menzel [this message]
2021-10-15 18:43 ` [PATCH 17/27] drm/amd/display: Increase watermark latencies for DCN3.1 Agustin Gutierrez
2021-10-18 22:56   ` Paul Menzel
2021-10-15 18:43 ` [PATCH 18/27] drm/amd/display: Disable dpstreamclk, symclk32_se, and symclk32_le Agustin Gutierrez
2021-10-15 18:43 ` [PATCH 19/27] drm/amd/display: Removed z10 save after dsc disable Agustin Gutierrez
2021-10-15 18:43 ` [PATCH 20/27] drm/amd/display: Moved dccg init to after bios golden init Agustin Gutierrez
2021-10-15 18:43 ` [PATCH 21/27] drm/amd/display: Disable hdmistream and hdmichar clocks Agustin Gutierrez
2021-10-15 18:43 ` [PATCH 22/27] drm/amd/display: Change initializer to single brace Agustin Gutierrez
2021-10-15 18:43 ` [PATCH 23/27] drm/amd/display: 3.2.157 Agustin Gutierrez
2021-10-15 18:43 ` [PATCH 24/27] drm/amd/display: Add bios parser support for latest firmware_info Agustin Gutierrez
2021-10-15 18:43 ` [PATCH 25/27] drm/amd/display: [FW Promotion] Release 0.0.88 Agustin Gutierrez
2021-10-15 18:43 ` [PATCH 26/27] Revert "drm/amd/display: Fix error in dmesg at boot" Agustin Gutierrez
2021-10-18 23:23   ` Paul Menzel
2021-10-15 18:43 ` [PATCH 27/27] Revert "drm/amd/display: Add helper for blanking all dp displays" Agustin Gutierrez
2021-10-18 23:25   ` Paul Menzel
2021-10-18 17:01 ` [PATCH 00/27] DC Patchset for October 15 Wheeler, Daniel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=111325f7-3c66-3d0c-64b4-be092c65f074@molgen.mpg.de \
    --to=pmenzel@molgen.mpg.de \
    --cc=Anson.Jacob@amd.com \
    --cc=Aurabindo.Pillai@amd.com \
    --cc=Bhawanpreet.Lakha@amd.com \
    --cc=Eric.Yang2@amd.com \
    --cc=Harry.Wentland@amd.com \
    --cc=Rodrigo.Siqueira@amd.com \
    --cc=Sunpeng.Li@amd.com \
    --cc=agustin.gutierrez@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=mike@fireburn.co.uk \
    --cc=mikita.lipski@amd.com \
    --cc=nicholas.kazlauskas@amd.com \
    --cc=pavle.kotarac@amd.com \
    --cc=qingqing.zhuo@amd.com \
    --cc=roman.li@amd.com \
    --cc=solomon.chiu@amd.com \
    --cc=stylon.wang@amd.com \
    --cc=wayne.lin@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.