Re: NAK new drivers without proper power management?

[Nigel Cunningham <nigel@nigel.suspend2.net>]

Hi.

On Sun, 2007-02-11 at 01:44 +0100, Rafael J. Wysocki wrote:
> > Well, it's probably more acceptable than silently doing nothing and the 
> > device failing or locking up the machine on resume, but I couldn't agree 
> > more that it's not what we want to be encouraging. Perfect may be the 
> > enemy of the good, but "works except no power management" is hardly what 
> > I would call good these days, more like pretty sloppy..
> 
> I think there are situations in which it can be justified, like:
> - The driver is not entirely finished, but we want to merge it early, because
> of many potential users,
> - The driver has only a few users who aren't interested in the suspend/resume
> functionality,

How do you determine that? How many users have to want suspend/resume
functionality before you say "Ok. It has to be done now"?

> - The device is undocumented and we don't know how to make it handle the
> suspend/resume (we may learn that in the future or not).

If we know how to initialise/cleanup, we know a good portion of what is
needed for suspend/resume. Sure, for some video chipsets, you need more
(you need to know how to reprogram the whole thing after S3), but
they're the exception. Yes, there are other cases. But on the whole,
we're not talking about esoteric knowledge.

Regards,

Nigel