From: John Rose <johnrose@austin.ibm.com> To: Jan-Bernd Themann <ossthema@de.ibm.com> Cc: Jeff Garzik <jeff@garzik.org>, Christoph Raisch <RAISCH@de.ibm.com>, Jan-Bernd Themann <themann@de.ibm.com>, linux-kernel <linux-kernel@vger.kernel.org>, linux-ppc <linuxppc-dev@ozlabs.org>, Marcus Eder <MEDER@de.ibm.com>, Thomas Klein <tklein@de.ibm.com>, stefan.roscher@de.ibm.com, netdev <netdev@vger.kernel.org>, Nathan Fontenot <nfont@austin.ibm.com> Subject: Re: [PATCH 2.6.21-rc1] ehea: dynamic add / remove port Date: Fri, 16 Feb 2007 09:51:29 -0600 [thread overview] Message-ID: <1171641089.9442.8.camel@sinatra.austin.ibm.com> (raw) In-Reply-To: <200702161606.52789.ossthema@de.ibm.com> Hi- Sounds good. A couple of questions/comments: > I think it is not necessary to have a special entry/kobject for each logical > port. I suggest we use SET_NETDEV_DEV to create links to all ethernet devices > that represent each a logical port. This should be in sync with all other > ethernet drivers. Port attributes like the "logical port id" that might be > need by the userspace application can be added to the net:ethX entry > (link created with SET_NETDEV_DEV) as additional attributes. As we develop the userspace tool, we are finding a need to know the following for each logical port: 1) the linux interface/device (a symlink would do this) 2) the logical port number - were you suggesting communicating this through the name of the symlink, or in the directory of the symlink target? 3) the open firmware path for the logical port. This is typically communicated through a sysfs attribute file "devspec", but we can't do this without a new kobject for the port. > > > > Second, the probe and remove functions do not communicate whether an add > > or remove was successful. Combine this with the lack of port > > information in the adapter sysfs directory, and the userspace tool has > > no way of verifying a dynamic add/remove. > > True. I suggest we return error codes (-EIO / -EINVAL) in case the adding > or removing of ports fails. This is possible as we know instantly if the > operation failed or not. It is a synchronus operation. Sounds good. Thanks! John
WARNING: multiple messages have this Message-ID (diff)
From: John Rose <johnrose@austin.ibm.com> To: Jan-Bernd Themann <ossthema@de.ibm.com> Cc: Thomas Klein <tklein@de.ibm.com>, Jeff Garzik <jeff@garzik.org>, Jan-Bernd Themann <themann@de.ibm.com>, netdev <netdev@vger.kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>, linux-ppc <linuxppc-dev@ozlabs.org>, Christoph Raisch <RAISCH@de.ibm.com>, Marcus Eder <MEDER@de.ibm.com>, stefan.roscher@de.ibm.com Subject: Re: [PATCH 2.6.21-rc1] ehea: dynamic add / remove port Date: Fri, 16 Feb 2007 09:51:29 -0600 [thread overview] Message-ID: <1171641089.9442.8.camel@sinatra.austin.ibm.com> (raw) In-Reply-To: <200702161606.52789.ossthema@de.ibm.com> Hi- Sounds good. A couple of questions/comments: > I think it is not necessary to have a special entry/kobject for each logical > port. I suggest we use SET_NETDEV_DEV to create links to all ethernet devices > that represent each a logical port. This should be in sync with all other > ethernet drivers. Port attributes like the "logical port id" that might be > need by the userspace application can be added to the net:ethX entry > (link created with SET_NETDEV_DEV) as additional attributes. As we develop the userspace tool, we are finding a need to know the following for each logical port: 1) the linux interface/device (a symlink would do this) 2) the logical port number - were you suggesting communicating this through the name of the symlink, or in the directory of the symlink target? 3) the open firmware path for the logical port. This is typically communicated through a sysfs attribute file "devspec", but we can't do this without a new kobject for the port. > > > > Second, the probe and remove functions do not communicate whether an add > > or remove was successful. Combine this with the lack of port > > information in the adapter sysfs directory, and the userspace tool has > > no way of verifying a dynamic add/remove. > > True. I suggest we return error codes (-EIO / -EINVAL) in case the adding > or removing of ports fails. This is possible as we know instantly if the > operation failed or not. It is a synchronus operation. Sounds good. Thanks! John
next prev parent reply other threads:[~2007-02-16 15:54 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2007-02-14 14:36 [PATCH 2.6.21-rc1] ehea: dynamic add / remove port Jan-Bernd Themann 2007-02-14 14:36 ` Jan-Bernd Themann 2007-02-14 22:25 ` John Rose 2007-02-14 22:25 ` John Rose 2007-02-15 17:04 ` John Rose 2007-02-15 17:04 ` John Rose 2007-02-16 15:06 ` Jan-Bernd Themann 2007-02-16 15:06 ` Jan-Bernd Themann 2007-02-16 15:51 ` John Rose [this message] 2007-02-16 15:51 ` John Rose
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1171641089.9442.8.camel@sinatra.austin.ibm.com \ --to=johnrose@austin.ibm.com \ --cc=MEDER@de.ibm.com \ --cc=RAISCH@de.ibm.com \ --cc=jeff@garzik.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@ozlabs.org \ --cc=netdev@vger.kernel.org \ --cc=nfont@austin.ibm.com \ --cc=ossthema@de.ibm.com \ --cc=stefan.roscher@de.ibm.com \ --cc=themann@de.ibm.com \ --cc=tklein@de.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.