From: Steve Grubb <sgrubb@redhat.com>
To: linux-audit@redhat.com, Enzo Matsumiya <ematsumiya@suse.de>
Subject: Re: [PATCH] auditd: fix missing space with enriched log format
Date: Tue, 14 Sep 2021 23:32:00 -0400 [thread overview]
Message-ID: <11826656.O9o76ZdvQC@x2> (raw)
In-Reply-To: <20210915015548.8515-1-ematsumiya@suse.de>
On Tuesday, September 14, 2021 9:55:48 PM EDT Enzo Matsumiya wrote:
> When audit.log is opened with cat or less, for example, with log format
> = ENRICHED, there's no space between data and the enriched part, only
> AUDIT_INTERP_SEPARATOR (0x1d):
This is by design.
> type=USER_CMD msg=audit(1631669179.082:2403): ... res=success'UID="enzo"
> AUID="unset" ^ (0x1d)
>
> sep_done should be checked if it's 1 as well, so a space is added before
> the first enriched field.
Why?
Thanks,
-Steve
> Signed-off-by: Enzo Matsumiya <ematsumiya@suse.de>
> ---
> src/auditd-event.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/auditd-event.c b/src/auditd-event.c
> index 788c44a08197..636553187279 100644
> --- a/src/auditd-event.c
> +++ b/src/auditd-event.c
> @@ -365,7 +365,7 @@ static int add_simple_field(auparse_state_t *au, size_t
> len_left, int encode)
>
> // Setup pointer
> ptr = &format_buf[FORMAT_BUF_LEN - len_left];
> - if (sep_done > 1) {
> + if (sep_done >= 1) {
> *ptr = ' ';
> ptr++;
> num = 1;
--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit
next prev parent reply other threads:[~2021-09-15 3:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 1:55 [PATCH] auditd: fix missing space with enriched log format Enzo Matsumiya
2021-09-15 3:32 ` Steve Grubb [this message]
2021-09-15 14:52 ` Enzo Matsumiya
2021-09-15 17:44 ` Steve Grubb
2021-09-15 17:55 ` Enzo Matsumiya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11826656.O9o76ZdvQC@x2 \
--to=sgrubb@redhat.com \
--cc=ematsumiya@suse.de \
--cc=linux-audit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.