From: Steve Grubb <sgrubb@redhat.com>
To: Enzo Matsumiya <ematsumiya@suse.de>
Cc: linux-audit@redhat.com
Subject: Re: [PATCH] auditd: fix missing space with enriched log format
Date: Wed, 15 Sep 2021 13:44:52 -0400 [thread overview]
Message-ID: <9990430.nUPlyArG6x@x2> (raw)
In-Reply-To: <20210915145228.2wz3s7ok7eggdujj@cyberdelia>
On Wednesday, September 15, 2021 10:52:28 AM EDT Enzo Matsumiya wrote:
> On 09/14, Steve Grubb wrote:
> >On Tuesday, September 14, 2021 9:55:48 PM EDT Enzo Matsumiya wrote:
> >> When audit.log is opened with cat or less, for example, with log format
> >> = ENRICHED, there's no space between data and the enriched part, only
> >
> >> AUDIT_INTERP_SEPARATOR (0x1d):
> >This is by design.
>
> I understand that, and the patch doesn't break it.
>
> >> type=USER_CMD msg=audit(1631669179.082:2403): ... res=success'UID="enzo"
> >> AUID="unset" ^ (0x1d)
> >>
> >> sep_done should be checked if it's 1 as well, so a space is added before
> >> the first enriched field.
> >
> >Why?
>
> Some people still rely on opening audit.log with tools that are not aware
> of the log format.
There is another log format, RAW, which should be suitable for the old tools.
Also, I don't understand what problems that causes. You haven't exactly
explained what the problem is and why this is needed. The ENRICHED format has
been documented for over 5 years. Plenty of time for tools to become aware.
> As far as I could test, the change is only cosmetic, as I expected. I did a
> basic test with ausearch and it was ok.
>
> Please clarify if you expect anything else to be affected by this
> change.
Without more context, I am reluctant to change a documented standard that has
existed for over 5 years.
https://github.com/linux-audit/audit-documentation/wiki/SPEC-Audit-Event-Enrichment
-Steve
--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit
next prev parent reply other threads:[~2021-09-15 17:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 1:55 [PATCH] auditd: fix missing space with enriched log format Enzo Matsumiya
2021-09-15 3:32 ` Steve Grubb
2021-09-15 14:52 ` Enzo Matsumiya
2021-09-15 17:44 ` Steve Grubb [this message]
2021-09-15 17:55 ` Enzo Matsumiya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9990430.nUPlyArG6x@x2 \
--to=sgrubb@redhat.com \
--cc=ematsumiya@suse.de \
--cc=linux-audit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.