From: Richard Henderson <richard.henderson@linaro.org>
To: Joelle van Dyne <j@getutm.app>, qemu-devel@nongnu.org
Cc: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>,
"open list:RISC-V TCG target" <qemu-riscv@nongnu.org>,
Stefan Weil <sw@weilnetz.de>,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
"open list:S390 TCG target" <qemu-s390x@nongnu.org>,
"open list:AArch64 TCG target" <qemu-arm@nongnu.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Huacai Chen <chenhc@lemote.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
Aurelien Jarno <aurelien@aurel32.net>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH v2 5/9] tcg: add const hints for code pointers
Date: Mon, 19 Oct 2020 16:27:18 -0700 [thread overview]
Message-ID: <11912dd5-2740-1d7c-c691-1174fa7ef390@linaro.org> (raw)
In-Reply-To: <20201019013928.72770-6-j@getutm.app>
On 10/18/20 6:39 PM, Joelle van Dyne wrote:
> From: osy <osy86@users.noreply.github.com>
>
> We will introduce mirror mapping for JIT segment with separate RX and RW
> access. Adding 'const' hints will make it easier to identify read-only
> accesses and allow us to easier catch bugs at compile time in the future.
>
> Signed-off-by: Joelle van Dyne <j@getutm.app>
> ---
> include/tcg/tcg.h | 8 ++++----
> tcg/tcg.c | 4 ++--
> tcg/aarch64/tcg-target.c.inc | 19 +++++++++++--------
> tcg/arm/tcg-target.c.inc | 12 +++++++-----
> tcg/i386/tcg-target.c.inc | 10 +++++-----
> tcg/mips/tcg-target.c.inc | 33 +++++++++++++++++++--------------
> tcg/ppc/tcg-target.c.inc | 21 +++++++++++++--------
> tcg/riscv/tcg-target.c.inc | 11 ++++++-----
> tcg/s390/tcg-target.c.inc | 9 +++++----
> tcg/sparc/tcg-target.c.inc | 10 +++++-----
> tcg/tcg-ldst.c.inc | 2 +-
> tcg/tci/tcg-target.c.inc | 2 +-
> 12 files changed, 79 insertions(+), 62 deletions(-)
tcg/ppc/tcg-target.c.inc:2349:26: error: assignment discards ‘const’ qualifier
from pointer target type [-Werror]
s->code_gen_epilogue = tb_ret_addr = s->code_ptr;
How many of the targets did you build?
r~
WARNING: multiple messages have this Message-ID (diff)
From: Richard Henderson <richard.henderson@linaro.org>
To: Joelle van Dyne <j@getutm.app>, qemu-devel@nongnu.org
Cc: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>,
"open list:RISC-V TCG target" <qemu-riscv@nongnu.org>,
Stefan Weil <sw@weilnetz.de>,
"open list:S390 TCG target" <qemu-s390x@nongnu.org>,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
"open list:AArch64 TCG target" <qemu-arm@nongnu.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Huacai Chen <chenhc@lemote.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
Aurelien Jarno <aurelien@aurel32.net>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH v2 5/9] tcg: add const hints for code pointers
Date: Mon, 19 Oct 2020 16:27:18 -0700 [thread overview]
Message-ID: <11912dd5-2740-1d7c-c691-1174fa7ef390@linaro.org> (raw)
In-Reply-To: <20201019013928.72770-6-j@getutm.app>
On 10/18/20 6:39 PM, Joelle van Dyne wrote:
> From: osy <osy86@users.noreply.github.com>
>
> We will introduce mirror mapping for JIT segment with separate RX and RW
> access. Adding 'const' hints will make it easier to identify read-only
> accesses and allow us to easier catch bugs at compile time in the future.
>
> Signed-off-by: Joelle van Dyne <j@getutm.app>
> ---
> include/tcg/tcg.h | 8 ++++----
> tcg/tcg.c | 4 ++--
> tcg/aarch64/tcg-target.c.inc | 19 +++++++++++--------
> tcg/arm/tcg-target.c.inc | 12 +++++++-----
> tcg/i386/tcg-target.c.inc | 10 +++++-----
> tcg/mips/tcg-target.c.inc | 33 +++++++++++++++++++--------------
> tcg/ppc/tcg-target.c.inc | 21 +++++++++++++--------
> tcg/riscv/tcg-target.c.inc | 11 ++++++-----
> tcg/s390/tcg-target.c.inc | 9 +++++----
> tcg/sparc/tcg-target.c.inc | 10 +++++-----
> tcg/tcg-ldst.c.inc | 2 +-
> tcg/tci/tcg-target.c.inc | 2 +-
> 12 files changed, 79 insertions(+), 62 deletions(-)
tcg/ppc/tcg-target.c.inc:2349:26: error: assignment discards ‘const’ qualifier
from pointer target type [-Werror]
s->code_gen_epilogue = tb_ret_addr = s->code_ptr;
How many of the targets did you build?
r~
next prev parent reply other threads:[~2020-10-19 23:31 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 1:39 [PATCH v2 0/9] iOS and Apple Silicon host support Joelle van Dyne
2020-10-19 1:39 ` [PATCH v2 1/9] configure: option to disable host block devices Joelle van Dyne
2020-10-19 1:39 ` [PATCH v2 2/9] configure: cross-compiling without cross_prefix Joelle van Dyne
2020-10-19 8:07 ` Thomas Huth
2020-10-19 8:09 ` Thomas Huth
2020-10-19 11:24 ` BALATON Zoltan via
2020-10-19 22:24 ` Joelle van Dyne
2020-10-20 5:15 ` Thomas Huth
2020-10-20 8:34 ` Paolo Bonzini
2020-10-25 19:24 ` Joelle van Dyne
2020-10-26 7:54 ` Paolo Bonzini
2020-10-26 15:33 ` Joelle van Dyne
2020-10-26 16:15 ` Paolo Bonzini
2020-10-26 18:51 ` Thomas Huth
2020-10-19 1:39 ` [PATCH v2 3/9] qemu: add support for iOS host Joelle van Dyne
2020-10-19 1:39 ` [PATCH v2 4/9] coroutine: add libucontext as external library Joelle van Dyne
2020-10-19 1:39 ` [PATCH v2 5/9] tcg: add const hints for code pointers Joelle van Dyne
2020-10-19 1:39 ` Joelle van Dyne
2020-10-19 23:19 ` Richard Henderson
2020-10-19 23:19 ` Richard Henderson
2020-10-19 23:26 ` Joelle van Dyne
2020-10-19 23:27 ` Richard Henderson [this message]
2020-10-19 23:27 ` Richard Henderson
2020-10-19 23:36 ` Joelle van Dyne
2020-10-19 23:41 ` Richard Henderson
2020-10-19 1:39 ` [PATCH v2 6/9] tcg: implement mirror mapped JIT for iOS Joelle van Dyne
2020-10-19 1:39 ` Joelle van Dyne
2020-10-19 11:48 ` BALATON Zoltan via
2020-10-19 11:48 ` BALATON Zoltan
2020-10-19 22:39 ` Joelle van Dyne
2020-10-19 23:45 ` BALATON Zoltan via
2020-10-20 0:19 ` Richard Henderson
2020-10-25 19:46 ` Joelle van Dyne
2020-10-25 20:51 ` Joelle van Dyne
2020-10-25 23:43 ` Alexander Bulekov
2020-10-19 1:39 ` [PATCH v2 7/9] tcg: mirror mapping RWX pages for iOS optional Joelle van Dyne
2020-10-20 1:27 ` Richard Henderson
2020-10-19 1:39 ` [PATCH v2 8/9] tcg: support JIT on Apple Silicon Joelle van Dyne
2020-10-19 1:39 ` [PATCH v2 9/9] block: check availablity for preadv/pwritev on mac Joelle van Dyne
2020-10-19 8:27 ` Thomas Huth
2020-10-19 22:20 ` Joelle van Dyne
2020-10-20 5:19 ` Thomas Huth
2020-10-19 8:29 ` [PATCH v2 0/9] iOS and Apple Silicon host support Thomas Huth
2020-10-26 15:30 ` Joelle van Dyne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11912dd5-2740-1d7c-c691-1174fa7ef390@linaro.org \
--to=richard.henderson@linaro.org \
--cc=Alistair.Francis@wdc.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=aleksandar.rikalo@syrmia.com \
--cc=aurelien@aurel32.net \
--cc=chenhc@lemote.com \
--cc=j@getutm.app \
--cc=palmer@dabbelt.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.