* [PATCH 0/1] vdpa: Make ncs autofree
@ 2022-02-14 19:34 Eugenio Pérez
2022-02-14 19:34 ` [PATCH 1/1] " Eugenio Pérez
0 siblings, 1 reply; 6+ messages in thread
From: Eugenio Pérez @ 2022-02-14 19:34 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Jason Wang, Michael S. Tsirkin
Trivial patch extracted from [1] series. It helps to simplify the memory
management of the function when adding exit paths following the qemu
guidelines.
Thanks!
[1] https://patchwork.kernel.org/project/qemu-devel/patch/20220121202733.404989-30-eperezma@redhat.com/
Eugenio Pérez (1):
vdpa: Make ncs autofree
net/vhost-vdpa.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
--
2.27.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] vdpa: Make ncs autofree
2022-02-14 19:34 [PATCH 0/1] vdpa: Make ncs autofree Eugenio Pérez
@ 2022-02-14 19:34 ` Eugenio Pérez
2022-02-14 22:14 ` Philippe Mathieu-Daudé via
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Eugenio Pérez @ 2022-02-14 19:34 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Jason Wang, Michael S. Tsirkin
Simplifying memory management.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
net/vhost-vdpa.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index 4125d13118..4befba5cc7 100644
--- a/net/vhost-vdpa.c
+++ b/net/vhost-vdpa.c
@@ -264,7 +264,8 @@ int net_init_vhost_vdpa(const Netdev *netdev, const char *name,
{
const NetdevVhostVDPAOptions *opts;
int vdpa_device_fd;
- NetClientState **ncs, *nc;
+ g_autofree NetClientState **ncs = NULL;
+ NetClientState *nc;
int queue_pairs, i, has_cvq = 0;
assert(netdev->type == NET_CLIENT_DRIVER_VHOST_VDPA);
@@ -302,7 +303,6 @@ int net_init_vhost_vdpa(const Netdev *netdev, const char *name,
goto err;
}
- g_free(ncs);
return 0;
err:
@@ -310,7 +310,6 @@ err:
qemu_del_net_client(ncs[0]);
}
qemu_close(vdpa_device_fd);
- g_free(ncs);
return -1;
}
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] vdpa: Make ncs autofree
2022-02-14 19:34 ` [PATCH 1/1] " Eugenio Pérez
@ 2022-02-14 22:14 ` Philippe Mathieu-Daudé via
2022-02-15 3:04 ` Jason Wang
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé via @ 2022-02-14 22:14 UTC (permalink / raw)
To: Eugenio Pérez, qemu-devel
Cc: qemu-trivial, Jason Wang, Michael S. Tsirkin
On 14/2/22 20:34, Eugenio Pérez wrote:
> Simplifying memory management.
>
> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> ---
> net/vhost-vdpa.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] vdpa: Make ncs autofree
2022-02-14 19:34 ` [PATCH 1/1] " Eugenio Pérez
2022-02-14 22:14 ` Philippe Mathieu-Daudé via
@ 2022-02-15 3:04 ` Jason Wang
2022-02-16 8:41 ` Stefano Garzarella
2022-02-22 0:34 ` Laurent Vivier
3 siblings, 0 replies; 6+ messages in thread
From: Jason Wang @ 2022-02-15 3:04 UTC (permalink / raw)
To: Eugenio Pérez; +Cc: qemu-trivial, qemu-devel, Michael S. Tsirkin
On Tue, Feb 15, 2022 at 3:34 AM Eugenio Pérez <eperezma@redhat.com> wrote:
>
> Simplifying memory management.
>
> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
> ---
> net/vhost-vdpa.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
> index 4125d13118..4befba5cc7 100644
> --- a/net/vhost-vdpa.c
> +++ b/net/vhost-vdpa.c
> @@ -264,7 +264,8 @@ int net_init_vhost_vdpa(const Netdev *netdev, const char *name,
> {
> const NetdevVhostVDPAOptions *opts;
> int vdpa_device_fd;
> - NetClientState **ncs, *nc;
> + g_autofree NetClientState **ncs = NULL;
> + NetClientState *nc;
> int queue_pairs, i, has_cvq = 0;
>
> assert(netdev->type == NET_CLIENT_DRIVER_VHOST_VDPA);
> @@ -302,7 +303,6 @@ int net_init_vhost_vdpa(const Netdev *netdev, const char *name,
> goto err;
> }
>
> - g_free(ncs);
> return 0;
>
> err:
> @@ -310,7 +310,6 @@ err:
> qemu_del_net_client(ncs[0]);
> }
> qemu_close(vdpa_device_fd);
> - g_free(ncs);
>
> return -1;
> }
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] vdpa: Make ncs autofree
2022-02-14 19:34 ` [PATCH 1/1] " Eugenio Pérez
2022-02-14 22:14 ` Philippe Mathieu-Daudé via
2022-02-15 3:04 ` Jason Wang
@ 2022-02-16 8:41 ` Stefano Garzarella
2022-02-22 0:34 ` Laurent Vivier
3 siblings, 0 replies; 6+ messages in thread
From: Stefano Garzarella @ 2022-02-16 8:41 UTC (permalink / raw)
To: Eugenio Pérez
Cc: qemu-trivial, Jason Wang, qemu-devel, Michael S. Tsirkin
On Mon, Feb 14, 2022 at 08:34:15PM +0100, Eugenio Pérez wrote:
>Simplifying memory management.
>
>Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
>---
> net/vhost-vdpa.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
>
>diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
>index 4125d13118..4befba5cc7 100644
>--- a/net/vhost-vdpa.c
>+++ b/net/vhost-vdpa.c
>@@ -264,7 +264,8 @@ int net_init_vhost_vdpa(const Netdev *netdev, const char *name,
> {
> const NetdevVhostVDPAOptions *opts;
> int vdpa_device_fd;
>- NetClientState **ncs, *nc;
>+ g_autofree NetClientState **ncs = NULL;
>+ NetClientState *nc;
> int queue_pairs, i, has_cvq = 0;
>
> assert(netdev->type == NET_CLIENT_DRIVER_VHOST_VDPA);
>@@ -302,7 +303,6 @@ int net_init_vhost_vdpa(const Netdev *netdev, const char *name,
> goto err;
> }
>
>- g_free(ncs);
> return 0;
>
> err:
>@@ -310,7 +310,6 @@ err:
> qemu_del_net_client(ncs[0]);
> }
> qemu_close(vdpa_device_fd);
>- g_free(ncs);
>
> return -1;
> }
>--
>2.27.0
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] vdpa: Make ncs autofree
2022-02-14 19:34 ` [PATCH 1/1] " Eugenio Pérez
` (2 preceding siblings ...)
2022-02-16 8:41 ` Stefano Garzarella
@ 2022-02-22 0:34 ` Laurent Vivier
3 siblings, 0 replies; 6+ messages in thread
From: Laurent Vivier @ 2022-02-22 0:34 UTC (permalink / raw)
To: Eugenio Pérez, qemu-devel
Cc: qemu-trivial, Jason Wang, Michael S. Tsirkin
Le 14/02/2022 à 20:34, Eugenio Pérez a écrit :
> Simplifying memory management.
>
> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> ---
> net/vhost-vdpa.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
> index 4125d13118..4befba5cc7 100644
> --- a/net/vhost-vdpa.c
> +++ b/net/vhost-vdpa.c
> @@ -264,7 +264,8 @@ int net_init_vhost_vdpa(const Netdev *netdev, const char *name,
> {
> const NetdevVhostVDPAOptions *opts;
> int vdpa_device_fd;
> - NetClientState **ncs, *nc;
> + g_autofree NetClientState **ncs = NULL;
> + NetClientState *nc;
> int queue_pairs, i, has_cvq = 0;
>
> assert(netdev->type == NET_CLIENT_DRIVER_VHOST_VDPA);
> @@ -302,7 +303,6 @@ int net_init_vhost_vdpa(const Netdev *netdev, const char *name,
> goto err;
> }
>
> - g_free(ncs);
> return 0;
>
> err:
> @@ -310,7 +310,6 @@ err:
> qemu_del_net_client(ncs[0]);
> }
> qemu_close(vdpa_device_fd);
> - g_free(ncs);
>
> return -1;
> }
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-02-22 0:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-14 19:34 [PATCH 0/1] vdpa: Make ncs autofree Eugenio Pérez
2022-02-14 19:34 ` [PATCH 1/1] " Eugenio Pérez
2022-02-14 22:14 ` Philippe Mathieu-Daudé via
2022-02-15 3:04 ` Jason Wang
2022-02-16 8:41 ` Stefano Garzarella
2022-02-22 0:34 ` Laurent Vivier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.