From: Sekhar Nori <nsekhar@ti.com> To: Bartosz Golaszewski <brgl@bgdev.pl>, Kevin Hilman <khilman@kernel.org>, Russell King <linux@armlinux.org.uk>, David Lechner <david@lechnology.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org> Cc: <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com> Subject: Re: [PATCH v2 06/13] ARM: davinci: omapl138-hawk: add aemif & nand support Date: Wed, 27 Jun 2018 15:41:24 +0530 [thread overview] Message-ID: <11b55553-435b-c363-9194-aebf47302198@ti.com> (raw) In-Reply-To: <20180626092537.6737-7-brgl@bgdev.pl> On Tuesday 26 June 2018 02:55 PM, Bartosz Golaszewski wrote: > arch/arm/mach-davinci/board-omapl138-hawk.c | 132 ++++++++++++++++++++ > 1 file changed, 132 insertions(+) > > diff --git a/arch/arm/mach-davinci/board-omapl138-hawk.c b/arch/arm/mach-davinci/board-omapl138-hawk.c > index 466e87b24e9a..8d8e3165a45c 100644 > --- a/arch/arm/mach-davinci/board-omapl138-hawk.c > +++ b/arch/arm/mach-davinci/board-omapl138-hawk.c > @@ -16,6 +16,11 @@ > #include <linux/gpio.h> > #include <linux/gpio/machine.h> > #include <linux/platform_data/gpio-davinci.h> > +#include <linux/platform_data/ti-aemif.h> > +#include <linux/mtd/rawnand.h> > +#include <linux/mtd/partitions.h> can you keep this (roughly) sorted by moving these above? > +#include <linux/platform_data/mtd-davinci.h> > +#include <linux/platform_data/mtd-davinci-aemif.h> > #include <linux/regulator/machine.h> > > #include <asm/mach-types.h> > @@ -166,6 +171,129 @@ static __init void omapl138_hawk_mmc_init(void) > gpiod_remove_lookup_table(&mmc_gpios_table); > } > > +static struct platform_device omapl138_hawk_aemif_devices[] = { > + { > + .name = "davinci_nand", > + .id = 1, This can be -1 now since you got "mtd: rawnand: davinci: stop using pdev->id as chipselect" merged. We cannot change for older platforms, but this is fresh support. > + .dev = { > + .platform_data = &omapl138_hawk_nandflash_data, > + }, > + .resource = omapl138_hawk_nandflash_resource, > + .num_resources = ARRAY_SIZE(omapl138_hawk_nandflash_resource), > + } > +}; Thanks, Sekhar
WARNING: multiple messages have this Message-ID (diff)
From: nsekhar@ti.com (Sekhar Nori) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 06/13] ARM: davinci: omapl138-hawk: add aemif & nand support Date: Wed, 27 Jun 2018 15:41:24 +0530 [thread overview] Message-ID: <11b55553-435b-c363-9194-aebf47302198@ti.com> (raw) In-Reply-To: <20180626092537.6737-7-brgl@bgdev.pl> On Tuesday 26 June 2018 02:55 PM, Bartosz Golaszewski wrote: > arch/arm/mach-davinci/board-omapl138-hawk.c | 132 ++++++++++++++++++++ > 1 file changed, 132 insertions(+) > > diff --git a/arch/arm/mach-davinci/board-omapl138-hawk.c b/arch/arm/mach-davinci/board-omapl138-hawk.c > index 466e87b24e9a..8d8e3165a45c 100644 > --- a/arch/arm/mach-davinci/board-omapl138-hawk.c > +++ b/arch/arm/mach-davinci/board-omapl138-hawk.c > @@ -16,6 +16,11 @@ > #include <linux/gpio.h> > #include <linux/gpio/machine.h> > #include <linux/platform_data/gpio-davinci.h> > +#include <linux/platform_data/ti-aemif.h> > +#include <linux/mtd/rawnand.h> > +#include <linux/mtd/partitions.h> can you keep this (roughly) sorted by moving these above? > +#include <linux/platform_data/mtd-davinci.h> > +#include <linux/platform_data/mtd-davinci-aemif.h> > #include <linux/regulator/machine.h> > > #include <asm/mach-types.h> > @@ -166,6 +171,129 @@ static __init void omapl138_hawk_mmc_init(void) > gpiod_remove_lookup_table(&mmc_gpios_table); > } > > +static struct platform_device omapl138_hawk_aemif_devices[] = { > + { > + .name = "davinci_nand", > + .id = 1, This can be -1 now since you got "mtd: rawnand: davinci: stop using pdev->id as chipselect" merged. We cannot change for older platforms, but this is fresh support. > + .dev = { > + .platform_data = &omapl138_hawk_nandflash_data, > + }, > + .resource = omapl138_hawk_nandflash_resource, > + .num_resources = ARRAY_SIZE(omapl138_hawk_nandflash_resource), > + } > +}; Thanks, Sekhar
next prev parent reply other threads:[~2018-06-27 10:12 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-06-26 9:25 [PATCH v2 00/13] ARM: davinci: remove duplicate aemif support Bartosz Golaszewski 2018-06-26 9:25 ` Bartosz Golaszewski 2018-06-26 9:25 ` [PATCH v2 01/13] clk: davinci: psc-da850: remove the 'davinci_nand.0" lookup Bartosz Golaszewski 2018-06-26 9:25 ` Bartosz Golaszewski 2018-06-26 16:15 ` David Lechner 2018-06-26 16:15 ` David Lechner 2018-06-26 9:25 ` [PATCH v2 02/13] clk: davinci: psc-dm365: use two lookup entries for the aemif clock Bartosz Golaszewski 2018-06-26 9:25 ` Bartosz Golaszewski 2018-06-26 16:16 ` David Lechner 2018-06-26 16:16 ` David Lechner 2018-06-26 9:25 ` [PATCH v2 03/13] clk: davinci: psc-dm644x: " Bartosz Golaszewski 2018-06-26 9:25 ` Bartosz Golaszewski 2018-06-26 16:17 ` David Lechner 2018-06-26 16:17 ` David Lechner 2018-06-26 9:25 ` [PATCH v2 04/13] clk: davinci: psc-dm646x: " Bartosz Golaszewski 2018-06-26 9:25 ` Bartosz Golaszewski 2018-06-26 16:17 ` David Lechner 2018-06-26 16:17 ` David Lechner 2018-06-27 10:01 ` Sekhar Nori 2018-06-27 10:01 ` Sekhar Nori 2018-06-27 10:03 ` Bartosz Golaszewski 2018-06-27 10:03 ` Bartosz Golaszewski 2018-06-27 10:26 ` Sekhar Nori 2018-06-27 10:26 ` Sekhar Nori 2018-06-27 16:54 ` David Lechner 2018-06-27 16:54 ` David Lechner 2018-06-26 9:25 ` [PATCH v2 05/13] clk: davinci: psc-da830: add a lookup entry for " Bartosz Golaszewski 2018-06-26 9:25 ` Bartosz Golaszewski 2018-06-26 16:18 ` David Lechner 2018-06-26 16:18 ` David Lechner 2018-06-26 9:25 ` [PATCH v2 06/13] ARM: davinci: omapl138-hawk: add aemif & nand support Bartosz Golaszewski 2018-06-26 9:25 ` Bartosz Golaszewski 2018-06-27 10:11 ` Sekhar Nori [this message] 2018-06-27 10:11 ` Sekhar Nori 2018-06-26 9:25 ` [PATCH v2 07/13] ARM: davinci: da850-evm: use aemif platform driver in legacy mode Bartosz Golaszewski 2018-06-26 9:25 ` Bartosz Golaszewski 2018-06-26 9:25 ` [PATCH v2 08/13] ARM: davinci: dm365-evm: use the ti-aemif soc driver Bartosz Golaszewski 2018-06-26 9:25 ` Bartosz Golaszewski 2018-06-26 9:25 ` [PATCH v2 09/13] ARM: davinci: dm644x-evm: use aemif platform driver Bartosz Golaszewski 2018-06-26 9:25 ` Bartosz Golaszewski 2018-06-26 9:25 ` [PATCH v2 10/13] ARM: davinci: da830-evm: " Bartosz Golaszewski 2018-06-26 9:25 ` Bartosz Golaszewski 2018-06-26 9:25 ` [PATCH v2 11/13] ARM: davinci: dm646x-evm: " Bartosz Golaszewski 2018-06-26 9:25 ` Bartosz Golaszewski 2018-06-26 9:25 ` [PATCH v2 12/13] ARM: davinci: mityomapl138: " Bartosz Golaszewski 2018-06-26 9:25 ` Bartosz Golaszewski 2018-06-26 9:25 ` [PATCH v2 13/13] ARM: davinci: unduplicate aemif support Bartosz Golaszewski 2018-06-26 9:25 ` Bartosz Golaszewski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=11b55553-435b-c363-9194-aebf47302198@ti.com \ --to=nsekhar@ti.com \ --cc=bgolaszewski@baylibre.com \ --cc=brgl@bgdev.pl \ --cc=david@lechnology.com \ --cc=khilman@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=mturquette@baylibre.com \ --cc=sboyd@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.