* [PATCH -tip] x86: ptrace ptrace_get_debugreg() should be static
@ 2009-06-18 10:55 Jaswinder Singh Rajput
2009-06-20 7:43 ` [PATCH -tip RESEND] " Jaswinder Singh Rajput
0 siblings, 1 reply; 2+ messages in thread
From: Jaswinder Singh Rajput @ 2009-06-18 10:55 UTC (permalink / raw)
To: Ingo Molnar, x86 maintainers, LKML, Steven Rostedt
ptrace_get_debugreg() is used only by the same file, so it should be static.
Also fixed sparse warning :
CHECK arch/x86/kernel/ptrace.c
arch/x86/kernel/ptrace.c:560:15: warning: symbol 'ptrace_get_debugreg' was not declared. Should it be static?
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
arch/x86/kernel/ptrace.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c
index b457f78..cabdabc 100644
--- a/arch/x86/kernel/ptrace.c
+++ b/arch/x86/kernel/ptrace.c
@@ -557,7 +557,7 @@ restore:
/*
* Handle PTRACE_PEEKUSR calls for the debug register area.
*/
-unsigned long ptrace_get_debugreg(struct task_struct *tsk, int n)
+static unsigned long ptrace_get_debugreg(struct task_struct *tsk, int n)
{
struct thread_struct *thread = &(tsk->thread);
unsigned long val = 0;
--
1.6.0.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH -tip RESEND] x86: ptrace ptrace_get_debugreg() should be static
2009-06-18 10:55 [PATCH -tip] x86: ptrace ptrace_get_debugreg() should be static Jaswinder Singh Rajput
@ 2009-06-20 7:43 ` Jaswinder Singh Rajput
0 siblings, 0 replies; 2+ messages in thread
From: Jaswinder Singh Rajput @ 2009-06-20 7:43 UTC (permalink / raw)
To: Ingo Molnar; +Cc: x86 maintainers, LKML, Steven Rostedt
ptrace_get_debugreg() is used only by the same file, so it should be static.
Also fixed sparse warning :
CHECK arch/x86/kernel/ptrace.c
arch/x86/kernel/ptrace.c:560:15: warning: symbol 'ptrace_get_debugreg' was not declared. Should it be static?
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
arch/x86/kernel/ptrace.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c
index b457f78..cabdabc 100644
--- a/arch/x86/kernel/ptrace.c
+++ b/arch/x86/kernel/ptrace.c
@@ -557,7 +557,7 @@ restore:
/*
* Handle PTRACE_PEEKUSR calls for the debug register area.
*/
-unsigned long ptrace_get_debugreg(struct task_struct *tsk, int n)
+static unsigned long ptrace_get_debugreg(struct task_struct *tsk, int n)
{
struct thread_struct *thread = &(tsk->thread);
unsigned long val = 0;
--
1.6.0.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-20 7:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-18 10:55 [PATCH -tip] x86: ptrace ptrace_get_debugreg() should be static Jaswinder Singh Rajput
2009-06-20 7:43 ` [PATCH -tip RESEND] " Jaswinder Singh Rajput
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.