[PATCH 1/1] perf probe: Annotate variable initialization

[PATCH 1/1] perf probe: Annotate variable initialization

[Arnaldo Carvalho de Melo]

From: Arnaldo Carvalho de Melo <acme@redhat.com>

    cc1: warnings being treated as errors
    builtin-probe.c: In function ‘parse_probe_event’:
    builtin-probe.c:72: warning: ‘nc’ is used uninitialized in this function

Cc: Masami Hiramatsu <mhiramat@redhat.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-probe.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
index a99a366..8124523 100644
--- a/tools/perf/builtin-probe.c
+++ b/tools/perf/builtin-probe.c
@@ -69,7 +69,7 @@ static struct {
 static void parse_probe_point(char *arg, struct probe_point *pp)
 {
 	char *ptr, *tmp;
-	char c, nc;
+	char c, nc = 0;
 	/*
 	 * <Syntax>
 	 * perf probe SRC:LN
-- 
1.5.5.1

Re: [PATCH 1/1] perf probe: Annotate variable initialization

[Masami Hiramatsu]

Arnaldo Carvalho de Melo wrote:
> From: Arnaldo Carvalho de Melo<acme@redhat.com>
>
>      cc1: warnings being treated as errors
>      builtin-probe.c: In function ‘parse_probe_event’:
>      builtin-probe.c:72: warning: ‘nc’ is used uninitialized in this function
>
> Cc: Masami Hiramatsu<mhiramat@redhat.com>
> Signed-off-by: Arnaldo Carvalho de Melo<acme@redhat.com>

Oops, thank you!

Acked-by: Masami Hiramatsu <mhiramat@redhat.com>

> ---
>   tools/perf/builtin-probe.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
> index a99a366..8124523 100644
> --- a/tools/perf/builtin-probe.c
> +++ b/tools/perf/builtin-probe.c
> @@ -69,7 +69,7 @@ static struct {
>   static void parse_probe_point(char *arg, struct probe_point *pp)
>   {
>   	char *ptr, *tmp;
> -	char c, nc;
> +	char c, nc = 0;
>   	/*
>   	 *<Syntax>
>   	* perf probe SRC:LN

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com