From: Vikas Manocha <vikas.manocha@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/6] stm32mp1: clk: define RCC_PLLNCFGR2_SHIFT macro
Date: Mon, 16 Jul 2018 11:30:21 -0700 [thread overview]
Message-ID: <1273b222-5c26-e34a-63d4-694863895229@st.com> (raw)
In-Reply-To: <1531730506-18633-1-git-send-email-patrick.delaunay@st.com>
Hi,
On 07/16/2018 01:41 AM, Patrick Delaunay wrote:
> This patch define RCC_PLLNCFGR2_SHIFT to reuse it in
> the pll function for set rate.
>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
Reviewed-by: Vikas Manocha <vikas.manocha@st.com>
Cheers,
Vikas
> ---
>
> drivers/clk/clk_stm32mp1.c | 15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/clk/clk_stm32mp1.c b/drivers/clk/clk_stm32mp1.c
> index 3f00c198..5177758 100644
> --- a/drivers/clk/clk_stm32mp1.c
> +++ b/drivers/clk/clk_stm32mp1.c
> @@ -175,13 +175,14 @@
> #define RCC_PLLNCFGR1_IFRGE_SHIFT 24
> #define RCC_PLLNCFGR1_IFRGE_MASK GENMASK(25, 24)
>
> -/* used for ALL PLLNCFGR2 registers */
> +/* used for ALL PLLNCFGR2 registers , using stm32mp1_div_id */
> +#define RCC_PLLNCFGR2_SHIFT(div_id) ((div_id) * 8)
> #define RCC_PLLNCFGR2_DIVX_MASK GENMASK(6, 0)
> -#define RCC_PLLNCFGR2_DIVP_SHIFT 0
> +#define RCC_PLLNCFGR2_DIVP_SHIFT RCC_PLLNCFGR2_SHIFT(_DIV_P)
> #define RCC_PLLNCFGR2_DIVP_MASK GENMASK(6, 0)
> -#define RCC_PLLNCFGR2_DIVQ_SHIFT 8
> +#define RCC_PLLNCFGR2_DIVQ_SHIFT RCC_PLLNCFGR2_SHIFT(_DIV_Q)
> #define RCC_PLLNCFGR2_DIVQ_MASK GENMASK(14, 8)
> -#define RCC_PLLNCFGR2_DIVR_SHIFT 16
> +#define RCC_PLLNCFGR2_DIVR_SHIFT RCC_PLLNCFGR2_SHIFT(_DIV_R)
> #define RCC_PLLNCFGR2_DIVR_MASK GENMASK(22, 16)
>
> /* used for ALL PLLNFRACR registers */
> @@ -814,10 +815,6 @@ static ulong stm32mp1_read_pll_freq(struct stm32mp1_clk_priv *priv,
> int divm, divn, divy, src;
> ulong refclk, dfout;
> u32 selr, cfgr1, cfgr2, fracr;
> - const u8 shift[_DIV_NB] = {
> - [_DIV_P] = RCC_PLLNCFGR2_DIVP_SHIFT,
> - [_DIV_Q] = RCC_PLLNCFGR2_DIVQ_SHIFT,
> - [_DIV_R] = RCC_PLLNCFGR2_DIVR_SHIFT };
>
> debug("%s(%d, %d)\n", __func__, pll_id, div_id);
> if (div_id > _DIV_NB)
> @@ -833,7 +830,7 @@ static ulong stm32mp1_read_pll_freq(struct stm32mp1_clk_priv *priv,
>
> divm = (cfgr1 & (RCC_PLLNCFGR1_DIVM_MASK)) >> RCC_PLLNCFGR1_DIVM_SHIFT;
> divn = cfgr1 & RCC_PLLNCFGR1_DIVN_MASK;
> - divy = (cfgr2 >> shift[div_id]) & RCC_PLLNCFGR2_DIVX_MASK;
> + divy = (cfgr2 >> RCC_PLLNCFGR2_SHIFT(div_id)) & RCC_PLLNCFGR2_DIVX_MASK;
>
> debug(" DIVN=%d DIVM=%d DIVY=%d\n", divn, divm, divy);
>
>
next prev parent reply other threads:[~2018-07-16 18:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 8:41 [U-Boot] [PATCH 1/6] stm32mp1: clk: define RCC_PLLNCFGR2_SHIFT macro Patrick Delaunay
2018-07-16 8:41 ` [U-Boot] [PATCH 2/6] stm32mp1: clk: add common function pll_get_fvco Patrick Delaunay
2018-07-20 22:36 ` [U-Boot] [U-Boot, " Tom Rini
2018-07-16 8:41 ` [U-Boot] [PATCH 3/6] stm32mp1: clk: add LDTC and DSI clock support Patrick Delaunay
2018-07-20 22:36 ` [U-Boot] [U-Boot, " Tom Rini
2018-07-16 8:41 ` [U-Boot] [PATCH 4/6] stm32mp1: clk: update Ethernet clock gating Patrick Delaunay
2018-07-20 22:36 ` [U-Boot] [U-Boot, " Tom Rini
2018-07-16 8:41 ` [U-Boot] [PATCH 5/6] stm32mp1: clk: add ADC " Patrick Delaunay
2018-07-20 22:36 ` [U-Boot] [U-Boot,5/6] " Tom Rini
2018-07-16 8:41 ` [U-Boot] [PATCH 6/6] stm32mp1: clk: support digital bypass Patrick Delaunay
2018-07-20 22:36 ` [U-Boot] [U-Boot,6/6] " Tom Rini
2018-07-16 18:30 ` Vikas Manocha [this message]
2018-07-20 22:36 ` [U-Boot] [U-Boot, 1/6] stm32mp1: clk: define RCC_PLLNCFGR2_SHIFT macro Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273b222-5c26-e34a-63d4-694863895229@st.com \
--to=vikas.manocha@st.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.