* [PATCH] arm64: dts: imx8mm: Add SNVS LPGPR on Data Modul i.MX8M Mini eDM SBC
@ 2022-05-22 17:57 Marek Vasut
2022-05-23 11:04 ` Fabio Estevam
2022-05-23 11:08 ` (EXT) " Alexander Stein
0 siblings, 2 replies; 6+ messages in thread
From: Marek Vasut @ 2022-05-22 17:57 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Marek Vasut, Fabio Estevam, Peng Fan, Shawn Guo, NXP Linux Team
Add SNVS LPGPR bindings on this system, the LPGPR is used to store
boot counter.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <festevam@denx.de>
Cc: Peng Fan <peng.fan@nxp.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: NXP Linux Team <linux-imx@nxp.com>
To: linux-arm-kernel@lists.infradead.org
---
NOTE: Depends on
https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=for-next&id=fee6de80bdd3df976a43f3092a165cb43c072f20
---
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
index 778bdbe228d31..93f14afc1f8a9 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
@@ -928,6 +928,12 @@ &sai5 {
status = "disabled";
};
+&snvs {
+ snvs-lpgpr {
+ compatible = "fsl,imx8mm-snvs-lpgpr", "fsl,imx7d-snvs-lpgpr";
+ };
+};
+
&uart1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_uart1>;
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: imx8mm: Add SNVS LPGPR on Data Modul i.MX8M Mini eDM SBC
2022-05-22 17:57 [PATCH] arm64: dts: imx8mm: Add SNVS LPGPR on Data Modul i.MX8M Mini eDM SBC Marek Vasut
@ 2022-05-23 11:04 ` Fabio Estevam
2022-05-23 11:08 ` (EXT) " Alexander Stein
1 sibling, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2022-05-23 11:04 UTC (permalink / raw)
To: Marek Vasut; +Cc: linux-arm-kernel, Peng Fan, Shawn Guo, NXP Linux Team
On 22/05/2022 14:57, Marek Vasut wrote:
> Add SNVS LPGPR bindings on this system, the LPGPR is used to store
> boot counter.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Fabio Estevam <festevam@denx.de>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> To: linux-arm-kernel@lists.infradead.org
> ---
> NOTE: Depends on
>
> https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=for-next&id=fee6de80bdd3df976a43f3092a165cb43c072f20
Reviewed-by: Fabio Estevam <festevam@denx.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: (EXT) [PATCH] arm64: dts: imx8mm: Add SNVS LPGPR on Data Modul i.MX8M Mini eDM SBC
2022-05-22 17:57 [PATCH] arm64: dts: imx8mm: Add SNVS LPGPR on Data Modul i.MX8M Mini eDM SBC Marek Vasut
2022-05-23 11:04 ` Fabio Estevam
@ 2022-05-23 11:08 ` Alexander Stein
2022-05-23 11:18 ` Marek Vasut
1 sibling, 1 reply; 6+ messages in thread
From: Alexander Stein @ 2022-05-23 11:08 UTC (permalink / raw)
To: Marek Vasut
Cc: linux-arm-kernel, Fabio Estevam, Peng Fan, Shawn Guo,
NXP Linux Team, Marek Vasut
Hi Marek,
Am Sonntag, 22. Mai 2022, 19:57:23 CEST schrieb Marek Vasut:
> Add SNVS LPGPR bindings on this system, the LPGPR is used to store
> boot counter.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Fabio Estevam <festevam@denx.de>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> To: linux-arm-kernel@lists.infradead.org
> ---
> NOTE: Depends on
>
> https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=fo
> r-next&id=fee6de80bdd3df976a43f3092a165cb43c072f20 ---
> arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
> b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts index
> 778bdbe228d31..93f14afc1f8a9 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
> @@ -928,6 +928,12 @@ &sai5 {
> status = "disabled";
> };
>
> +&snvs {
> + snvs-lpgpr {
> + compatible = "fsl,imx8mm-snvs-lpgpr", "fsl,imx7d-snvs-
lpgpr";
> + };
> +};
> +
> &uart1 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_uart1>;
Shouldn't this go into imx8mm.dtsi?
Best regards,
Alexander
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: (EXT) [PATCH] arm64: dts: imx8mm: Add SNVS LPGPR on Data Modul i.MX8M Mini eDM SBC
2022-05-23 11:08 ` (EXT) " Alexander Stein
@ 2022-05-23 11:18 ` Marek Vasut
2022-05-23 11:43 ` Alexander Stein
0 siblings, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2022-05-23 11:18 UTC (permalink / raw)
To: Alexander Stein
Cc: linux-arm-kernel, Fabio Estevam, Peng Fan, Shawn Guo, NXP Linux Team
On 5/23/22 13:08, Alexander Stein wrote:
Hi,
[...]
>> +&snvs {
>> + snvs-lpgpr {
>> + compatible = "fsl,imx8mm-snvs-lpgpr", "fsl,imx7d-snvs-
> lpgpr";
>> + };
>> +};
>> +
>> &uart1 {
>> pinctrl-names = "default";
>> pinctrl-0 = <&pinctrl_uart1>;
>
> Shouldn't this go into imx8mm.dtsi?
No, not everyone uses this register for boot counter or wants to expose
it to Linux that way. This is board-specific behavior.
(the other SNVS related entries should be in the SoC common file
however, those are SoC-specific).
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: (EXT) [PATCH] arm64: dts: imx8mm: Add SNVS LPGPR on Data Modul i.MX8M Mini eDM SBC
2022-05-23 11:18 ` Marek Vasut
@ 2022-05-23 11:43 ` Alexander Stein
2022-05-23 12:09 ` Marek Vasut
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Stein @ 2022-05-23 11:43 UTC (permalink / raw)
To: Marek Vasut
Cc: linux-arm-kernel, Fabio Estevam, Peng Fan, Shawn Guo, NXP Linux Team
Am Montag, 23. Mai 2022, 13:18:01 CEST schrieb Marek Vasut:
> On 5/23/22 13:08, Alexander Stein wrote:
>
> Hi,
>
> [...]
>
> >> +&snvs {
> >> + snvs-lpgpr {
> >> + compatible = "fsl,imx8mm-snvs-lpgpr", "fsl,imx7d-snvs-
> >
> > lpgpr";
> >
> >> + };
> >> +};
> >> +
> >>
> >> &uart1 {
> >>
> >> pinctrl-names = "default";
> >> pinctrl-0 = <&pinctrl_uart1>;
> >
> > Shouldn't this go into imx8mm.dtsi?
>
> No, not everyone uses this register for boot counter or wants to expose
> it to Linux that way. This is board-specific behavior.
Sure the actual usage of the general purpose registers is very much board-
specific. Nevertheless the DT describes the hardware and there is snvs-lpgpr
in all imx8mm. IMHO there is no harm exposing those GPR unconditionally.
Best regards,
Alexander
>
> (the other SNVS related entries should be in the SoC common file
> however, those are SoC-specific).
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: (EXT) [PATCH] arm64: dts: imx8mm: Add SNVS LPGPR on Data Modul i.MX8M Mini eDM SBC
2022-05-23 11:43 ` Alexander Stein
@ 2022-05-23 12:09 ` Marek Vasut
0 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2022-05-23 12:09 UTC (permalink / raw)
To: Alexander Stein
Cc: linux-arm-kernel, Fabio Estevam, Peng Fan, Shawn Guo, NXP Linux Team
On 5/23/22 13:43, Alexander Stein wrote:
> Am Montag, 23. Mai 2022, 13:18:01 CEST schrieb Marek Vasut:
>> On 5/23/22 13:08, Alexander Stein wrote:
>>
>> Hi,
>>
>> [...]
>>
>>>> +&snvs {
>>>> + snvs-lpgpr {
>>>> + compatible = "fsl,imx8mm-snvs-lpgpr", "fsl,imx7d-snvs-
>>>
>>> lpgpr";
>>>
>>>> + };
>>>> +};
>>>> +
>>>>
>>>> &uart1 {
>>>>
>>>> pinctrl-names = "default";
>>>> pinctrl-0 = <&pinctrl_uart1>;
>>>
>>> Shouldn't this go into imx8mm.dtsi?
>>
>> No, not everyone uses this register for boot counter or wants to expose
>> it to Linux that way. This is board-specific behavior.
>
> Sure the actual usage of the general purpose registers is very much board-
> specific. Nevertheless the DT describes the hardware and there is snvs-lpgpr
> in all imx8mm. IMHO there is no harm exposing those GPR unconditionally.
Imagine someone is storing information which shouldn't be exposed to
Linux in those registers, in any way.
I see (in git grep) other SoCs already did add it unconditionally into
their DTSI though, hummmmm. Then maybe we should be consistent and just
add it to them all.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-05-23 12:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-22 17:57 [PATCH] arm64: dts: imx8mm: Add SNVS LPGPR on Data Modul i.MX8M Mini eDM SBC Marek Vasut
2022-05-23 11:04 ` Fabio Estevam
2022-05-23 11:08 ` (EXT) " Alexander Stein
2022-05-23 11:18 ` Marek Vasut
2022-05-23 11:43 ` Alexander Stein
2022-05-23 12:09 ` Marek Vasut
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.