From: Wolfram Sang <w.sang@pengutronix.de> To: linux-i2c@vger.kernel.org Cc: Wolfram Sang <w.sang@pengutronix.de>, Greg Kroah-Hartman <gregkh@suse.de>, Naveen Kumar Gaddipati <naveen.gaddipati@stericsson.com>, Linus Walleij <linus.walleij@stericsson.com>, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/4] staging/ste_rmi4: Remove obsolete cleanup for clientdata Date: Mon, 24 Jan 2011 11:44:29 +0100 [thread overview] Message-ID: <1295865880-27672-3-git-send-email-w.sang@pengutronix.de> (raw) In-Reply-To: <1295865880-27672-1-git-send-email-w.sang@pengutronix.de> A few new i2c-drivers came into the kernel which clear the clientdata-pointer on exit or error. This is obsolete meanwhile, the core will do it. Signed-off-by: Wolfram Sang <w.sang@pengutronix.de> Cc: Greg Kroah-Hartman <gregkh@suse.de> Cc: Naveen Kumar Gaddipati <naveen.gaddipati@stericsson.com> Cc: Linus Walleij <linus.walleij@stericsson.com> --- Compile tested only. drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c index e8f047e..c9207de 100644 --- a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c +++ b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c @@ -989,7 +989,7 @@ static int __devinit synaptics_rmi4_probe retval = input_register_device(rmi4_data->input_dev); if (retval) { dev_err(&client->dev, "%s:input register failed\n", __func__); - goto err_input_register; + goto err_query_dev; } /* Clear interrupts */ @@ -1011,8 +1011,6 @@ static int __devinit synaptics_rmi4_probe err_request_irq: free_irq(platformdata->irq_number, rmi4_data); input_unregister_device(rmi4_data->input_dev); -err_input_register: - i2c_set_clientdata(client, NULL); err_query_dev: if (platformdata->regulator_en) { regulator_disable(rmi4_data->regulator); -- 1.7.2.3
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> To: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>, Greg Kroah-Hartman <gregkh-l3A5Bk7waGM@public.gmane.org>, Naveen Kumar Gaddipati <naveen.gaddipati-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>, Linus Walleij <linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>, devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: [PATCH 3/4] staging/ste_rmi4: Remove obsolete cleanup for clientdata Date: Mon, 24 Jan 2011 11:44:29 +0100 [thread overview] Message-ID: <1295865880-27672-3-git-send-email-w.sang@pengutronix.de> (raw) In-Reply-To: <1295865880-27672-1-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> A few new i2c-drivers came into the kernel which clear the clientdata-pointer on exit or error. This is obsolete meanwhile, the core will do it. Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Cc: Greg Kroah-Hartman <gregkh-l3A5Bk7waGM@public.gmane.org> Cc: Naveen Kumar Gaddipati <naveen.gaddipati-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org> Cc: Linus Walleij <linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org> --- Compile tested only. drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c index e8f047e..c9207de 100644 --- a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c +++ b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c @@ -989,7 +989,7 @@ static int __devinit synaptics_rmi4_probe retval = input_register_device(rmi4_data->input_dev); if (retval) { dev_err(&client->dev, "%s:input register failed\n", __func__); - goto err_input_register; + goto err_query_dev; } /* Clear interrupts */ @@ -1011,8 +1011,6 @@ static int __devinit synaptics_rmi4_probe err_request_irq: free_irq(platformdata->irq_number, rmi4_data); input_unregister_device(rmi4_data->input_dev); -err_input_register: - i2c_set_clientdata(client, NULL); err_query_dev: if (platformdata->regulator_en) { regulator_disable(rmi4_data->regulator); -- 1.7.2.3
next prev parent reply other threads:[~2011-01-24 10:45 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-01-24 10:44 [PATCH 1/4] mfd: Remove obsolete cleanup for clientdata Wolfram Sang 2011-01-24 10:44 ` Wolfram Sang 2011-01-24 10:44 ` [PATCH 2/4] power: " Wolfram Sang 2011-01-24 10:44 ` Wolfram Sang [this message] 2011-01-24 10:44 ` [PATCH 3/4] staging/ste_rmi4: " Wolfram Sang 2011-01-24 10:44 ` [PATCH 4/4] drivers/staging/lirc: " Wolfram Sang 2011-01-24 14:54 ` Jarod Wilson 2011-01-24 14:54 ` Jarod Wilson 2011-01-25 0:09 ` Andy Walls 2011-01-25 0:09 ` Andy Walls 2011-01-25 7:49 ` Jean Delvare 2011-01-25 7:49 ` Jean Delvare 2011-01-25 20:57 ` Wolfram Sang 2011-01-25 20:57 ` Wolfram Sang 2011-01-31 10:45 ` [PATCH 1/4] mfd: " Samuel Ortiz 2011-01-31 10:45 ` Samuel Ortiz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1295865880-27672-3-git-send-email-w.sang@pengutronix.de \ --to=w.sang@pengutronix.de \ --cc=devel@driverdev.osuosl.org \ --cc=gregkh@suse.de \ --cc=linus.walleij@stericsson.com \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=naveen.gaddipati@stericsson.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.