All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: amit.shah@redhat.com, alevy@redhat.com, kraxel@redhat.com
Subject: [Qemu-devel] [PATCH 1/4] usb-ccid: Drop unused CCIDCardInfo callback print()
Date: Thu, 19 May 2011 13:37:14 +0200	[thread overview]
Message-ID: <1305805037-17752-2-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1305805037-17752-1-git-send-email-armbru@redhat.com>


Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 hw/ccid.h     |    1 -
 hw/usb-ccid.c |   11 -----------
 2 files changed, 0 insertions(+), 12 deletions(-)

diff --git a/hw/ccid.h b/hw/ccid.h
index dbfc13c..d3e0371 100644
--- a/hw/ccid.h
+++ b/hw/ccid.h
@@ -29,7 +29,6 @@ struct CCIDCardState {
  */
 struct CCIDCardInfo {
     DeviceInfo qdev;
-    void (*print)(Monitor *mon, CCIDCardState *card, int indent);
     const uint8_t *(*get_atr)(CCIDCardState *card, uint32_t *len);
     void (*apdu_from_guest)(CCIDCardState *card,
                             const uint8_t *apdu,
diff --git a/hw/usb-ccid.c b/hw/usb-ccid.c
index 079b4a2..7772fe7 100644
--- a/hw/usb-ccid.c
+++ b/hw/usb-ccid.c
@@ -1103,16 +1103,6 @@ static Answer *ccid_peek_next_answer(USBCCIDState *s)
         : &s->pending_answers[s->pending_answers_start % PENDING_ANSWERS_NUM];
 }
 
-static void ccid_bus_dev_print(Monitor *mon, DeviceState *qdev, int indent)
-{
-    CCIDCardState *card = DO_UPCAST(CCIDCardState, qdev, qdev);
-    CCIDCardInfo *info = DO_UPCAST(CCIDCardInfo, qdev, qdev->info);
-
-    if (info->print) {
-        info->print(mon, card, indent);
-    }
-}
-
 struct CCIDBus {
     BusState qbus;
 };
@@ -1120,7 +1110,6 @@ struct CCIDBus {
 static struct BusInfo ccid_bus_info = {
     .name = "ccid-bus",
     .size = sizeof(CCIDBus),
-    .print_dev = ccid_bus_dev_print,
     .props = (Property[]) {
         DEFINE_PROP_UINT32("slot", struct CCIDCardState, slot, 0),
         DEFINE_PROP_END_OF_LIST(),
-- 
1.7.2.3

  reply	other threads:[~2011-05-19 11:37 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-19 11:37 [Qemu-devel] [PATCH 0/4] A few cleanups of qdev users Markus Armbruster
2011-05-19 11:37 ` Markus Armbruster [this message]
2011-05-19 11:49   ` [Qemu-devel] [PATCH 1/4] usb-ccid: Drop unused CCIDCardInfo callback print() Alon Levy
2011-05-19 11:37 ` [Qemu-devel] [PATCH 2/4] virtio-serial: Clean up virtser_bus_dev_print() output Markus Armbruster
2011-05-19 13:10   ` Amit Shah
2011-05-19 14:18     ` Markus Armbruster
2011-05-19 14:24       ` Amit Shah
2011-06-27 19:32       ` Andreas Färber
2011-06-29  8:33         ` Gerd Hoffmann
2011-06-29  9:26           ` Markus Armbruster
2011-06-29 18:33           ` Andreas Färber
2011-06-29  9:22         ` Markus Armbruster
2011-05-19 11:37 ` [Qemu-devel] [PATCH 3/4] virtio-serial: Turn props any virtio-serial-bus device must have into bus props Markus Armbruster
2011-05-19 13:11   ` Amit Shah
2011-05-19 14:05     ` Markus Armbruster
2011-05-19 14:08       ` Amit Shah
2011-05-19 11:37 ` [Qemu-devel] [PATCH 4/4] ide: Turn properties any IDE device must have into bus properties Markus Armbruster
2011-05-19 12:11 ` [Qemu-devel] [PATCH 0/4] A few cleanups of qdev users Gerd Hoffmann
2011-06-24 11:57 ` Markus Armbruster
2011-06-27  9:54   ` Amit Shah
2011-06-27 12:36     ` Markus Armbruster
2011-06-28 11:26       ` Amit Shah
2011-06-28 12:24         ` Markus Armbruster
2011-06-28 12:34           ` Amit Shah
2011-07-23 16:54 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305805037-17752-2-git-send-email-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=alevy@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.