From: "Andreas Färber" <andreas.faerber@web.de>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>,
alevy@redhat.com, Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/4] virtio-serial: Clean up virtser_bus_dev_print() output
Date: Wed, 29 Jun 2011 20:33:18 +0200 [thread overview]
Message-ID: <64183861-041D-458A-916C-0E2177A0D3BC@web.de> (raw)
In-Reply-To: <4E0AE365.1070101@redhat.com>
Hi,
Am 29.06.2011 um 10:33 schrieb Gerd Hoffmann:
>> Erm, I'm not aware that my qdev bool patch got committed yet, so the
>> question of how to parse/print bool properties (on/off vs. yes/no) is
>> still undecided, no comments so far. It would be entirely possible to
>> let the author decide that on a case-by-case basis by using different
>> property type enums for the same 'bool' type.
>
> Just accept both "on" and "yes" for true and both "off" and "no" for
> false?
That's exactly what the patch does, in Markus' parse_bit() among others:
http://patchwork.ozlabs.org/patch/100271/
> For printing we'll have to pick one though. I'd tend to pick on/off
> as I guess most properties will enable or disable some feature. Or
> have the two enums ...
Like I wrote in another thread, on/off only applies to nouns, not
adjectives like "enabled". I'll revisit this topic the weekend.
Andreas
next prev parent reply other threads:[~2011-06-29 18:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 11:37 [Qemu-devel] [PATCH 0/4] A few cleanups of qdev users Markus Armbruster
2011-05-19 11:37 ` [Qemu-devel] [PATCH 1/4] usb-ccid: Drop unused CCIDCardInfo callback print() Markus Armbruster
2011-05-19 11:49 ` Alon Levy
2011-05-19 11:37 ` [Qemu-devel] [PATCH 2/4] virtio-serial: Clean up virtser_bus_dev_print() output Markus Armbruster
2011-05-19 13:10 ` Amit Shah
2011-05-19 14:18 ` Markus Armbruster
2011-05-19 14:24 ` Amit Shah
2011-06-27 19:32 ` Andreas Färber
2011-06-29 8:33 ` Gerd Hoffmann
2011-06-29 9:26 ` Markus Armbruster
2011-06-29 18:33 ` Andreas Färber [this message]
2011-06-29 9:22 ` Markus Armbruster
2011-05-19 11:37 ` [Qemu-devel] [PATCH 3/4] virtio-serial: Turn props any virtio-serial-bus device must have into bus props Markus Armbruster
2011-05-19 13:11 ` Amit Shah
2011-05-19 14:05 ` Markus Armbruster
2011-05-19 14:08 ` Amit Shah
2011-05-19 11:37 ` [Qemu-devel] [PATCH 4/4] ide: Turn properties any IDE device must have into bus properties Markus Armbruster
2011-05-19 12:11 ` [Qemu-devel] [PATCH 0/4] A few cleanups of qdev users Gerd Hoffmann
2011-06-24 11:57 ` Markus Armbruster
2011-06-27 9:54 ` Amit Shah
2011-06-27 12:36 ` Markus Armbruster
2011-06-28 11:26 ` Amit Shah
2011-06-28 12:24 ` Markus Armbruster
2011-06-28 12:34 ` Amit Shah
2011-07-23 16:54 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64183861-041D-458A-916C-0E2177A0D3BC@web.de \
--to=andreas.faerber@web.de \
--cc=alevy@redhat.com \
--cc=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.