* [PATCH] xfsprogs: don't hard code the shell binary
@ 2011-06-28 7:15 Dave Chinner
2011-06-28 7:41 ` Christoph Hellwig
0 siblings, 1 reply; 6+ messages in thread
From: Dave Chinner @ 2011-06-28 7:15 UTC (permalink / raw)
To: xfs
From: Dave Chinner <dchinner@redhat.com>
Recent changes to debian unstable user space have caused the
xfsprogs build to break as certain shell functionality is being
assumed by libtool and friends. The configure scripts test and
select the correct shell, but the input files ignore this and hard
code the shell to use and hence now break.
Fix this by using the shell that the configure scripts decide is the
right one to use.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
include/builddefs.in | 1 +
include/buildmacros | 1 -
2 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/builddefs.in b/include/builddefs.in
index f895ed9..4c8ec64 100644
--- a/include/builddefs.in
+++ b/include/builddefs.in
@@ -71,6 +71,7 @@ MAKE = @make@
ECHO = @echo@
SORT = @sort@
LN_S = @LN_S@
+SHELL = @SHELL@
LIBTOOL = @LIBTOOL@
MAKEDEPEND = @makedepend@
diff --git a/include/buildmacros b/include/buildmacros
index 62babca..31c7eb0 100644
--- a/include/buildmacros
+++ b/include/buildmacros
@@ -32,7 +32,6 @@ OBJECTS = $(ASFILES:.s=.o) \
INSTALL = $(TOPDIR)/install-sh -o $(PKG_USER) -g $(PKG_GROUP)
-SHELL = /bin/sh
IMAGES_DIR = $(TOPDIR)/all-images
DIST_DIR = $(TOPDIR)/dist
--
1.7.5.1
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] xfsprogs: don't hard code the shell binary
2011-06-28 7:15 [PATCH] xfsprogs: don't hard code the shell binary Dave Chinner
@ 2011-06-28 7:41 ` Christoph Hellwig
2011-06-28 8:45 ` Dave Chinner
2011-07-14 18:27 ` Alex Elder
0 siblings, 2 replies; 6+ messages in thread
From: Christoph Hellwig @ 2011-06-28 7:41 UTC (permalink / raw)
To: Dave Chinner; +Cc: xfs
On Tue, Jun 28, 2011 at 05:15:48PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Recent changes to debian unstable user space have caused the
> xfsprogs build to break as certain shell functionality is being
> assumed by libtool and friends. The configure scripts test and
> select the correct shell, but the input files ignore this and hard
> code the shell to use and hence now break.
>
> Fix this by using the shell that the configure scripts decide is the
> right one to use.
Looks good. The same fix should also be applied to xfsdump, xfstests
and dmapi.
Signed-off-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfsprogs: don't hard code the shell binary
2011-06-28 7:41 ` Christoph Hellwig
@ 2011-06-28 8:45 ` Dave Chinner
2011-07-14 18:27 ` Alex Elder
1 sibling, 0 replies; 6+ messages in thread
From: Dave Chinner @ 2011-06-28 8:45 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
On Tue, Jun 28, 2011 at 03:41:37AM -0400, Christoph Hellwig wrote:
> On Tue, Jun 28, 2011 at 05:15:48PM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > Recent changes to debian unstable user space have caused the
> > xfsprogs build to break as certain shell functionality is being
> > assumed by libtool and friends. The configure scripts test and
> > select the correct shell, but the input files ignore this and hard
> > code the shell to use and hence now break.
> >
> > Fix this by using the shell that the configure scripts decide is the
> > right one to use.
>
> Looks good. The same fix should also be applied to xfsdump, xfstests
> and dmapi.
Yes, it should. I just haven't got to them yet ;)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfsprogs: don't hard code the shell binary
2011-06-28 7:41 ` Christoph Hellwig
2011-06-28 8:45 ` Dave Chinner
@ 2011-07-14 18:27 ` Alex Elder
2011-07-16 18:08 ` Christoph Hellwig
1 sibling, 1 reply; 6+ messages in thread
From: Alex Elder @ 2011-07-14 18:27 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
On Tue, 2011-06-28 at 03:41 -0400, Christoph Hellwig wrote:
> On Tue, Jun 28, 2011 at 05:15:48PM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > Recent changes to debian unstable user space have caused the
> > xfsprogs build to break as certain shell functionality is being
> > assumed by libtool and friends. The configure scripts test and
> > select the correct shell, but the input files ignore this and hard
> > code the shell to use and hence now break.
> >
> > Fix this by using the shell that the configure scripts decide is the
> > right one to use.
>
> Looks good. The same fix should also be applied to xfsdump, xfstests
> and dmapi.
Agree.
Reviewed-by: Alex Elder <aelder@sgi.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfsprogs: don't hard code the shell binary
2011-07-14 18:27 ` Alex Elder
@ 2011-07-16 18:08 ` Christoph Hellwig
2011-07-17 1:48 ` Dave Chinner
0 siblings, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2011-07-16 18:08 UTC (permalink / raw)
To: Alex Elder; +Cc: xfs
Dave, can you commit this one ASAP to all trees? I just updated my test
system and I'm hitting the issue too now.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfsprogs: don't hard code the shell binary
2011-07-16 18:08 ` Christoph Hellwig
@ 2011-07-17 1:48 ` Dave Chinner
0 siblings, 0 replies; 6+ messages in thread
From: Dave Chinner @ 2011-07-17 1:48 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs, Alex Elder
On Sat, Jul 16, 2011 at 02:08:37PM -0400, Christoph Hellwig wrote:
> Dave, can you commit this one ASAP to all trees? I just updated my test
> system and I'm hitting the issue too now.
Done.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-07-17 1:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-28 7:15 [PATCH] xfsprogs: don't hard code the shell binary Dave Chinner
2011-06-28 7:41 ` Christoph Hellwig
2011-06-28 8:45 ` Dave Chinner
2011-07-14 18:27 ` Alex Elder
2011-07-16 18:08 ` Christoph Hellwig
2011-07-17 1:48 ` Dave Chinner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.