All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] panic: remove warning "'noreturn' function does return"
@ 2011-07-27  6:55 Heiko Schocher
  2011-07-28 20:54 ` Wolfgang Denk
  0 siblings, 1 reply; 2+ messages in thread
From: Heiko Schocher @ 2011-07-27  6:55 UTC (permalink / raw)
  To: u-boot

since commit

commit d2e8b911c0a0661d395ccac72156040702ac842d
Author: Mike Frysinger <vapier@gentoo.org>
Date:   Wed Jun 29 11:58:04 2011 +0000

    panic: add noreturn attribute

I see the following warnings:

vsprintf.c: In function 'panic':
vsprintf.c:730: warning: 'noreturn' function does return

for nearly all boards. This patch fixes this warning.

Signed-off-by: Heiko Schocher <hs@denx.de>
cc: Mike Frysinger <vapier@gentoo.org>
---
 lib/vsprintf.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index 3b924ec..c029fbb 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -727,4 +727,6 @@ void panic(const char *fmt, ...)
 	udelay (100000);	/* allow messages to go out */
 	do_reset (NULL, 0, 0, NULL);
 #endif
+	while (1)
+		;
 }
-- 
1.7.6

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH] panic: remove warning "'noreturn' function does return"
  2011-07-27  6:55 [U-Boot] [PATCH] panic: remove warning "'noreturn' function does return" Heiko Schocher
@ 2011-07-28 20:54 ` Wolfgang Denk
  0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Denk @ 2011-07-28 20:54 UTC (permalink / raw)
  To: u-boot

Dear Heiko Schocher,

In message <1311749757-20962-1-git-send-email-hs@denx.de> you wrote:
> since commit
> 
> commit d2e8b911c0a0661d395ccac72156040702ac842d
> Author: Mike Frysinger <vapier@gentoo.org>
> Date:   Wed Jun 29 11:58:04 2011 +0000
> 
>     panic: add noreturn attribute
> 
> I see the following warnings:
> 
> vsprintf.c: In function 'panic':
> vsprintf.c:730: warning: 'noreturn' function does return
> 
> for nearly all boards. This patch fixes this warning.
> 
> Signed-off-by: Heiko Schocher <hs@denx.de>
> cc: Mike Frysinger <vapier@gentoo.org>
> ---
>  lib/vsprintf.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"We don't have to protect the environment -- the Second Coming is  at
hand."                                                   - James Watt

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-07-28 20:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-27  6:55 [U-Boot] [PATCH] panic: remove warning "'noreturn' function does return" Heiko Schocher
2011-07-28 20:54 ` Wolfgang Denk

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.