[PATCH] wiznet: Add missing #include <linux/irq.h>

[PATCH] wiznet: Add missing #include <linux/irq.h>

[Geert Uytterhoeven]

m68k/allmodconfig:

drivers/net/ethernet/wiznet/w5100.c: In function ‘w5100_hw_probe’:
drivers/net/ethernet/wiznet/w5100.c:680: error: ‘IRQ_TYPE_LEVEL_LOW’ undeclared (first use in this function)
drivers/net/ethernet/wiznet/w5300.c: In function ‘w5300_hw_probe’:
drivers/net/ethernet/wiznet/w5300.c:594: error: ‘IRQ_TYPE_LEVEL_LOW’ undeclared (first use in this function)

Include <linux/irq.h>, which provides the declaration for IRQ_TYPE_LEVEL_LOW.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
--
Or should these drivers use IRQF_TRIGGER_LOW (from <linux/interrupt.h>)
instead?

http://kisskb.ellerman.id.au/kisskb/buildresult/6095757/
---
 drivers/net/ethernet/wiznet/w5100.c |    1 +
 drivers/net/ethernet/wiznet/w5300.c |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/net/ethernet/wiznet/w5100.c b/drivers/net/ethernet/wiznet/w5100.c
index c28e1d5..ecc6820 100644
--- a/drivers/net/ethernet/wiznet/w5100.c
+++ b/drivers/net/ethernet/wiznet/w5100.c
@@ -24,6 +24,7 @@
 #include <linux/io.h>
 #include <linux/ioport.h>
 #include <linux/interrupt.h>
+#include <linux/irq.h>
 #include <linux/gpio.h>
 
 #define DRV_NAME	"w5100"
diff --git a/drivers/net/ethernet/wiznet/w5300.c b/drivers/net/ethernet/wiznet/w5300.c
index 88afde9..0a20797 100644
--- a/drivers/net/ethernet/wiznet/w5300.c
+++ b/drivers/net/ethernet/wiznet/w5300.c
@@ -25,6 +25,7 @@
 #include <linux/io.h>
 #include <linux/ioport.h>
 #include <linux/interrupt.h>
+#include <linux/irq.h>
 #include <linux/gpio.h>
 
 #define DRV_NAME	"w5300"
-- 
1.7.0.4

Re: [PATCH] wiznet: Add missing #include <linux/irq.h>

[David Miller]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: Text/Plain; charset=iso-8859-7, Size: 786 bytes --]

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Thu, 12 Apr 2012 21:19:23 +0200

> m68k/allmodconfig:
> 
> drivers/net/ethernet/wiznet/w5100.c: In function ¡w5100_hw_probe¢:
> drivers/net/ethernet/wiznet/w5100.c:680: error: ¡IRQ_TYPE_LEVEL_LOW¢ undeclared (first use in this function)
> drivers/net/ethernet/wiznet/w5300.c: In function ¡w5300_hw_probe¢:
> drivers/net/ethernet/wiznet/w5300.c:594: error: ¡IRQ_TYPE_LEVEL_LOW¢ undeclared (first use in this function)
> 
> Include <linux/irq.h>, which provides the declaration for IRQ_TYPE_LEVEL_LOW.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Applied.
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [PATCH] wiznet: Add missing #include <linux/irq.h>

[David Miller]

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Thu, 12 Apr 2012 21:19:23 +0200

> m68k/allmodconfig:
> 
> drivers/net/ethernet/wiznet/w5100.c: In function ‘w5100_hw_probe’:
> drivers/net/ethernet/wiznet/w5100.c:680: error: ‘IRQ_TYPE_LEVEL_LOW’ undeclared (first use in this function)
> drivers/net/ethernet/wiznet/w5300.c: In function ‘w5300_hw_probe’:
> drivers/net/ethernet/wiznet/w5300.c:594: error: ‘IRQ_TYPE_LEVEL_LOW’ undeclared (first use in this function)
> 
> Include <linux/irq.h>, which provides the declaration for IRQ_TYPE_LEVEL_LOW.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Applied.