* autoconf: --enable-githttp doesn't work
@ 2012-04-13 9:16 Ian Campbell
2012-04-13 10:16 ` Roger Pau Monne
0 siblings, 1 reply; 3+ messages in thread
From: Ian Campbell @ 2012-04-13 9:16 UTC (permalink / raw)
To: xen-devel; +Cc: Roger Pau Monne
This is because the toplevel Config.mk does not include config/Tools.mk
and therefore GIT_HTTP is not defined.
I'm not sure what the best fix here is, we don't really want to include
config/Tools.mk in the top-level Config.mk since that would mean you had
to run configure to build the hypervisor, which we want to avoid.
Perhaps a bunch of the tools-level config stuff from Config.mk should go
into config/Tools.mk.in? It looks like most of the content of Config.mk
from the definition of QEMU_REMOTE onwards could/should be moved but
I've not actually tried it.
Or perhaps some stuff should become actual configure options,
CONFIG_{OVMF,ROMBIOS,SEABIOS} and ETHERBOOT_NICS seem like good
candidates for that. Perhaps --qemu-upstream-url=URL etc make sense too?
I'm less sure there.
Ian.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: autoconf: --enable-githttp doesn't work
2012-04-13 9:16 autoconf: --enable-githttp doesn't work Ian Campbell
@ 2012-04-13 10:16 ` Roger Pau Monne
2012-04-13 10:19 ` Ian Campbell
0 siblings, 1 reply; 3+ messages in thread
From: Roger Pau Monne @ 2012-04-13 10:16 UTC (permalink / raw)
To: Ian Campbell; +Cc: xen-devel
El 13/04/2012, a las 10:16, Ian Campbell escribió:
> This is because the toplevel Config.mk does not include config/Tools.mk
> and therefore GIT_HTTP is not defined.
Yes, sorry, this is a leftover from when I though that the output from configure would be used by the top level Config.mk file.
>
> I'm not sure what the best fix here is, we don't really want to include
> config/Tools.mk in the top-level Config.mk since that would mean you had
> to run configure to build the hypervisor, which we want to avoid.
>
> Perhaps a bunch of the tools-level config stuff from Config.mk should go
> into config/Tools.mk.in? It looks like most of the content of Config.mk
> from the definition of QEMU_REMOTE onwards could/should be moved but
> I've not actually tried it.
Probably, I don't think any of this are used by the hypervisor.
>
> Or perhaps some stuff should become actual configure options,
> CONFIG_{OVMF,ROMBIOS,SEABIOS} and ETHERBOOT_NICS seem like good
> candidates for that. Perhaps --qemu-upstream-url=URL etc make sense too?
I'm quite confident this:
CONFIG_OVMF ?= n
CONFIG_ROMBIOS ?= y
CONFIG_SEABIOS ?= y
should become configure options, if (as I think) they have no relation with the hypervisor. I'm not really confident that letting the user set it's own qemu/seabios… repository so easily is a good idea.
> I'm less sure there.
>
> Ian.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: autoconf: --enable-githttp doesn't work
2012-04-13 10:16 ` Roger Pau Monne
@ 2012-04-13 10:19 ` Ian Campbell
0 siblings, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2012-04-13 10:19 UTC (permalink / raw)
To: Roger Pau Monne; +Cc: xen-devel
On Fri, 2012-04-13 at 11:16 +0100, Roger Pau Monne wrote:
> I'm quite confident this:
>
> CONFIG_OVMF ?= n
> CONFIG_ROMBIOS ?= y
> CONFIG_SEABIOS ?= y
>
> should become configure options, if (as I think) they have no relation
> with the hypervisor.
I'm pretty sure they have no relation with the hypervisor.
> I'm not really confident that letting the user set it's own
> qemu/seabios… repository so easily is a good idea.
Lets just move those to Tools.mk.in then, if there's demand for an
option later we can always do it then.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-13 10:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-13 9:16 autoconf: --enable-githttp doesn't work Ian Campbell
2012-04-13 10:16 ` Roger Pau Monne
2012-04-13 10:19 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.