All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] [EXT4] super.c: unused variable warning without CONFIG_QUOTA
@ 2012-04-22 15:50 Eldad Zack
  2012-04-24  1:39   ` Ted Ts'o
  0 siblings, 1 reply; 3+ messages in thread
From: Eldad Zack @ 2012-04-22 15:50 UTC (permalink / raw)
  To: Theodore Ts'o, Andreas Dilger, linux-ext4, linux-kernel; +Cc: Eldad Zack

sb info is only checked with quota support.

fs/ext4/super.c: In function ‘parse_options’:
fs/ext4/super.c:1600:23: warning: unused variable ‘sbi’ [-Wunused-variable]

Signed-off-by: Eldad Zack <eldad@fogrefinery.com>
---
 fs/ext4/super.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 6da1935..e1fb1d5 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1597,7 +1597,9 @@ static int parse_options(char *options, struct super_block *sb,
 			 unsigned int *journal_ioprio,
 			 int is_remount)
 {
+#ifdef CONFIG_QUOTA
 	struct ext4_sb_info *sbi = EXT4_SB(sb);
+#endif
 	char *p;
 	substring_t args[MAX_OPT_ARGS];
 	int token;
-- 
1.7.10


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] [EXT4] super.c: unused variable warning without CONFIG_QUOTA
  2012-04-22 15:50 [PATCH] [EXT4] super.c: unused variable warning without CONFIG_QUOTA Eldad Zack
@ 2012-04-24  1:39   ` Ted Ts'o
  0 siblings, 0 replies; 3+ messages in thread
From: Ted Ts'o @ 2012-04-24  1:39 UTC (permalink / raw)
  To: Eldad Zack; +Cc: Andreas Dilger, linux-ext4, linux-kernel

On Sun, Apr 22, 2012 at 05:50:52PM +0200, Eldad Zack wrote:
> sb info is only checked with quota support.
> 
> fs/ext4/super.c: In function ‘parse_options’:
> fs/ext4/super.c:1600:23: warning: unused variable ‘sbi’ [-Wunused-variable]
> 
> Signed-off-by: Eldad Zack <eldad@fogrefinery.com>

Thanks, applied.

					- Ted

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] [EXT4] super.c: unused variable warning without CONFIG_QUOTA
@ 2012-04-24  1:39   ` Ted Ts'o
  0 siblings, 0 replies; 3+ messages in thread
From: Ted Ts'o @ 2012-04-24  1:39 UTC (permalink / raw)
  To: Eldad Zack; +Cc: Andreas Dilger, linux-ext4, linux-kernel

On Sun, Apr 22, 2012 at 05:50:52PM +0200, Eldad Zack wrote:
> sb info is only checked with quota support.
> 
> fs/ext4/super.c: In function ‘parse_options’:
> fs/ext4/super.c:1600:23: warning: unused variable ‘sbi’ [-Wunused-variable]
> 
> Signed-off-by: Eldad Zack <eldad@fogrefinery.com>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-04-24  1:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-22 15:50 [PATCH] [EXT4] super.c: unused variable warning without CONFIG_QUOTA Eldad Zack
2012-04-24  1:39 ` Ted Ts'o
2012-04-24  1:39   ` Ted Ts'o

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.