All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fs: btrfs: Replaced calls to kmalloc and memcpy with kmemdup
@ 2013-03-09 12:42 Alexandru Gheorghiu
  0 siblings, 0 replies; only message in thread
From: Alexandru Gheorghiu @ 2013-03-09 12:42 UTC (permalink / raw)
  To: Chris Mason; +Cc: linux-btrfs, linux-kernel, Alexandru Gheorghiu

Replaced calls to kmalloc followed by memcpy with single call to kmemdup.
This patch was found using coccicheck.

Signed-off-by: Alexandru Gheorghiu <gheorghiuandru@gmail.com>
---
 fs/btrfs/send.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
index f7a8b86..f1e1e34 100644
--- a/fs/btrfs/send.c
+++ b/fs/btrfs/send.c
@@ -3429,10 +3429,9 @@ static int __find_xattr(int num, struct btrfs_key *di_key,
 	    strncmp(name, ctx->name, name_len) == 0) {
 		ctx->found_idx = num;
 		ctx->found_data_len = data_len;
-		ctx->found_data = kmalloc(data_len, GFP_NOFS);
+		ctx->found_data = kmemdup(data, data_len, GFP_NOFS);
 		if (!ctx->found_data)
 			return -ENOMEM;
-		memcpy(ctx->found_data, data, data_len);
 		return 1;
 	}
 	return 0;
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2013-03-10 23:42 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-09 12:42 [PATCH] fs: btrfs: Replaced calls to kmalloc and memcpy with kmemdup Alexandru Gheorghiu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.