From: Wolfram Sang <wsa@the-dreams.de> To: linux-kernel@vger.kernel.org Cc: Wolfram Sang <wsa@the-dreams.de>, Thierry Reding <thierry.reding@avionic-design.de>, Stephen Warren <swarren@wwwdotorg.org>, Tony Prisk <linux@prisktech.co.nz>, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 15/33] drivers/pwm: don't check resource with devm_ioremap_resource Date: Thu, 16 May 2013 13:15:43 +0200 [thread overview] Message-ID: <1368702961-4325-16-git-send-email-wsa@the-dreams.de> (raw) In-Reply-To: <1368702961-4325-1-git-send-email-wsa@the-dreams.de> devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang <wsa@the-dreams.de> --- drivers/pwm/pwm-imx.c | 5 ----- drivers/pwm/pwm-puv3.c | 5 ----- drivers/pwm/pwm-pxa.c | 5 ----- drivers/pwm/pwm-tegra.c | 5 ----- drivers/pwm/pwm-tiecap.c | 5 ----- drivers/pwm/pwm-tiehrpwm.c | 5 ----- drivers/pwm/pwm-tipwmss.c | 5 ----- drivers/pwm/pwm-vt8500.c | 5 ----- 8 files changed, 40 deletions(-) diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c index ec28798..c938bae 100644 --- a/drivers/pwm/pwm-imx.c +++ b/drivers/pwm/pwm-imx.c @@ -265,11 +265,6 @@ static int imx_pwm_probe(struct platform_device *pdev) imx->chip.npwm = 1; r = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (r == NULL) { - dev_err(&pdev->dev, "no memory resource defined\n"); - return -ENODEV; - } - imx->mmio_base = devm_ioremap_resource(&pdev->dev, r); if (IS_ERR(imx->mmio_base)) return PTR_ERR(imx->mmio_base); diff --git a/drivers/pwm/pwm-puv3.c b/drivers/pwm/pwm-puv3.c index d1eb499..ed6007b 100644 --- a/drivers/pwm/pwm-puv3.c +++ b/drivers/pwm/pwm-puv3.c @@ -117,11 +117,6 @@ static int pwm_probe(struct platform_device *pdev) return PTR_ERR(puv3->clk); r = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (r == NULL) { - dev_err(&pdev->dev, "no memory resource defined\n"); - return -ENODEV; - } - puv3->base = devm_ioremap_resource(&pdev->dev, r); if (IS_ERR(puv3->base)) return PTR_ERR(puv3->base); diff --git a/drivers/pwm/pwm-pxa.c b/drivers/pwm/pwm-pxa.c index dee6ab55..dc97175 100644 --- a/drivers/pwm/pwm-pxa.c +++ b/drivers/pwm/pwm-pxa.c @@ -147,11 +147,6 @@ static int pwm_probe(struct platform_device *pdev) pwm->chip.npwm = (id->driver_data & HAS_SECONDARY_PWM) ? 2 : 1; r = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (r == NULL) { - dev_err(&pdev->dev, "no memory resource defined\n"); - return -ENODEV; - } - pwm->mmio_base = devm_ioremap_resource(&pdev->dev, r); if (IS_ERR(pwm->mmio_base)) return PTR_ERR(pwm->mmio_base); diff --git a/drivers/pwm/pwm-tegra.c b/drivers/pwm/pwm-tegra.c index 3d75f4a..a540293 100644 --- a/drivers/pwm/pwm-tegra.c +++ b/drivers/pwm/pwm-tegra.c @@ -181,11 +181,6 @@ static int tegra_pwm_probe(struct platform_device *pdev) pwm->dev = &pdev->dev; r = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!r) { - dev_err(&pdev->dev, "no memory resources defined\n"); - return -ENODEV; - } - pwm->mmio_base = devm_ioremap_resource(&pdev->dev, r); if (IS_ERR(pwm->mmio_base)) return PTR_ERR(pwm->mmio_base); diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c index 0d65fb2..72ca42d 100644 --- a/drivers/pwm/pwm-tiecap.c +++ b/drivers/pwm/pwm-tiecap.c @@ -240,11 +240,6 @@ static int ecap_pwm_probe(struct platform_device *pdev) pc->chip.npwm = 1; r = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!r) { - dev_err(&pdev->dev, "no memory resource defined\n"); - return -ENODEV; - } - pc->mmio_base = devm_ioremap_resource(&pdev->dev, r); if (IS_ERR(pc->mmio_base)) return PTR_ERR(pc->mmio_base); diff --git a/drivers/pwm/pwm-tiehrpwm.c b/drivers/pwm/pwm-tiehrpwm.c index 6a21759..48a485c 100644 --- a/drivers/pwm/pwm-tiehrpwm.c +++ b/drivers/pwm/pwm-tiehrpwm.c @@ -471,11 +471,6 @@ static int ehrpwm_pwm_probe(struct platform_device *pdev) pc->chip.npwm = NUM_PWM_CHANNEL; r = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!r) { - dev_err(&pdev->dev, "no memory resource defined\n"); - return -ENODEV; - } - pc->mmio_base = devm_ioremap_resource(&pdev->dev, r); if (IS_ERR(pc->mmio_base)) return PTR_ERR(pc->mmio_base); diff --git a/drivers/pwm/pwm-tipwmss.c b/drivers/pwm/pwm-tipwmss.c index c9c3d3a..3b119bc 100644 --- a/drivers/pwm/pwm-tipwmss.c +++ b/drivers/pwm/pwm-tipwmss.c @@ -70,11 +70,6 @@ static int pwmss_probe(struct platform_device *pdev) mutex_init(&info->pwmss_lock); r = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!r) { - dev_err(&pdev->dev, "no memory resource defined\n"); - return -ENODEV; - } - info->mmio_base = devm_ioremap_resource(&pdev->dev, r); if (IS_ERR(info->mmio_base)) return PTR_ERR(info->mmio_base); diff --git a/drivers/pwm/pwm-vt8500.c b/drivers/pwm/pwm-vt8500.c index 69effd1..323125a 100644 --- a/drivers/pwm/pwm-vt8500.c +++ b/drivers/pwm/pwm-vt8500.c @@ -230,11 +230,6 @@ static int vt8500_pwm_probe(struct platform_device *pdev) } r = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (r == NULL) { - dev_err(&pdev->dev, "no memory resource defined\n"); - return -ENODEV; - } - chip->base = devm_ioremap_resource(&pdev->dev, r); if (IS_ERR(chip->base)) return PTR_ERR(chip->base); -- 1.7.10.4
WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 15/33] drivers/pwm: don't check resource with devm_ioremap_resource Date: Thu, 16 May 2013 13:15:43 +0200 [thread overview] Message-ID: <1368702961-4325-16-git-send-email-wsa@the-dreams.de> (raw) In-Reply-To: <1368702961-4325-1-git-send-email-wsa@the-dreams.de> devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang <wsa@the-dreams.de> --- drivers/pwm/pwm-imx.c | 5 ----- drivers/pwm/pwm-puv3.c | 5 ----- drivers/pwm/pwm-pxa.c | 5 ----- drivers/pwm/pwm-tegra.c | 5 ----- drivers/pwm/pwm-tiecap.c | 5 ----- drivers/pwm/pwm-tiehrpwm.c | 5 ----- drivers/pwm/pwm-tipwmss.c | 5 ----- drivers/pwm/pwm-vt8500.c | 5 ----- 8 files changed, 40 deletions(-) diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c index ec28798..c938bae 100644 --- a/drivers/pwm/pwm-imx.c +++ b/drivers/pwm/pwm-imx.c @@ -265,11 +265,6 @@ static int imx_pwm_probe(struct platform_device *pdev) imx->chip.npwm = 1; r = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (r == NULL) { - dev_err(&pdev->dev, "no memory resource defined\n"); - return -ENODEV; - } - imx->mmio_base = devm_ioremap_resource(&pdev->dev, r); if (IS_ERR(imx->mmio_base)) return PTR_ERR(imx->mmio_base); diff --git a/drivers/pwm/pwm-puv3.c b/drivers/pwm/pwm-puv3.c index d1eb499..ed6007b 100644 --- a/drivers/pwm/pwm-puv3.c +++ b/drivers/pwm/pwm-puv3.c @@ -117,11 +117,6 @@ static int pwm_probe(struct platform_device *pdev) return PTR_ERR(puv3->clk); r = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (r == NULL) { - dev_err(&pdev->dev, "no memory resource defined\n"); - return -ENODEV; - } - puv3->base = devm_ioremap_resource(&pdev->dev, r); if (IS_ERR(puv3->base)) return PTR_ERR(puv3->base); diff --git a/drivers/pwm/pwm-pxa.c b/drivers/pwm/pwm-pxa.c index dee6ab55..dc97175 100644 --- a/drivers/pwm/pwm-pxa.c +++ b/drivers/pwm/pwm-pxa.c @@ -147,11 +147,6 @@ static int pwm_probe(struct platform_device *pdev) pwm->chip.npwm = (id->driver_data & HAS_SECONDARY_PWM) ? 2 : 1; r = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (r == NULL) { - dev_err(&pdev->dev, "no memory resource defined\n"); - return -ENODEV; - } - pwm->mmio_base = devm_ioremap_resource(&pdev->dev, r); if (IS_ERR(pwm->mmio_base)) return PTR_ERR(pwm->mmio_base); diff --git a/drivers/pwm/pwm-tegra.c b/drivers/pwm/pwm-tegra.c index 3d75f4a..a540293 100644 --- a/drivers/pwm/pwm-tegra.c +++ b/drivers/pwm/pwm-tegra.c @@ -181,11 +181,6 @@ static int tegra_pwm_probe(struct platform_device *pdev) pwm->dev = &pdev->dev; r = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!r) { - dev_err(&pdev->dev, "no memory resources defined\n"); - return -ENODEV; - } - pwm->mmio_base = devm_ioremap_resource(&pdev->dev, r); if (IS_ERR(pwm->mmio_base)) return PTR_ERR(pwm->mmio_base); diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c index 0d65fb2..72ca42d 100644 --- a/drivers/pwm/pwm-tiecap.c +++ b/drivers/pwm/pwm-tiecap.c @@ -240,11 +240,6 @@ static int ecap_pwm_probe(struct platform_device *pdev) pc->chip.npwm = 1; r = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!r) { - dev_err(&pdev->dev, "no memory resource defined\n"); - return -ENODEV; - } - pc->mmio_base = devm_ioremap_resource(&pdev->dev, r); if (IS_ERR(pc->mmio_base)) return PTR_ERR(pc->mmio_base); diff --git a/drivers/pwm/pwm-tiehrpwm.c b/drivers/pwm/pwm-tiehrpwm.c index 6a21759..48a485c 100644 --- a/drivers/pwm/pwm-tiehrpwm.c +++ b/drivers/pwm/pwm-tiehrpwm.c @@ -471,11 +471,6 @@ static int ehrpwm_pwm_probe(struct platform_device *pdev) pc->chip.npwm = NUM_PWM_CHANNEL; r = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!r) { - dev_err(&pdev->dev, "no memory resource defined\n"); - return -ENODEV; - } - pc->mmio_base = devm_ioremap_resource(&pdev->dev, r); if (IS_ERR(pc->mmio_base)) return PTR_ERR(pc->mmio_base); diff --git a/drivers/pwm/pwm-tipwmss.c b/drivers/pwm/pwm-tipwmss.c index c9c3d3a..3b119bc 100644 --- a/drivers/pwm/pwm-tipwmss.c +++ b/drivers/pwm/pwm-tipwmss.c @@ -70,11 +70,6 @@ static int pwmss_probe(struct platform_device *pdev) mutex_init(&info->pwmss_lock); r = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!r) { - dev_err(&pdev->dev, "no memory resource defined\n"); - return -ENODEV; - } - info->mmio_base = devm_ioremap_resource(&pdev->dev, r); if (IS_ERR(info->mmio_base)) return PTR_ERR(info->mmio_base); diff --git a/drivers/pwm/pwm-vt8500.c b/drivers/pwm/pwm-vt8500.c index 69effd1..323125a 100644 --- a/drivers/pwm/pwm-vt8500.c +++ b/drivers/pwm/pwm-vt8500.c @@ -230,11 +230,6 @@ static int vt8500_pwm_probe(struct platform_device *pdev) } r = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (r == NULL) { - dev_err(&pdev->dev, "no memory resource defined\n"); - return -ENODEV; - } - chip->base = devm_ioremap_resource(&pdev->dev, r); if (IS_ERR(chip->base)) return PTR_ERR(chip->base); -- 1.7.10.4
next prev parent reply other threads:[~2013-05-16 11:15 UTC|newest] Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-05-16 11:15 [PATCH 00/33] devm improvement series, part 1, take 2 Wolfram Sang 2013-05-16 11:15 ` Wolfram Sang 2013-05-16 11:15 ` Wolfram Sang 2013-05-16 11:15 ` [PATCH 01/33] drivers/ata: don't check resource with devm_ioremap_resource Wolfram Sang 2013-05-16 11:15 ` [PATCH 02/33] drivers/char/hw_random: " Wolfram Sang 2013-05-16 11:15 ` [PATCH 03/33] drivers/cpufreq: " Wolfram Sang 2013-05-16 11:15 ` Viresh Kumar [not found] ` <1368702961-4325-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> 2013-05-16 11:15 ` [PATCH 04/33] drivers/dma: " Wolfram Sang 2013-05-16 11:15 ` Wolfram Sang 2013-05-16 11:15 ` [PATCH 17/33] drivers/spi: " Wolfram Sang 2013-05-16 11:15 ` Wolfram Sang 2013-05-16 11:15 ` [PATCH 05/33] drivers/gpio: " Wolfram Sang 2013-05-16 11:15 ` [PATCH 06/33] drivers/gpu/drm/exynos: " Wolfram Sang 2013-05-16 11:15 ` [PATCH 07/33] drivers/gpu/host1x/drm: " Wolfram Sang 2013-05-16 11:15 ` [PATCH 08/33] drivers/i2c/busses: " Wolfram Sang 2013-05-16 11:15 ` Wolfram Sang [not found] ` <1368702961-4325-9-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> 2013-05-16 12:22 ` Barry Song 2013-05-16 12:22 ` Barry Song 2013-05-16 12:22 ` Barry Song 2013-05-20 16:40 ` Kukjin Kim 2013-05-20 16:40 ` Kukjin Kim 2013-05-16 11:15 ` [PATCH 09/33] drivers/memory: " Wolfram Sang 2013-05-16 11:15 ` [PATCH 10/33] drivers/mfd: " Wolfram Sang 2013-05-16 11:15 ` [PATCH 11/33] drivers/misc: " Wolfram Sang 2013-05-16 11:15 ` [PATCH 12/33] drivers/mtd/nand: " Wolfram Sang 2013-05-16 11:15 ` Wolfram Sang 2013-05-16 11:15 ` [PATCH 13/33] drivers/net/ethernet/renesas: " Wolfram Sang 2013-05-16 15:37 ` Joe Perches 2013-05-16 11:15 ` [PATCH 14/33] drivers/pinctrl: " Wolfram Sang 2013-05-20 11:39 ` Linus Walleij 2013-05-20 17:13 ` Wolfram Sang 2013-05-20 18:34 ` Linus Walleij 2013-05-16 11:15 ` Wolfram Sang [this message] 2013-05-16 11:15 ` [PATCH 15/33] drivers/pwm: " Wolfram Sang 2013-05-16 11:15 ` [PATCH 16/33] drivers/rtc: " Wolfram Sang 2013-05-16 11:15 ` Wolfram Sang 2013-05-16 11:15 ` Wolfram Sang 2013-05-16 11:15 ` [PATCH 18/33] drivers/staging/dwc2: " Wolfram Sang 2013-05-16 11:15 ` [PATCH 19/33] drivers/staging/nvec: " Wolfram Sang 2013-05-16 11:15 ` Wolfram Sang 2013-05-16 11:15 ` [PATCH 20/33] drivers/thermal: " Wolfram Sang 2013-05-20 15:38 ` Zhang, Rui 2013-05-16 11:15 ` [PATCH 21/33] drivers/usb/chipidea: " Wolfram Sang 2013-05-16 11:29 ` Alexander Shishkin 2013-05-16 11:15 ` [PATCH 22/33] drivers/usb/gadget: " Wolfram Sang 2013-05-16 11:15 ` [PATCH 23/33] drivers/usb/host: " Wolfram Sang 2013-05-16 14:27 ` Alan Stern 2013-05-16 11:15 ` [PATCH 24/33] drivers/usb/phy: " Wolfram Sang 2013-05-16 11:15 ` [PATCH 25/33] drivers/video/omap2: " Wolfram Sang 2013-05-16 11:15 ` Wolfram Sang 2013-05-16 11:15 ` [PATCH 26/33] drivers/video/omap2/dss: " Wolfram Sang 2013-05-16 11:15 ` Wolfram Sang 2013-05-16 11:15 ` [PATCH 27/33] drivers/w1/masters: " Wolfram Sang 2013-05-16 11:15 ` [PATCH 28/33] drivers/watchdog: " Wolfram Sang 2013-05-16 11:15 ` [PATCH 29/33] arch/arm/mach-tegra: " Wolfram Sang 2013-05-16 11:15 ` Wolfram Sang 2013-05-16 11:15 ` [PATCH 30/33] arch/arm/plat-samsung: " Wolfram Sang 2013-05-16 11:15 ` Wolfram Sang 2013-05-20 16:38 ` Kukjin Kim 2013-05-20 16:38 ` Kukjin Kim 2013-05-20 17:11 ` Wolfram Sang 2013-05-20 17:11 ` Wolfram Sang 2013-05-20 17:13 ` Kukjin Kim 2013-05-20 17:13 ` Kukjin Kim 2013-05-16 11:15 ` [PATCH 31/33] arch/mips/lantiq/xway: " Wolfram Sang 2013-05-16 14:42 ` John Crispin 2013-05-16 11:16 ` [PATCH 32/33] sound/soc/fsl: " Wolfram Sang 2013-05-16 11:16 ` [PATCH 33/33] sound/soc/kirkwood: " Wolfram Sang 2013-05-16 11:57 ` [PATCH 00/33] devm improvement series, part 1, take 2 Artem Bityutskiy 2013-05-16 11:57 ` Artem Bityutskiy 2013-05-16 11:57 ` Artem Bityutskiy 2013-05-16 12:55 ` Viresh Kumar 2013-05-16 12:55 ` Viresh Kumar 2013-05-16 12:55 ` Viresh Kumar 2013-05-16 12:55 ` Viresh Kumar 2013-05-16 13:11 ` Artem Bityutskiy 2013-05-16 13:11 ` Artem Bityutskiy 2013-05-16 13:11 ` Artem Bityutskiy 2013-05-16 13:11 ` Artem Bityutskiy 2013-05-16 13:11 ` Artem Bityutskiy 2013-05-16 13:17 ` Tomi Valkeinen 2013-05-16 13:17 ` Tomi Valkeinen 2013-05-16 13:17 ` Tomi Valkeinen 2013-05-16 13:17 ` Tomi Valkeinen 2013-05-16 13:17 ` Tomi Valkeinen 2013-05-16 16:13 ` Wolfram Sang 2013-05-16 16:13 ` Wolfram Sang 2013-05-16 16:13 ` Wolfram Sang 2013-05-16 16:13 ` Wolfram Sang 2013-05-16 18:29 ` Stephen Warren 2013-05-16 18:29 ` Stephen Warren 2013-05-16 18:29 ` Stephen Warren 2013-05-16 18:29 ` Stephen Warren 2013-05-23 20:32 ` Thierry Reding 2013-05-23 20:32 ` Thierry Reding 2013-05-23 20:32 ` Thierry Reding
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1368702961-4325-16-git-send-email-wsa@the-dreams.de \ --to=wsa@the-dreams.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=linux@prisktech.co.nz \ --cc=swarren@wwwdotorg.org \ --cc=thierry.reding@avionic-design.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.