* [PATCH] powerpc/85xx: DTS - re-organize the SPI partitions property
@ 2013-09-06 8:05 Mingkai Hu
2013-09-10 23:33 ` Scott Wood
0 siblings, 1 reply; 10+ messages in thread
From: Mingkai Hu @ 2013-09-06 8:05 UTC (permalink / raw)
To: linuxppc-dev; +Cc: scottwood, Mingkai Hu
Re-organize the SPI partitions and use the same SPI flash memory
map for most of the platforms which have 16MB SPI flash mounted.
1. Extend the U-Boot partition to 1MB
The image for booting from SPI is larger than 512KB, while
the size of U-Boot partition is 512KB on some boards, so
enlarge it to 1MB in order to contain the whole U-Boot image.
2. Reserve space for U-Boot environment variables
The environment variables are stored at offset 0x100000, so
if other image was put at this address, it'll be overlapped
when saving the environment variables.
3. Reserve space for FMAN ucode
The FMAN ucode is required on DPAA platform and is stored at
offset 0x110000, this address should not be used to store any
other images.
4. Extend the kernel partition to 5MB
Here is diagram for the SPI flash memory map:
0x000000 |-------------|
| U-Boot |
| (1MB) |
0x100000 |-------------|
| Env(64KB) |
0x110000 |-------------|
| ucode |
0x180000 |-------------|
| DTB |
| (512KB) |
0x200000 |-------------|
| kernel |
| (5MB) |
0x700000 |-------------|
| file system |
| (9MB) |
0x1000000 |-------------|
Signed-off-by: Mingkai Hu <Mingkai.Hu@freescale.com>
---
Based on 'next' branch on git tree:
git://git.kernel.org/pub/scm/linux/kernel/git/scottwood/linux.git
arch/powerpc/boot/dts/bsc9131rdb.dtsi | 35 ++++++++++++-----------------
arch/powerpc/boot/dts/c293pcie.dts | 35 ++++++++++++-----------------
arch/powerpc/boot/dts/mpc8536ds.dtsi | 12 +++++-----
arch/powerpc/boot/dts/p1010rdb.dtsi | 40 ++++++++++++----------------------
arch/powerpc/boot/dts/p1020rdb-pc.dtsi | 24 +++++---------------
arch/powerpc/boot/dts/p1020rdb-pd.dts | 34 ++++++++++++-----------------
arch/powerpc/boot/dts/p1020rdb.dtsi | 23 ++++---------------
arch/powerpc/boot/dts/p1021mds.dts | 17 +++++++--------
arch/powerpc/boot/dts/p1021rdb-pc.dtsi | 32 +++++++++------------------
arch/powerpc/boot/dts/p1022ds.dtsi | 21 +++++++++---------
arch/powerpc/boot/dts/p1023rds.dts | 10 ++-------
arch/powerpc/boot/dts/p1024rdb.dtsi | 40 ++++++++++++----------------------
arch/powerpc/boot/dts/p1025rdb.dtsi | 23 +++++--------------
arch/powerpc/boot/dts/p2020rdb-pc.dtsi | 40 ++++++++++++----------------------
arch/powerpc/boot/dts/p2020rdb.dts | 38 ++++++++++----------------------
arch/powerpc/boot/dts/p2041rdb.dts | 12 +++++-----
arch/powerpc/boot/dts/p3041ds.dts | 12 +++++-----
arch/powerpc/boot/dts/p4080ds.dts | 12 +++++-----
arch/powerpc/boot/dts/p5020ds.dts | 12 +++++-----
arch/powerpc/boot/dts/p5040ds.dts | 13 ++++++-----
20 files changed, 180 insertions(+), 305 deletions(-)
diff --git a/arch/powerpc/boot/dts/bsc9131rdb.dtsi b/arch/powerpc/boot/dts/bsc9131rdb.dtsi
index 9e6c013..8250593 100644
--- a/arch/powerpc/boot/dts/bsc9131rdb.dtsi
+++ b/arch/powerpc/boot/dts/bsc9131rdb.dtsi
@@ -81,32 +81,25 @@
compatible = "spansion,s25sl12801";
reg = <0>;
spi-max-frequency = <50000000>;
-
- /* 512KB for u-boot Bootloader Image */
- partition@0 {
- reg = <0x0 0x00080000>;
- label = "SPI Flash U-Boot Image";
+ partition@u-boot {
+ label = "u-boot";
+ reg = <0x00000000 0x00100000>;
read-only;
};
-
- /* 512KB for DTB Image */
- partition@80000 {
- reg = <0x00080000 0x00080000>;
- label = "SPI Flash DTB Image";
+ partition@dtb {
+ label = "dtb";
+ reg = <0x00180000 0x00080000>;
+ read-only;
};
-
- /* 4MB for Linux Kernel Image */
- partition@100000 {
- reg = <0x00100000 0x00400000>;
- label = "SPI Flash Kernel Image";
+ partition@kernel {
+ label = "kernel";
+ reg = <0x00200000 0x00500000>;
+ read-only;
};
-
- /*11MB for RFS Image */
- partition@500000 {
- reg = <0x00500000 0x00B00000>;
- label = "SPI Flash RFS Image";
+ partition@fs {
+ label = "file system";
+ reg = <0x00700000 0x00900000>;
};
-
};
};
diff --git a/arch/powerpc/boot/dts/c293pcie.dts b/arch/powerpc/boot/dts/c293pcie.dts
index 1238bda..8ee8459 100644
--- a/arch/powerpc/boot/dts/c293pcie.dts
+++ b/arch/powerpc/boot/dts/c293pcie.dts
@@ -169,31 +169,24 @@
compatible = "spansion,s25sl12801";
reg = <0>;
spi-max-frequency = <50000000>;
-
- partition@0 {
- /* 1MB for u-boot Bootloader Image */
- /* 1MB for Environment */
- reg = <0x0 0x00100000>;
- label = "SPI Flash U-Boot Image";
+ partition@u-boot {
+ label = "u-boot";
+ reg = <0x00000000 0x00100000>;
read-only;
};
-
- partition@100000 {
- /* 512KB for DTB Image */
- reg = <0x00100000 0x00080000>;
- label = "SPI Flash DTB Image";
+ partition@dtb {
+ label = "dtb";
+ reg = <0x00180000 0x00080000>;
+ read-only;
};
-
- partition@180000 {
- /* 4MB for Linux Kernel Image */
- reg = <0x00180000 0x00400000>;
- label = "SPI Flash Linux Kernel Image";
+ partition@kernel {
+ label = "kernel";
+ reg = <0x00200000 0x00500000>;
+ read-only;
};
-
- partition@580000 {
- /* 10.5MB for RFS Image */
- reg = <0x00580000 0x00a80000>;
- label = "SPI Flash RFS Image";
+ partition@fs {
+ label = "file system";
+ reg = <0x00700000 0x00900000>;
};
};
};
diff --git a/arch/powerpc/boot/dts/mpc8536ds.dtsi b/arch/powerpc/boot/dts/mpc8536ds.dtsi
index 7c3dde8..daa3de4 100644
--- a/arch/powerpc/boot/dts/mpc8536ds.dtsi
+++ b/arch/powerpc/boot/dts/mpc8536ds.dtsi
@@ -150,14 +150,14 @@
reg = <0x00000000 0x00100000>;
read-only;
};
- partition@kernel {
- label = "kernel";
- reg = <0x00100000 0x00500000>;
- read-only;
- };
partition@dtb {
label = "dtb";
- reg = <0x00600000 0x00100000>;
+ reg = <0x00180000 0x00080000>;
+ read-only;
+ };
+ partition@kernel {
+ label = "kernel";
+ reg = <0x00200000 0x00500000>;
read-only;
};
partition@fs {
diff --git a/arch/powerpc/boot/dts/p1010rdb.dtsi b/arch/powerpc/boot/dts/p1010rdb.dtsi
index ec7c27a..e67db57 100644
--- a/arch/powerpc/boot/dts/p1010rdb.dtsi
+++ b/arch/powerpc/boot/dts/p1010rdb.dtsi
@@ -152,36 +152,24 @@
reg = <0>;
spi-max-frequency = <40000000>;
- partition@0 {
- /* 1MB for u-boot Bootloader Image */
- /* 1MB for Environment */
- reg = <0x0 0x00100000>;
- label = "SPI Flash U-Boot Image";
+ partition@u-boot {
+ label = "u-boot";
+ reg = <0x00000000 0x00100000>;
read-only;
};
-
- partition@100000 {
- /* 512KB for DTB Image */
- reg = <0x00100000 0x00080000>;
- label = "SPI Flash DTB Image";
- };
-
- partition@180000 {
- /* 4MB for Linux Kernel Image */
- reg = <0x00180000 0x00400000>;
- label = "SPI Flash Linux Kernel Image";
+ partition@dtb {
+ label = "dtb";
+ reg = <0x00180000 0x00080000>;
+ read-only;
};
-
- partition@580000 {
- /* 4MB for Compressed RFS Image */
- reg = <0x00580000 0x00400000>;
- label = "SPI Flash Compressed RFSImage";
+ partition@kernel {
+ label = "kernel";
+ reg = <0x00200000 0x00500000>;
+ read-only;
};
-
- partition@980000 {
- /* 6.5MB for JFFS2 based RFS */
- reg = <0x00980000 0x00680000>;
- label = "SPI Flash JFFS2 RFS";
+ partition@fs {
+ label = "file system";
+ reg = <0x00700000 0x00900000>;
};
};
};
diff --git a/arch/powerpc/boot/dts/p1020rdb-pc.dtsi b/arch/powerpc/boot/dts/p1020rdb-pc.dtsi
index c952cd3..277b563 100644
--- a/arch/powerpc/boot/dts/p1020rdb-pc.dtsi
+++ b/arch/powerpc/boot/dts/p1020rdb-pc.dtsi
@@ -154,36 +154,24 @@
compatible = "spansion,s25sl12801";
reg = <0>;
spi-max-frequency = <40000000>; /* input clock */
-
partition@u-boot {
- /* 512KB for u-boot Bootloader Image */
- reg = <0x0 0x00080000>;
label = "u-boot";
+ reg = <0x00000000 0x00100000>;
read-only;
};
-
partition@dtb {
- /* 512KB for DTB Image*/
- reg = <0x00080000 0x00080000>;
label = "dtb";
+ reg = <0x00180000 0x00080000>;
+ read-only;
};
-
partition@kernel {
- /* 4MB for Linux Kernel Image */
- reg = <0x00100000 0x00400000>;
label = "kernel";
+ reg = <0x00200000 0x00500000>;
+ read-only;
};
-
partition@fs {
- /* 4MB for Compressed RFS Image */
- reg = <0x00500000 0x00400000>;
label = "file system";
- };
-
- partition@jffs-fs {
- /* 7MB for JFFS2 based RFS */
- reg = <0x00900000 0x00700000>;
- label = "file system jffs2";
+ reg = <0x00700000 0x00900000>;
};
};
};
diff --git a/arch/powerpc/boot/dts/p1020rdb-pd.dts b/arch/powerpc/boot/dts/p1020rdb-pd.dts
index 987017e..b37f3e0 100644
--- a/arch/powerpc/boot/dts/p1020rdb-pd.dts
+++ b/arch/powerpc/boot/dts/p1020rdb-pd.dts
@@ -159,30 +159,24 @@
reg = <0>;
/* input clock */
spi-max-frequency = <40000000>;
-
- partition@0 {
- /* 512KB for u-boot Bootloader Image */
- reg = <0x0 0x00080000>;
- label = "SPI U-Boot Image";
+ partition@u-boot {
+ label = "u-boot";
+ reg = <0x00000000 0x00100000>;
read-only;
};
-
- partition@80000 {
- /* 512KB for DTB Image*/
- reg = <0x00080000 0x00080000>;
- label = "SPI DTB Image";
+ partition@dtb {
+ label = "dtb";
+ reg = <0x00180000 0x00080000>;
+ read-only;
};
-
- partition@100000 {
- /* 4MB for Linux Kernel Image */
- reg = <0x00100000 0x00400000>;
- label = "SPI Linux Kernel Image";
+ partition@kernel {
+ label = "kernel";
+ reg = <0x00200000 0x00500000>;
+ read-only;
};
-
- partition@500000 {
- /* 11MB for FS System Image */
- reg = <0x00500000 0x00b00000>;
- label = "SPI File System Image";
+ partition@fs {
+ label = "file system";
+ reg = <0x00700000 0x00900000>;
};
};
diff --git a/arch/powerpc/boot/dts/p1020rdb.dtsi b/arch/powerpc/boot/dts/p1020rdb.dtsi
index 1fb7e0e..f320acc 100644
--- a/arch/powerpc/boot/dts/p1020rdb.dtsi
+++ b/arch/powerpc/boot/dts/p1020rdb.dtsi
@@ -151,39 +151,24 @@
compatible = "spansion,s25sl12801";
reg = <0>;
spi-max-frequency = <40000000>; /* input clock */
-
partition@u-boot {
- /* 512KB for u-boot Bootloader Image */
- reg = <0x0 0x00080000>;
label = "u-boot";
+ reg = <0x00000000 0x00100000>;
read-only;
};
-
partition@dtb {
- /* 512KB for DTB Image */
- reg = <0x00080000 0x00080000>;
label = "dtb";
+ reg = <0x00180000 0x00080000>;
read-only;
};
-
partition@kernel {
- /* 4MB for Linux Kernel Image */
- reg = <0x00100000 0x00400000>;
label = "kernel";
+ reg = <0x00200000 0x00500000>;
read-only;
};
-
partition@fs {
- /* 4MB for Compressed RFS Image */
- reg = <0x00500000 0x00400000>;
label = "file system";
- read-only;
- };
-
- partition@jffs-fs {
- /* 7MB for JFFS2 based RFS */
- reg = <0x00900000 0x00700000>;
- label = "file system jffs2";
+ reg = <0x00700000 0x00900000>;
};
};
};
diff --git a/arch/powerpc/boot/dts/p1021mds.dts b/arch/powerpc/boot/dts/p1021mds.dts
index 97116f1..0d0b6f7 100644
--- a/arch/powerpc/boot/dts/p1021mds.dts
+++ b/arch/powerpc/boot/dts/p1021mds.dts
@@ -126,24 +126,23 @@
compatible = "spansion,s25sl12801";
reg = <0>;
spi-max-frequency = <40000000>; /* input clock */
-
partition@u-boot {
- label = "u-boot-spi";
+ label = "u-boot";
reg = <0x00000000 0x00100000>;
read-only;
};
- partition@kernel {
- label = "kernel-spi";
- reg = <0x00100000 0x00500000>;
+ partition@dtb {
+ label = "dtb";
+ reg = <0x00180000 0x00080000>;
read-only;
};
- partition@dtb {
- label = "dtb-spi";
- reg = <0x00600000 0x00100000>;
+ partition@kernel {
+ label = "kernel";
+ reg = <0x00200000 0x00500000>;
read-only;
};
partition@fs {
- label = "file system-spi";
+ label = "file system";
reg = <0x00700000 0x00900000>;
};
};
diff --git a/arch/powerpc/boot/dts/p1021rdb-pc.dtsi b/arch/powerpc/boot/dts/p1021rdb-pc.dtsi
index d6274c5..4e6aedd 100644
--- a/arch/powerpc/boot/dts/p1021rdb-pc.dtsi
+++ b/arch/powerpc/boot/dts/p1021rdb-pc.dtsi
@@ -153,36 +153,24 @@
compatible = "spansion,s25sl12801";
reg = <0>;
spi-max-frequency = <40000000>; /* input clock */
-
partition@u-boot {
- /* 512KB for u-boot Bootloader Image */
- reg = <0x0 0x00080000>;
- label = "SPI Flash U-Boot Image";
+ label = "u-boot";
+ reg = <0x00000000 0x00100000>;
read-only;
};
-
partition@dtb {
- /* 512KB for DTB Image */
- reg = <0x00080000 0x00080000>;
- label = "SPI Flash DTB Image";
+ label = "dtb";
+ reg = <0x00180000 0x00080000>;
+ read-only;
};
-
partition@kernel {
- /* 4MB for Linux Kernel Image */
- reg = <0x00100000 0x00400000>;
- label = "SPI Flash Linux Kernel Image";
+ label = "kernel";
+ reg = <0x00200000 0x00500000>;
+ read-only;
};
-
partition@fs {
- /* 4MB for Compressed RFS Image */
- reg = <0x00500000 0x00400000>;
- label = "SPI Flash Compressed RFSImage";
- };
-
- partition@jffs-fs {
- /* 7MB for JFFS2 based RFS */
- reg = <0x00900000 0x00700000>;
- label = "SPI Flash JFFS2 RFS";
+ label = "file system";
+ reg = <0x00700000 0x00900000>;
};
};
};
diff --git a/arch/powerpc/boot/dts/p1022ds.dtsi b/arch/powerpc/boot/dts/p1022ds.dtsi
index 873da35..faa2cb0 100644
--- a/arch/powerpc/boot/dts/p1022ds.dtsi
+++ b/arch/powerpc/boot/dts/p1022ds.dtsi
@@ -162,24 +162,23 @@
compatible = "spansion,s25sl12801";
reg = <0>;
spi-max-frequency = <40000000>; /* input clock */
-
- partition@0 {
- label = "u-boot-spi";
+ partition@u-boot {
+ label = "u-boot";
reg = <0x00000000 0x00100000>;
read-only;
};
- partition@100000 {
- label = "kernel-spi";
- reg = <0x00100000 0x00500000>;
+ partition@dtb {
+ label = "dtb";
+ reg = <0x00180000 0x00080000>;
read-only;
};
- partition@600000 {
- label = "dtb-spi";
- reg = <0x00600000 0x00100000>;
+ partition@kernel {
+ label = "kernel";
+ reg = <0x00200000 0x00500000>;
read-only;
};
- partition@700000 {
- label = "file system-spi";
+ partition@fs {
+ label = "file system";
reg = <0x00700000 0x00900000>;
};
};
diff --git a/arch/powerpc/boot/dts/p1023rds.dts b/arch/powerpc/boot/dts/p1023rds.dts
index beb6cb1..9fcf9af 100644
--- a/arch/powerpc/boot/dts/p1023rds.dts
+++ b/arch/powerpc/boot/dts/p1023rds.dts
@@ -65,15 +65,9 @@
reg = <0>;
spi-max-frequency = <40000000>; /* input clock */
partition@u-boot {
- /* 512KB for u-boot Bootloader Image */
+ /* 1MB for u-boot Bootloader Image */
label = "u-boot-spi";
- reg = <0x00000000 0x00080000>;
- read-only;
- };
- partition@dtb {
- /* 512KB for DTB Image */
- label = "dtb-spi";
- reg = <0x00080000 0x00080000>;
+ reg = <0x00000000 0x00100000>;
read-only;
};
};
diff --git a/arch/powerpc/boot/dts/p1024rdb.dtsi b/arch/powerpc/boot/dts/p1024rdb.dtsi
index b05dcb4..2896f98 100644
--- a/arch/powerpc/boot/dts/p1024rdb.dtsi
+++ b/arch/powerpc/boot/dts/p1024rdb.dtsi
@@ -132,36 +132,24 @@
compatible = "spansion,m25p80";
reg = <0>;
spi-max-frequency = <40000000>;
-
- partition@0 {
- /* 512KB for u-boot Bootloader Image */
- reg = <0x0 0x00080000>;
- label = "SPI U-Boot Image";
+ partition@u-boot {
+ label = "u-boot";
+ reg = <0x00000000 0x00100000>;
read-only;
};
-
- partition@80000 {
- /* 512KB for DTB Image */
- reg = <0x00080000 0x00080000>;
- label = "SPI DTB Image";
- };
-
- partition@100000 {
- /* 4MB for Linux Kernel Image */
- reg = <0x00100000 0x00400000>;
- label = "SPI Linux Kernel Image";
+ partition@dtb {
+ label = "dtb";
+ reg = <0x00180000 0x00080000>;
+ read-only;
};
-
- partition@500000 {
- /* 4MB for Compressed RFS Image */
- reg = <0x00500000 0x00400000>;
- label = "SPI Compressed RFS Image";
+ partition@kernel {
+ label = "kernel";
+ reg = <0x00200000 0x00500000>;
+ read-only;
};
-
- partition@900000 {
- /* 7MB for JFFS2 based RFS */
- reg = <0x00900000 0x00700000>;
- label = "SPI JFFS2 RFS";
+ partition@fs {
+ label = "file system";
+ reg = <0x00700000 0x00900000>;
};
};
};
diff --git a/arch/powerpc/boot/dts/p1025rdb.dtsi b/arch/powerpc/boot/dts/p1025rdb.dtsi
index f502564..e74439c8 100644
--- a/arch/powerpc/boot/dts/p1025rdb.dtsi
+++ b/arch/powerpc/boot/dts/p1025rdb.dtsi
@@ -142,34 +142,23 @@
spi-max-frequency = <40000000>; /* input clock */
partition@u-boot {
- /* 512KB for u-boot Bootloader Image */
- reg = <0x0 0x00080000>;
label = "u-boot";
+ reg = <0x00000000 0x00100000>;
read-only;
};
-
partition@dtb {
- /* 512KB for DTB Image */
- reg = <0x00080000 0x00080000>;
label = "dtb";
+ reg = <0x00180000 0x00080000>;
+ read-only;
};
-
partition@kernel {
- /* 4MB for Linux Kernel Image */
- reg = <0x00100000 0x00400000>;
label = "kernel";
+ reg = <0x00200000 0x00500000>;
+ read-only;
};
-
partition@fs {
- /* 4MB for Compressed RFS Image */
- reg = <0x00500000 0x00400000>;
label = "file system";
- };
-
- partition@jffs-fs {
- /* 7MB for JFFS2 based RFS */
- reg = <0x00900000 0x00700000>;
- label = "file system jffs2";
+ reg = <0x00700000 0x00900000>;
};
};
};
diff --git a/arch/powerpc/boot/dts/p2020rdb-pc.dtsi b/arch/powerpc/boot/dts/p2020rdb-pc.dtsi
index c21d1c7..d501d35 100644
--- a/arch/powerpc/boot/dts/p2020rdb-pc.dtsi
+++ b/arch/powerpc/boot/dts/p2020rdb-pc.dtsi
@@ -154,36 +154,24 @@
compatible = "spansion,m25p80";
reg = <0>;
spi-max-frequency = <40000000>;
-
- partition@0 {
- /* 512KB for u-boot Bootloader Image */
- reg = <0x0 0x00080000>;
- label = "SPI U-Boot Image";
+ partition@u-boot {
+ label = "u-boot";
+ reg = <0x00000000 0x00100000>;
read-only;
};
-
- partition@80000 {
- /* 512KB for DTB Image */
- reg = <0x00080000 0x00080000>;
- label = "SPI DTB Image";
- };
-
- partition@100000 {
- /* 4MB for Linux Kernel Image */
- reg = <0x00100000 0x00400000>;
- label = "SPI Linux Kernel Image";
+ partition@dtb {
+ label = "dtb";
+ reg = <0x00180000 0x00080000>;
+ read-only;
};
-
- partition@500000 {
- /* 4MB for Compressed RFS Image */
- reg = <0x00500000 0x00400000>;
- label = "SPI Compressed RFS Image";
+ partition@kernel {
+ label = "kernel";
+ reg = <0x00200000 0x00500000>;
+ read-only;
};
-
- partition@900000 {
- /* 7MB for JFFS2 based RFS */
- reg = <0x00900000 0x00700000>;
- label = "SPI JFFS2 RFS";
+ partition@fs {
+ label = "file system";
+ reg = <0x00700000 0x00900000>;
};
};
};
diff --git a/arch/powerpc/boot/dts/p2020rdb.dts b/arch/powerpc/boot/dts/p2020rdb.dts
index 4d52bce..d47ae13 100644
--- a/arch/powerpc/boot/dts/p2020rdb.dts
+++ b/arch/powerpc/boot/dts/p2020rdb.dts
@@ -159,38 +159,24 @@
reg = <0>;
spi-max-frequency = <40000000>;
- partition@0 {
- /* 512KB for u-boot Bootloader Image */
- reg = <0x0 0x00080000>;
- label = "SPI (RO) U-Boot Image";
+ partition@u-boot {
+ label = "u-boot";
+ reg = <0x00000000 0x00100000>;
read-only;
};
-
- partition@80000 {
- /* 512KB for DTB Image */
- reg = <0x00080000 0x00080000>;
- label = "SPI (RO) DTB Image";
- read-only;
- };
-
- partition@100000 {
- /* 4MB for Linux Kernel Image */
- reg = <0x00100000 0x00400000>;
- label = "SPI (RO) Linux Kernel Image";
+ partition@dtb {
+ label = "dtb";
+ reg = <0x00180000 0x00080000>;
read-only;
};
-
- partition@500000 {
- /* 4MB for Compressed RFS Image */
- reg = <0x00500000 0x00400000>;
- label = "SPI (RO) Compressed RFS Image";
+ partition@kernel {
+ label = "kernel";
+ reg = <0x00200000 0x00500000>;
read-only;
};
-
- partition@900000 {
- /* 7MB for JFFS2 based RFS */
- reg = <0x00900000 0x00700000>;
- label = "SPI (RW) JFFS2 RFS";
+ partition@fs {
+ label = "file system";
+ reg = <0x00700000 0x00900000>;
};
};
};
diff --git a/arch/powerpc/boot/dts/p2041rdb.dts b/arch/powerpc/boot/dts/p2041rdb.dts
index d97ad74..6fed1ea 100644
--- a/arch/powerpc/boot/dts/p2041rdb.dts
+++ b/arch/powerpc/boot/dts/p2041rdb.dts
@@ -64,14 +64,14 @@
reg = <0x00000000 0x00100000>;
read-only;
};
- partition@kernel {
- label = "kernel";
- reg = <0x00100000 0x00500000>;
- read-only;
- };
partition@dtb {
label = "dtb";
- reg = <0x00600000 0x00100000>;
+ reg = <0x00180000 0x00080000>;
+ read-only;
+ };
+ partition@kernel {
+ label = "kernel";
+ reg = <0x00200000 0x00500000>;
read-only;
};
partition@fs {
diff --git a/arch/powerpc/boot/dts/p3041ds.dts b/arch/powerpc/boot/dts/p3041ds.dts
index 2fed3bc..74a3b7e 100644
--- a/arch/powerpc/boot/dts/p3041ds.dts
+++ b/arch/powerpc/boot/dts/p3041ds.dts
@@ -64,14 +64,14 @@
reg = <0x00000000 0x00100000>;
read-only;
};
- partition@kernel {
- label = "kernel";
- reg = <0x00100000 0x00500000>;
- read-only;
- };
partition@dtb {
label = "dtb";
- reg = <0x00600000 0x00100000>;
+ reg = <0x00180000 0x00080000>;
+ read-only;
+ };
+ partition@kernel {
+ label = "kernel";
+ reg = <0x00200000 0x00500000>;
read-only;
};
partition@fs {
diff --git a/arch/powerpc/boot/dts/p4080ds.dts b/arch/powerpc/boot/dts/p4080ds.dts
index 1cf6148..06525b3 100644
--- a/arch/powerpc/boot/dts/p4080ds.dts
+++ b/arch/powerpc/boot/dts/p4080ds.dts
@@ -65,14 +65,14 @@
reg = <0x00000000 0x00100000>;
read-only;
};
- partition@kernel {
- label = "kernel";
- reg = <0x00100000 0x00500000>;
- read-only;
- };
partition@dtb {
label = "dtb";
- reg = <0x00600000 0x00100000>;
+ reg = <0x00180000 0x00080000>;
+ read-only;
+ };
+ partition@kernel {
+ label = "kernel";
+ reg = <0x00200000 0x00500000>;
read-only;
};
partition@fs {
diff --git a/arch/powerpc/boot/dts/p5020ds.dts b/arch/powerpc/boot/dts/p5020ds.dts
index 2869fea..b0615a3 100644
--- a/arch/powerpc/boot/dts/p5020ds.dts
+++ b/arch/powerpc/boot/dts/p5020ds.dts
@@ -64,14 +64,14 @@
reg = <0x00000000 0x00100000>;
read-only;
};
- partition@kernel {
- label = "kernel";
- reg = <0x00100000 0x00500000>;
- read-only;
- };
partition@dtb {
label = "dtb";
- reg = <0x00600000 0x00100000>;
+ reg = <0x00180000 0x00080000>;
+ read-only;
+ };
+ partition@kernel {
+ label = "kernel";
+ reg = <0x00200000 0x00500000>;
read-only;
};
partition@fs {
diff --git a/arch/powerpc/boot/dts/p5040ds.dts b/arch/powerpc/boot/dts/p5040ds.dts
index 860b5cc..1a3a994 100644
--- a/arch/powerpc/boot/dts/p5040ds.dts
+++ b/arch/powerpc/boot/dts/p5040ds.dts
@@ -62,14 +62,17 @@
partition@u-boot {
label = "u-boot";
reg = <0x00000000 0x00100000>;
- };
- partition@kernel {
- label = "kernel";
- reg = <0x00100000 0x00500000>;
+ read-only;
};
partition@dtb {
label = "dtb";
- reg = <0x00600000 0x00100000>;
+ reg = <0x00180000 0x00080000>;
+ read-only;
+ };
+ partition@kernel {
+ label = "kernel";
+ reg = <0x00200000 0x00500000>;
+ read-only;
};
partition@fs {
label = "file system";
--
1.8.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc/85xx: DTS - re-organize the SPI partitions property
2013-09-06 8:05 [PATCH] powerpc/85xx: DTS - re-organize the SPI partitions property Mingkai Hu
@ 2013-09-10 23:33 ` Scott Wood
2013-09-11 2:07 ` Hu Mingkai-B21284
0 siblings, 1 reply; 10+ messages in thread
From: Scott Wood @ 2013-09-10 23:33 UTC (permalink / raw)
To: Mingkai Hu; +Cc: linuxppc-dev
On Fri, 2013-09-06 at 16:05 +0800, Mingkai Hu wrote:
> Re-organize the SPI partitions and use the same SPI flash memory
> map for most of the platforms which have 16MB SPI flash mounted.
[snip]
> Based on 'next' branch on git tree:
> git://git.kernel.org/pub/scm/linux/kernel/git/scottwood/linux.git
>
> arch/powerpc/boot/dts/bsc9131rdb.dtsi | 35 ++++++++++++-----------------
> arch/powerpc/boot/dts/c293pcie.dts | 35 ++++++++++++-----------------
> arch/powerpc/boot/dts/mpc8536ds.dtsi | 12 +++++-----
> arch/powerpc/boot/dts/p1010rdb.dtsi | 40 ++++++++++++----------------------
> arch/powerpc/boot/dts/p1020rdb-pc.dtsi | 24 +++++---------------
> arch/powerpc/boot/dts/p1020rdb-pd.dts | 34 ++++++++++++-----------------
> arch/powerpc/boot/dts/p1020rdb.dtsi | 23 ++++---------------
> arch/powerpc/boot/dts/p1021mds.dts | 17 +++++++--------
> arch/powerpc/boot/dts/p1021rdb-pc.dtsi | 32 +++++++++------------------
> arch/powerpc/boot/dts/p1022ds.dtsi | 21 +++++++++---------
> arch/powerpc/boot/dts/p1023rds.dts | 10 ++-------
> arch/powerpc/boot/dts/p1024rdb.dtsi | 40 ++++++++++++----------------------
> arch/powerpc/boot/dts/p1025rdb.dtsi | 23 +++++--------------
> arch/powerpc/boot/dts/p2020rdb-pc.dtsi | 40 ++++++++++++----------------------
> arch/powerpc/boot/dts/p2020rdb.dts | 38 ++++++++++----------------------
> arch/powerpc/boot/dts/p2041rdb.dts | 12 +++++-----
> arch/powerpc/boot/dts/p3041ds.dts | 12 +++++-----
> arch/powerpc/boot/dts/p4080ds.dts | 12 +++++-----
> arch/powerpc/boot/dts/p5020ds.dts | 12 +++++-----
> arch/powerpc/boot/dts/p5040ds.dts | 13 ++++++-----
What happens to exsting users whose flash is laid out the existing way,
when they upgrade to these device trees?
We really should not be putting partition layout info in the device tree
to begin with...
-Scott
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] powerpc/85xx: DTS - re-organize the SPI partitions property
2013-09-10 23:33 ` Scott Wood
@ 2013-09-11 2:07 ` Hu Mingkai-B21284
2013-09-12 1:15 ` Scott Wood
0 siblings, 1 reply; 10+ messages in thread
From: Hu Mingkai-B21284 @ 2013-09-11 2:07 UTC (permalink / raw)
To: Wood Scott-B07421; +Cc: linuxppc-dev
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0
MjENCj4gU2VudDogV2VkbmVzZGF5LCBTZXB0ZW1iZXIgMTEsIDIwMTMgNzozMyBBTQ0KPiBUbzog
SHUgTWluZ2thaS1CMjEyODQNCj4gQ2M6IGxpbnV4cHBjLWRldkBvemxhYnMub3JnDQo+IFN1Ympl
Y3Q6IFJlOiBbUEFUQ0hdIHBvd2VycGMvODV4eDogRFRTIC0gcmUtb3JnYW5pemUgdGhlIFNQSSBw
YXJ0aXRpb25zDQo+IHByb3BlcnR5DQo+IA0KPiBPbiBGcmksIDIwMTMtMDktMDYgYXQgMTY6MDUg
KzA4MDAsIE1pbmdrYWkgSHUgd3JvdGU6DQo+ID4gUmUtb3JnYW5pemUgdGhlIFNQSSBwYXJ0aXRp
b25zIGFuZCB1c2UgdGhlIHNhbWUgU1BJIGZsYXNoIG1lbW9yeSBtYXANCj4gPiBmb3IgbW9zdCBv
ZiB0aGUgcGxhdGZvcm1zIHdoaWNoIGhhdmUgMTZNQiBTUEkgZmxhc2ggbW91bnRlZC4NCj4gW3Nu
aXBdDQo+ID4gQmFzZWQgb24gJ25leHQnIGJyYW5jaCBvbiBnaXQgdHJlZToNCj4gPiBnaXQ6Ly9n
aXQua2VybmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvc2NvdHR3b29kL2xpbnV4Lmdp
dA0KPiA+DQo+ID4gIGFyY2gvcG93ZXJwYy9ib290L2R0cy9ic2M5MTMxcmRiLmR0c2kgIHwgMzUg
KysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0NCj4gLS0tDQo+ID4gIGFyY2gvcG93ZXJwYy9ib290
L2R0cy9jMjkzcGNpZS5kdHMgICAgIHwgMzUgKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0NCj4g
LS0tDQo+ID4gIGFyY2gvcG93ZXJwYy9ib290L2R0cy9tcGM4NTM2ZHMuZHRzaSAgIHwgMTIgKysr
KystLS0tLQ0KPiA+ICBhcmNoL3Bvd2VycGMvYm9vdC9kdHMvcDEwMTByZGIuZHRzaSAgICB8IDQw
ICsrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tDQo+IC0tLS0tLS0tDQo+ID4gIGFyY2gvcG93ZXJw
Yy9ib290L2R0cy9wMTAyMHJkYi1wYy5kdHNpIHwgMjQgKysrKystLS0tLS0tLS0tLS0tLS0NCj4g
PiBhcmNoL3Bvd2VycGMvYm9vdC9kdHMvcDEwMjByZGItcGQuZHRzICB8IDM0ICsrKysrKysrKysr
Ky0tLS0tLS0tLS0tLS0tLQ0KPiAtLQ0KPiA+ICBhcmNoL3Bvd2VycGMvYm9vdC9kdHMvcDEwMjBy
ZGIuZHRzaSAgICB8IDIzICsrKystLS0tLS0tLS0tLS0tLS0NCj4gPiAgYXJjaC9wb3dlcnBjL2Jv
b3QvZHRzL3AxMDIxbWRzLmR0cyAgICAgfCAxNyArKysrKysrLS0tLS0tLS0NCj4gPiAgYXJjaC9w
b3dlcnBjL2Jvb3QvZHRzL3AxMDIxcmRiLXBjLmR0c2kgfCAzMiArKysrKysrKystLS0tLS0tLS0t
LS0tLS0tLQ0KPiAtDQo+ID4gIGFyY2gvcG93ZXJwYy9ib290L2R0cy9wMTAyMmRzLmR0c2kgICAg
IHwgMjEgKysrKysrKysrLS0tLS0tLS0tDQo+ID4gIGFyY2gvcG93ZXJwYy9ib290L2R0cy9wMTAy
M3Jkcy5kdHMgICAgIHwgMTAgKystLS0tLS0tDQo+ID4gIGFyY2gvcG93ZXJwYy9ib290L2R0cy9w
MTAyNHJkYi5kdHNpICAgIHwgNDAgKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0NCj4gLS0tLS0t
LS0NCj4gPiAgYXJjaC9wb3dlcnBjL2Jvb3QvZHRzL3AxMDI1cmRiLmR0c2kgICAgfCAyMyArKysr
Ky0tLS0tLS0tLS0tLS0tDQo+ID4gIGFyY2gvcG93ZXJwYy9ib290L2R0cy9wMjAyMHJkYi1wYy5k
dHNpIHwgNDAgKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0NCj4gLS0tLS0tLS0NCj4gPiAgYXJj
aC9wb3dlcnBjL2Jvb3QvZHRzL3AyMDIwcmRiLmR0cyAgICAgfCAzOCArKysrKysrKysrLS0tLS0t
LS0tLS0tLS0tLQ0KPiAtLS0tLS0NCj4gPiAgYXJjaC9wb3dlcnBjL2Jvb3QvZHRzL3AyMDQxcmRi
LmR0cyAgICAgfCAxMiArKysrKy0tLS0tDQo+ID4gIGFyY2gvcG93ZXJwYy9ib290L2R0cy9wMzA0
MWRzLmR0cyAgICAgIHwgMTIgKysrKystLS0tLQ0KPiA+ICBhcmNoL3Bvd2VycGMvYm9vdC9kdHMv
cDQwODBkcy5kdHMgICAgICB8IDEyICsrKysrLS0tLS0NCj4gPiAgYXJjaC9wb3dlcnBjL2Jvb3Qv
ZHRzL3A1MDIwZHMuZHRzICAgICAgfCAxMiArKysrKy0tLS0tDQo+ID4gIGFyY2gvcG93ZXJwYy9i
b290L2R0cy9wNTA0MGRzLmR0cyAgICAgIHwgMTMgKysrKysrLS0tLS0NCj4gDQo+IFdoYXQgaGFw
cGVucyB0byBleHN0aW5nIHVzZXJzIHdob3NlIGZsYXNoIGlzIGxhaWQgb3V0IHRoZSBleGlzdGlu
ZyB3YXksDQo+IHdoZW4gdGhleSB1cGdyYWRlIHRvIHRoZXNlIGRldmljZSB0cmVlcz8NCj4gDQoN
ClRoZSBTUEkgZmxhc2ggbGF5b3V0IHNob3VsZCBiZSBtYXBwaW5nIHRoZSBuZXcgZGV2aWNlIHRy
ZWUuDQoNCklmIHRoZSBleGlzdGluZyBkZXZpY2UgdHJlZSBpcyB1c2VkIHRvIGRlcGxveSB0aGUg
U1BJIGZsYXNoLCB0aGUgZm9sbG93aW5nIGlzc3Vlcw0KbXVzdCBiZSBydW4gaW50byBhcyB0aGUg
Y29tbWl0IG1lc3NhZ2UgZGVzY3JpYmVkOg0KDQoxLiBLZXJuZWwgaW1hZ2VzIHdvdWxkIGJlIG92
ZXJsYXBwZWQgd2l0aCBVLUJvb3QgaW1hZ2UuDQoyLiBLZXJuZWwgaW1hZ2VzIHdvdWxkIGJlIG92
ZXJsYXBwZWQgd2l0aCBGTUFOIHVjb2RlLg0KMy4gU2F2aW5nIGVudmlyb25tZW50IHZhcmlhYmxl
cyB3aWxsIGNyYXNoIHRoZSBrZXJuZWwgaW1hZ2UuDQoNCj4gV2UgcmVhbGx5IHNob3VsZCBub3Qg
YmUgcHV0dGluZyBwYXJ0aXRpb24gbGF5b3V0IGluZm8gaW4gdGhlIGRldmljZSB0cmVlDQo+IHRv
IGJlZ2luIHdpdGguLi4NCj4gDQpPSywgSSB3aWxsIHJlbW92ZSB0aGUgbGF5b3V0IGRpYWdyYW0g
aW4gdGhlIGNvbW1pdCBtZXNzYWdlLg0KDQpUaGFua3MsDQpNaW5na2FpDQo=
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc/85xx: DTS - re-organize the SPI partitions property
2013-09-11 2:07 ` Hu Mingkai-B21284
@ 2013-09-12 1:15 ` Scott Wood
2013-09-17 11:06 ` Hu Mingkai-B21284
0 siblings, 1 reply; 10+ messages in thread
From: Scott Wood @ 2013-09-12 1:15 UTC (permalink / raw)
To: Hu Mingkai-B21284; +Cc: Wood Scott-B07421, linuxppc-dev
On Tue, 2013-09-10 at 21:07 -0500, Hu Mingkai-B21284 wrote:
>
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Wednesday, September 11, 2013 7:33 AM
> > To: Hu Mingkai-B21284
> > Cc: linuxppc-dev@ozlabs.org
> > Subject: Re: [PATCH] powerpc/85xx: DTS - re-organize the SPI partitions
> > property
> >
> > What happens to exsting users whose flash is laid out the existing way,
> > when they upgrade to these device trees?
> >
>
> The SPI flash layout should be mapping the new device tree.
>
> If the existing device tree is used to deploy the SPI flash, the following issues
> must be run into as the commit message described:
>
> 1. Kernel images would be overlapped with U-Boot image.
> 2. Kernel images would be overlapped with FMAN ucode.
> 3. Saving environment variables will crash the kernel image.
Has the SPI U-Boot image always been larger than 512K for all these
platforms? Why, given that we're under 512K for other boot modes?
> > We really should not be putting partition layout info in the device tree
> > to begin with...
> >
> OK, I will remove the layout diagram in the commit message.
That's not what I meant. I meant that the dts should be describing
hardware, and this is the sort of trouble we run into when we deviate
from that. A better way would be to use the mtdparts command line
option. Even better would be some sort of on-flash partition table.
-Scott
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] powerpc/85xx: DTS - re-organize the SPI partitions property
2013-09-12 1:15 ` Scott Wood
@ 2013-09-17 11:06 ` Hu Mingkai-B21284
2013-09-23 23:02 ` Scott Wood
0 siblings, 1 reply; 10+ messages in thread
From: Hu Mingkai-B21284 @ 2013-09-17 11:06 UTC (permalink / raw)
To: Wood Scott-B07421; +Cc: linuxppc-dev
U2NvdHQsDQpTb3JyeSBmb3IgdGhlIGRlbGF5ZWQgcmVzcG9uc2UuDQpQbGVhc2UgZmluZSBteSBj
b21tZW50cy4NClRoYW5rcywNCk1pbmdrYWkNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0t
LQ0KPiBGcm9tOiBXb29kIFNjb3R0LUIwNzQyMQ0KPiBTZW50OiBUaHVyc2RheSwgU2VwdGVtYmVy
IDEyLCAyMDEzIDk6MTYgQU0NCj4gVG86IEh1IE1pbmdrYWktQjIxMjg0DQo+IENjOiBXb29kIFNj
b3R0LUIwNzQyMTsgbGludXhwcGMtZGV2QG96bGFicy5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRD
SF0gcG93ZXJwYy84NXh4OiBEVFMgLSByZS1vcmdhbml6ZSB0aGUgU1BJIHBhcnRpdGlvbnMNCj4g
cHJvcGVydHkNCj4gDQo+IE9uIFR1ZSwgMjAxMy0wOS0xMCBhdCAyMTowNyAtMDUwMCwgSHUgTWlu
Z2thaS1CMjEyODQgd3JvdGU6DQo+ID4NCj4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0t
DQo+ID4gPiBGcm9tOiBXb29kIFNjb3R0LUIwNzQyMQ0KPiA+ID4gU2VudDogV2VkbmVzZGF5LCBT
ZXB0ZW1iZXIgMTEsIDIwMTMgNzozMyBBTQ0KPiA+ID4gVG86IEh1IE1pbmdrYWktQjIxMjg0DQo+
ID4gPiBDYzogbGludXhwcGMtZGV2QG96bGFicy5vcmcNCj4gPiA+IFN1YmplY3Q6IFJlOiBbUEFU
Q0hdIHBvd2VycGMvODV4eDogRFRTIC0gcmUtb3JnYW5pemUgdGhlIFNQSQ0KPiA+ID4gcGFydGl0
aW9ucyBwcm9wZXJ0eQ0KPiA+ID4NCj4gPiA+IFdoYXQgaGFwcGVucyB0byBleHN0aW5nIHVzZXJz
IHdob3NlIGZsYXNoIGlzIGxhaWQgb3V0IHRoZSBleGlzdGluZw0KPiA+ID4gd2F5LCB3aGVuIHRo
ZXkgdXBncmFkZSB0byB0aGVzZSBkZXZpY2UgdHJlZXM/DQo+ID4gPg0KPiA+DQo+ID4gVGhlIFNQ
SSBmbGFzaCBsYXlvdXQgc2hvdWxkIGJlIG1hcHBpbmcgdGhlIG5ldyBkZXZpY2UgdHJlZS4NCj4g
Pg0KPiA+IElmIHRoZSBleGlzdGluZyBkZXZpY2UgdHJlZSBpcyB1c2VkIHRvIGRlcGxveSB0aGUg
U1BJIGZsYXNoLCB0aGUNCj4gPiBmb2xsb3dpbmcgaXNzdWVzIG11c3QgYmUgcnVuIGludG8gYXMg
dGhlIGNvbW1pdCBtZXNzYWdlIGRlc2NyaWJlZDoNCj4gPg0KPiA+IDEuIEtlcm5lbCBpbWFnZXMg
d291bGQgYmUgb3ZlcmxhcHBlZCB3aXRoIFUtQm9vdCBpbWFnZS4NCj4gPiAyLiBLZXJuZWwgaW1h
Z2VzIHdvdWxkIGJlIG92ZXJsYXBwZWQgd2l0aCBGTUFOIHVjb2RlLg0KPiA+IDMuIFNhdmluZyBl
bnZpcm9ubWVudCB2YXJpYWJsZXMgd2lsbCBjcmFzaCB0aGUga2VybmVsIGltYWdlLg0KPiANCj4g
SGFzIHRoZSBTUEkgVS1Cb290IGltYWdlIGFsd2F5cyBiZWVuIGxhcmdlciB0aGFuIDUxMksgZm9y
IGFsbCB0aGVzZQ0KPiBwbGF0Zm9ybXM/ICBXaHksIGdpdmVuIHRoYXQgd2UncmUgdW5kZXIgNTEy
SyBmb3Igb3RoZXIgYm9vdCBtb2Rlcz8NCj4gDQoNCkZvciBEUEFBIHBsYXRmb3JtLCB0aGUgbGQg
c2NyaXB0IHVzZWQgdG8gbGluayB0aGUgdS1ib290IGltYWdlIGlzIA0KIi4vYXJjaC9wb3dlcnBj
L2NwdS9tcGM4NXh4L3UtYm9vdC5sZHMiIHdoaWNoIHdpbGwgZ2VuZXJhdGUgdGhlIDUxMksgdS1i
b290DQpJbWFnZS4gVGhpcyBpbWFnZSB3aWxsIGJlIHNwbGl0IGludG8gNjRieXRlcyBhbmQgYXBw
ZW5kZWQgUEJMIGNvbW1hbmQgZm9yIA0KRWFjaCA2NGJ5dGVzIHBpZWNlcywgc28gdGhlIHNpemUg
b2YgZmluYWwgaW1hZ2UgbXVzdCBiZSBncmVhdGVyIHRoYW4gNTEySy4NCg0KVGhlIHNhbWUgYXBw
bGllcyB0byB0aGUgbm9uLURQQUEgcGxhdGZvcm0gd2hpY2ggZG9lc24ndCBzdXBwb3J0IFRQTC4N
Cg0KRm9yIG5vbi1EUEFBIHBsYXRmb3JtIHdoaWNoIHN1cHBvcnQgVFBMLCB0aGUgaW1hZ2Ugc2l6
ZSBpcyBhbHNvIGdyZWF0ZXIgdGhhbiA1MTJLLg0KDQo+ID4gPiBXZSByZWFsbHkgc2hvdWxkIG5v
dCBiZSBwdXR0aW5nIHBhcnRpdGlvbiBsYXlvdXQgaW5mbyBpbiB0aGUgZGV2aWNlDQo+ID4gPiB0
cmVlIHRvIGJlZ2luIHdpdGguLi4NCj4gPiA+DQo+ID4gT0ssIEkgd2lsbCByZW1vdmUgdGhlIGxh
eW91dCBkaWFncmFtIGluIHRoZSBjb21taXQgbWVzc2FnZS4NCj4gDQo+IFRoYXQncyBub3Qgd2hh
dCBJIG1lYW50LiAgSSBtZWFudCB0aGF0IHRoZSBkdHMgc2hvdWxkIGJlIGRlc2NyaWJpbmcNCj4g
aGFyZHdhcmUsIGFuZCB0aGlzIGlzIHRoZSBzb3J0IG9mIHRyb3VibGUgd2UgcnVuIGludG8gd2hl
biB3ZSBkZXZpYXRlDQo+IGZyb20gdGhhdC4gIEEgYmV0dGVyIHdheSB3b3VsZCBiZSB0byB1c2Ug
dGhlIG10ZHBhcnRzIGNvbW1hbmQgbGluZSBvcHRpb24uDQo+IEV2ZW4gYmV0dGVyIHdvdWxkIGJl
IHNvbWUgc29ydCBvZiBvbi1mbGFzaCBwYXJ0aXRpb24gdGFibGUuDQo+IA0KDQpZb3UncmUgcmln
aHQsIGJ1dCBtYXliZSBzb21lIGN1c3RvbWVyIGhhcyBhbHJlYWR5IHVzZWQgdGhlIGRldmljZSB0
cmVlIHBhcnRpdGlvbiB0YWJsZS4uLg0KDQpUaGFua3MsDQpNaW5na2FpDQoNCg==
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc/85xx: DTS - re-organize the SPI partitions property
2013-09-17 11:06 ` Hu Mingkai-B21284
@ 2013-09-23 23:02 ` Scott Wood
2013-09-24 10:27 ` Hu Mingkai-B21284
0 siblings, 1 reply; 10+ messages in thread
From: Scott Wood @ 2013-09-23 23:02 UTC (permalink / raw)
To: Hu Mingkai-B21284; +Cc: Wood Scott-B07421, linuxppc-dev
On Tue, 2013-09-17 at 06:06 -0500, Hu Mingkai-B21284 wrote:
> Scott,
> Sorry for the delayed response.
> Please fine my comments.
> Thanks,
> Mingkai
>
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Thursday, September 12, 2013 9:16 AM
> > To: Hu Mingkai-B21284
> > Cc: Wood Scott-B07421; linuxppc-dev@ozlabs.org
> > Subject: Re: [PATCH] powerpc/85xx: DTS - re-organize the SPI partitions
> > property
> >
> > On Tue, 2013-09-10 at 21:07 -0500, Hu Mingkai-B21284 wrote:
> > >
> > > > -----Original Message-----
> > > > From: Wood Scott-B07421
> > > > Sent: Wednesday, September 11, 2013 7:33 AM
> > > > To: Hu Mingkai-B21284
> > > > Cc: linuxppc-dev@ozlabs.org
> > > > Subject: Re: [PATCH] powerpc/85xx: DTS - re-organize the SPI
> > > > partitions property
> > > >
> > > > What happens to exsting users whose flash is laid out the existing
> > > > way, when they upgrade to these device trees?
> > > >
> > >
> > > The SPI flash layout should be mapping the new device tree.
> > >
> > > If the existing device tree is used to deploy the SPI flash, the
> > > following issues must be run into as the commit message described:
> > >
> > > 1. Kernel images would be overlapped with U-Boot image.
> > > 2. Kernel images would be overlapped with FMAN ucode.
> > > 3. Saving environment variables will crash the kernel image.
> >
> > Has the SPI U-Boot image always been larger than 512K for all these
> > platforms? Why, given that we're under 512K for other boot modes?
> >
>
> For DPAA platform, the ld script used to link the u-boot image is
> "./arch/powerpc/cpu/mpc85xx/u-boot.lds" which will generate the 512K u-boot
> Image. This image will be split into 64bytes and appended PBL command for
> Each 64bytes pieces, so the size of final image must be greater than 512K.
What is the entry point in SRAM when you load from PBL? If it is (or
can be made to be) the beginning of the image rather than the end, then
turn off the resetvec and the fixed image size that results.
> > > > We really should not be putting partition layout info in the device
> > > > tree to begin with...
> > > >
> > > OK, I will remove the layout diagram in the commit message.
> >
> > That's not what I meant. I meant that the dts should be describing
> > hardware, and this is the sort of trouble we run into when we deviate
> > from that. A better way would be to use the mtdparts command line option.
> > Even better would be some sort of on-flash partition table.
> >
>
> You're right, but maybe some customer has already used the device tree partition table...
My main point was to encourage us to shift away from this rather than to
rip it out right this instant.
-Scott
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] powerpc/85xx: DTS - re-organize the SPI partitions property
2013-09-23 23:02 ` Scott Wood
@ 2013-09-24 10:27 ` Hu Mingkai-B21284
2013-09-24 19:37 ` Scott Wood
0 siblings, 1 reply; 10+ messages in thread
From: Hu Mingkai-B21284 @ 2013-09-24 10:27 UTC (permalink / raw)
To: Wood Scott-B07421; +Cc: linuxppc-dev
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0
MjENCj4gU2VudDogVHVlc2RheSwgU2VwdGVtYmVyIDI0LCAyMDEzIDc6MDMgQU0NCj4gVG86IEh1
IE1pbmdrYWktQjIxMjg0DQo+IENjOiBXb29kIFNjb3R0LUIwNzQyMTsgbGludXhwcGMtZGV2QG96
bGFicy5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSF0gcG93ZXJwYy84NXh4OiBEVFMgLSByZS1v
cmdhbml6ZSB0aGUgU1BJIHBhcnRpdGlvbnMNCj4gcHJvcGVydHkNCj4gDQo+IE9uIFR1ZSwgMjAx
My0wOS0xNyBhdCAwNjowNiAtMDUwMCwgSHUgTWluZ2thaS1CMjEyODQgd3JvdGU6DQo+ID4gU2Nv
dHQsDQo+ID4gU29ycnkgZm9yIHRoZSBkZWxheWVkIHJlc3BvbnNlLg0KPiA+IFBsZWFzZSBmaW5l
IG15IGNvbW1lbnRzLg0KPiA+IFRoYW5rcywNCj4gPiBNaW5na2FpDQo+ID4NCj4gPiA+IC0tLS0t
T3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4gPiBGcm9tOiBXb29kIFNjb3R0LUIwNzQyMQ0KPiA+
ID4gU2VudDogVGh1cnNkYXksIFNlcHRlbWJlciAxMiwgMjAxMyA5OjE2IEFNDQo+ID4gPiBUbzog
SHUgTWluZ2thaS1CMjEyODQNCj4gPiA+IENjOiBXb29kIFNjb3R0LUIwNzQyMTsgbGludXhwcGMt
ZGV2QG96bGFicy5vcmcNCj4gPiA+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdIHBvd2VycGMvODV4eDog
RFRTIC0gcmUtb3JnYW5pemUgdGhlIFNQSQ0KPiA+ID4gcGFydGl0aW9ucyBwcm9wZXJ0eQ0KPiA+
ID4NCj4gPiA+IE9uIFR1ZSwgMjAxMy0wOS0xMCBhdCAyMTowNyAtMDUwMCwgSHUgTWluZ2thaS1C
MjEyODQgd3JvdGU6DQo+ID4gPiA+DQo+ID4gPiA+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0t
LS0NCj4gPiA+ID4gPiBGcm9tOiBXb29kIFNjb3R0LUIwNzQyMQ0KPiA+ID4gPiA+IFNlbnQ6IFdl
ZG5lc2RheSwgU2VwdGVtYmVyIDExLCAyMDEzIDc6MzMgQU0NCj4gPiA+ID4gPiBUbzogSHUgTWlu
Z2thaS1CMjEyODQNCj4gPiA+ID4gPiBDYzogbGludXhwcGMtZGV2QG96bGFicy5vcmcNCj4gPiA+
ID4gPiBTdWJqZWN0OiBSZTogW1BBVENIXSBwb3dlcnBjLzg1eHg6IERUUyAtIHJlLW9yZ2FuaXpl
IHRoZSBTUEkNCj4gPiA+ID4gPiBwYXJ0aXRpb25zIHByb3BlcnR5DQo+ID4gPiA+ID4NCj4gPiA+
ID4gPiBXaGF0IGhhcHBlbnMgdG8gZXhzdGluZyB1c2VycyB3aG9zZSBmbGFzaCBpcyBsYWlkIG91
dCB0aGUNCj4gPiA+ID4gPiBleGlzdGluZyB3YXksIHdoZW4gdGhleSB1cGdyYWRlIHRvIHRoZXNl
IGRldmljZSB0cmVlcz8NCj4gPiA+ID4gPg0KPiA+ID4gPg0KPiA+ID4gPiBUaGUgU1BJIGZsYXNo
IGxheW91dCBzaG91bGQgYmUgbWFwcGluZyB0aGUgbmV3IGRldmljZSB0cmVlLg0KPiA+ID4gPg0K
PiA+ID4gPiBJZiB0aGUgZXhpc3RpbmcgZGV2aWNlIHRyZWUgaXMgdXNlZCB0byBkZXBsb3kgdGhl
IFNQSSBmbGFzaCwgdGhlDQo+ID4gPiA+IGZvbGxvd2luZyBpc3N1ZXMgbXVzdCBiZSBydW4gaW50
byBhcyB0aGUgY29tbWl0IG1lc3NhZ2UgZGVzY3JpYmVkOg0KPiA+ID4gPg0KPiA+ID4gPiAxLiBL
ZXJuZWwgaW1hZ2VzIHdvdWxkIGJlIG92ZXJsYXBwZWQgd2l0aCBVLUJvb3QgaW1hZ2UuDQo+ID4g
PiA+IDIuIEtlcm5lbCBpbWFnZXMgd291bGQgYmUgb3ZlcmxhcHBlZCB3aXRoIEZNQU4gdWNvZGUu
DQo+ID4gPiA+IDMuIFNhdmluZyBlbnZpcm9ubWVudCB2YXJpYWJsZXMgd2lsbCBjcmFzaCB0aGUg
a2VybmVsIGltYWdlLg0KPiA+ID4NCj4gPiA+IEhhcyB0aGUgU1BJIFUtQm9vdCBpbWFnZSBhbHdh
eXMgYmVlbiBsYXJnZXIgdGhhbiA1MTJLIGZvciBhbGwgdGhlc2UNCj4gPiA+IHBsYXRmb3Jtcz8g
IFdoeSwgZ2l2ZW4gdGhhdCB3ZSdyZSB1bmRlciA1MTJLIGZvciBvdGhlciBib290IG1vZGVzPw0K
PiA+ID4NCj4gPg0KPiA+IEZvciBEUEFBIHBsYXRmb3JtLCB0aGUgbGQgc2NyaXB0IHVzZWQgdG8g
bGluayB0aGUgdS1ib290IGltYWdlIGlzDQo+ID4gIi4vYXJjaC9wb3dlcnBjL2NwdS9tcGM4NXh4
L3UtYm9vdC5sZHMiIHdoaWNoIHdpbGwgZ2VuZXJhdGUgdGhlIDUxMksNCj4gPiB1LWJvb3QgSW1h
Z2UuIFRoaXMgaW1hZ2Ugd2lsbCBiZSBzcGxpdCBpbnRvIDY0Ynl0ZXMgYW5kIGFwcGVuZGVkIFBC
TA0KPiA+IGNvbW1hbmQgZm9yIEVhY2ggNjRieXRlcyBwaWVjZXMsIHNvIHRoZSBzaXplIG9mIGZp
bmFsIGltYWdlIG11c3QgYmUNCj4gZ3JlYXRlciB0aGFuIDUxMksuDQo+IA0KPiBXaGF0IGlzIHRo
ZSBlbnRyeSBwb2ludCBpbiBTUkFNIHdoZW4geW91IGxvYWQgZnJvbSBQQkw/ICBJZiBpdCBpcyAo
b3IgY2FuDQo+IGJlIG1hZGUgdG8gYmUpIHRoZSBiZWdpbm5pbmcgb2YgdGhlIGltYWdlIHJhdGhl
ciB0aGFuIHRoZSBlbmQsIHRoZW4gdHVybg0KPiBvZmYgdGhlIHJlc2V0dmVjIGFuZCB0aGUgZml4
ZWQgaW1hZ2Ugc2l6ZSB0aGF0IHJlc3VsdHMuDQo+IA0KDQoxLiBUaHVzIGEgc3BlY2lhbCBsZCBz
Y3JpcHQgbmVlZCB0byBiZSBwcm92aWRlZC4NCjIuIE5vdyB0aGUgc3BpIGltYWdlIHNpemUgaXMg
YWJvdXQgNTQwS0IsIHRoYXQncyB0byBzYXkgdGhlIFBCTCBuZWVkcyBhYm91dCB+MzBLDQogICBm
b3IgUEJMIGNvbW1hbmRzLiBJdCdzIGhhcmQgdG8gc2F2ZSBzdWNoIGEgYmlnIHNwYWNlIGV2ZW4g
d2UgdHVybiBvZmYgdGhlDQogICByZXNldHZlYy4NCg0KPiA+ID4gPiA+IFdlIHJlYWxseSBzaG91
bGQgbm90IGJlIHB1dHRpbmcgcGFydGl0aW9uIGxheW91dCBpbmZvIGluIHRoZQ0KPiA+ID4gPiA+
IGRldmljZSB0cmVlIHRvIGJlZ2luIHdpdGguLi4NCj4gPiA+ID4gPg0KPiA+ID4gPiBPSywgSSB3
aWxsIHJlbW92ZSB0aGUgbGF5b3V0IGRpYWdyYW0gaW4gdGhlIGNvbW1pdCBtZXNzYWdlLg0KPiA+
ID4NCj4gPiA+IFRoYXQncyBub3Qgd2hhdCBJIG1lYW50LiAgSSBtZWFudCB0aGF0IHRoZSBkdHMg
c2hvdWxkIGJlIGRlc2NyaWJpbmcNCj4gPiA+IGhhcmR3YXJlLCBhbmQgdGhpcyBpcyB0aGUgc29y
dCBvZiB0cm91YmxlIHdlIHJ1biBpbnRvIHdoZW4gd2UNCj4gPiA+IGRldmlhdGUgZnJvbSB0aGF0
LiAgQSBiZXR0ZXIgd2F5IHdvdWxkIGJlIHRvIHVzZSB0aGUgbXRkcGFydHMgY29tbWFuZA0KPiBs
aW5lIG9wdGlvbi4NCj4gPiA+IEV2ZW4gYmV0dGVyIHdvdWxkIGJlIHNvbWUgc29ydCBvZiBvbi1m
bGFzaCBwYXJ0aXRpb24gdGFibGUuDQo+ID4gPg0KPiA+DQo+ID4gWW91J3JlIHJpZ2h0LCBidXQg
bWF5YmUgc29tZSBjdXN0b21lciBoYXMgYWxyZWFkeSB1c2VkIHRoZSBkZXZpY2UgdHJlZQ0KPiBw
YXJ0aXRpb24gdGFibGUuLi4NCj4gDQo+IE15IG1haW4gcG9pbnQgd2FzIHRvIGVuY291cmFnZSB1
cyB0byBzaGlmdCBhd2F5IGZyb20gdGhpcyByYXRoZXIgdGhhbiB0bw0KPiByaXAgaXQgb3V0IHJp
Z2h0IHRoaXMgaW5zdGFudC4NCj4gDQoNClllcywgdGhhdCdzIHRoZSBjb3JyZWN0IHdheSB3ZSBz
aG91bGQgZ28uDQpXb3VsZCB5b3UgcGxlYXNlIHBpY2sgdXAgdGhpcyBwYXRjaCBmaXJzdCB0byBy
ZXNvbHZlIGN1cnJlbnQgaXNzdWUgd2UgZmFjZWQ/DQpBbmQgd2UgY2FuIGNvbnNpZGVyIHRvIHVz
ZSB0aGUgbXRkcGFydHMgb3Igb24tZmxhc2ggcGFydGl0aW9uIHRhYmxlIGZvciBsb25nIHRlcm0u
DQoNClRoYW5rcywNCk1pbmdrYWkNCg==
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc/85xx: DTS - re-organize the SPI partitions property
2013-09-24 10:27 ` Hu Mingkai-B21284
@ 2013-09-24 19:37 ` Scott Wood
2013-09-30 8:31 ` Hu Mingkai-B21284
0 siblings, 1 reply; 10+ messages in thread
From: Scott Wood @ 2013-09-24 19:37 UTC (permalink / raw)
To: Hu Mingkai-B21284; +Cc: Wood Scott-B07421, linuxppc-dev
On Tue, 2013-09-24 at 05:27 -0500, Hu Mingkai-B21284 wrote:
>
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Tuesday, September 24, 2013 7:03 AM
> > To: Hu Mingkai-B21284
> > Cc: Wood Scott-B07421; linuxppc-dev@ozlabs.org
> > Subject: Re: [PATCH] powerpc/85xx: DTS - re-organize the SPI partitions
> > property
> >
> > On Tue, 2013-09-17 at 06:06 -0500, Hu Mingkai-B21284 wrote:
> > > Scott,
> > > Sorry for the delayed response.
> > > Please fine my comments.
> > > Thanks,
> > > Mingkai
> > >
> > > > -----Original Message-----
> > > > From: Wood Scott-B07421
> > > > Sent: Thursday, September 12, 2013 9:16 AM
> > > > To: Hu Mingkai-B21284
> > > > Cc: Wood Scott-B07421; linuxppc-dev@ozlabs.org
> > > > Subject: Re: [PATCH] powerpc/85xx: DTS - re-organize the SPI
> > > > partitions property
> > > >
> > > > On Tue, 2013-09-10 at 21:07 -0500, Hu Mingkai-B21284 wrote:
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Wood Scott-B07421
> > > > > > Sent: Wednesday, September 11, 2013 7:33 AM
> > > > > > To: Hu Mingkai-B21284
> > > > > > Cc: linuxppc-dev@ozlabs.org
> > > > > > Subject: Re: [PATCH] powerpc/85xx: DTS - re-organize the SPI
> > > > > > partitions property
> > > > > >
> > > > > > What happens to exsting users whose flash is laid out the
> > > > > > existing way, when they upgrade to these device trees?
> > > > > >
> > > > >
> > > > > The SPI flash layout should be mapping the new device tree.
> > > > >
> > > > > If the existing device tree is used to deploy the SPI flash, the
> > > > > following issues must be run into as the commit message described:
> > > > >
> > > > > 1. Kernel images would be overlapped with U-Boot image.
> > > > > 2. Kernel images would be overlapped with FMAN ucode.
> > > > > 3. Saving environment variables will crash the kernel image.
> > > >
> > > > Has the SPI U-Boot image always been larger than 512K for all these
> > > > platforms? Why, given that we're under 512K for other boot modes?
> > > >
> > >
> > > For DPAA platform, the ld script used to link the u-boot image is
> > > "./arch/powerpc/cpu/mpc85xx/u-boot.lds" which will generate the 512K
> > > u-boot Image. This image will be split into 64bytes and appended PBL
> > > command for Each 64bytes pieces, so the size of final image must be
> > greater than 512K.
> >
> > What is the entry point in SRAM when you load from PBL? If it is (or can
> > be made to be) the beginning of the image rather than the end, then turn
> > off the resetvec and the fixed image size that results.
> >
>
> 1. Thus a special ld script need to be provided.
This is already supported. See CONFIG_SYS_MPC85XX_NO_RESETVEC.
> 2. Now the spi image size is about 540KB, that's to say the PBL needs about ~30K
> for PBL commands. It's hard to save such a big space even we turn off the
> resetvec.
Turning off the resetvec doesn't just eliminate the resetvec code; it
eliminates the padding to 512K (or if it doesn't, that's a bug to be
fixed).
> > > > > > We really should not be putting partition layout info in the
> > > > > > device tree to begin with...
> > > > > >
> > > > > OK, I will remove the layout diagram in the commit message.
> > > >
> > > > That's not what I meant. I meant that the dts should be describing
> > > > hardware, and this is the sort of trouble we run into when we
> > > > deviate from that. A better way would be to use the mtdparts command
> > line option.
> > > > Even better would be some sort of on-flash partition table.
> > > >
> > >
> > > You're right, but maybe some customer has already used the device tree
> > partition table...
> >
> > My main point was to encourage us to shift away from this rather than to
> > rip it out right this instant.
> >
>
> Yes, that's the correct way we should go.
> Would you please pick up this patch first to resolve current issue we faced?
> And we can consider to use the mtdparts or on-flash partition table for long term.
Fixing U-Boot would make the problem go away without any issues with
partition compatibility. Are you sure nobody's using these SPI
partitions without booting from SPI? Even if nobody's using this, it
seems a wasteful solution. These are pretty small flashes.
-Scott
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] powerpc/85xx: DTS - re-organize the SPI partitions property
2013-09-24 19:37 ` Scott Wood
@ 2013-09-30 8:31 ` Hu Mingkai-B21284
2013-10-01 19:37 ` Scott Wood
0 siblings, 1 reply; 10+ messages in thread
From: Hu Mingkai-B21284 @ 2013-09-30 8:31 UTC (permalink / raw)
To: Wood Scott-B07421; +Cc: linuxppc-dev
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0
MjENCj4gU2VudDogV2VkbmVzZGF5LCBTZXB0ZW1iZXIgMjUsIDIwMTMgMzozNyBBTQ0KPiBUbzog
SHUgTWluZ2thaS1CMjEyODQNCj4gQ2M6IFdvb2QgU2NvdHQtQjA3NDIxOyBsaW51eHBwYy1kZXZA
b3psYWJzLm9yZw0KPiBTdWJqZWN0OiBSZTogW1BBVENIXSBwb3dlcnBjLzg1eHg6IERUUyAtIHJl
LW9yZ2FuaXplIHRoZSBTUEkgcGFydGl0aW9ucw0KPiBwcm9wZXJ0eQ0KPiANCj4gT24gVHVlLCAy
MDEzLTA5LTI0IGF0IDA1OjI3IC0wNTAwLCBIdSBNaW5na2FpLUIyMTI4NCB3cm90ZToNCj4gPg0K
PiA+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiA+IEZyb206IFdvb2QgU2NvdHQt
QjA3NDIxDQo+ID4gPiBTZW50OiBUdWVzZGF5LCBTZXB0ZW1iZXIgMjQsIDIwMTMgNzowMyBBTQ0K
PiA+ID4gVG86IEh1IE1pbmdrYWktQjIxMjg0DQo+ID4gPiBDYzogV29vZCBTY290dC1CMDc0MjE7
IGxpbnV4cHBjLWRldkBvemxhYnMub3JnDQo+ID4gPiBTdWJqZWN0OiBSZTogW1BBVENIXSBwb3dl
cnBjLzg1eHg6IERUUyAtIHJlLW9yZ2FuaXplIHRoZSBTUEkNCj4gPiA+IHBhcnRpdGlvbnMgcHJv
cGVydHkNCj4gPiA+DQo+ID4gPiBPbiBUdWUsIDIwMTMtMDktMTcgYXQgMDY6MDYgLTA1MDAsIEh1
IE1pbmdrYWktQjIxMjg0IHdyb3RlOg0KPiA+ID4gPiBTY290dCwNCj4gPiA+ID4gU29ycnkgZm9y
IHRoZSBkZWxheWVkIHJlc3BvbnNlLg0KPiA+ID4gPiBQbGVhc2UgZmluZSBteSBjb21tZW50cy4N
Cj4gPiA+ID4gVGhhbmtzLA0KPiA+ID4gPiBNaW5na2FpDQo+ID4gPiA+DQo+ID4gPiA+ID4gLS0t
LS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiA+ID4gPiBGcm9tOiBXb29kIFNjb3R0LUIwNzQy
MQ0KPiA+ID4gPiA+IFNlbnQ6IFRodXJzZGF5LCBTZXB0ZW1iZXIgMTIsIDIwMTMgOToxNiBBTQ0K
PiA+ID4gPiA+IFRvOiBIdSBNaW5na2FpLUIyMTI4NA0KPiA+ID4gPiA+IENjOiBXb29kIFNjb3R0
LUIwNzQyMTsgbGludXhwcGMtZGV2QG96bGFicy5vcmcNCj4gPiA+ID4gPiBTdWJqZWN0OiBSZTog
W1BBVENIXSBwb3dlcnBjLzg1eHg6IERUUyAtIHJlLW9yZ2FuaXplIHRoZSBTUEkNCj4gPiA+ID4g
PiBwYXJ0aXRpb25zIHByb3BlcnR5DQo+ID4gPiA+ID4NCj4gPiA+ID4gPiBPbiBUdWUsIDIwMTMt
MDktMTAgYXQgMjE6MDcgLTA1MDAsIEh1IE1pbmdrYWktQjIxMjg0IHdyb3RlOg0KPiA+ID4gPiA+
ID4NCj4gPiA+ID4gPiA+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiA+ID4gPiA+
ID4gRnJvbTogV29vZCBTY290dC1CMDc0MjENCj4gPiA+ID4gPiA+ID4gU2VudDogV2VkbmVzZGF5
LCBTZXB0ZW1iZXIgMTEsIDIwMTMgNzozMyBBTQ0KPiA+ID4gPiA+ID4gPiBUbzogSHUgTWluZ2th
aS1CMjEyODQNCj4gPiA+ID4gPiA+ID4gQ2M6IGxpbnV4cHBjLWRldkBvemxhYnMub3JnDQo+ID4g
PiA+ID4gPiA+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdIHBvd2VycGMvODV4eDogRFRTIC0gcmUtb3Jn
YW5pemUgdGhlIFNQSQ0KPiA+ID4gPiA+ID4gPiBwYXJ0aXRpb25zIHByb3BlcnR5DQo+ID4gPiA+
ID4gPiA+DQo+ID4gPiA+ID4gPiA+IFdoYXQgaGFwcGVucyB0byBleHN0aW5nIHVzZXJzIHdob3Nl
IGZsYXNoIGlzIGxhaWQgb3V0IHRoZQ0KPiA+ID4gPiA+ID4gPiBleGlzdGluZyB3YXksIHdoZW4g
dGhleSB1cGdyYWRlIHRvIHRoZXNlIGRldmljZSB0cmVlcz8NCj4gPiA+ID4gPiA+ID4NCj4gPiA+
ID4gPiA+DQo+ID4gPiA+ID4gPiBUaGUgU1BJIGZsYXNoIGxheW91dCBzaG91bGQgYmUgbWFwcGlu
ZyB0aGUgbmV3IGRldmljZSB0cmVlLg0KPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+IElmIHRoZSBl
eGlzdGluZyBkZXZpY2UgdHJlZSBpcyB1c2VkIHRvIGRlcGxveSB0aGUgU1BJIGZsYXNoLA0KPiA+
ID4gPiA+ID4gdGhlIGZvbGxvd2luZyBpc3N1ZXMgbXVzdCBiZSBydW4gaW50byBhcyB0aGUgY29t
bWl0IG1lc3NhZ2UNCj4gZGVzY3JpYmVkOg0KPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+IDEuIEtl
cm5lbCBpbWFnZXMgd291bGQgYmUgb3ZlcmxhcHBlZCB3aXRoIFUtQm9vdCBpbWFnZS4NCj4gPiA+
ID4gPiA+IDIuIEtlcm5lbCBpbWFnZXMgd291bGQgYmUgb3ZlcmxhcHBlZCB3aXRoIEZNQU4gdWNv
ZGUuDQo+ID4gPiA+ID4gPiAzLiBTYXZpbmcgZW52aXJvbm1lbnQgdmFyaWFibGVzIHdpbGwgY3Jh
c2ggdGhlIGtlcm5lbCBpbWFnZS4NCj4gPiA+ID4gPg0KPiA+ID4gPiA+IEhhcyB0aGUgU1BJIFUt
Qm9vdCBpbWFnZSBhbHdheXMgYmVlbiBsYXJnZXIgdGhhbiA1MTJLIGZvciBhbGwNCj4gPiA+ID4g
PiB0aGVzZSBwbGF0Zm9ybXM/ICBXaHksIGdpdmVuIHRoYXQgd2UncmUgdW5kZXIgNTEySyBmb3Ig
b3RoZXIgYm9vdA0KPiBtb2Rlcz8NCj4gPiA+ID4gPg0KPiA+ID4gPg0KPiA+ID4gPiBGb3IgRFBB
QSBwbGF0Zm9ybSwgdGhlIGxkIHNjcmlwdCB1c2VkIHRvIGxpbmsgdGhlIHUtYm9vdCBpbWFnZSBp
cw0KPiA+ID4gPiAiLi9hcmNoL3Bvd2VycGMvY3B1L21wYzg1eHgvdS1ib290LmxkcyIgd2hpY2gg
d2lsbCBnZW5lcmF0ZSB0aGUNCj4gPiA+ID4gNTEySyB1LWJvb3QgSW1hZ2UuIFRoaXMgaW1hZ2Ug
d2lsbCBiZSBzcGxpdCBpbnRvIDY0Ynl0ZXMgYW5kDQo+ID4gPiA+IGFwcGVuZGVkIFBCTCBjb21t
YW5kIGZvciBFYWNoIDY0Ynl0ZXMgcGllY2VzLCBzbyB0aGUgc2l6ZSBvZiBmaW5hbA0KPiA+ID4g
PiBpbWFnZSBtdXN0IGJlDQo+ID4gPiBncmVhdGVyIHRoYW4gNTEySy4NCj4gPiA+DQo+ID4gPiBX
aGF0IGlzIHRoZSBlbnRyeSBwb2ludCBpbiBTUkFNIHdoZW4geW91IGxvYWQgZnJvbSBQQkw/ICBJ
ZiBpdCBpcw0KPiA+ID4gKG9yIGNhbiBiZSBtYWRlIHRvIGJlKSB0aGUgYmVnaW5uaW5nIG9mIHRo
ZSBpbWFnZSByYXRoZXIgdGhhbiB0aGUNCj4gPiA+IGVuZCwgdGhlbiB0dXJuIG9mZiB0aGUgcmVz
ZXR2ZWMgYW5kIHRoZSBmaXhlZCBpbWFnZSBzaXplIHRoYXQgcmVzdWx0cy4NCj4gPiA+DQo+ID4N
Cj4gPiAxLiBUaHVzIGEgc3BlY2lhbCBsZCBzY3JpcHQgbmVlZCB0byBiZSBwcm92aWRlZC4NCj4g
DQo+IFRoaXMgaXMgYWxyZWFkeSBzdXBwb3J0ZWQuICBTZWUgQ09ORklHX1NZU19NUEM4NVhYX05P
X1JFU0VUVkVDLg0KPiANCj4gPiAyLiBOb3cgdGhlIHNwaSBpbWFnZSBzaXplIGlzIGFib3V0IDU0
MEtCLCB0aGF0J3MgdG8gc2F5IHRoZSBQQkwgbmVlZHMNCj4gYWJvdXQgfjMwSw0KPiA+ICAgIGZv
ciBQQkwgY29tbWFuZHMuIEl0J3MgaGFyZCB0byBzYXZlIHN1Y2ggYSBiaWcgc3BhY2UgZXZlbiB3
ZSB0dXJuDQo+IG9mZiB0aGUNCj4gPiAgICByZXNldHZlYy4NCj4gDQo+IFR1cm5pbmcgb2ZmIHRo
ZSByZXNldHZlYyBkb2Vzbid0IGp1c3QgZWxpbWluYXRlIHRoZSByZXNldHZlYyBjb2RlOyBpdA0K
PiBlbGltaW5hdGVzIHRoZSBwYWRkaW5nIHRvIDUxMksgKG9yIGlmIGl0IGRvZXNuJ3QsIHRoYXQn
cyBhIGJ1ZyB0byBiZQ0KPiBmaXhlZCkuDQo+IA0KPiA+ID4gPiA+ID4gPiBXZSByZWFsbHkgc2hv
dWxkIG5vdCBiZSBwdXR0aW5nIHBhcnRpdGlvbiBsYXlvdXQgaW5mbyBpbiB0aGUNCj4gPiA+ID4g
PiA+ID4gZGV2aWNlIHRyZWUgdG8gYmVnaW4gd2l0aC4uLg0KPiA+ID4gPiA+ID4gPg0KPiA+ID4g
PiA+ID4gT0ssIEkgd2lsbCByZW1vdmUgdGhlIGxheW91dCBkaWFncmFtIGluIHRoZSBjb21taXQg
bWVzc2FnZS4NCj4gPiA+ID4gPg0KPiA+ID4gPiA+IFRoYXQncyBub3Qgd2hhdCBJIG1lYW50LiAg
SSBtZWFudCB0aGF0IHRoZSBkdHMgc2hvdWxkIGJlDQo+ID4gPiA+ID4gZGVzY3JpYmluZyBoYXJk
d2FyZSwgYW5kIHRoaXMgaXMgdGhlIHNvcnQgb2YgdHJvdWJsZSB3ZSBydW4gaW50bw0KPiA+ID4g
PiA+IHdoZW4gd2UgZGV2aWF0ZSBmcm9tIHRoYXQuICBBIGJldHRlciB3YXkgd291bGQgYmUgdG8g
dXNlIHRoZQ0KPiA+ID4gPiA+IG10ZHBhcnRzIGNvbW1hbmQNCj4gPiA+IGxpbmUgb3B0aW9uLg0K
PiA+ID4gPiA+IEV2ZW4gYmV0dGVyIHdvdWxkIGJlIHNvbWUgc29ydCBvZiBvbi1mbGFzaCBwYXJ0
aXRpb24gdGFibGUuDQo+ID4gPiA+ID4NCj4gPiA+ID4NCj4gPiA+ID4gWW91J3JlIHJpZ2h0LCBi
dXQgbWF5YmUgc29tZSBjdXN0b21lciBoYXMgYWxyZWFkeSB1c2VkIHRoZSBkZXZpY2UNCj4gPiA+
ID4gdHJlZQ0KPiA+ID4gcGFydGl0aW9uIHRhYmxlLi4uDQo+ID4gPg0KPiA+ID4gTXkgbWFpbiBw
b2ludCB3YXMgdG8gZW5jb3VyYWdlIHVzIHRvIHNoaWZ0IGF3YXkgZnJvbSB0aGlzIHJhdGhlcg0K
PiA+ID4gdGhhbiB0byByaXAgaXQgb3V0IHJpZ2h0IHRoaXMgaW5zdGFudC4NCj4gPiA+DQo+ID4N
Cj4gPiBZZXMsIHRoYXQncyB0aGUgY29ycmVjdCB3YXkgd2Ugc2hvdWxkIGdvLg0KPiA+IFdvdWxk
IHlvdSBwbGVhc2UgcGljayB1cCB0aGlzIHBhdGNoIGZpcnN0IHRvIHJlc29sdmUgY3VycmVudCBp
c3N1ZSB3ZQ0KPiBmYWNlZD8NCj4gPiBBbmQgd2UgY2FuIGNvbnNpZGVyIHRvIHVzZSB0aGUgbXRk
cGFydHMgb3Igb24tZmxhc2ggcGFydGl0aW9uIHRhYmxlIGZvcg0KPiBsb25nIHRlcm0uDQo+IA0K
PiBGaXhpbmcgVS1Cb290IHdvdWxkIG1ha2UgdGhlIHByb2JsZW0gZ28gYXdheSB3aXRob3V0IGFu
eSBpc3N1ZXMgd2l0aA0KPiBwYXJ0aXRpb24gY29tcGF0aWJpbGl0eS4gIEFyZSB5b3Ugc3VyZSBu
b2JvZHkncyB1c2luZyB0aGVzZSBTUEkNCj4gcGFydGl0aW9ucyB3aXRob3V0IGJvb3RpbmcgZnJv
bSBTUEk/ICBFdmVuIGlmIG5vYm9keSdzIHVzaW5nIHRoaXMsIGl0DQo+IHNlZW1zIGEgd2FzdGVm
dWwgc29sdXRpb24uICBUaGVzZSBhcmUgcHJldHR5IHNtYWxsIGZsYXNoZXMuDQo+IA0KU2NvdHQs
DQoNCkkgd2lsbCBzdWJtaXQgYSBwYXRjaCBpbiBVLUJvb3QgdG8gZml4IHRoaXMgaXNzdWUuIFNv
bWUgcXVpY2sgcXVlc3Rpb25zOg0KMS4gU2hvdWxkIHdlIHNldCB0aGUgU1BJIGZsYXNoIGFzIE1U
RFBBUlRTX0RFRkFVTFQ/DQoyLiBTaG91bGQgd2UgY29uc2lkZXIgdGhlIHBhcnRpdGlvbiBmb3Ig
TkFORC9OT1IgaW4gbXRkcGFydHM/DQozLiBXZSBuZWVkIHRvIHJlbW92ZSB0aGUgcGFydGl0aW9u
IHRhYmxlIGluIGRldmljZSB0cmVlLCByaWdodD8NCg0KVGhhbmtzLA0KTWluZ2thaQ0K
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc/85xx: DTS - re-organize the SPI partitions property
2013-09-30 8:31 ` Hu Mingkai-B21284
@ 2013-10-01 19:37 ` Scott Wood
0 siblings, 0 replies; 10+ messages in thread
From: Scott Wood @ 2013-10-01 19:37 UTC (permalink / raw)
To: Hu Mingkai-B21284; +Cc: Wood Scott-B07421, linuxppc-dev
On Mon, 2013-09-30 at 03:31 -0500, Hu Mingkai-B21284 wrote:
>
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Wednesday, September 25, 2013 3:37 AM
> > To: Hu Mingkai-B21284
> > Cc: Wood Scott-B07421; linuxppc-dev@ozlabs.org
> > Subject: Re: [PATCH] powerpc/85xx: DTS - re-organize the SPI partitions
> > property
> >
> > Fixing U-Boot would make the problem go away without any issues with
> > partition compatibility. Are you sure nobody's using these SPI
> > partitions without booting from SPI? Even if nobody's using this, it
> > seems a wasteful solution. These are pretty small flashes.
> >
> Scott,
>
> I will submit a patch in U-Boot to fix this issue. Some quick questions:
> 1. Should we set the SPI flash as MTDPARTS_DEFAULT?
> 2. Should we consider the partition for NAND/NOR in mtdparts?
> 3. We need to remove the partition table in device tree, right?
Fixing the U-Boot size problem is separate from changing how we do
partitioning, but yes, we should transition all flashes to using
mtdparts instead of device tree partitions.
As to when to remove them from the device tree, that's a bit tricky.
There's no guarantee when a user updates their U-Boot environment
relative to when they update their device tree. It's better to have
the partitions appear twice than to not appear at all. But we do want
to discourage the use of the device tree partitions, and it would be
bad if the descriptions don't match and a user ends up mixing the two.
-Scott
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-10-01 19:37 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-06 8:05 [PATCH] powerpc/85xx: DTS - re-organize the SPI partitions property Mingkai Hu
2013-09-10 23:33 ` Scott Wood
2013-09-11 2:07 ` Hu Mingkai-B21284
2013-09-12 1:15 ` Scott Wood
2013-09-17 11:06 ` Hu Mingkai-B21284
2013-09-23 23:02 ` Scott Wood
2013-09-24 10:27 ` Hu Mingkai-B21284
2013-09-24 19:37 ` Scott Wood
2013-09-30 8:31 ` Hu Mingkai-B21284
2013-10-01 19:37 ` Scott Wood
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.