[PATCH 1/2] [media] tvp5150: Fix type mismatch warning in clamp macro

[PATCH 1/2] [media] tvp5150: Fix type mismatch warning in clamp macro

[Philipp Zabel]

This patch fixes the following warning:

drivers/media/i2c/tvp5150.c: In function '__tvp5150_try_crop':
include/linux/kernel.h:762:17: warning: comparison of distinct pointer types lacks a cast [enabled by default]
  (void) (&__val == &__min);  \
                 ^
drivers/media/i2c/tvp5150.c:886:16: note: in expansion of macro 'clamp'
  rect->width = clamp(rect->width,
                ^
include/linux/kernel.h:763:17: warning: comparison of distinct pointer types lacks a cast [enabled by default]
  (void) (&__val == &__max);  \
                 ^
drivers/media/i2c/tvp5150.c:886:16: note: in expansion of macro 'clamp'
  rect->width = clamp(rect->width,
                ^
include/linux/kernel.h:762:17: warning: comparison of distinct pointer types lacks a cast [enabled by default]
  (void) (&__val == &__min);  \
                 ^
drivers/media/i2c/tvp5150.c:904:17: note: in expansion of macro 'clamp'
  rect->height = clamp(rect->height,
                 ^
include/linux/kernel.h:763:17: warning: comparison of distinct pointer types lacks a cast [enabled by default]
  (void) (&__val == &__max);  \
                 ^
drivers/media/i2c/tvp5150.c:904:17: note: in expansion of macro 'clamp'
  rect->height = clamp(rect->height,
                 ^

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 drivers/media/i2c/tvp5150.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index 542d252..8ac52fc 100644
--- a/drivers/media/i2c/tvp5150.c
+++ b/drivers/media/i2c/tvp5150.c
@@ -16,9 +16,9 @@
 
 #include "tvp5150_reg.h"
 
-#define TVP5150_H_MAX		720
-#define TVP5150_V_MAX_525_60	480
-#define TVP5150_V_MAX_OTHERS	576
+#define TVP5150_H_MAX		720U
+#define TVP5150_V_MAX_525_60	480U
+#define TVP5150_V_MAX_OTHERS	576U
 #define TVP5150_MAX_CROP_LEFT	511
 #define TVP5150_MAX_CROP_TOP	127
 #define TVP5150_CROP_SHIFT	2
-- 
1.8.5.3

[PATCH 2/2] [media] tvp5150: Make debug module parameter visible in sysfs

[Philipp Zabel]

Set permissions on the debug module parameter to make it appear in sysfs.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 drivers/media/i2c/tvp5150.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index 8ac52fc..4fd3688 100644
--- a/drivers/media/i2c/tvp5150.c
+++ b/drivers/media/i2c/tvp5150.c
@@ -29,7 +29,7 @@ MODULE_LICENSE("GPL");
 
 
 static int debug;
-module_param(debug, int, 0);
+module_param(debug, int, 0644);
 MODULE_PARM_DESC(debug, "Debug level (0-2)");
 
 struct tvp5150 {
-- 
1.8.5.3

Re: [PATCH 1/2] [media] tvp5150: Fix type mismatch warning in clamp macro

[Prabhakar Lad]

Hi Philipp,

Thanks for the patch.

On Thu, Feb 27, 2014 at 10:14 PM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> This patch fixes the following warning:
>
> drivers/media/i2c/tvp5150.c: In function '__tvp5150_try_crop':
> include/linux/kernel.h:762:17: warning: comparison of distinct pointer types lacks a cast [enabled by default]
>   (void) (&__val == &__min);  \
>                  ^
> drivers/media/i2c/tvp5150.c:886:16: note: in expansion of macro 'clamp'
>   rect->width = clamp(rect->width,
>                 ^
> include/linux/kernel.h:763:17: warning: comparison of distinct pointer types lacks a cast [enabled by default]
>   (void) (&__val == &__max);  \
>                  ^
> drivers/media/i2c/tvp5150.c:886:16: note: in expansion of macro 'clamp'
>   rect->width = clamp(rect->width,
>                 ^
> include/linux/kernel.h:762:17: warning: comparison of distinct pointer types lacks a cast [enabled by default]
>   (void) (&__val == &__min);  \
>                  ^
> drivers/media/i2c/tvp5150.c:904:17: note: in expansion of macro 'clamp'
>   rect->height = clamp(rect->height,
>                  ^
> include/linux/kernel.h:763:17: warning: comparison of distinct pointer types lacks a cast [enabled by default]
>   (void) (&__val == &__max);  \
>                  ^
> drivers/media/i2c/tvp5150.c:904:17: note: in expansion of macro 'clamp'
>   rect->height = clamp(rect->height,
>                  ^
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>

Thanks,
--Prabhakar Lad

Re: [PATCH 2/2] [media] tvp5150: Make debug module parameter visible in sysfs

[Prabhakar Lad]

Hi Philipp,

Thanks for the patch.

On Thu, Feb 27, 2014 at 10:14 PM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Set permissions on the debug module parameter to make it appear in sysfs.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>

Thanks,
--Prabhakar Lad