From: Tomasz Figa <tomasz.figa@gmail.com> To: Doug Anderson <dianders@chromium.org> Cc: "Tomasz Figa" <t.figa@samsung.com>, linux-samsung-soc <linux-samsung-soc@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "Kukjin Kim" <kgene.kim@samsung.com>, "Arnd Bergmann" <arnd@arndb.de>, "Olof Johansson" <olof@lixom.net>, "Heiko Stübner" <heiko@sntech.de>, "Stephen Warren" <swarren@wwwdotorg.org>, "Thomas Abraham" <thomas.abraham@linaro.org>, "Linus Walleij" <linus.walleij@linaro.org>, "Prathyush K" <prathyush.k@samsung.com>, "Kyungmin Park" <kyungmin.park@samsung.com>, s.nawrocki@samsung.com Subject: Re: [PATCH 2/6] ARM: EXYNOS: Fix EINT wake-up mask configuration when pinctrl is used Date: Fri, 17 May 2013 21:49:13 +0200 [thread overview] Message-ID: <13970900.6bfa7bMWJL@flatron> (raw) In-Reply-To: <CAD=FV=UUzB=FwHfzTwRMDDGn3+FkuZPbXG9QL_h07qZgRMkZrw@mail.gmail.com> Hi Doug, On Friday 17 of May 2013 12:22:36 Doug Anderson wrote: > Tomasz, > > On Fri, May 17, 2013 at 9:24 AM, Tomasz Figa <t.figa@samsung.com> wrote: > > On DT-enabled systems pinctrl-exynos driver is responsible for > > handling > > of wake-up EINT interrupts. This patch adjusts wake-up mask > > configuration code to take wake-up mask value from pinctrl-exynos > > driver on DT-enabled systems. > > > > Signed-off-by: Tomasz Figa <t.figa@samsung.com> > > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > > --- > > > > arch/arm/mach-exynos/include/mach/pm-core.h | 14 +++++++++++++- > > 1 file changed, 13 insertions(+), 1 deletion(-) > > A little ugly Hehe. I thought exactly the same, but I don't see any better solution at the moment, except persuading the whole suspend/resume support in plat- samsung to be a friend of multiplatform, which will have to be done eventually, but at the moment I don't have time to work on it. > because of the need to support old non-device tree > boards, but seems reasonable. Means that if you have a device tree > you'd better be using pincontrol. Assuming that's true now someone > needs to go through and remove all of the device tree support (and > bindings Documentation) for gpio-samsung. Maybe someone has already > started? If I remember correctly Sylwester Nawrocki had some patches to remove that. He's on a leave right now, so he won't send them for a while, but I guess it's nothing urgent. > On exynos5250-snow (pinmux backported to 3.8): > > Tested-by: Doug Anderson <dianders@chromium.org> > > Reviewed-by: Doug Anderson <dianders@chromium.org> Thanks. Best regards, Tomasz > On Fri, May 17, 2013 at 9:24 AM, Tomasz Figa <t.figa@samsung.com> wrote: > > On DT-enabled systems pinctrl-exynos driver is responsible for > > handling > > of wake-up EINT interrupts. This patch adjusts wake-up mask > > configuration code to take wake-up mask value from pinctrl-exynos > > driver on DT-enabled systems. > > > > Signed-off-by: Tomasz Figa <t.figa@samsung.com> > > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > > --- > > > > arch/arm/mach-exynos/include/mach/pm-core.h | 14 +++++++++++++- > > 1 file changed, 13 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/mach-exynos/include/mach/pm-core.h > > b/arch/arm/mach-exynos/include/mach/pm-core.h index 7dbbfec..296090e > > 100644 > > --- a/arch/arm/mach-exynos/include/mach/pm-core.h > > +++ b/arch/arm/mach-exynos/include/mach/pm-core.h > > @@ -18,8 +18,15 @@ > > > > #ifndef __ASM_ARCH_PM_CORE_H > > #define __ASM_ARCH_PM_CORE_H __FILE__ > > > > +#include <linux/of.h> > > > > #include <mach/regs-pmu.h> > > > > +#ifdef CONFIG_PINCTRL_EXYNOS > > +extern u32 exynos_get_eint_wake_mask(void); > > +#else > > +static inline u32 exynos_get_eint_wake_mask(void) { return > > 0xffffffff; } +#endif > > + > > > > static inline void s3c_pm_debug_init_uart(void) > > { > > > > /* nothing here yet */ > > > > @@ -27,7 +34,12 @@ static inline void s3c_pm_debug_init_uart(void) > > > > static inline void s3c_pm_arch_prepare_irqs(void) > > { > > > > - __raw_writel(s3c_irqwake_eintmask, S5P_EINT_WAKEUP_MASK); > > + u32 eintmask = s3c_irqwake_eintmask; > > + > > + if (of_have_populated_dt()) > > + eintmask = exynos_get_eint_wake_mask(); > > + > > + __raw_writel(eintmask, S5P_EINT_WAKEUP_MASK); > > > > __raw_writel(s3c_irqwake_intmask & ~(1 << 31), > > S5P_WAKEUP_MASK); > > > > } > > > > -- > > 1.8.2.1 > > -- > To unsubscribe from this list: send the line "unsubscribe > linux-samsung-soc" in the body of a message to > majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: tomasz.figa@gmail.com (Tomasz Figa) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/6] ARM: EXYNOS: Fix EINT wake-up mask configuration when pinctrl is used Date: Fri, 17 May 2013 21:49:13 +0200 [thread overview] Message-ID: <13970900.6bfa7bMWJL@flatron> (raw) In-Reply-To: <CAD=FV=UUzB=FwHfzTwRMDDGn3+FkuZPbXG9QL_h07qZgRMkZrw@mail.gmail.com> Hi Doug, On Friday 17 of May 2013 12:22:36 Doug Anderson wrote: > Tomasz, > > On Fri, May 17, 2013 at 9:24 AM, Tomasz Figa <t.figa@samsung.com> wrote: > > On DT-enabled systems pinctrl-exynos driver is responsible for > > handling > > of wake-up EINT interrupts. This patch adjusts wake-up mask > > configuration code to take wake-up mask value from pinctrl-exynos > > driver on DT-enabled systems. > > > > Signed-off-by: Tomasz Figa <t.figa@samsung.com> > > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > > --- > > > > arch/arm/mach-exynos/include/mach/pm-core.h | 14 +++++++++++++- > > 1 file changed, 13 insertions(+), 1 deletion(-) > > A little ugly Hehe. I thought exactly the same, but I don't see any better solution at the moment, except persuading the whole suspend/resume support in plat- samsung to be a friend of multiplatform, which will have to be done eventually, but at the moment I don't have time to work on it. > because of the need to support old non-device tree > boards, but seems reasonable. Means that if you have a device tree > you'd better be using pincontrol. Assuming that's true now someone > needs to go through and remove all of the device tree support (and > bindings Documentation) for gpio-samsung. Maybe someone has already > started? If I remember correctly Sylwester Nawrocki had some patches to remove that. He's on a leave right now, so he won't send them for a while, but I guess it's nothing urgent. > On exynos5250-snow (pinmux backported to 3.8): > > Tested-by: Doug Anderson <dianders@chromium.org> > > Reviewed-by: Doug Anderson <dianders@chromium.org> Thanks. Best regards, Tomasz > On Fri, May 17, 2013 at 9:24 AM, Tomasz Figa <t.figa@samsung.com> wrote: > > On DT-enabled systems pinctrl-exynos driver is responsible for > > handling > > of wake-up EINT interrupts. This patch adjusts wake-up mask > > configuration code to take wake-up mask value from pinctrl-exynos > > driver on DT-enabled systems. > > > > Signed-off-by: Tomasz Figa <t.figa@samsung.com> > > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > > --- > > > > arch/arm/mach-exynos/include/mach/pm-core.h | 14 +++++++++++++- > > 1 file changed, 13 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/mach-exynos/include/mach/pm-core.h > > b/arch/arm/mach-exynos/include/mach/pm-core.h index 7dbbfec..296090e > > 100644 > > --- a/arch/arm/mach-exynos/include/mach/pm-core.h > > +++ b/arch/arm/mach-exynos/include/mach/pm-core.h > > @@ -18,8 +18,15 @@ > > > > #ifndef __ASM_ARCH_PM_CORE_H > > #define __ASM_ARCH_PM_CORE_H __FILE__ > > > > +#include <linux/of.h> > > > > #include <mach/regs-pmu.h> > > > > +#ifdef CONFIG_PINCTRL_EXYNOS > > +extern u32 exynos_get_eint_wake_mask(void); > > +#else > > +static inline u32 exynos_get_eint_wake_mask(void) { return > > 0xffffffff; } +#endif > > + > > > > static inline void s3c_pm_debug_init_uart(void) > > { > > > > /* nothing here yet */ > > > > @@ -27,7 +34,12 @@ static inline void s3c_pm_debug_init_uart(void) > > > > static inline void s3c_pm_arch_prepare_irqs(void) > > { > > > > - __raw_writel(s3c_irqwake_eintmask, S5P_EINT_WAKEUP_MASK); > > + u32 eintmask = s3c_irqwake_eintmask; > > + > > + if (of_have_populated_dt()) > > + eintmask = exynos_get_eint_wake_mask(); > > + > > + __raw_writel(eintmask, S5P_EINT_WAKEUP_MASK); > > > > __raw_writel(s3c_irqwake_intmask & ~(1 << 31), > > S5P_WAKEUP_MASK); > > > > } > > > > -- > > 1.8.2.1 > > -- > To unsubscribe from this list: send the line "unsubscribe > linux-samsung-soc" in the body of a message to > majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-05-17 19:49 UTC|newest] Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-05-17 16:24 [PATCH 0/6] Fix suspend/resume issues created by pinmux on exynos, part 2 Tomasz Figa 2013-05-17 16:24 ` Tomasz Figa 2013-05-17 16:24 ` [PATCH 1/6] pinctrl: exynos: Add support for set_irq_wake of wake-up EINTs Tomasz Figa 2013-05-17 16:24 ` Tomasz Figa 2013-05-17 19:17 ` Doug Anderson 2013-05-17 19:17 ` Doug Anderson 2013-05-21 11:25 ` Linus Walleij 2013-05-21 11:25 ` Linus Walleij 2013-05-17 16:24 ` [PATCH 2/6] ARM: EXYNOS: Fix EINT wake-up mask configuration when pinctrl is used Tomasz Figa 2013-05-17 16:24 ` Tomasz Figa 2013-05-17 19:22 ` Doug Anderson 2013-05-17 19:22 ` Doug Anderson 2013-05-17 19:49 ` Tomasz Figa [this message] 2013-05-17 19:49 ` Tomasz Figa 2013-05-21 11:27 ` Linus Walleij 2013-05-21 11:27 ` Linus Walleij 2013-05-17 16:24 ` [PATCH 3/6] ARM: SAMSUNG: pm: Adjust for pinctrl- and DT-enabled platforms Tomasz Figa 2013-05-17 16:24 ` Tomasz Figa 2013-05-17 19:24 ` Doug Anderson 2013-05-17 19:24 ` Doug Anderson 2013-05-17 20:23 ` Tomasz Figa 2013-05-17 20:23 ` Tomasz Figa 2013-05-17 20:56 ` Doug Anderson 2013-05-17 20:56 ` Doug Anderson 2013-05-17 21:07 ` Tomasz Figa 2013-05-17 21:07 ` Tomasz Figa 2013-05-21 11:29 ` Linus Walleij 2013-05-21 11:29 ` Linus Walleij 2013-05-21 13:15 ` Tomasz Figa 2013-05-21 13:15 ` Tomasz Figa 2013-05-21 17:06 ` Tomasz Figa 2013-05-21 17:06 ` Tomasz Figa 2013-06-10 14:45 ` Tomasz Figa 2013-06-10 14:45 ` Tomasz Figa 2013-06-10 16:13 ` Linus Walleij 2013-06-10 16:13 ` Linus Walleij 2013-06-11 7:45 ` Olof Johansson 2013-06-11 7:45 ` Olof Johansson 2013-06-11 8:21 ` Olof Johansson 2013-06-11 8:21 ` Olof Johansson 2013-06-12 0:15 ` Tomasz Figa 2013-06-12 0:15 ` Tomasz Figa 2013-06-12 0:20 ` Olof Johansson 2013-06-12 0:20 ` Olof Johansson 2013-05-17 16:24 ` [PATCH 4/6] pinctrl: samsung: Add support for SoC-specific suspend/resume callbacks Tomasz Figa 2013-05-17 16:24 ` Tomasz Figa 2013-05-17 19:24 ` Doug Anderson 2013-05-17 19:24 ` Doug Anderson 2013-05-17 20:51 ` Tomasz Figa 2013-05-17 20:51 ` Tomasz Figa 2013-05-24 9:07 ` Linus Walleij 2013-05-24 9:07 ` Linus Walleij 2013-05-24 9:20 ` Tomasz Figa 2013-05-24 9:20 ` Tomasz Figa 2013-05-17 16:24 ` [PATCH 5/6] pinctrl: samsung: Allow per-bank SoC-specific private data Tomasz Figa 2013-05-17 16:24 ` Tomasz Figa 2013-05-17 19:24 ` Doug Anderson 2013-05-17 19:24 ` Doug Anderson 2013-05-24 9:09 ` Linus Walleij 2013-05-24 9:09 ` Linus Walleij 2013-05-17 16:24 ` [PATCH 6/6] pinctrl: exynos: Handle suspend/resume of GPIO EINT registers Tomasz Figa 2013-05-17 16:24 ` Tomasz Figa 2013-05-17 19:25 ` Doug Anderson 2013-05-17 19:25 ` Doug Anderson 2013-05-17 20:34 ` Tomasz Figa 2013-05-17 20:34 ` Tomasz Figa 2013-05-17 21:18 ` Doug Anderson 2013-05-17 21:18 ` Doug Anderson 2013-05-21 17:05 ` [PATCH v2 " Tomasz Figa 2013-05-21 17:05 ` Tomasz Figa 2013-05-22 4:46 ` Doug Anderson 2013-05-22 4:46 ` Doug Anderson 2013-05-22 13:32 ` Tomasz Figa 2013-05-22 13:32 ` Tomasz Figa 2013-05-22 14:03 ` [PATCH v3 " Tomasz Figa 2013-05-22 14:03 ` Tomasz Figa 2013-05-22 15:57 ` Doug Anderson 2013-05-22 15:57 ` Doug Anderson 2013-05-24 9:12 ` Linus Walleij 2013-05-24 9:12 ` Linus Walleij 2013-05-24 9:23 ` Tomasz Figa 2013-05-24 9:23 ` Tomasz Figa 2013-05-20 9:35 ` [PATCH 0/6] Fix suspend/resume issues created by pinmux on exynos, part 2 Tushar Behera 2013-05-20 9:35 ` Tushar Behera
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=13970900.6bfa7bMWJL@flatron \ --to=tomasz.figa@gmail.com \ --cc=arnd@arndb.de \ --cc=dianders@chromium.org \ --cc=heiko@sntech.de \ --cc=kgene.kim@samsung.com \ --cc=kyungmin.park@samsung.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=olof@lixom.net \ --cc=prathyush.k@samsung.com \ --cc=s.nawrocki@samsung.com \ --cc=swarren@wwwdotorg.org \ --cc=t.figa@samsung.com \ --cc=thomas.abraham@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.