All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sricharan R <r.sricharan@ti.com>
To: <linux-omap@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <tony@atomide.com>, <santosh.shilimkar@ti.com>, <nm@ti.com>,
	<rnayak@ti.com>, <linux@arm.linux.org.uk>, <r.sricharan@ti.com>,
	<tglx@linutronix.de>, <jason@lakedaemon.net>
Subject: [PATCH V2 04/19] irqchip: crossbar: Initialise the crossbar with a safe value
Date: Thu, 12 Jun 2014 17:23:12 +0530	[thread overview]
Message-ID: <1402574007-13987-5-git-send-email-r.sricharan@ti.com> (raw)
In-Reply-To: <1402574007-13987-1-git-send-email-r.sricharan@ti.com>

From: Nishanth Menon <nm@ti.com>

Since crossbar is s/w configurable, the initial settings of the
crossbar cannot be assumed to be sane. This implies that:
a) On initialization all un-reserved crossbars must be initialized to
   a known 'safe' value.
b) When unmapping the interrupt, the safe value must be written to
   ensure that the crossbar mapping matches with interrupt controller
   usage.

So provide a safe value in the compatible data to map if
'0' is not safe for the platform and use it during init and unmap

Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Sricharan R <r.sricharan@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 drivers/irqchip/irq-crossbar.c |   14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index 847f6e3..287d3ce 100644
--- a/drivers/irqchip/irq-crossbar.c
+++ b/drivers/irqchip/irq-crossbar.c
@@ -44,6 +44,7 @@ struct crossbar_device {
 struct crossbar_data {
 	const uint *irqs_unused;
 	const uint size;
+	const uint safe_map;
 };
 
 static struct crossbar_device *cb;
@@ -134,7 +135,7 @@ const struct irq_domain_ops routable_irq_domain_ops = {
 static int __init crossbar_of_init(struct device_node *node,
 				   const struct crossbar_data *data)
 {
-	int i, size, max, reserved = 0, entry;
+	int i, size, max, reserved = 0, entry, safe_map;
 	const __be32 *irqsr;
 	const int *irqsk = NULL;
 
@@ -212,6 +213,7 @@ static int __init crossbar_of_init(struct device_node *node,
 	if (data) {
 		irqsk = data->irqs_unused;
 		size = data->size;
+		safe_map = data->safe_map;
 
 		for (i = 0; i < size; i++) {
 			entry = irqsk[i];
@@ -222,6 +224,14 @@ static int __init crossbar_of_init(struct device_node *node,
 			}
 			cb->irq_map[entry] = IRQ_SKIP;
 		}
+
+		for (i = 0; i < max; i++) {
+			if (cb->irq_map[i] == IRQ_RESERVED ||
+			    cb->irq_map[i] == IRQ_SKIP)
+				continue;
+
+			cb->write(i, safe_map);
+		}
 	}
 
 	register_routable_domain_ops(&routable_irq_domain_ops);
@@ -241,7 +251,7 @@ err1:
 /* irq number 10 cannot be used because of hw bug */
 int dra_irqs_unused[] = { 10 };
 struct crossbar_data cb_dra_data = { dra_irqs_unused,
-				     ARRAY_SIZE(dra_irqs_unused) };
+				     ARRAY_SIZE(dra_irqs_unused), 0 };
 
 static const struct of_device_id crossbar_match[] __initconst = {
 	{ .compatible = "ti,irq-crossbar", .data = &cb_dra_data },
-- 
1.7.9.5


WARNING: multiple messages have this Message-ID (diff)
From: Sricharan R <r.sricharan@ti.com>
To: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: tony@atomide.com, santosh.shilimkar@ti.com, nm@ti.com,
	rnayak@ti.com, linux@arm.linux.org.uk, r.sricharan@ti.com,
	tglx@linutronix.de, jason@lakedaemon.net
Subject: [PATCH V2 04/19] irqchip: crossbar: Initialise the crossbar with a safe value
Date: Thu, 12 Jun 2014 17:23:12 +0530	[thread overview]
Message-ID: <1402574007-13987-5-git-send-email-r.sricharan@ti.com> (raw)
In-Reply-To: <1402574007-13987-1-git-send-email-r.sricharan@ti.com>

From: Nishanth Menon <nm@ti.com>

Since crossbar is s/w configurable, the initial settings of the
crossbar cannot be assumed to be sane. This implies that:
a) On initialization all un-reserved crossbars must be initialized to
   a known 'safe' value.
b) When unmapping the interrupt, the safe value must be written to
   ensure that the crossbar mapping matches with interrupt controller
   usage.

So provide a safe value in the compatible data to map if
'0' is not safe for the platform and use it during init and unmap

Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Sricharan R <r.sricharan@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 drivers/irqchip/irq-crossbar.c |   14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index 847f6e3..287d3ce 100644
--- a/drivers/irqchip/irq-crossbar.c
+++ b/drivers/irqchip/irq-crossbar.c
@@ -44,6 +44,7 @@ struct crossbar_device {
 struct crossbar_data {
 	const uint *irqs_unused;
 	const uint size;
+	const uint safe_map;
 };
 
 static struct crossbar_device *cb;
@@ -134,7 +135,7 @@ const struct irq_domain_ops routable_irq_domain_ops = {
 static int __init crossbar_of_init(struct device_node *node,
 				   const struct crossbar_data *data)
 {
-	int i, size, max, reserved = 0, entry;
+	int i, size, max, reserved = 0, entry, safe_map;
 	const __be32 *irqsr;
 	const int *irqsk = NULL;
 
@@ -212,6 +213,7 @@ static int __init crossbar_of_init(struct device_node *node,
 	if (data) {
 		irqsk = data->irqs_unused;
 		size = data->size;
+		safe_map = data->safe_map;
 
 		for (i = 0; i < size; i++) {
 			entry = irqsk[i];
@@ -222,6 +224,14 @@ static int __init crossbar_of_init(struct device_node *node,
 			}
 			cb->irq_map[entry] = IRQ_SKIP;
 		}
+
+		for (i = 0; i < max; i++) {
+			if (cb->irq_map[i] == IRQ_RESERVED ||
+			    cb->irq_map[i] == IRQ_SKIP)
+				continue;
+
+			cb->write(i, safe_map);
+		}
 	}
 
 	register_routable_domain_ops(&routable_irq_domain_ops);
@@ -241,7 +251,7 @@ err1:
 /* irq number 10 cannot be used because of hw bug */
 int dra_irqs_unused[] = { 10 };
 struct crossbar_data cb_dra_data = { dra_irqs_unused,
-				     ARRAY_SIZE(dra_irqs_unused) };
+				     ARRAY_SIZE(dra_irqs_unused), 0 };
 
 static const struct of_device_id crossbar_match[] __initconst = {
 	{ .compatible = "ti,irq-crossbar", .data = &cb_dra_data },
-- 
1.7.9.5

WARNING: multiple messages have this Message-ID (diff)
From: r.sricharan@ti.com (Sricharan R)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 04/19] irqchip: crossbar: Initialise the crossbar with a safe value
Date: Thu, 12 Jun 2014 17:23:12 +0530	[thread overview]
Message-ID: <1402574007-13987-5-git-send-email-r.sricharan@ti.com> (raw)
In-Reply-To: <1402574007-13987-1-git-send-email-r.sricharan@ti.com>

From: Nishanth Menon <nm@ti.com>

Since crossbar is s/w configurable, the initial settings of the
crossbar cannot be assumed to be sane. This implies that:
a) On initialization all un-reserved crossbars must be initialized to
   a known 'safe' value.
b) When unmapping the interrupt, the safe value must be written to
   ensure that the crossbar mapping matches with interrupt controller
   usage.

So provide a safe value in the compatible data to map if
'0' is not safe for the platform and use it during init and unmap

Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Sricharan R <r.sricharan@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 drivers/irqchip/irq-crossbar.c |   14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index 847f6e3..287d3ce 100644
--- a/drivers/irqchip/irq-crossbar.c
+++ b/drivers/irqchip/irq-crossbar.c
@@ -44,6 +44,7 @@ struct crossbar_device {
 struct crossbar_data {
 	const uint *irqs_unused;
 	const uint size;
+	const uint safe_map;
 };
 
 static struct crossbar_device *cb;
@@ -134,7 +135,7 @@ const struct irq_domain_ops routable_irq_domain_ops = {
 static int __init crossbar_of_init(struct device_node *node,
 				   const struct crossbar_data *data)
 {
-	int i, size, max, reserved = 0, entry;
+	int i, size, max, reserved = 0, entry, safe_map;
 	const __be32 *irqsr;
 	const int *irqsk = NULL;
 
@@ -212,6 +213,7 @@ static int __init crossbar_of_init(struct device_node *node,
 	if (data) {
 		irqsk = data->irqs_unused;
 		size = data->size;
+		safe_map = data->safe_map;
 
 		for (i = 0; i < size; i++) {
 			entry = irqsk[i];
@@ -222,6 +224,14 @@ static int __init crossbar_of_init(struct device_node *node,
 			}
 			cb->irq_map[entry] = IRQ_SKIP;
 		}
+
+		for (i = 0; i < max; i++) {
+			if (cb->irq_map[i] == IRQ_RESERVED ||
+			    cb->irq_map[i] == IRQ_SKIP)
+				continue;
+
+			cb->write(i, safe_map);
+		}
 	}
 
 	register_routable_domain_ops(&routable_irq_domain_ops);
@@ -241,7 +251,7 @@ err1:
 /* irq number 10 cannot be used because of hw bug */
 int dra_irqs_unused[] = { 10 };
 struct crossbar_data cb_dra_data = { dra_irqs_unused,
-				     ARRAY_SIZE(dra_irqs_unused) };
+				     ARRAY_SIZE(dra_irqs_unused), 0 };
 
 static const struct of_device_id crossbar_match[] __initconst = {
 	{ .compatible = "ti,irq-crossbar", .data = &cb_dra_data },
-- 
1.7.9.5

  parent reply	other threads:[~2014-06-12 11:56 UTC|newest]

Thread overview: 175+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-12 11:53 [PATCH V2 00/19] irqchip: crossbar: driver fixes Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 01/19] irqchip: crossbar: dont use '0' to mark reserved interrupts Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 02/19] irqchip: crossbar: check for premapped crossbar before allocating Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 03/19] irqchip: crossbar: Skip some irqs from getting mapped to crossbar Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 12:51   ` Jason Cooper
2014-06-12 12:51     ` Jason Cooper
2014-06-12 13:19     ` Sricharan R
2014-06-12 13:19       ` Sricharan R
2014-06-12 13:19       ` Sricharan R
2014-06-12 14:07       ` Jason Cooper
2014-06-12 14:07         ` Jason Cooper
2014-06-12 14:07         ` Jason Cooper
2014-06-13  6:37         ` Sricharan R
2014-06-13  6:37           ` Sricharan R
2014-06-13  6:37           ` Sricharan R
2014-06-13 13:34           ` Jason Cooper
2014-06-13 13:34             ` Jason Cooper
2014-06-12 13:57     ` Tony Lindgren
2014-06-12 13:57       ` Tony Lindgren
2014-06-12 14:05       ` Jason Cooper
2014-06-12 14:05         ` Jason Cooper
2014-06-13  6:56         ` Sricharan R
2014-06-13  6:56           ` Sricharan R
2014-06-13  6:56           ` Sricharan R
2014-06-13 11:04           ` Sricharan R
2014-06-13 11:04             ` Sricharan R
2014-06-13 11:04             ` Sricharan R
2014-06-13 13:10           ` Jason Cooper
2014-06-13 13:10             ` Jason Cooper
2014-06-13 13:35             ` Santosh Shilimkar
2014-06-13 13:35               ` Santosh Shilimkar
2014-06-13 13:35               ` Santosh Shilimkar
2014-06-13 13:41               ` Jason Cooper
2014-06-13 13:41                 ` Jason Cooper
2014-06-13  6:31       ` Sricharan R
2014-06-13  6:31         ` Sricharan R
2014-06-13  6:31         ` Sricharan R
2014-06-12 11:53 ` Sricharan R [this message]
2014-06-12 11:53   ` [PATCH V2 04/19] irqchip: crossbar: Initialise the crossbar with a safe value Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 05/19] irqchip: crossbar: Change allocation logic by reversing search for free irqs Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 12:56   ` Jason Cooper
2014-06-12 12:56     ` Jason Cooper
2014-06-12 12:56     ` Jason Cooper
2014-06-13  6:09     ` Sricharan R
2014-06-13  6:09       ` Sricharan R
2014-06-13  6:09       ` Sricharan R
2014-06-13 13:13       ` Jason Cooper
2014-06-13 13:13         ` Jason Cooper
2014-06-13 13:13         ` Jason Cooper
2014-06-12 11:53 ` [PATCH V2 06/19] irqchip: crossbar: remove IS_ERR_VALUE check Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 07/19] irqchip: crossbar: fix sparse warnings Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 08/19] irqchip: crossbar: fix checkpatch warning Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 13:10   ` Jason Cooper
2014-06-12 13:10     ` Jason Cooper
2014-06-12 13:10     ` Jason Cooper
2014-06-12 13:35     ` Sricharan R
2014-06-12 13:35       ` Sricharan R
2014-06-12 13:35       ` Sricharan R
2014-06-12 14:18       ` Joe Perches
2014-06-12 14:18         ` Joe Perches
2014-06-12 14:18         ` Joe Perches
2014-06-12 15:32         ` Jason Cooper
2014-06-12 15:32           ` Jason Cooper
2014-06-12 16:05           ` Joe Perches
2014-06-12 16:05             ` Joe Perches
2014-06-12 16:05             ` Joe Perches
2014-06-13  6:30             ` Sricharan R
2014-06-13  6:30               ` Sricharan R
2014-06-13  6:30               ` Sricharan R
2014-06-13 13:15               ` Jason Cooper
2014-06-13 13:15                 ` Jason Cooper
2014-06-13 13:15                 ` Jason Cooper
2014-06-12 11:53 ` [PATCH V2 09/19] irqchip: crossbar: fix kerneldoc warning Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 13:14   ` Jason Cooper
2014-06-12 13:14     ` Jason Cooper
2014-06-12 13:14     ` Jason Cooper
2014-06-12 13:39     ` Sricharan R
2014-06-12 13:39       ` Sricharan R
2014-06-12 13:39       ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 10/19] irqchip: crossbar: DRA7: Fix unused crossbar list Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 13:16   ` Jason Cooper
2014-06-12 13:16     ` Jason Cooper
2014-06-12 13:16     ` Jason Cooper
2014-06-12 13:21     ` Sricharan R
2014-06-12 13:21       ` Sricharan R
2014-06-12 13:21       ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 11/19] irqchip: crossbar: fix memory leak incase of invalid entry Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 13:20   ` Jason Cooper
2014-06-12 13:20     ` Jason Cooper
2014-06-12 13:20     ` Jason Cooper
2014-06-12 13:37     ` Sricharan R
2014-06-12 13:37       ` Sricharan R
2014-06-12 13:37       ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 12/19] irqchip: crossbar: return proper error value Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 13:39   ` Jason Cooper
2014-06-12 13:39     ` Jason Cooper
2014-06-12 11:53 ` [PATCH V2 13/19] irqchip: crossbar: change the goto naming Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 13:41   ` Jason Cooper
2014-06-12 13:41     ` Jason Cooper
2014-06-12 13:41     ` Jason Cooper
2014-06-12 11:53 ` [PATCH V2 14/19] irqchip: crossbar: set cb pointer to null in case of error Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 15/19] irqchip: crossbar: Add kerneldoc for crossbar_domain_unmap callback Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 13:49   ` Jason Cooper
2014-06-12 13:49     ` Jason Cooper
2014-06-12 13:50     ` Sricharan R
2014-06-12 13:50       ` Sricharan R
2014-06-12 13:50       ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 16/19] irqchip: crossbar: introduce ti,max-crossbar-sources to identify valid crossbar mapping Sricharan R
2014-06-12 11:53   ` [PATCH V2 16/19] irqchip: crossbar: introduce ti, max-crossbar-sources " Sricharan R
2014-06-12 11:53   ` [PATCH V2 16/19] irqchip: crossbar: introduce ti,max-crossbar-sources " Sricharan R
2014-06-12 13:54   ` Jason Cooper
2014-06-12 13:54     ` Jason Cooper
2014-06-12 13:54     ` Jason Cooper
2014-06-13 10:54     ` Sricharan R
2014-06-13 10:54       ` [PATCH V2 16/19] irqchip: crossbar: introduce ti, max-crossbar-sources " Sricharan R
2014-06-13 10:54       ` [PATCH V2 16/19] irqchip: crossbar: introduce ti,max-crossbar-sources " Sricharan R
2014-06-13 13:17       ` Jason Cooper
2014-06-13 13:17         ` Jason Cooper
2014-06-12 11:53 ` [PATCH V2 17/19] irqchip: crossbar: introduce centralized check for crossbar write Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 18/19] Documentation: dt: OMAP: crossbar: add description for interrupt consumer Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 19/19] irqchip: crossbar allow for quirky hardware with direct hardwiring of GIC Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-13 15:01 ` [PATCH V2 00/19] irqchip: crossbar: driver fixes Jason Cooper
2014-06-13 15:01   ` Jason Cooper
2014-06-13 15:01   ` Jason Cooper
2014-06-13 16:14   ` Joe Perches
2014-06-13 16:14     ` Joe Perches
2014-06-13 16:37     ` Jason Cooper
2014-06-13 16:37       ` Jason Cooper
2014-06-13 16:37       ` Jason Cooper
2014-06-13 16:48       ` Joe Perches
2014-06-13 16:48         ` Joe Perches
2014-06-13 16:54         ` Jason Cooper
2014-06-13 16:54           ` Jason Cooper
2014-06-13 20:38           ` Thomas Gleixner
2014-06-13 20:38             ` Thomas Gleixner
2014-06-13 22:22             ` Joe Perches
2014-06-13 22:22               ` Joe Perches
2014-06-13 22:22               ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1402574007-13987-5-git-send-email-r.sricharan@ti.com \
    --to=r.sricharan@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=nm@ti.com \
    --cc=rnayak@ti.com \
    --cc=santosh.shilimkar@ti.com \
    --cc=tglx@linutronix.de \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.