* [PATCH] UBIFS: fix some comments
@ 2014-07-01 14:45 ` Seunghun Lee
0 siblings, 0 replies; 8+ messages in thread
From: Seunghun Lee @ 2014-07-01 14:45 UTC (permalink / raw)
To: dedekind1, adrian.hunter
Cc: linux-mtd, linux-kernel, linux-fsdevel, Seunghun Lee
This patch fixes some comments about return type.
Signed-off-by: Seunghun Lee <waydi1@gmail.com>
---
fs/ubifs/recovery.c | 4 ++--
fs/ubifs/scan.c | 5 ++---
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/fs/ubifs/recovery.c b/fs/ubifs/recovery.c
index c14adb2..933dda5 100644
--- a/fs/ubifs/recovery.c
+++ b/fs/ubifs/recovery.c
@@ -629,8 +629,8 @@ static void drop_last_node(struct ubifs_scan_leb *sleb, int *offs)
*
* This function does a scan of a LEB, but caters for errors that might have
* been caused by the unclean unmount from which we are attempting to recover.
- * Returns %0 in case of success, %-EUCLEAN if an unrecoverable corruption is
- * found, and a negative error code in case of failure.
+ * Returns the scaned information on success and a negative error code on
+ * failure.
*/
struct ubifs_scan_leb *ubifs_recover_leb(struct ubifs_info *c, int lnum,
int offs, void *sbuf, int jhead)
diff --git a/fs/ubifs/scan.c b/fs/ubifs/scan.c
index 58aa05d..327d84a 100644
--- a/fs/ubifs/scan.c
+++ b/fs/ubifs/scan.c
@@ -131,7 +131,8 @@ int ubifs_scan_a_node(const struct ubifs_info *c, void *buf, int len, int lnum,
* @offs: offset to start at (usually zero)
* @sbuf: scan buffer (must be c->leb_size)
*
- * This function returns %0 on success and a negative error code on failure.
+ * This function returns the scaned information on success and a negative error
+ * code on failure.
*/
struct ubifs_scan_leb *ubifs_start_scan(const struct ubifs_info *c, int lnum,
int offs, void *sbuf)
@@ -169,8 +170,6 @@ struct ubifs_scan_leb *ubifs_start_scan(const struct ubifs_info *c, int lnum,
* @sleb: scanning information
* @lnum: logical eraseblock number
* @offs: offset to start at (usually zero)
- *
- * This function returns %0 on success and a negative error code on failure.
*/
void ubifs_end_scan(const struct ubifs_info *c, struct ubifs_scan_leb *sleb,
int lnum, int offs)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] UBIFS: fix some comments
@ 2014-07-01 14:45 ` Seunghun Lee
0 siblings, 0 replies; 8+ messages in thread
From: Seunghun Lee @ 2014-07-01 14:45 UTC (permalink / raw)
To: dedekind1, adrian.hunter
Cc: linux-fsdevel, Seunghun Lee, linux-mtd, linux-kernel
This patch fixes some comments about return type.
Signed-off-by: Seunghun Lee <waydi1@gmail.com>
---
fs/ubifs/recovery.c | 4 ++--
fs/ubifs/scan.c | 5 ++---
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/fs/ubifs/recovery.c b/fs/ubifs/recovery.c
index c14adb2..933dda5 100644
--- a/fs/ubifs/recovery.c
+++ b/fs/ubifs/recovery.c
@@ -629,8 +629,8 @@ static void drop_last_node(struct ubifs_scan_leb *sleb, int *offs)
*
* This function does a scan of a LEB, but caters for errors that might have
* been caused by the unclean unmount from which we are attempting to recover.
- * Returns %0 in case of success, %-EUCLEAN if an unrecoverable corruption is
- * found, and a negative error code in case of failure.
+ * Returns the scaned information on success and a negative error code on
+ * failure.
*/
struct ubifs_scan_leb *ubifs_recover_leb(struct ubifs_info *c, int lnum,
int offs, void *sbuf, int jhead)
diff --git a/fs/ubifs/scan.c b/fs/ubifs/scan.c
index 58aa05d..327d84a 100644
--- a/fs/ubifs/scan.c
+++ b/fs/ubifs/scan.c
@@ -131,7 +131,8 @@ int ubifs_scan_a_node(const struct ubifs_info *c, void *buf, int len, int lnum,
* @offs: offset to start at (usually zero)
* @sbuf: scan buffer (must be c->leb_size)
*
- * This function returns %0 on success and a negative error code on failure.
+ * This function returns the scaned information on success and a negative error
+ * code on failure.
*/
struct ubifs_scan_leb *ubifs_start_scan(const struct ubifs_info *c, int lnum,
int offs, void *sbuf)
@@ -169,8 +170,6 @@ struct ubifs_scan_leb *ubifs_start_scan(const struct ubifs_info *c, int lnum,
* @sleb: scanning information
* @lnum: logical eraseblock number
* @offs: offset to start at (usually zero)
- *
- * This function returns %0 on success and a negative error code on failure.
*/
void ubifs_end_scan(const struct ubifs_info *c, struct ubifs_scan_leb *sleb,
int lnum, int offs)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] UBIFS: fix some comments
2014-07-01 14:45 ` Seunghun Lee
@ 2014-07-01 14:57 ` Artem Bityutskiy
-1 siblings, 0 replies; 8+ messages in thread
From: Artem Bityutskiy @ 2014-07-01 14:57 UTC (permalink / raw)
To: Seunghun Lee; +Cc: adrian.hunter, linux-mtd, linux-kernel, linux-fsdevel
On Tue, 2014-07-01 at 23:45 +0900, Seunghun Lee wrote:
> This patch fixes some comments about return type.
>
> Signed-off-by: Seunghun Lee <waydi1@gmail.com>
Pushed to linux-ubifs.git, thanks!
--
Best Regards,
Artem Bityutskiy
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] UBIFS: fix some comments
@ 2014-07-01 14:57 ` Artem Bityutskiy
0 siblings, 0 replies; 8+ messages in thread
From: Artem Bityutskiy @ 2014-07-01 14:57 UTC (permalink / raw)
To: Seunghun Lee; +Cc: linux-fsdevel, linux-mtd, adrian.hunter, linux-kernel
On Tue, 2014-07-01 at 23:45 +0900, Seunghun Lee wrote:
> This patch fixes some comments about return type.
>
> Signed-off-by: Seunghun Lee <waydi1@gmail.com>
Pushed to linux-ubifs.git, thanks!
--
Best Regards,
Artem Bityutskiy
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] UBIFS: fix some comments
2014-07-01 14:45 ` Seunghun Lee
@ 2014-07-01 15:27 ` Randy Dunlap
-1 siblings, 0 replies; 8+ messages in thread
From: Randy Dunlap @ 2014-07-01 15:27 UTC (permalink / raw)
To: Seunghun Lee, dedekind1, adrian.hunter
Cc: linux-mtd, linux-kernel, linux-fsdevel
On 07/01/14 07:45, Seunghun Lee wrote:
> This patch fixes some comments about return type.
>
> Signed-off-by: Seunghun Lee <waydi1@gmail.com>
> ---
> fs/ubifs/recovery.c | 4 ++--
> fs/ubifs/scan.c | 5 ++---
> 2 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/fs/ubifs/recovery.c b/fs/ubifs/recovery.c
> index c14adb2..933dda5 100644
> --- a/fs/ubifs/recovery.c
> +++ b/fs/ubifs/recovery.c
> @@ -629,8 +629,8 @@ static void drop_last_node(struct ubifs_scan_leb *sleb, int *offs)
> *
> * This function does a scan of a LEB, but caters for errors that might have
> * been caused by the unclean unmount from which we are attempting to recover.
> - * Returns %0 in case of success, %-EUCLEAN if an unrecoverable corruption is
> - * found, and a negative error code in case of failure.
> + * Returns the scaned information on success and a negative error code on
scanned
> + * failure.
> */
> struct ubifs_scan_leb *ubifs_recover_leb(struct ubifs_info *c, int lnum,
> int offs, void *sbuf, int jhead)
> diff --git a/fs/ubifs/scan.c b/fs/ubifs/scan.c
> index 58aa05d..327d84a 100644
> --- a/fs/ubifs/scan.c
> +++ b/fs/ubifs/scan.c
> @@ -131,7 +131,8 @@ int ubifs_scan_a_node(const struct ubifs_info *c, void *buf, int len, int lnum,
> * @offs: offset to start at (usually zero)
> * @sbuf: scan buffer (must be c->leb_size)
> *
> - * This function returns %0 on success and a negative error code on failure.
> + * This function returns the scaned information on success and a negative error
scanned
> + * code on failure.
> */
> struct ubifs_scan_leb *ubifs_start_scan(const struct ubifs_info *c, int lnum,
> int offs, void *sbuf)
--
~Randy
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] UBIFS: fix some comments
@ 2014-07-01 15:27 ` Randy Dunlap
0 siblings, 0 replies; 8+ messages in thread
From: Randy Dunlap @ 2014-07-01 15:27 UTC (permalink / raw)
To: Seunghun Lee, dedekind1, adrian.hunter
Cc: linux-fsdevel, linux-mtd, linux-kernel
On 07/01/14 07:45, Seunghun Lee wrote:
> This patch fixes some comments about return type.
>
> Signed-off-by: Seunghun Lee <waydi1@gmail.com>
> ---
> fs/ubifs/recovery.c | 4 ++--
> fs/ubifs/scan.c | 5 ++---
> 2 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/fs/ubifs/recovery.c b/fs/ubifs/recovery.c
> index c14adb2..933dda5 100644
> --- a/fs/ubifs/recovery.c
> +++ b/fs/ubifs/recovery.c
> @@ -629,8 +629,8 @@ static void drop_last_node(struct ubifs_scan_leb *sleb, int *offs)
> *
> * This function does a scan of a LEB, but caters for errors that might have
> * been caused by the unclean unmount from which we are attempting to recover.
> - * Returns %0 in case of success, %-EUCLEAN if an unrecoverable corruption is
> - * found, and a negative error code in case of failure.
> + * Returns the scaned information on success and a negative error code on
scanned
> + * failure.
> */
> struct ubifs_scan_leb *ubifs_recover_leb(struct ubifs_info *c, int lnum,
> int offs, void *sbuf, int jhead)
> diff --git a/fs/ubifs/scan.c b/fs/ubifs/scan.c
> index 58aa05d..327d84a 100644
> --- a/fs/ubifs/scan.c
> +++ b/fs/ubifs/scan.c
> @@ -131,7 +131,8 @@ int ubifs_scan_a_node(const struct ubifs_info *c, void *buf, int len, int lnum,
> * @offs: offset to start at (usually zero)
> * @sbuf: scan buffer (must be c->leb_size)
> *
> - * This function returns %0 on success and a negative error code on failure.
> + * This function returns the scaned information on success and a negative error
scanned
> + * code on failure.
> */
> struct ubifs_scan_leb *ubifs_start_scan(const struct ubifs_info *c, int lnum,
> int offs, void *sbuf)
--
~Randy
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] UBIFS: fix some comments
2014-07-01 15:27 ` Randy Dunlap
@ 2014-07-01 15:31 ` Artem Bityutskiy
-1 siblings, 0 replies; 8+ messages in thread
From: Artem Bityutskiy @ 2014-07-01 15:31 UTC (permalink / raw)
To: Randy Dunlap
Cc: Seunghun Lee, adrian.hunter, linux-mtd, linux-kernel, linux-fsdevel
On Tue, 2014-07-01 at 08:27 -0700, Randy Dunlap wrote:
> > - * This function returns %0 on success and a negative error code on failure.
> > + * This function returns the scaned information on success and a negative error
>
> scanned
I'll correct this, thanks!
--
Best Regards,
Artem Bityutskiy
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] UBIFS: fix some comments
@ 2014-07-01 15:31 ` Artem Bityutskiy
0 siblings, 0 replies; 8+ messages in thread
From: Artem Bityutskiy @ 2014-07-01 15:31 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-fsdevel, Seunghun Lee, linux-mtd, adrian.hunter, linux-kernel
On Tue, 2014-07-01 at 08:27 -0700, Randy Dunlap wrote:
> > - * This function returns %0 on success and a negative error code on failure.
> > + * This function returns the scaned information on success and a negative error
>
> scanned
I'll correct this, thanks!
--
Best Regards,
Artem Bityutskiy
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-07-01 15:32 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-01 14:45 [PATCH] UBIFS: fix some comments Seunghun Lee
2014-07-01 14:45 ` Seunghun Lee
2014-07-01 14:57 ` Artem Bityutskiy
2014-07-01 14:57 ` Artem Bityutskiy
2014-07-01 15:27 ` Randy Dunlap
2014-07-01 15:27 ` Randy Dunlap
2014-07-01 15:31 ` Artem Bityutskiy
2014-07-01 15:31 ` Artem Bityutskiy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.