* [PATCH -next] clk: sunxi: sun6i-apb0: fix sparse non static symbol warning
@ 2014-07-28 13:27 ` weiyj_lk at 163.com
0 siblings, 0 replies; 4+ messages in thread
From: weiyj_lk @ 2014-07-28 13:27 UTC (permalink / raw)
To: emilio, mturquette, maxime.ripard, grant.likely, robh+dt
Cc: Wei Yongjun, linux-kernel, linux-arm-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fixes the following sparse warnings:
drivers/clk/sunxi/clk-sun6i-apb0.c:60:27: warning:
symbol 'sun6i_a31_apb0_clk_dt_ids' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/clk/sunxi/clk-sun6i-apb0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/sunxi/clk-sun6i-apb0.c b/drivers/clk/sunxi/clk-sun6i-apb0.c
index 11f17c3..1fa2337 100644
--- a/drivers/clk/sunxi/clk-sun6i-apb0.c
+++ b/drivers/clk/sunxi/clk-sun6i-apb0.c
@@ -57,7 +57,7 @@ static int sun6i_a31_apb0_clk_probe(struct platform_device *pdev)
return of_clk_add_provider(np, of_clk_src_simple_get, clk);
}
-const struct of_device_id sun6i_a31_apb0_clk_dt_ids[] = {
+static const struct of_device_id sun6i_a31_apb0_clk_dt_ids[] = {
{ .compatible = "allwinner,sun6i-a31-apb0-clk" },
{ /* sentinel */ }
};
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH -next] clk: sunxi: sun6i-apb0: fix sparse non static symbol warning
@ 2014-07-28 13:27 ` weiyj_lk at 163.com
0 siblings, 0 replies; 4+ messages in thread
From: weiyj_lk at 163.com @ 2014-07-28 13:27 UTC (permalink / raw)
To: linux-arm-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fixes the following sparse warnings:
drivers/clk/sunxi/clk-sun6i-apb0.c:60:27: warning:
symbol 'sun6i_a31_apb0_clk_dt_ids' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/clk/sunxi/clk-sun6i-apb0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/sunxi/clk-sun6i-apb0.c b/drivers/clk/sunxi/clk-sun6i-apb0.c
index 11f17c3..1fa2337 100644
--- a/drivers/clk/sunxi/clk-sun6i-apb0.c
+++ b/drivers/clk/sunxi/clk-sun6i-apb0.c
@@ -57,7 +57,7 @@ static int sun6i_a31_apb0_clk_probe(struct platform_device *pdev)
return of_clk_add_provider(np, of_clk_src_simple_get, clk);
}
-const struct of_device_id sun6i_a31_apb0_clk_dt_ids[] = {
+static const struct of_device_id sun6i_a31_apb0_clk_dt_ids[] = {
{ .compatible = "allwinner,sun6i-a31-apb0-clk" },
{ /* sentinel */ }
};
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] clk: sunxi: sun6i-apb0: fix sparse non static symbol warning
2014-07-28 13:27 ` weiyj_lk at 163.com
@ 2014-07-28 15:50 ` Emilio López
-1 siblings, 0 replies; 4+ messages in thread
From: Emilio López @ 2014-07-28 15:50 UTC (permalink / raw)
To: weiyj_lk
Cc: mturquette, maxime.ripard, grant.likely, robh+dt, Wei Yongjun,
linux-kernel, linux-arm-kernel
Hi,
El 28/07/14 a las 10:27, weiyj_lk@163.com escibió:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fixes the following sparse warnings:
>
> drivers/clk/sunxi/clk-sun6i-apb0.c:60:27: warning:
> symbol 'sun6i_a31_apb0_clk_dt_ids' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
I sent patches earlier today to fix this and other sparse warnings,
please see
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-July/275680.html
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-July/275681.html
Cheers,
Emilio
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH -next] clk: sunxi: sun6i-apb0: fix sparse non static symbol warning
@ 2014-07-28 15:50 ` Emilio López
0 siblings, 0 replies; 4+ messages in thread
From: Emilio López @ 2014-07-28 15:50 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
El 28/07/14 a las 10:27, weiyj_lk at 163.com escibi?:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fixes the following sparse warnings:
>
> drivers/clk/sunxi/clk-sun6i-apb0.c:60:27: warning:
> symbol 'sun6i_a31_apb0_clk_dt_ids' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
I sent patches earlier today to fix this and other sparse warnings,
please see
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-July/275680.html
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-July/275681.html
Cheers,
Emilio
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-28 15:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-28 13:27 [PATCH -next] clk: sunxi: sun6i-apb0: fix sparse non static symbol warning weiyj_lk
2014-07-28 13:27 ` weiyj_lk at 163.com
2014-07-28 15:50 ` Emilio López
2014-07-28 15:50 ` Emilio López
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.