[Qemu-devel] ui causes latest master build failure on rhel6

[Qemu-devel] ui causes latest master build failure on rhel6

[Michael S. Tsirkin]

I observe two errors with latest master:

ui/qemu-pixman.c: In function ‘qemu_pixelformat_from_pixman’:
ui/qemu-pixman.c:42: error: ‘PIXMAN_TYPE_RGBA’ undeclared (first use in this function)
ui/qemu-pixman.c:42: error: (Each undeclared identifier is reported only once
ui/qemu-pixman.c:42: error: for each function it appears in.)
make: *** [ui/qemu-pixman.o] Error 1

Also:

In file included from /usr/include/gtk-2.0/gtk/gtk.h:228,
                 from ui/gtk.c:48:
/usr/include/gtk-2.0/gtk/gtkitemfactory.h:47: warning: function
declaration isn’t a prototype


Note: 2.1.1 builds fine.

-- 
MST

Re: [Qemu-devel] ui causes latest master build failure on rhel6

[Gerd Hoffmann]

On Do, 2014-09-11 at 17:59 +0300, Michael S. Tsirkin wrote:
> I observe two errors with latest master:
> 
> ui/qemu-pixman.c: In function ‘qemu_pixelformat_from_pixman’:
> ui/qemu-pixman.c:42: error: ‘PIXMAN_TYPE_RGBA’ undeclared (first use in this function)
> ui/qemu-pixman.c:42: error: (Each undeclared identifier is reported only once
> ui/qemu-pixman.c:42: error: for each function it appears in.)
> make: *** [ui/qemu-pixman.o] Error 1

Guess we need to raise the minimum pixman version in configure ...

pixman-0.21.8 is the oldest release which has PIXMAN_TYPE_RGBA.
We don't check for a minimum version.
RHEL-6 is probably older.

Try 'configure --without-system-pixman' as workaround (after checking
out the pixman submodule).

I'll cook up a patch,
  Gerd

Re: [Qemu-devel] ui causes latest master build failure on rhel6

[Gerd Hoffmann]

  Hi,

> In file included from /usr/include/gtk-2.0/gtk/gtk.h:228,
>                  from ui/gtk.c:48:
> /usr/include/gtk-2.0/gtk/gtkitemfactory.h:47: warning: function
> declaration isn’t a prototype

That isn't new.  Bug in the gtk2 header files.  gtk3 has it fixed, but
gtk2.x seems to stay bug compatible forever ...

Maybe we should throw in a #pragma to turn off that warning in gtk.c ...

cheers,
  Gerd

Re: [Qemu-devel] ui causes latest master build failure on rhel6

[Michael S. Tsirkin]

On Thu, Sep 11, 2014 at 05:21:13PM +0200, Gerd Hoffmann wrote:
> On Do, 2014-09-11 at 17:59 +0300, Michael S. Tsirkin wrote:
> > I observe two errors with latest master:
> > 
> > ui/qemu-pixman.c: In function ‘qemu_pixelformat_from_pixman’:
> > ui/qemu-pixman.c:42: error: ‘PIXMAN_TYPE_RGBA’ undeclared (first use in this function)
> > ui/qemu-pixman.c:42: error: (Each undeclared identifier is reported only once
> > ui/qemu-pixman.c:42: error: for each function it appears in.)
> > make: *** [ui/qemu-pixman.o] Error 1
> 
> Guess we need to raise the minimum pixman version in configure ...
> 
> pixman-0.21.8 is the oldest release which has PIXMAN_TYPE_RGBA.
> We don't check for a minimum version.
> RHEL-6 is probably older.
> 
> Try 'configure --without-system-pixman' as workaround (after checking
> out the pixman submodule).

I guess but is it a must?
We used to have this within an ifdef:
+#if PIXMAN_VERSION >= PIXMAN_VERSION_ENCODE(0, 21, 8)
+            type = PIXMAN_TYPE_RGBA;
+#endif
+        }

can't we keep system pixman working a bit longer?


> I'll cook up a patch,
>   Gerd
> 

Re: [Qemu-devel] ui causes latest master build failure on rhel6

[Gerd Hoffmann]

> > pixman-0.21.8 is the oldest release which has PIXMAN_TYPE_RGBA.
> > We don't check for a minimum version.
> > RHEL-6 is probably older.

Uhm, well, it isn't (any more):

[root@rhel6 ~]# rpm -q pixman
pixman-0.26.2-5.1.el6_5.x86_64

Seems to be rebased somewhen (used to be 0.16 for RHEL-6.0 IIRC).
Looks like you should simply update your RHEL-6 machine.

> > Try 'configure --without-system-pixman' as workaround (after checking
> > out the pixman submodule).
> 
> I guess but is it a must?
> We used to have this within an ifdef:
> +#if PIXMAN_VERSION >= PIXMAN_VERSION_ENCODE(0, 21, 8)
> +            type = PIXMAN_TYPE_RGBA;
> +#endif
> +        }

That ifdef is still there, we got new PIXMAN_TYPE_RGBA references
though.

> can't we keep system pixman working a bit longer?

I'd much prefer to raise the minimum pixman version and ditch the
#ifdefs.  The common kvm case will work fine without RGBA, you may run
into trouble though when emulating bigendian guests on a little endian
host (or visa versa), because pixman will have to deal with uncommon
pixel formats then.

cheers,
  Gerd

Re: [Qemu-devel] ui causes latest master build failure on rhel6

[Peter Maydell]

On 11 September 2014 16:21, Gerd Hoffmann <kraxel@redhat.com> wrote:
> pixman-0.21.8 is the oldest release which has PIXMAN_TYPE_RGBA.
> We don't check for a minimum version.
> RHEL-6 is probably older.

Ubuntu LTS hits this too.

> Try 'configure --without-system-pixman' as workaround (after checking
> out the pixman submodule).

The version of pixman we have in our submodule doesn't
have TYPE_RGBA either as far as I can tell...

> I'll cook up a patch,

That would be nice :-)

thanks
-- PMM

Re: [Qemu-devel] ui causes latest master build failure on rhel6

[Gerd Hoffmann]

On Fr, 2014-09-12 at 15:58 +0100, Peter Maydell wrote:
> On 11 September 2014 16:21, Gerd Hoffmann <kraxel@redhat.com> wrote:
> > pixman-0.21.8 is the oldest release which has PIXMAN_TYPE_RGBA.
> > We don't check for a minimum version.
> > RHEL-6 is probably older.
> 
> Ubuntu LTS hits this too.
> 
> > Try 'configure --without-system-pixman' as workaround (after checking
> > out the pixman submodule).
> 
> The version of pixman we have in our submodule doesn't
> have TYPE_RGBA either as far as I can tell...

Oops, indeed.  There was a windows build fix in pixman somewhere around
0.26, I thougth we've upgraded to that version, but apparently not, in
fact we are still at 0.18.x ...

cheers,
  Gerd