All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: "Christoph Hellwig" <hch@lst.de>,
	"Pawel Osciak" <pawel@osciak.com>,
	"Kyungmin Park" <kyungmin.park@samsung.com>,
	"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: Russell King <linux@armlinux.org.uk>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	iommu@lists.linux-foundation.org,
	linux-arm-kernel@lists.infradead.org,
	linuxppc-dev@lists.ozlabs.org, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: fix a layering violation in videobuf2 and improve dma_map_resource
Date: Mon, 14 Jan 2019 12:43:03 +0100	[thread overview]
Message-ID: <141501f5-a9f4-98d7-e958-ca40fc870454@samsung.com> (raw)
In-Reply-To: <20190111181731.11782-1-hch@lst.de>

Hi Christoph,

On 2019-01-11 19:17, Christoph Hellwig wrote:
> Hi all,
>
> this series fixes a rather gross layering violation in videobuf2, which
> pokes into arm DMA mapping internals to get a DMA address for memory that
> does not have a page structure, and to do so fixes up the dma_map_resource
> implementation to be practically useful.

Thanks for rewriting this 'temporary code'! It predates
dma_map_resource() and that time this was the only way to get it working
somehow. Good that now it is possible to implement in it a clean way
without any unwritten assumptions about the DMA mapping internals. Feel
free to add my:

Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com>

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland


WARNING: multiple messages have this Message-ID (diff)
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: "Christoph Hellwig" <hch@lst.de>,
	"Pawel Osciak" <pawel@osciak.com>,
	"Kyungmin Park" <kyungmin.park@samsung.com>,
	"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: Russell King <linux@armlinux.org.uk>,
	linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linuxppc-dev@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org
Subject: Re: fix a layering violation in videobuf2 and improve dma_map_resource
Date: Mon, 14 Jan 2019 12:43:03 +0100	[thread overview]
Message-ID: <141501f5-a9f4-98d7-e958-ca40fc870454@samsung.com> (raw)
In-Reply-To: <20190111181731.11782-1-hch@lst.de>

Hi Christoph,

On 2019-01-11 19:17, Christoph Hellwig wrote:
> Hi all,
>
> this series fixes a rather gross layering violation in videobuf2, which
> pokes into arm DMA mapping internals to get a DMA address for memory that
> does not have a page structure, and to do so fixes up the dma_map_resource
> implementation to be practically useful.

Thanks for rewriting this 'temporary code'! It predates
dma_map_resource() and that time this was the only way to get it working
somehow. Good that now it is possible to implement in it a clean way
without any unwritten assumptions about the DMA mapping internals. Feel
free to add my:

Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com>

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland


WARNING: multiple messages have this Message-ID (diff)
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: "Christoph Hellwig" <hch@lst.de>,
	"Pawel Osciak" <pawel@osciak.com>,
	"Kyungmin Park" <kyungmin.park@samsung.com>,
	"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: Russell King <linux@armlinux.org.uk>,
	linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linuxppc-dev@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org
Subject: Re: fix a layering violation in videobuf2 and improve dma_map_resource
Date: Mon, 14 Jan 2019 12:43:03 +0100	[thread overview]
Message-ID: <141501f5-a9f4-98d7-e958-ca40fc870454@samsung.com> (raw)
In-Reply-To: <20190111181731.11782-1-hch@lst.de>

Hi Christoph,

On 2019-01-11 19:17, Christoph Hellwig wrote:
> Hi all,
>
> this series fixes a rather gross layering violation in videobuf2, which
> pokes into arm DMA mapping internals to get a DMA address for memory that
> does not have a page structure, and to do so fixes up the dma_map_resource
> implementation to be practically useful.

Thanks for rewriting this 'temporary code'! It predates
dma_map_resource() and that time this was the only way to get it working
somehow. Good that now it is possible to implement in it a clean way
without any unwritten assumptions about the DMA mapping internals. Feel
free to add my:

Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com>

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-01-14 11:43 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20190111181841epcas3p2d7c0bf8f5c11a9863e22ec1b12da6e1b@epcas3p2.samsung.com>
2019-01-11 18:17 ` fix a layering violation in videobuf2 and improve dma_map_resource Christoph Hellwig
2019-01-11 18:17   ` Christoph Hellwig
2019-01-11 18:17   ` Christoph Hellwig
2019-01-11 18:17   ` [PATCH 1/3] dma-mapping: remove the default map_resource implementation Christoph Hellwig
2019-01-11 18:17     ` Christoph Hellwig
2019-01-11 18:17     ` Christoph Hellwig
2019-01-14 13:12     ` Robin Murphy
2019-01-14 13:12       ` Robin Murphy
2019-01-14 17:08       ` Christoph Hellwig
2019-01-14 17:08         ` Christoph Hellwig
2019-01-14 17:08         ` Christoph Hellwig
2019-01-11 18:17   ` [PATCH 2/3] dma-mapping: don't BUG when calling dma_map_resource on RAM Christoph Hellwig
2019-01-11 18:17     ` Christoph Hellwig
2019-01-11 18:17     ` Christoph Hellwig
2019-01-14 14:16     ` Robin Murphy
2019-01-14 14:16       ` Robin Murphy
2019-01-11 18:17   ` [PATCH 3/3] videobuf2: replace a layering violation with dma_map_resource Christoph Hellwig
2019-01-11 18:17     ` Christoph Hellwig
2019-01-11 18:17     ` Christoph Hellwig
2019-01-11 19:54     ` Mauro Carvalho Chehab
2019-01-11 19:54       ` Mauro Carvalho Chehab
2019-01-11 19:54       ` Mauro Carvalho Chehab
2019-01-14 10:31       ` Christoph Hellwig
2019-01-14 10:31         ` Christoph Hellwig
2019-01-14 10:31         ` Christoph Hellwig
2019-01-14 11:04         ` Mauro Carvalho Chehab
2019-01-14 11:04           ` Mauro Carvalho Chehab
2019-01-14 11:04           ` Mauro Carvalho Chehab
2019-01-14 11:12           ` Christoph Hellwig
2019-01-14 11:12             ` Christoph Hellwig
2019-01-14 11:12             ` Christoph Hellwig
2019-01-14 12:42     ` Marek Szyprowski
2019-01-14 12:42       ` Marek Szyprowski
2019-01-14 12:42       ` Marek Szyprowski
2019-01-17 17:21       ` Christoph Hellwig
2019-01-17 17:21         ` Christoph Hellwig
2019-01-17 17:21         ` Christoph Hellwig
2019-01-18  9:41         ` Marek Szyprowski
2019-01-18  9:41           ` Marek Szyprowski
2019-01-18  9:41           ` Marek Szyprowski
2019-01-31 15:31           ` Christoph Hellwig
2019-01-31 15:31             ` Christoph Hellwig
2019-01-31 15:31             ` Christoph Hellwig
2019-01-14 11:43   ` Marek Szyprowski [this message]
2019-01-14 11:43     ` fix a layering violation in videobuf2 and improve dma_map_resource Marek Szyprowski
2019-01-14 11:43     ` Marek Szyprowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=141501f5-a9f4-98d7-e958-ca40fc870454@samsung.com \
    --to=m.szyprowski@samsung.com \
    --cc=hch@lst.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mchehab@kernel.org \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    --cc=pawel@osciak.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.