* [PATCH net] tcp: ipv4: initialize unicast_sock sk_pacing_rate
@ 2015-01-28 13:47 Eric Dumazet
2015-01-29 7:25 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Eric Dumazet @ 2015-01-28 13:47 UTC (permalink / raw)
To: David Miller; +Cc: netdev
From: Eric Dumazet <edumazet@google.com>
When I added sk_pacing_rate field, I forgot to initialize its value
in the per cpu unicast_sock used in ip_send_unicast_reply()
This means that for sch_fq users, RST packets, or ACK packets sent
on behalf of TIME_WAIT sockets might be sent to slowly or even dropped
once we reach the per flow limit.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Fixes: 95bd09eb2750 ("tcp: TSO packets automatic sizing")
---
net/ipv4/ip_output.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
index b50861b22b6bea036b1a99ddf141d7ed2d6cf6cd..38a20a9cca1af327618c816e0695e92e8e152bb5 100644
--- a/net/ipv4/ip_output.c
+++ b/net/ipv4/ip_output.c
@@ -1517,6 +1517,7 @@ static DEFINE_PER_CPU(struct inet_sock, unicast_sock) = {
.sk_wmem_alloc = ATOMIC_INIT(1),
.sk_allocation = GFP_ATOMIC,
.sk_flags = (1UL << SOCK_USE_WRITE_QUEUE),
+ .sk_pacing_rate = ~0U,
},
.pmtudisc = IP_PMTUDISC_WANT,
.uc_ttl = -1,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] tcp: ipv4: initialize unicast_sock sk_pacing_rate
2015-01-28 13:47 [PATCH net] tcp: ipv4: initialize unicast_sock sk_pacing_rate Eric Dumazet
@ 2015-01-29 7:25 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-01-29 7:25 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 28 Jan 2015 05:47:11 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> When I added sk_pacing_rate field, I forgot to initialize its value
> in the per cpu unicast_sock used in ip_send_unicast_reply()
>
> This means that for sch_fq users, RST packets, or ACK packets sent
> on behalf of TIME_WAIT sockets might be sent to slowly or even dropped
> once we reach the per flow limit.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Fixes: 95bd09eb2750 ("tcp: TSO packets automatic sizing")
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-29 7:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-28 13:47 [PATCH net] tcp: ipv4: initialize unicast_sock sk_pacing_rate Eric Dumazet
2015-01-29 7:25 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.