From: Rasmus Villemoes <linux@rasmusvillemoes.dk> To: Andrew Morton <akpm@linux-foundation.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Trond Myklebust <trond.myklebust@primarydata.com>, "J. Bruce Fields" <bfields@fieldses.org>, "David S. Miller" <davem@davemloft.net> Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v3 0/3] Two printf fixes Date: Tue, 10 Feb 2015 00:44:47 +0100 [thread overview] Message-ID: <1423525491-12613-1-git-send-email-linux@rasmusvillemoes.dk> (raw) In-Reply-To: <1422525801-26560-1-git-send-email-linux@rasmusvillemoes.dk> Both %pE and %ph are unusable in kasprintf(), since the occurrence of either will trigger an oops during the first vsnprintf call where kasprintf tries to find the correct size to allocate. These oopses could be papered over with somewhat smaller patches than these, but then the return value from vsnprintf would still not reflect the actual size needed. For %pE, this requires a change of semantics of string_escape_mem and hence an annoyingly large diffstat. Not changed in v3: The test_string_escape_nomem helper is still gone, and the overflow test done in test_string_escape. I also kept the "if (out + 1 < end)" conditionals that way. Changed in v3: * Add Andy's ack to 1/3. * Ensure that string_escape_mem doesn't output partial escape sequences after 2/3, while still preparing for it to do exactly that in 3/3. * Leave the return value of string_escape_mem as int. v2: Suggestions from Andy Shevchenko: * Simpler fix of hex_string(). * The string_escape_mem change is split in two, 2/3 updating the internal helpers and 3/3 then changing the external interface. Rasmus Villemoes (3): lib/vsprintf.c: Fix potential NULL deref in hex_string lib/string_helpers.c: Refactor string_escape_mem lib/string_helpers.c: Change semantics of string_escape_mem include/linux/string_helpers.h | 8 +- lib/string_helpers.c | 189 ++++++++++++++++------------------------- lib/test-string_helpers.c | 35 ++++---- lib/vsprintf.c | 24 ++++-- net/sunrpc/cache.c | 8 +- 5 files changed, 113 insertions(+), 151 deletions(-) -- 2.1.3
WARNING: multiple messages have this Message-ID (diff)
From: Rasmus Villemoes <linux-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org> To: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>, Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>, Trond Myklebust <trond.myklebust-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>, "J. Bruce Fields" <bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>, "David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org> Cc: Rasmus Villemoes <linux-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: [PATCH v3 0/3] Two printf fixes Date: Tue, 10 Feb 2015 00:44:47 +0100 [thread overview] Message-ID: <1423525491-12613-1-git-send-email-linux@rasmusvillemoes.dk> (raw) In-Reply-To: <1422525801-26560-1-git-send-email-linux-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org> Both %pE and %ph are unusable in kasprintf(), since the occurrence of either will trigger an oops during the first vsnprintf call where kasprintf tries to find the correct size to allocate. These oopses could be papered over with somewhat smaller patches than these, but then the return value from vsnprintf would still not reflect the actual size needed. For %pE, this requires a change of semantics of string_escape_mem and hence an annoyingly large diffstat. Not changed in v3: The test_string_escape_nomem helper is still gone, and the overflow test done in test_string_escape. I also kept the "if (out + 1 < end)" conditionals that way. Changed in v3: * Add Andy's ack to 1/3. * Ensure that string_escape_mem doesn't output partial escape sequences after 2/3, while still preparing for it to do exactly that in 3/3. * Leave the return value of string_escape_mem as int. v2: Suggestions from Andy Shevchenko: * Simpler fix of hex_string(). * The string_escape_mem change is split in two, 2/3 updating the internal helpers and 3/3 then changing the external interface. Rasmus Villemoes (3): lib/vsprintf.c: Fix potential NULL deref in hex_string lib/string_helpers.c: Refactor string_escape_mem lib/string_helpers.c: Change semantics of string_escape_mem include/linux/string_helpers.h | 8 +- lib/string_helpers.c | 189 ++++++++++++++++------------------------- lib/test-string_helpers.c | 35 ++++---- lib/vsprintf.c | 24 ++++-- net/sunrpc/cache.c | 8 +- 5 files changed, 113 insertions(+), 151 deletions(-) -- 2.1.3 -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-02-09 23:45 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-01-28 13:25 [PATCH 0/2] Two printf fixes Rasmus Villemoes 2015-01-28 13:25 ` [PATCH 1/2] lib/vsprintf.c: Fix potential NULL deref in hex_string Rasmus Villemoes 2015-01-28 14:53 ` Andy Shevchenko 2015-01-28 15:49 ` Rasmus Villemoes 2015-01-28 16:43 ` Andy Shevchenko 2015-01-28 13:25 ` [PATCH 2/2] string_helpers: Change semantics of string_escape_mem Rasmus Villemoes 2015-01-28 15:05 ` Andy Shevchenko 2015-01-29 10:03 ` [PATCH v2 0/3] Two printf fixes Rasmus Villemoes 2015-01-29 10:03 ` [PATCH v2 1/3] lib/vsprintf.c: Fix potential NULL deref in hex_string Rasmus Villemoes 2015-01-29 10:43 ` Andy Shevchenko 2015-01-29 10:03 ` [PATCH v2 2/3] lib/string_helpers.c: Refactor string_escape_mem Rasmus Villemoes 2015-01-29 12:12 ` Andy Shevchenko 2015-01-29 13:10 ` Rasmus Villemoes 2015-01-29 13:37 ` Andy Shevchenko 2015-01-29 19:33 ` Jeff Epler 2015-01-30 10:14 ` Andy Shevchenko 2015-01-29 10:03 ` [PATCH v2 3/3] lib/string_helpers.c: Change semantics of string_escape_mem Rasmus Villemoes 2015-01-29 13:29 ` Andy Shevchenko 2015-01-29 14:29 ` Rasmus Villemoes 2015-01-30 10:27 ` Andy Shevchenko 2015-01-30 23:39 ` Rasmus Villemoes 2015-01-30 23:39 ` Rasmus Villemoes 2015-02-02 10:56 ` Andy Shevchenko 2015-02-09 23:44 ` Rasmus Villemoes [this message] 2015-02-09 23:44 ` [PATCH v3 0/3] Two printf fixes Rasmus Villemoes 2015-02-09 23:44 ` [PATCH v3 1/3] lib/vsprintf.c: Fix potential NULL deref in hex_string Rasmus Villemoes 2015-02-09 23:44 ` [PATCH v3 2/3] lib/string_helpers.c: Refactor string_escape_mem Rasmus Villemoes 2015-02-10 12:16 ` Andy Shevchenko 2015-02-09 23:44 ` [PATCH v3 3/3] lib/string_helpers.c: Change semantics of string_escape_mem Rasmus Villemoes 2015-02-09 23:44 ` Rasmus Villemoes 2015-02-10 12:32 ` Andy Shevchenko 2015-02-10 12:32 ` Andy Shevchenko 2015-02-10 13:02 ` Rasmus Villemoes 2015-02-10 14:22 ` Andy Shevchenko 2015-02-10 14:22 ` Andy Shevchenko 2015-02-21 1:35 ` Rasmus Villemoes 2015-02-23 12:50 ` Andy Shevchenko 2015-02-23 12:50 ` Andy Shevchenko 2015-02-23 22:55 ` Rasmus Villemoes 2015-02-23 22:55 ` Rasmus Villemoes 2015-03-02 12:37 ` Andy Shevchenko 2015-03-02 12:37 ` Andy Shevchenko 2015-03-02 23:03 ` Rasmus Villemoes 2015-03-03 10:26 ` Andy Shevchenko 2015-03-03 10:26 ` Andy Shevchenko 2015-03-03 23:20 ` [PATCH v4 0/3] Two printf fixes Rasmus Villemoes 2015-03-03 23:20 ` [PATCH v4 1/3] lib/vsprintf.c: Fix potential NULL deref in hex_string Rasmus Villemoes 2015-03-03 23:20 ` [PATCH v4 2/3] lib/string_helpers.c: Refactor string_escape_mem Rasmus Villemoes 2015-03-04 10:51 ` Andy Shevchenko 2015-03-03 23:20 ` [PATCH v4 3/3] lib/string_helpers.c: Change semantics of string_escape_mem Rasmus Villemoes 2015-03-04 11:49 ` Andy Shevchenko 2015-03-04 11:49 ` Andy Shevchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1423525491-12613-1-git-send-email-linux@rasmusvillemoes.dk \ --to=linux@rasmusvillemoes.dk \ --cc=akpm@linux-foundation.org \ --cc=andriy.shevchenko@linux.intel.com \ --cc=bfields@fieldses.org \ --cc=davem@davemloft.net \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nfs@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=trond.myklebust@primarydata.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.