From: Namhyung Kim <namhyung@kernel.org> To: Arnaldo Carvalho de Melo <acme@kernel.org> Cc: Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <a.p.zijlstra@chello.nl>, Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>, Minchan Kim <minchan@kernel.org>, Joonsoo Kim <js1304@gmail.com>, linux-mm@kvack.org, Jiri Olsa <jolsa@kernel.org> Subject: [PATCH 1/9] perf kmem: Respect -i option Date: Mon, 6 Apr 2015 14:36:08 +0900 [thread overview] Message-ID: <1428298576-9785-2-git-send-email-namhyung@kernel.org> (raw) In-Reply-To: <1428298576-9785-1-git-send-email-namhyung@kernel.org> From: Jiri Olsa <jolsa@kernel.org> Currently the perf kmem does not respect -i option. Initializing the file.path properly after options get parsed. Signed-off-by: Jiri Olsa <jolsa@kernel.org> Signed-off-by: Namhyung Kim <namhyung@kernel.org> --- tools/perf/builtin-kmem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/perf/builtin-kmem.c b/tools/perf/builtin-kmem.c index ac303ef9f2f0..4ebf65c79434 100644 --- a/tools/perf/builtin-kmem.c +++ b/tools/perf/builtin-kmem.c @@ -663,7 +663,6 @@ int cmd_kmem(int argc, const char **argv, const char *prefix __maybe_unused) { const char * const default_sort_order = "frag,hit,bytes"; struct perf_data_file file = { - .path = input_name, .mode = PERF_DATA_MODE_READ, }; const struct option kmem_options[] = { @@ -701,6 +700,8 @@ int cmd_kmem(int argc, const char **argv, const char *prefix __maybe_unused) return __cmd_record(argc, argv); } + file.path = input_name; + session = perf_session__new(&file, false, &perf_kmem); if (session == NULL) return -1; -- 2.3.2
WARNING: multiple messages have this Message-ID (diff)
From: Namhyung Kim <namhyung@kernel.org> To: Arnaldo Carvalho de Melo <acme@kernel.org> Cc: Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <a.p.zijlstra@chello.nl>, Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>, Minchan Kim <minchan@kernel.org>, Joonsoo Kim <js1304@gmail.com>, linux-mm@kvack.org, Jiri Olsa <jolsa@kernel.org> Subject: [PATCH 1/9] perf kmem: Respect -i option Date: Mon, 6 Apr 2015 14:36:08 +0900 [thread overview] Message-ID: <1428298576-9785-2-git-send-email-namhyung@kernel.org> (raw) In-Reply-To: <1428298576-9785-1-git-send-email-namhyung@kernel.org> From: Jiri Olsa <jolsa@kernel.org> Currently the perf kmem does not respect -i option. Initializing the file.path properly after options get parsed. Signed-off-by: Jiri Olsa <jolsa@kernel.org> Signed-off-by: Namhyung Kim <namhyung@kernel.org> --- tools/perf/builtin-kmem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/perf/builtin-kmem.c b/tools/perf/builtin-kmem.c index ac303ef9f2f0..4ebf65c79434 100644 --- a/tools/perf/builtin-kmem.c +++ b/tools/perf/builtin-kmem.c @@ -663,7 +663,6 @@ int cmd_kmem(int argc, const char **argv, const char *prefix __maybe_unused) { const char * const default_sort_order = "frag,hit,bytes"; struct perf_data_file file = { - .path = input_name, .mode = PERF_DATA_MODE_READ, }; const struct option kmem_options[] = { @@ -701,6 +700,8 @@ int cmd_kmem(int argc, const char **argv, const char *prefix __maybe_unused) return __cmd_record(argc, argv); } + file.path = input_name; + session = perf_session__new(&file, false, &perf_kmem); if (session == NULL) return -1; -- 2.3.2 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-04-06 5:37 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-04-06 5:36 [PATCHSET 0/9] perf kmem: Implement page allocation analysis (v6) Namhyung Kim 2015-04-06 5:36 ` Namhyung Kim 2015-04-06 5:36 ` Namhyung Kim [this message] 2015-04-06 5:36 ` [PATCH 1/9] perf kmem: Respect -i option Namhyung Kim 2015-04-08 15:11 ` [tip:perf/core] " tip-bot for Jiri Olsa 2015-04-06 5:36 ` [PATCH 2/9] tracing, mm: Record pfn instead of pointer to struct page Namhyung Kim 2015-04-06 5:36 ` Namhyung Kim 2015-04-14 12:16 ` [tip:perf/urgent] " tip-bot for Namhyung Kim 2015-04-06 5:36 ` [PATCH 3/9] perf kmem: Analyze page allocator events also Namhyung Kim 2015-04-06 5:36 ` Namhyung Kim 2015-04-10 21:06 ` Arnaldo Carvalho de Melo 2015-04-10 21:06 ` Arnaldo Carvalho de Melo 2015-04-10 21:10 ` Arnaldo Carvalho de Melo 2015-04-10 21:10 ` Arnaldo Carvalho de Melo 2015-04-13 6:59 ` Namhyung Kim 2015-04-13 6:59 ` Namhyung Kim 2015-04-13 13:21 ` Arnaldo Carvalho de Melo 2015-04-13 13:21 ` Arnaldo Carvalho de Melo 2015-04-13 13:40 ` Arnaldo Carvalho de Melo 2015-04-13 13:40 ` Arnaldo Carvalho de Melo 2015-04-14 12:17 ` [tip:perf/urgent] " tip-bot for Namhyung Kim 2015-04-06 5:36 ` [PATCH 4/9] perf kmem: Implement stat --page --caller Namhyung Kim 2015-04-06 5:36 ` Namhyung Kim 2015-04-13 13:40 ` Arnaldo Carvalho de Melo 2015-04-13 13:40 ` Arnaldo Carvalho de Melo 2015-04-14 2:17 ` Namhyung Kim 2015-04-14 2:17 ` Namhyung Kim 2015-04-06 5:36 ` [PATCH 5/9] perf kmem: Support sort keys on page analysis Namhyung Kim 2015-04-06 5:36 ` Namhyung Kim 2015-04-06 5:36 ` [PATCH 6/9] perf kmem: Add --live option for current allocation stat Namhyung Kim 2015-04-06 5:36 ` Namhyung Kim 2015-04-06 5:36 ` [PATCH 7/9] perf kmem: Print gfp flags in human readable string Namhyung Kim 2015-04-06 5:36 ` Namhyung Kim 2015-04-06 5:36 ` [PATCH 8/9] perf kmem: Add kmem.default config option Namhyung Kim 2015-04-06 5:36 ` Namhyung Kim 2015-04-06 5:36 ` [PATCH 9/9] tools lib traceevent: Honor operator priority Namhyung Kim 2015-04-06 5:36 ` Namhyung Kim 2015-04-06 14:45 ` Steven Rostedt 2015-04-06 14:45 ` Steven Rostedt 2015-04-07 7:52 ` Namhyung Kim 2015-04-07 7:52 ` Namhyung Kim 2015-04-07 13:02 ` Arnaldo Carvalho de Melo 2015-04-07 13:02 ` Arnaldo Carvalho de Melo 2015-04-07 13:57 ` Steven Rostedt 2015-04-07 13:57 ` Steven Rostedt 2015-04-07 14:10 ` Namhyung Kim 2015-04-07 14:10 ` Namhyung Kim 2015-04-08 15:11 ` [tip:perf/core] " tip-bot for Namhyung Kim 2015-04-13 13:41 ` [PATCH 9/9] " Arnaldo Carvalho de Melo 2015-04-13 13:41 ` Arnaldo Carvalho de Melo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1428298576-9785-2-git-send-email-namhyung@kernel.org \ --to=namhyung@kernel.org \ --cc=a.p.zijlstra@chello.nl \ --cc=acme@kernel.org \ --cc=dsahern@gmail.com \ --cc=jolsa@kernel.org \ --cc=jolsa@redhat.com \ --cc=js1304@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=minchan@kernel.org \ --cc=mingo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.