From: Sascha Hauer <s.hauer@pengutronix.de> To: linux-pm@vger.kernel.org Cc: Zhang Rui <rui.zhang@intel.com>, Eduardo Valentin <edubezval@gmail.com>, linux-kernel@vger.kernel.org, Stephen Warren <swarren@wwwdotorg.org>, Mikko Perttunen <mikko.perttunen@kapsi.fi>, kernel@pengutronix.de, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Brian Norris <computersforpeace@gmail.com>, Sascha Hauer <s.hauer@pengutronix.de> Subject: [PATCH 06/13] thermal: Add comment explaining test for critical temperature Date: Tue, 28 Apr 2015 10:25:56 +0200 [thread overview] Message-ID: <1430209563-647-7-git-send-email-s.hauer@pengutronix.de> (raw) In-Reply-To: <1430209563-647-1-git-send-email-s.hauer@pengutronix.de> The code testing if a temperature should be emulated or not is not obvious. Add a comment explaining why this test is done. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> --- drivers/thermal/thermal_core.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c index 4633964..ffe09186 100644 --- a/drivers/thermal/thermal_core.c +++ b/drivers/thermal/thermal_core.c @@ -435,6 +435,11 @@ int thermal_zone_get_temp(struct thermal_zone_device *tz, int *temp) } } + /* + * Only allow emulating a temperature when the real temperature + * is below the critical temperature so that the emulation code + * cannot hide critical conditions. + */ if (!ret && *temp < crit_temp) *temp = tz->emul_temperature; } -- 2.1.4
WARNING: multiple messages have this Message-ID (diff)
From: s.hauer@pengutronix.de (Sascha Hauer) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 06/13] thermal: Add comment explaining test for critical temperature Date: Tue, 28 Apr 2015 10:25:56 +0200 [thread overview] Message-ID: <1430209563-647-7-git-send-email-s.hauer@pengutronix.de> (raw) In-Reply-To: <1430209563-647-1-git-send-email-s.hauer@pengutronix.de> The code testing if a temperature should be emulated or not is not obvious. Add a comment explaining why this test is done. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> --- drivers/thermal/thermal_core.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c index 4633964..ffe09186 100644 --- a/drivers/thermal/thermal_core.c +++ b/drivers/thermal/thermal_core.c @@ -435,6 +435,11 @@ int thermal_zone_get_temp(struct thermal_zone_device *tz, int *temp) } } + /* + * Only allow emulating a temperature when the real temperature + * is below the critical temperature so that the emulation code + * cannot hide critical conditions. + */ if (!ret && *temp < crit_temp) *temp = tz->emul_temperature; } -- 2.1.4
next prev parent reply other threads:[~2015-04-28 8:26 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-04-28 8:25 [PATCH v2] Thermal cleanups and hardware trip points Sascha Hauer 2015-04-28 8:25 ` Sascha Hauer 2015-04-28 8:25 ` [PATCH 01/13] thermal: consistently use int for temperatures Sascha Hauer 2015-04-28 8:25 ` Sascha Hauer 2015-04-28 8:25 ` [PATCH 02/13] thermal: trivial: fix typo in comment Sascha Hauer 2015-04-28 8:25 ` Sascha Hauer 2015-04-28 8:25 ` [PATCH 03/13] thermal: trivial: Add missing whitespace in message Sascha Hauer 2015-04-28 8:25 ` Sascha Hauer 2015-04-28 8:25 ` Sascha Hauer 2015-04-28 8:25 ` [PATCH 04/13] thermal: remove useless call to thermal_zone_device_set_polling Sascha Hauer 2015-04-28 8:25 ` Sascha Hauer 2015-04-28 8:25 ` [PATCH 05/13] thermal: Use IS_ENABLED instead of #ifdef Sascha Hauer 2015-04-28 8:25 ` Sascha Hauer 2015-04-28 8:25 ` Sascha Hauer [this message] 2015-04-28 8:25 ` [PATCH 06/13] thermal: Add comment explaining test for critical temperature Sascha Hauer 2015-04-28 8:25 ` [PATCH 07/13] thermal: inline only once used function Sascha Hauer 2015-04-28 8:25 ` Sascha Hauer 2015-04-28 8:25 ` [PATCH 08/13] thermal: streamline get_trend callbacks Sascha Hauer 2015-04-28 8:25 ` Sascha Hauer 2015-04-28 8:25 ` [PATCH 09/13] thermal: Allow sensor ops to fail with -ENOSYS Sascha Hauer 2015-04-28 8:25 ` Sascha Hauer 2015-04-28 8:26 ` [PATCH 10/13] thermal: of: always set sensor related callbacks Sascha Hauer 2015-04-28 8:26 ` Sascha Hauer 2015-04-28 8:26 ` Sascha Hauer 2015-04-28 8:26 ` [PATCH 11/13] thermal: Make struct thermal_zone_device_ops const Sascha Hauer 2015-04-28 8:26 ` Sascha Hauer 2015-04-28 8:26 ` [PATCH 12/13] thermal: thermal: Add support for hardware-tracked trip points Sascha Hauer 2015-04-28 8:26 ` Sascha Hauer 2015-04-28 8:26 ` [PATCH 13/13] thermal: of: implement .set_trips for device tree thermal zones Sascha Hauer 2015-04-28 8:26 ` Sascha Hauer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1430209563-647-7-git-send-email-s.hauer@pengutronix.de \ --to=s.hauer@pengutronix.de \ --cc=computersforpeace@gmail.com \ --cc=edubezval@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=mikko.perttunen@kapsi.fi \ --cc=rui.zhang@intel.com \ --cc=swarren@wwwdotorg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.