From: "Jon Medhurst (Tixy)" <tixy@linaro.org> To: Liviu Dudau <Liviu.Dudau@arm.com> Cc: Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <Mark.Rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Marc Zyngier <Marc.Zyngier@arm.com>, Catalin Marinas <Catalin.Marinas@arm.com>, Will Deacon <Will.Deacon@arm.com>, Sudeep Holla <Sudeep.Holla@arm.com>, devicetree <devicetree@vger.kernel.org>, LAKML <linux-arm-kernel@lists.infradead.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 2/5] arm64: Juno: Split juno.dts into juno-base.dtsi and juno.dts. Date: Thu, 14 May 2015 12:04:31 +0100 [thread overview] Message-ID: <1431601471.2881.36.camel@linaro.org> (raw) In-Reply-To: <20150514103040.GN2345@e106497-lin.cambridge.arm.com> On Thu, 2015-05-14 at 11:30 +0100, Liviu Dudau wrote: > On Thu, May 14, 2015 at 10:35:42AM +0100, Jon Medhurst (Tixy) wrote: [...] > > > > What criteria were used to select the contents of juno-base.dtsi? > > From what I can see, the stuff left out of base is still the same for r0 > > and r1 (cpu, pmu, memory, psci!). [...] > > There are potential differences. Cortex-A53 cluster in r1 has limited > CPUfreq functionality due to a chip errata and there were talks internally > to actually disable it, hence the reason for keeping CPUs outside the > juno-base.dtsi. r2 will have a different set of big CPUs as well, so this > is preparing for the future as well. > > PMU are linked to the CPUs, hence the reason they stayed. As for the > memory and psci nodes the thinking behind it was mostly to allow for > ACPI to make changes there, but it does look now like retrofitting an > explanation to something that I did not give too much thought at that > moment. I guess my concern was motivated by the selfish aspect of having to maintain a bunch of out-of-tree Juno patches (like cpuidle and cpufreq related DT updates) and having to duplicate those in more than one DT, and also having backport DT reorgs like this patch. Of course, none of that should be a consideration in deciding what goes into mainline, I just wanted to make sure there was a reason for the patch. -- Tixy
WARNING: multiple messages have this Message-ID (diff)
From: tixy@linaro.org (Jon Medhurst (Tixy)) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/5] arm64: Juno: Split juno.dts into juno-base.dtsi and juno.dts. Date: Thu, 14 May 2015 12:04:31 +0100 [thread overview] Message-ID: <1431601471.2881.36.camel@linaro.org> (raw) In-Reply-To: <20150514103040.GN2345@e106497-lin.cambridge.arm.com> On Thu, 2015-05-14 at 11:30 +0100, Liviu Dudau wrote: > On Thu, May 14, 2015 at 10:35:42AM +0100, Jon Medhurst (Tixy) wrote: [...] > > > > What criteria were used to select the contents of juno-base.dtsi? > > From what I can see, the stuff left out of base is still the same for r0 > > and r1 (cpu, pmu, memory, psci!). [...] > > There are potential differences. Cortex-A53 cluster in r1 has limited > CPUfreq functionality due to a chip errata and there were talks internally > to actually disable it, hence the reason for keeping CPUs outside the > juno-base.dtsi. r2 will have a different set of big CPUs as well, so this > is preparing for the future as well. > > PMU are linked to the CPUs, hence the reason they stayed. As for the > memory and psci nodes the thinking behind it was mostly to allow for > ACPI to make changes there, but it does look now like retrofitting an > explanation to something that I did not give too much thought at that > moment. I guess my concern was motivated by the selfish aspect of having to maintain a bunch of out-of-tree Juno patches (like cpuidle and cpufreq related DT updates) and having to duplicate those in more than one DT, and also having backport DT reorgs like this patch. Of course, none of that should be a consideration in deciding what goes into mainline, I just wanted to make sure there was a reason for the patch. -- Tixy
next prev parent reply other threads:[~2015-05-14 11:04 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-05-13 17:11 [PATCH 0/5] arm64: Juno DT updates and new DT for Juno R1 Liviu Dudau 2015-05-13 17:11 ` Liviu Dudau 2015-05-13 17:11 ` [PATCH 1/5] arm64: Juno: Fix the GIC node address label and the frequency of FAXI clock Liviu Dudau 2015-05-13 17:11 ` Liviu Dudau 2015-05-13 17:11 ` [PATCH 2/5] arm64: Juno: Split juno.dts into juno-base.dtsi and juno.dts Liviu Dudau 2015-05-13 17:11 ` Liviu Dudau 2015-05-14 9:35 ` Jon Medhurst (Tixy) 2015-05-14 9:35 ` Jon Medhurst (Tixy) 2015-05-14 10:30 ` Liviu Dudau 2015-05-14 10:30 ` Liviu Dudau 2015-05-14 11:04 ` Jon Medhurst (Tixy) [this message] 2015-05-14 11:04 ` Jon Medhurst (Tixy) 2015-05-14 13:11 ` Liviu Dudau 2015-05-14 13:11 ` Liviu Dudau 2015-05-14 13:11 ` Liviu Dudau 2015-05-14 13:50 ` Jon Medhurst (Tixy) 2015-05-14 13:50 ` Jon Medhurst (Tixy) 2015-05-14 13:44 ` Sudeep Holla 2015-05-14 13:44 ` Sudeep Holla 2015-05-14 13:44 ` Sudeep Holla 2015-05-13 17:11 ` [PATCH 3/5] arm64: Juno: Add memory mapped timer node Liviu Dudau 2015-05-13 17:11 ` Liviu Dudau 2015-05-13 17:11 ` [PATCH 4/5] arm64: Juno: Add GICv2m support in device tree Liviu Dudau 2015-05-13 17:11 ` Liviu Dudau 2015-05-13 17:11 ` [PATCH 5/5] arm64: Add DT support for Juno r1 board Liviu Dudau 2015-05-13 17:11 ` Liviu Dudau 2015-05-14 14:07 ` Jon Medhurst (Tixy) 2015-05-14 14:07 ` Jon Medhurst (Tixy) 2015-05-14 14:14 ` Liviu Dudau 2015-05-14 14:14 ` Liviu Dudau 2015-05-14 14:18 ` Mark Rutland 2015-05-14 14:18 ` Mark Rutland 2015-05-14 14:18 ` Mark Rutland 2015-05-14 15:14 ` Jon Medhurst (Tixy) 2015-05-14 15:14 ` Jon Medhurst (Tixy)
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1431601471.2881.36.camel@linaro.org \ --to=tixy@linaro.org \ --cc=Catalin.Marinas@arm.com \ --cc=Liviu.Dudau@arm.com \ --cc=Marc.Zyngier@arm.com \ --cc=Mark.Rutland@arm.com \ --cc=Sudeep.Holla@arm.com \ --cc=Will.Deacon@arm.com \ --cc=arnd@arndb.de \ --cc=devicetree@vger.kernel.org \ --cc=ijc+devicetree@hellion.org.uk \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=olof@lixom.net \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.