* [PATCH] ath9k_htc: match wait_for_completion_timeout return type
@ 2015-05-14 15:29 Nicholas Mc Guire
2015-08-13 12:25 ` [ath9k-devel] " Kalle Valo
0 siblings, 1 reply; 3+ messages in thread
From: Nicholas Mc Guire @ 2015-05-14 15:29 UTC (permalink / raw)
To: QCA ath9k Development
Cc: Kalle Valo, linux-wireless, ath9k-devel, netdev, linux-kernel,
Nicholas Mc Guire
Return type of wait_for_completion_timeout is unsigned long not int.
As time_left is exclusively used for wait_for_completion_timeout here its
type is simply changed to unsigned long.
API conformance testing for completions with coccinelle spatches are being
used to locate API usage inconsistencies:
./drivers/net/wireless/ath/ath9k/htc_hst.c:171
int return assigned to unsigned long
./drivers/net/wireless/ath/ath9k/htc_hst.c:277
int return assigned to unsigned long
./drivers/net/wireless/ath/ath9k/htc_hst.c:206
int return assigned to unsigned long
Patch was compile tested with x86_64_defconfig + CONFIG_ATH_CARDS=m,
CONFIG_ATH9K_HTC=m
Patch is against 4.1-rc3 (localversion-next is -next-20150514)
Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
---
drivers/net/wireless/ath/ath9k/htc_hst.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/htc_hst.c b/drivers/net/wireless/ath/ath9k/htc_hst.c
index d2408da..2294709 100644
--- a/drivers/net/wireless/ath/ath9k/htc_hst.c
+++ b/drivers/net/wireless/ath/ath9k/htc_hst.c
@@ -146,7 +146,8 @@ static int htc_config_pipe_credits(struct htc_target *target)
{
struct sk_buff *skb;
struct htc_config_pipe_msg *cp_msg;
- int ret, time_left;
+ int ret;
+ unsigned long time_left;
skb = alloc_skb(50 + sizeof(struct htc_frame_hdr), GFP_ATOMIC);
if (!skb) {
@@ -184,7 +185,8 @@ static int htc_setup_complete(struct htc_target *target)
{
struct sk_buff *skb;
struct htc_comp_msg *comp_msg;
- int ret = 0, time_left;
+ int ret = 0;
+ unsigned long time_left;
skb = alloc_skb(50 + sizeof(struct htc_frame_hdr), GFP_ATOMIC);
if (!skb) {
@@ -236,7 +238,8 @@ int htc_connect_service(struct htc_target *target,
struct sk_buff *skb;
struct htc_endpoint *endpoint;
struct htc_conn_svc_msg *conn_msg;
- int ret, time_left;
+ int ret;
+ unsigned long time_left;
/* Find an available endpoint */
endpoint = get_next_avail_ep(target->endpoint);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: ath9k_htc: match wait_for_completion_timeout return type
2015-05-14 15:29 [PATCH] ath9k_htc: match wait_for_completion_timeout return type Nicholas Mc Guire
@ 2015-08-13 12:25 ` Kalle Valo
0 siblings, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2015-08-13 12:25 UTC (permalink / raw)
To: Nicholas Mc Guire
Cc: QCA ath9k Development, linux-wireless, ath9k-devel, netdev,
linux-kernel, Nicholas Mc Guire
> Return type of wait_for_completion_timeout is unsigned long not int.
> As time_left is exclusively used for wait_for_completion_timeout here its
> type is simply changed to unsigned long.
>
> API conformance testing for completions with coccinelle spatches are being
> used to locate API usage inconsistencies:
> ./drivers/net/wireless/ath/ath9k/htc_hst.c:171
> int return assigned to unsigned long
> ./drivers/net/wireless/ath/ath9k/htc_hst.c:277
> int return assigned to unsigned long
> ./drivers/net/wireless/ath/ath9k/htc_hst.c:206
> int return assigned to unsigned long
>
> Patch was compile tested with x86_64_defconfig + CONFIG_ATH_CARDS=m,
> CONFIG_ATH9K_HTC=m
>
> Patch is against 4.1-rc3 (localversion-next is -next-20150514)
>
>
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
^ permalink raw reply [flat|nested] 3+ messages in thread
* [ath9k-devel] ath9k_htc: match wait_for_completion_timeout return type
@ 2015-08-13 12:25 ` Kalle Valo
0 siblings, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2015-08-13 12:25 UTC (permalink / raw)
To: ath9k-devel
> Return type of wait_for_completion_timeout is unsigned long not int.
> As time_left is exclusively used for wait_for_completion_timeout here its
> type is simply changed to unsigned long.
>
> API conformance testing for completions with coccinelle spatches are being
> used to locate API usage inconsistencies:
> ./drivers/net/wireless/ath/ath9k/htc_hst.c:171
> int return assigned to unsigned long
> ./drivers/net/wireless/ath/ath9k/htc_hst.c:277
> int return assigned to unsigned long
> ./drivers/net/wireless/ath/ath9k/htc_hst.c:206
> int return assigned to unsigned long
>
> Patch was compile tested with x86_64_defconfig + CONFIG_ATH_CARDS=m,
> CONFIG_ATH9K_HTC=m
>
> Patch is against 4.1-rc3 (localversion-next is -next-20150514)
>
>
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-08-13 12:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-14 15:29 [PATCH] ath9k_htc: match wait_for_completion_timeout return type Nicholas Mc Guire
2015-08-13 12:25 ` Kalle Valo
2015-08-13 12:25 ` [ath9k-devel] " Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.