[PATCH lttng-tools 1/2] Fix: pids should be numbers only

[PATCH lttng-tools 1/2] Fix: pids should be numbers only

[Jonathan Rajotte]

Ruled out cases: word, number+word, word+number, number+word+number
Ex: foo, 123foo, foo123, 123foo123

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
---
 src/bin/lttng/commands/track-untrack.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/bin/lttng/commands/track-untrack.c b/src/bin/lttng/commands/track-untrack.c
index 52442cc..639e184 100644
--- a/src/bin/lttng/commands/track-untrack.c
+++ b/src/bin/lttng/commands/track-untrack.c
@@ -96,6 +96,7 @@ int parse_pid_string(const char *_pid_string,
 	int count = 0;
 	int *pid_list = NULL;
 	char *pid_string = NULL;
+	char *endptr;
 
 	if (all && _pid_string) {
 		ERR("An empty PID string is expected with --all");
@@ -132,13 +133,16 @@ int parse_pid_string(const char *_pid_string,
 	while (one_pid_str != NULL) {
 		unsigned long v;
 
-		v = strtoul(one_pid_str, NULL, 10);
+		errno = 0;
+		v = strtoul(one_pid_str, &endptr, 10);
 		if ((v == 0 && errno == EINVAL)
-				|| (v == ULONG_MAX && errno == ERANGE)) {
+				|| (v == ULONG_MAX && errno == ERANGE)
+				|| (*one_pid_str != '\0' && *endptr != '\0')){
 			ERR("Error parsing PID %s", one_pid_str);
 			retval = CMD_ERROR;
 			goto error;
 		}
+
 		if ((long) v > INT_MAX || (int) v < 0) {
 			ERR("Invalid PID value %ld", (long) v);
 			retval = CMD_ERROR;
-- 
2.1.4

Re: [PATCH lttng-tools 1/2] Fix: pids should be numbers only

[Jérémie Galarneau]

[-- Attachment #1.1: Type: text/plain, Size: 1987 bytes --]

Merged, thanks!

J/r/mie

On Fri, Jul 24, 2015 at 5:42 PM, Jonathan Rajotte <
jonathan.rajotte-julien@efficios.com> wrote:

> Ruled out cases: word, number+word, word+number, number+word+number
> Ex: foo, 123foo, foo123, 123foo123
>
> Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
> ---
>  src/bin/lttng/commands/track-untrack.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/src/bin/lttng/commands/track-untrack.c
> b/src/bin/lttng/commands/track-untrack.c
> index 52442cc..639e184 100644
> --- a/src/bin/lttng/commands/track-untrack.c
> +++ b/src/bin/lttng/commands/track-untrack.c
> @@ -96,6 +96,7 @@ int parse_pid_string(const char *_pid_string,
>         int count = 0;
>         int *pid_list = NULL;
>         char *pid_string = NULL;
> +       char *endptr;
>
>         if (all && _pid_string) {
>                 ERR("An empty PID string is expected with --all");
> @@ -132,13 +133,16 @@ int parse_pid_string(const char *_pid_string,
>         while (one_pid_str != NULL) {
>                 unsigned long v;
>
> -               v = strtoul(one_pid_str, NULL, 10);
> +               errno = 0;
> +               v = strtoul(one_pid_str, &endptr, 10);
>                 if ((v == 0 && errno == EINVAL)
> -                               || (v == ULONG_MAX && errno == ERANGE)) {
> +                               || (v == ULONG_MAX && errno == ERANGE)
> +                               || (*one_pid_str != '\0' && *endptr !=
> '\0')){
>                         ERR("Error parsing PID %s", one_pid_str);
>                         retval = CMD_ERROR;
>                         goto error;
>                 }
> +
>                 if ((long) v > INT_MAX || (int) v < 0) {
>                         ERR("Invalid PID value %ld", (long) v);
>                         retval = CMD_ERROR;
> --
> 2.1.4
>
>


-- 
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com

[-- Attachment #1.2: Type: text/html, Size: 2931 bytes --]

[-- Attachment #2: Type: text/plain, Size: 155 bytes --]

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev