[meta-multimedia][PATCH 1/3] VLC: depends on gst-plugins-bad only if gst is enabled

[meta-multimedia][PATCH 1/3] VLC: depends on gst-plugins-bad only if gst is enabled

[Rafaël Carré]

---
 meta-multimedia/recipes-multimedia/vlc/vlc.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta-multimedia/recipes-multimedia/vlc/vlc.inc b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
index ee90ac8..b989849 100644
--- a/meta-multimedia/recipes-multimedia/vlc/vlc.inc
+++ b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
@@ -5,7 +5,7 @@ SECTION = "multimedia"
 LICENSE = "GPL-2.0"
 LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 
-DEPENDS = "libfribidi libtool libgcrypt libgcrypt-native gst-plugins-bad \
+DEPENDS = "libfribidi libtool libgcrypt libgcrypt-native \
    virtual/libsdl libsdl-image dbus dbus-glib libxml2 gnutls \
    tremor faad2 ffmpeg flac libxpm libxinerama fluidsynth alsa-lib \
    libdvdcss libdvdread lua-native lua libidn libnotify gtk+ gnome-vfs \
@@ -54,7 +54,7 @@ PACKAGECONFIG[postproc] = "--enable-postproc,--disable-postproc,libpostproc"
 PACKAGECONFIG[opencv] = "--enable-opencv,--disable-opencv,opencv"
 PACKAGECONFIG[libva] = "--enable-libva --enable-avcodec,--disable-libva --disable-avcodec,libva libav"
 PACKAGECONFIG[speex] = "--enable-speex,--disable-speex,speex"
-PACKAGECONFIG[gstreamer] = "--enable-gst-decode,--disable-gst-decode,gstreamer1.0 gstreamer1.0-plugins-base"
+PACKAGECONFIG[gstreamer] = "--enable-gst-decode,--disable-gst-decode,gstreamer1.0 gstreamer1.0-plugins-base gst-plugins-bad"
 PACKAGECONFIG[vpx] = "--enable-vpx,--disable-vpx, libvpx"
 PACKAGECONFIG[qt4] = "--enable-qt,--disable-qt, qt4-x11-free"
 PACKAGECONFIG[freerdp] = "--enable-freerdp,--disable-freerdp, freerdp"
-- 
2.5.0

[meta-multimedia][PATCH 2/3] VLC: make libnotify a configurable dependency

[Rafaël Carré]

---
 meta-multimedia/recipes-multimedia/vlc/vlc.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta-multimedia/recipes-multimedia/vlc/vlc.inc b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
index b989849..ad5c81d 100644
--- a/meta-multimedia/recipes-multimedia/vlc/vlc.inc
+++ b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
@@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 DEPENDS = "libfribidi libtool libgcrypt libgcrypt-native \
    virtual/libsdl libsdl-image dbus dbus-glib libxml2 gnutls \
    tremor faad2 ffmpeg flac libxpm libxinerama fluidsynth alsa-lib \
-   libdvdcss libdvdread lua-native lua libidn libnotify gtk+ gnome-vfs \
+   libdvdcss libdvdread lua-native lua libidn gnome-vfs \
    libdc1394 libraw1394 avahi libjpeg-turbo xz libmodplug mpeg2dec \
    libmtp libopus orc libsamplerate0 libusb1 schroedinger taglib \
    tiff xcb-util-keysyms samba"
@@ -58,6 +58,7 @@ PACKAGECONFIG[gstreamer] = "--enable-gst-decode,--disable-gst-decode,gstreamer1.
 PACKAGECONFIG[vpx] = "--enable-vpx,--disable-vpx, libvpx"
 PACKAGECONFIG[qt4] = "--enable-qt,--disable-qt, qt4-x11-free"
 PACKAGECONFIG[freerdp] = "--enable-freerdp,--disable-freerdp, freerdp"
+PACKAGECONFIG[notify] = "--enable-notify,--disable-notify, libnotify gtk+"
 
 do_configure_prepend() {
     cp ${STAGING_DATADIR}/libtool/config.* ${S}/autotools/ || true
-- 
2.5.0

[meta-multimedia][PATCH 3/3] VLC: drop gnome-vfs, it will be removed from upstream in VLC 3.0

[Rafaël Carré]

---
 meta-multimedia/recipes-multimedia/vlc/vlc.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-multimedia/recipes-multimedia/vlc/vlc.inc b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
index ad5c81d..dddbb5b 100644
--- a/meta-multimedia/recipes-multimedia/vlc/vlc.inc
+++ b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
@@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 DEPENDS = "libfribidi libtool libgcrypt libgcrypt-native \
    virtual/libsdl libsdl-image dbus dbus-glib libxml2 gnutls \
    tremor faad2 ffmpeg flac libxpm libxinerama fluidsynth alsa-lib \
-   libdvdcss libdvdread lua-native lua libidn gnome-vfs \
+   libdvdcss libdvdread lua-native lua libidn \
    libdc1394 libraw1394 avahi libjpeg-turbo xz libmodplug mpeg2dec \
    libmtp libopus orc libsamplerate0 libusb1 schroedinger taglib \
    tiff xcb-util-keysyms samba"
-- 
2.5.0

Re: [meta-multimedia][PATCH 3/3] VLC: drop gnome-vfs, it will be removed from upstream in VLC 3.0

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1440 bytes --]

On Wed, Nov 04, 2015 at 05:03:19PM +0100, Rafaël Carré wrote:
> ---

Is it still used in 2.2.1 version? we aren't using 3.0 yet:

./meta-multimedia/recipes-multimedia/vlc/vlc_2.2.1.bb

>  meta-multimedia/recipes-multimedia/vlc/vlc.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-multimedia/recipes-multimedia/vlc/vlc.inc b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
> index ad5c81d..dddbb5b 100644
> --- a/meta-multimedia/recipes-multimedia/vlc/vlc.inc
> +++ b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
> @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
>  DEPENDS = "libfribidi libtool libgcrypt libgcrypt-native \
>     virtual/libsdl libsdl-image dbus dbus-glib libxml2 gnutls \
>     tremor faad2 ffmpeg flac libxpm libxinerama fluidsynth alsa-lib \
> -   libdvdcss libdvdread lua-native lua libidn gnome-vfs \
> +   libdvdcss libdvdread lua-native lua libidn \
>     libdc1394 libraw1394 avahi libjpeg-turbo xz libmodplug mpeg2dec \
>     libmtp libopus orc libsamplerate0 libusb1 schroedinger taglib \
>     tiff xcb-util-keysyms samba"
> -- 
> 2.5.0
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [meta-multimedia][PATCH 3/3] VLC: drop gnome-vfs, it will be removed from upstream in VLC 3.0

[Rafaël Carré]

Hello,

On 04/11/2015 23:25, Martin Jansa wrote:
> On Wed, Nov 04, 2015 at 05:03:19PM +0100, Rafaël Carré wrote:
>> ---
> 
> Is it still used in 2.2.1 version? we aren't using 3.0 yet:

Yes, that module is still present in 2.2 (2.2.1 and future 2.2.X versions).

I'm testing the waters here, as I couldn't build gnome-vfs, and since
that module
is being removed from upstream (again, in future 3.0 version but not
2.2.X), I
didn't bother to add a PACKAGECONFIG knob for it.

With this patch the gnome-vfs module will still if gnome-vfs is present,
although it will not load at runtime if gnome-vfs is not installed (without
preventing the rest of VLC to work properly).

It would be in the same position than the libarchive, dvdnav, samba,
ssh2 modules, etc
which coincidentally implement the capabilities that the deprecated (in
gnome) gnome-vfs
provides :)

So this simple patch fixes my build failure and at the same time reduces
future work for when
VLC 3.0 will be released.


What do you think?


Thanks for the feedback

>>  meta-multimedia/recipes-multimedia/vlc/vlc.inc | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta-multimedia/recipes-multimedia/vlc/vlc.inc b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
>> index ad5c81d..dddbb5b 100644
>> --- a/meta-multimedia/recipes-multimedia/vlc/vlc.inc
>> +++ b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
>> @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
>>  DEPENDS = "libfribidi libtool libgcrypt libgcrypt-native \
>>     virtual/libsdl libsdl-image dbus dbus-glib libxml2 gnutls \
>>     tremor faad2 ffmpeg flac libxpm libxinerama fluidsynth alsa-lib \
>> -   libdvdcss libdvdread lua-native lua libidn gnome-vfs \
>> +   libdvdcss libdvdread lua-native lua libidn \
>>     libdc1394 libraw1394 avahi libjpeg-turbo xz libmodplug mpeg2dec \
>>     libmtp libopus orc libsamplerate0 libusb1 schroedinger taglib \
>>     tiff xcb-util-keysyms samba"

Re: [meta-multimedia][PATCH 3/3] VLC: drop gnome-vfs, it will be removed from upstream in VLC 3.0

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 3083 bytes --]

On Thu, Nov 05, 2015 at 11:59:14AM +0100, Rafaël Carré wrote:
> Hello,
> 
> On 04/11/2015 23:25, Martin Jansa wrote:
> > On Wed, Nov 04, 2015 at 05:03:19PM +0100, Rafaël Carré wrote:
> >> ---
> > 
> > Is it still used in 2.2.1 version? we aren't using 3.0 yet:
> 
> Yes, that module is still present in 2.2 (2.2.1 and future 2.2.X versions).
> 
> I'm testing the waters here, as I couldn't build gnome-vfs, and since
> that module
> is being removed from upstream (again, in future 3.0 version but not
> 2.2.X), I
> didn't bother to add a PACKAGECONFIG knob for it.
> 
> With this patch the gnome-vfs module will still if gnome-vfs is present,
> although it will not load at runtime if gnome-vfs is not installed (without
> preventing the rest of VLC to work properly).
> 
> It would be in the same position than the libarchive, dvdnav, samba,
> ssh2 modules, etc
> which coincidentally implement the capabilities that the deprecated (in
> gnome) gnome-vfs
> provides :)
> 
> So this simple patch fixes my build failure and at the same time reduces
> future work for when
> VLC 3.0 will be released.
> 
> 
> What do you think?

NAK it's not acceptable to make gnome-vfs support undeterministic in
2.2.x just because some future 3.0 recipe won't use it.

We already have too many autodetected dependencies again, last bunch
added by new 1394 recipes in meta-multimedia:
vlc-2.2.1: vlc rdepends on libavc1394, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on libdvdnav, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on libupnp, but it isn't a build dependency? [build-deps]

Add PACKAGECONFIG for it please and to get bonus points add
PACKAGECONFIG for deps from QA issues above.

> Thanks for the feedback
> 
> >>  meta-multimedia/recipes-multimedia/vlc/vlc.inc | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/meta-multimedia/recipes-multimedia/vlc/vlc.inc b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
> >> index ad5c81d..dddbb5b 100644
> >> --- a/meta-multimedia/recipes-multimedia/vlc/vlc.inc
> >> +++ b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
> >> @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> >>  DEPENDS = "libfribidi libtool libgcrypt libgcrypt-native \
> >>     virtual/libsdl libsdl-image dbus dbus-glib libxml2 gnutls \
> >>     tremor faad2 ffmpeg flac libxpm libxinerama fluidsynth alsa-lib \
> >> -   libdvdcss libdvdread lua-native lua libidn gnome-vfs \
> >> +   libdvdcss libdvdread lua-native lua libidn \
> >>     libdc1394 libraw1394 avahi libjpeg-turbo xz libmodplug mpeg2dec \
> >>     libmtp libopus orc libsamplerate0 libusb1 schroedinger taglib \
> >>     tiff xcb-util-keysyms samba"
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [meta-multimedia][PATCH 3/3] VLC: drop gnome-vfs, it will be removed from upstream in VLC 3.0

[Rafaël Carré]

On 05/11/2015 12:16, Martin Jansa wrote:
> On Thu, Nov 05, 2015 at 11:59:14AM +0100, Rafaël Carré wrote:
>> Hello,
>>
>> On 04/11/2015 23:25, Martin Jansa wrote:
>>> On Wed, Nov 04, 2015 at 05:03:19PM +0100, Rafaël Carré wrote:
>>>> ---
>>>
>>> Is it still used in 2.2.1 version? we aren't using 3.0 yet:
>>
>> Yes, that module is still present in 2.2 (2.2.1 and future 2.2.X versions).


>> What do you think?
> 
> NAK it's not acceptable to make gnome-vfs support undeterministic in
> 2.2.x just because some future 3.0 recipe won't use it.

Ok

> We already have too many autodetected dependencies again, last bunch
> added by new 1394 recipes in meta-multimedia:
> vlc-2.2.1: vlc rdepends on libavc1394, but it isn't a build dependency? [build-deps]
> vlc-2.2.1: vlc rdepends on libdvdnav, but it isn't a build dependency? [build-deps]
> vlc-2.2.1: vlc rdepends on libupnp, but it isn't a build dependency? [build-deps]
> 
> Add PACKAGECONFIG for it please and to get bonus points add

Done

> PACKAGECONFIG for deps from QA issues above.

I will take a deeper look as there are more than just those

>> Thanks for the feedback
>>
>>>>  meta-multimedia/recipes-multimedia/vlc/vlc.inc | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/meta-multimedia/recipes-multimedia/vlc/vlc.inc b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
>>>> index ad5c81d..dddbb5b 100644
>>>> --- a/meta-multimedia/recipes-multimedia/vlc/vlc.inc
>>>> +++ b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
>>>> @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
>>>>  DEPENDS = "libfribidi libtool libgcrypt libgcrypt-native \
>>>>     virtual/libsdl libsdl-image dbus dbus-glib libxml2 gnutls \
>>>>     tremor faad2 ffmpeg flac libxpm libxinerama fluidsynth alsa-lib \
>>>> -   libdvdcss libdvdread lua-native lua libidn gnome-vfs \
>>>> +   libdvdcss libdvdread lua-native lua libidn \
>>>>     libdc1394 libraw1394 avahi libjpeg-turbo xz libmodplug mpeg2dec \
>>>>     libmtp libopus orc libsamplerate0 libusb1 schroedinger taglib \
>>>>     tiff xcb-util-keysyms samba"

Re: [meta-multimedia][PATCH 2/3] VLC: make libnotify a configurable dependency

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 3297 bytes --]

On Wed, Nov 04, 2015 at 05:03:18PM +0100, Rafaël Carré wrote:
> ---
>  meta-multimedia/recipes-multimedia/vlc/vlc.inc | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-multimedia/recipes-multimedia/vlc/vlc.inc b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
> index b989849..ad5c81d 100644
> --- a/meta-multimedia/recipes-multimedia/vlc/vlc.inc
> +++ b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
> @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
>  DEPENDS = "libfribidi libtool libgcrypt libgcrypt-native \
>     virtual/libsdl libsdl-image dbus dbus-glib libxml2 gnutls \
>     tremor faad2 ffmpeg flac libxpm libxinerama fluidsynth alsa-lib \
> -   libdvdcss libdvdread lua-native lua libidn libnotify gtk+ gnome-vfs \
> +   libdvdcss libdvdread lua-native lua libidn gnome-vfs \
>     libdc1394 libraw1394 avahi libjpeg-turbo xz libmodplug mpeg2dec \
>     libmtp libopus orc libsamplerate0 libusb1 schroedinger taglib \
>     tiff xcb-util-keysyms samba"
> @@ -58,6 +58,7 @@ PACKAGECONFIG[gstreamer] = "--enable-gst-decode,--disable-gst-decode,gstreamer1.
>  PACKAGECONFIG[vpx] = "--enable-vpx,--disable-vpx, libvpx"
>  PACKAGECONFIG[qt4] = "--enable-qt,--disable-qt, qt4-x11-free"
>  PACKAGECONFIG[freerdp] = "--enable-freerdp,--disable-freerdp, freerdp"
> +PACKAGECONFIG[notify] = "--enable-notify,--disable-notify, libnotify gtk+"

Removing gtk+ from DEPENDS causes even more undeterministic
dependencies:

vlc-2.2.1: vlc: configure was passed unrecognised options:
--disable-gnome-vfs [unknown-configure-option]
vlc-2.2.1: vlc rdepends on fontconfig, but it isn't a build dependency?
[build-deps]
vlc-2.2.1: vlc rdepends on pixman, but it isn't a build dependency?
[build-deps]
vlc-2.2.1: vlc rdepends on freetype, but it isn't a build dependency?
[build-deps]
vlc-2.2.1: vlc rdepends on libupnp, but it isn't a build dependency?
[build-deps]
vlc-2.2.1: vlc rdepends on pango, but it isn't a build dependency?
[build-deps]
vlc-2.2.1: vlc rdepends on libvorbis, but it isn't a build dependency?
[build-deps]
vlc-2.2.1: vlc rdepends on cairo, but it isn't a build dependency?
[build-deps]
vlc-2.2.1: vlc rdepends on libavc1394, but it isn't a build dependency?
[build-deps]
vlc-2.2.1: vlc rdepends on harfbuzz, but it isn't a build dependency?
[build-deps]
vlc-2.2.1: vlc rdepends on libssh2, but it isn't a build dependency?
[build-deps]
vlc-2.2.1: vlc rdepends on gdk-pixbuf, but it isn't a build dependency?
[build-deps]
vlc-2.2.1: vlc rdepends on gnome-vfs, but it isn't a build dependency?
[build-deps]
vlc-2.2.1: vlc rdepends on libcroco, but it isn't a build dependency?
[build-deps]
vlc-2.2.1: vlc rdepends on libdvdnav, but it isn't a build dependency?
[build-deps]
vlc-2.2.1: vlc rdepends on librsvg, but it isn't a build dependency?
[build-deps]

>  
>  do_configure_prepend() {
>      cp ${STAGING_DATADIR}/libtool/config.* ${S}/autotools/ || true
> -- 
> 2.5.0
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [meta-multimedia][PATCH 2/3] VLC: make libnotify a configurable dependency

[Rafaël Carré]

On 05/11/2015 21:17, Martin Jansa wrote:
> On Wed, Nov 04, 2015 at 05:03:18PM +0100, Rafaël Carré wrote:
>> ---
>>  meta-multimedia/recipes-multimedia/vlc/vlc.inc | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta-multimedia/recipes-multimedia/vlc/vlc.inc b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
>> index b989849..ad5c81d 100644
>> --- a/meta-multimedia/recipes-multimedia/vlc/vlc.inc
>> +++ b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
>> @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
>>  DEPENDS = "libfribidi libtool libgcrypt libgcrypt-native \
>>     virtual/libsdl libsdl-image dbus dbus-glib libxml2 gnutls \
>>     tremor faad2 ffmpeg flac libxpm libxinerama fluidsynth alsa-lib \
>> -   libdvdcss libdvdread lua-native lua libidn libnotify gtk+ gnome-vfs \
>> +   libdvdcss libdvdread lua-native lua libidn gnome-vfs \
>>     libdc1394 libraw1394 avahi libjpeg-turbo xz libmodplug mpeg2dec \
>>     libmtp libopus orc libsamplerate0 libusb1 schroedinger taglib \
>>     tiff xcb-util-keysyms samba"
>> @@ -58,6 +58,7 @@ PACKAGECONFIG[gstreamer] = "--enable-gst-decode,--disable-gst-decode,gstreamer1.
>>  PACKAGECONFIG[vpx] = "--enable-vpx,--disable-vpx, libvpx"
>>  PACKAGECONFIG[qt4] = "--enable-qt,--disable-qt, qt4-x11-free"
>>  PACKAGECONFIG[freerdp] = "--enable-freerdp,--disable-freerdp, freerdp"
>> +PACKAGECONFIG[notify] = "--enable-notify,--disable-notify, libnotify gtk+"
> 
> Removing gtk+ from DEPENDS causes even more undeterministic
> dependencies:

I would guess those real dependencies were hidden by gtk+ which depends on
every single one of them.

Except maybe vorbis which was hidden by gstreamer plugins?

I agree that although depending on gtk+ is not fully nice neither
correct, it makes
things deterministic.


So I guess I should rather add all the PACKAGECONFIG for these modules
first and then move
those dependencies to their respective PACKAGECONFIG ?


How is your jenkins instance built: world first, then VLC ?

Should I check for additional automatic dependencies inside VLC or
assume that
the list below is exhaustive?

> vlc-2.2.1: vlc: configure was passed unrecognised options:
> --disable-gnome-vfs [unknown-configure-option]
> vlc-2.2.1: vlc rdepends on fontconfig, but it isn't a build dependency?
> [build-deps]
> vlc-2.2.1: vlc rdepends on pixman, but it isn't a build dependency?
> [build-deps]
> vlc-2.2.1: vlc rdepends on freetype, but it isn't a build dependency?
> [build-deps]
> vlc-2.2.1: vlc rdepends on libupnp, but it isn't a build dependency?
> [build-deps]
> vlc-2.2.1: vlc rdepends on pango, but it isn't a build dependency?
> [build-deps]
> vlc-2.2.1: vlc rdepends on libvorbis, but it isn't a build dependency?
> [build-deps]
> vlc-2.2.1: vlc rdepends on cairo, but it isn't a build dependency?
> [build-deps]
> vlc-2.2.1: vlc rdepends on libavc1394, but it isn't a build dependency?
> [build-deps]
> vlc-2.2.1: vlc rdepends on harfbuzz, but it isn't a build dependency?
> [build-deps]
> vlc-2.2.1: vlc rdepends on libssh2, but it isn't a build dependency?
> [build-deps]
> vlc-2.2.1: vlc rdepends on gdk-pixbuf, but it isn't a build dependency?
> [build-deps]
> vlc-2.2.1: vlc rdepends on gnome-vfs, but it isn't a build dependency?
> [build-deps]
> vlc-2.2.1: vlc rdepends on libcroco, but it isn't a build dependency?
> [build-deps]
> vlc-2.2.1: vlc rdepends on libdvdnav, but it isn't a build dependency?
> [build-deps]
> vlc-2.2.1: vlc rdepends on librsvg, but it isn't a build dependency?
> [build-deps]
> 
>>  
>>  do_configure_prepend() {
>>      cp ${STAGING_DATADIR}/libtool/config.* ${S}/autotools/ || true

Re: [meta-multimedia][PATCH 2/3] VLC: make libnotify a configurable dependency

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 4769 bytes --]

On Thu, Nov 05, 2015 at 09:42:43PM +0100, Rafaël Carré wrote:
> On 05/11/2015 21:17, Martin Jansa wrote:
> > On Wed, Nov 04, 2015 at 05:03:18PM +0100, Rafaël Carré wrote:
> >> ---
> >>  meta-multimedia/recipes-multimedia/vlc/vlc.inc | 3 ++-
> >>  1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/meta-multimedia/recipes-multimedia/vlc/vlc.inc b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
> >> index b989849..ad5c81d 100644
> >> --- a/meta-multimedia/recipes-multimedia/vlc/vlc.inc
> >> +++ b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
> >> @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> >>  DEPENDS = "libfribidi libtool libgcrypt libgcrypt-native \
> >>     virtual/libsdl libsdl-image dbus dbus-glib libxml2 gnutls \
> >>     tremor faad2 ffmpeg flac libxpm libxinerama fluidsynth alsa-lib \
> >> -   libdvdcss libdvdread lua-native lua libidn libnotify gtk+ gnome-vfs \
> >> +   libdvdcss libdvdread lua-native lua libidn gnome-vfs \
> >>     libdc1394 libraw1394 avahi libjpeg-turbo xz libmodplug mpeg2dec \
> >>     libmtp libopus orc libsamplerate0 libusb1 schroedinger taglib \
> >>     tiff xcb-util-keysyms samba"
> >> @@ -58,6 +58,7 @@ PACKAGECONFIG[gstreamer] = "--enable-gst-decode,--disable-gst-decode,gstreamer1.
> >>  PACKAGECONFIG[vpx] = "--enable-vpx,--disable-vpx, libvpx"
> >>  PACKAGECONFIG[qt4] = "--enable-qt,--disable-qt, qt4-x11-free"
> >>  PACKAGECONFIG[freerdp] = "--enable-freerdp,--disable-freerdp, freerdp"
> >> +PACKAGECONFIG[notify] = "--enable-notify,--disable-notify, libnotify gtk+"
> > 
> > Removing gtk+ from DEPENDS causes even more undeterministic
> > dependencies:
> 
> I would guess those real dependencies were hidden by gtk+ which depends on
> every single one of them.
> 
> Except maybe vorbis which was hidden by gstreamer plugins?
> 
> I agree that although depending on gtk+ is not fully nice neither
> correct, it makes
> things deterministic.
> 
> 
> So I guess I should rather add all the PACKAGECONFIG for these modules
> first and then move
> those dependencies to their respective PACKAGECONFIG ?

yes

> 
> How is your jenkins instance built: world first, then VLC ?

No, only in test-dependencies builds, this was just incremental world
build, so the list doesn't have to be complete.

> Should I check for additional automatic dependencies inside VLC or
> assume that
> the list below is exhaustive?

It will cover most (maybe all) of them, because there weren't many
changes in last increment, so it's a bit more likely that other recipes
were already reused from sstate before vlc (one of recipes with
modification) was built.

To test it properly I would need to run test-dependencies job, but that
takes too long I cannot spare now when jethro release is close.

Regards,

> > vlc-2.2.1: vlc: configure was passed unrecognised options:
> > --disable-gnome-vfs [unknown-configure-option]
> > vlc-2.2.1: vlc rdepends on fontconfig, but it isn't a build dependency?
> > [build-deps]
> > vlc-2.2.1: vlc rdepends on pixman, but it isn't a build dependency?
> > [build-deps]
> > vlc-2.2.1: vlc rdepends on freetype, but it isn't a build dependency?
> > [build-deps]
> > vlc-2.2.1: vlc rdepends on libupnp, but it isn't a build dependency?
> > [build-deps]
> > vlc-2.2.1: vlc rdepends on pango, but it isn't a build dependency?
> > [build-deps]
> > vlc-2.2.1: vlc rdepends on libvorbis, but it isn't a build dependency?
> > [build-deps]
> > vlc-2.2.1: vlc rdepends on cairo, but it isn't a build dependency?
> > [build-deps]
> > vlc-2.2.1: vlc rdepends on libavc1394, but it isn't a build dependency?
> > [build-deps]
> > vlc-2.2.1: vlc rdepends on harfbuzz, but it isn't a build dependency?
> > [build-deps]
> > vlc-2.2.1: vlc rdepends on libssh2, but it isn't a build dependency?
> > [build-deps]
> > vlc-2.2.1: vlc rdepends on gdk-pixbuf, but it isn't a build dependency?
> > [build-deps]
> > vlc-2.2.1: vlc rdepends on gnome-vfs, but it isn't a build dependency?
> > [build-deps]
> > vlc-2.2.1: vlc rdepends on libcroco, but it isn't a build dependency?
> > [build-deps]
> > vlc-2.2.1: vlc rdepends on libdvdnav, but it isn't a build dependency?
> > [build-deps]
> > vlc-2.2.1: vlc rdepends on librsvg, but it isn't a build dependency?
> > [build-deps]
> > 
> >>  
> >>  do_configure_prepend() {
> >>      cp ${STAGING_DATADIR}/libtool/config.* ${S}/autotools/ || true
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [meta-multimedia][PATCH 2/3] VLC: make libnotify a configurable dependency

[Tim Orling]

On Thu, Nov 5, 2015 at 12:57 PM, Martin Jansa <martin.jansa@gmail.com>
wrote:

> On Thu, Nov 05, 2015 at 09:42:43PM +0100, Rafaël Carré wrote:
> > On 05/11/2015 21:17, Martin Jansa wrote:
> > > On Wed, Nov 04, 2015 at 05:03:18PM +0100, Rafaël Carré wrote:
> > >> ---
> > >>  meta-multimedia/recipes-multimedia/vlc/vlc.inc | 3 ++-
> > >>  1 file changed, 2 insertions(+), 1 deletion(-)
> > >>
> > >> diff --git a/meta-multimedia/recipes-multimedia/vlc/vlc.inc
> b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
> > >> index b989849..ad5c81d 100644
> > >> --- a/meta-multimedia/recipes-multimedia/vlc/vlc.inc
> > >> +++ b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
> > >> @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM =
> "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> > >>  DEPENDS = "libfribidi libtool libgcrypt libgcrypt-native \
> > >>     virtual/libsdl libsdl-image dbus dbus-glib libxml2 gnutls \
> > >>     tremor faad2 ffmpeg flac libxpm libxinerama fluidsynth alsa-lib \
> > >> -   libdvdcss libdvdread lua-native lua libidn libnotify gtk+
> gnome-vfs \
> > >> +   libdvdcss libdvdread lua-native lua libidn gnome-vfs \
> > >>     libdc1394 libraw1394 avahi libjpeg-turbo xz libmodplug mpeg2dec \
> > >>     libmtp libopus orc libsamplerate0 libusb1 schroedinger taglib \
> > >>     tiff xcb-util-keysyms samba"
> > >> @@ -58,6 +58,7 @@ PACKAGECONFIG[gstreamer] =
> "--enable-gst-decode,--disable-gst-decode,gstreamer1.
> > >>  PACKAGECONFIG[vpx] = "--enable-vpx,--disable-vpx, libvpx"
> > >>  PACKAGECONFIG[qt4] = "--enable-qt,--disable-qt, qt4-x11-free"
> > >>  PACKAGECONFIG[freerdp] = "--enable-freerdp,--disable-freerdp,
> freerdp"
> > >> +PACKAGECONFIG[notify] = "--enable-notify,--disable-notify, libnotify
> gtk+"
> > >
> > > Removing gtk+ from DEPENDS causes even more undeterministic
> > > dependencies:
> >
> > I would guess those real dependencies were hidden by gtk+ which depends
> on
> > every single one of them.
> >
> > Except maybe vorbis which was hidden by gstreamer plugins?
> >
> > I agree that although depending on gtk+ is not fully nice neither
> > correct, it makes
> > things deterministic.
> >
> >
> > So I guess I should rather add all the PACKAGECONFIG for these modules
> > first and then move
> > those dependencies to their respective PACKAGECONFIG ?
>
> yes
>
> There are 112 AC_ARG_ENABLE clauses in configure.ac
<https://github.com/videolan/vlc/blob/master/configure.ac>... but adding
PACKAGECONFIG for those that make sense has been on my list of TODO for a
long time. Not all of them apply to our usage (winstore_app for instance).
Testing all those options is one of the things that has held me back...so
the approach of fixing what becomes broken has been the easier route.

At least there aren't a large amount of PKG_CHECK_MODULES which leads to
endless patches to make it deterministic which other upstreams have zero
interest in applying.

--Tim

Re: [meta-multimedia][PATCH 2/3] VLC: make libnotify a configurable dependency

[Rafaël Carré]

On 06/11/2015 01:07, Tim Orling wrote:
> On Thu, Nov 5, 2015 at 12:57 PM, Martin Jansa <martin.jansa@gmail.com>
> wrote:
> 
>> On Thu, Nov 05, 2015 at 09:42:43PM +0100, Rafaël Carré wrote:
>>> On 05/11/2015 21:17, Martin Jansa wrote:
>>>> On Wed, Nov 04, 2015 at 05:03:18PM +0100, Rafaël Carré wrote:
>>>>> ---
>>>>>  meta-multimedia/recipes-multimedia/vlc/vlc.inc | 3 ++-
>>>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/meta-multimedia/recipes-multimedia/vlc/vlc.inc
>> b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
>>>>> index b989849..ad5c81d 100644
>>>>> --- a/meta-multimedia/recipes-multimedia/vlc/vlc.inc
>>>>> +++ b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
>>>>> @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM =
>> "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
>>>>>  DEPENDS = "libfribidi libtool libgcrypt libgcrypt-native \
>>>>>     virtual/libsdl libsdl-image dbus dbus-glib libxml2 gnutls \
>>>>>     tremor faad2 ffmpeg flac libxpm libxinerama fluidsynth alsa-lib \
>>>>> -   libdvdcss libdvdread lua-native lua libidn libnotify gtk+
>> gnome-vfs \
>>>>> +   libdvdcss libdvdread lua-native lua libidn gnome-vfs \
>>>>>     libdc1394 libraw1394 avahi libjpeg-turbo xz libmodplug mpeg2dec \
>>>>>     libmtp libopus orc libsamplerate0 libusb1 schroedinger taglib \
>>>>>     tiff xcb-util-keysyms samba"
>>>>> @@ -58,6 +58,7 @@ PACKAGECONFIG[gstreamer] =
>> "--enable-gst-decode,--disable-gst-decode,gstreamer1.
>>>>>  PACKAGECONFIG[vpx] = "--enable-vpx,--disable-vpx, libvpx"
>>>>>  PACKAGECONFIG[qt4] = "--enable-qt,--disable-qt, qt4-x11-free"
>>>>>  PACKAGECONFIG[freerdp] = "--enable-freerdp,--disable-freerdp,
>> freerdp"
>>>>> +PACKAGECONFIG[notify] = "--enable-notify,--disable-notify, libnotify
>> gtk+"
>>>>
>>>> Removing gtk+ from DEPENDS causes even more undeterministic
>>>> dependencies:
>>>
>>> I would guess those real dependencies were hidden by gtk+ which depends
>> on
>>> every single one of them.
>>>
>>> Except maybe vorbis which was hidden by gstreamer plugins?
>>>
>>> I agree that although depending on gtk+ is not fully nice neither
>>> correct, it makes
>>> things deterministic.
>>>
>>>
>>> So I guess I should rather add all the PACKAGECONFIG for these modules
>>> first and then move
>>> those dependencies to their respective PACKAGECONFIG ?
>>
>> yes
>>
>> There are 112 AC_ARG_ENABLE clauses in configure.ac
> <https://github.com/videolan/vlc/blob/master/configure.ac>... but adding
> PACKAGECONFIG for those that make sense has been on my list of TODO for a
> long time. Not all of them apply to our usage (winstore_app for instance).
> Testing all those options is one of the things that has held me back...so
> the approach of fixing what becomes broken has been the easier route.
> 
> At least there aren't a large amount of PKG_CHECK_MODULES which leads to
> endless patches to make it deterministic which other upstreams have zero
> interest in applying.

There are a lot PKG_ENABLE_MODULES_VLC which call that macro though

> --Tim
>