[lustre-devel] [PATCH] Staging: lustre: lustre_mds: Remove unused md_should_create

[lustre-devel] [PATCH] Staging: lustre: lustre_mds: Remove unused md_should_create

[Shraddha Barke]

md_should_create has been defined in header file but not used.
Thus remove it.

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
 drivers/staging/lustre/lustre/include/lustre_mds.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/staging/lustre/lustre/include/lustre_mds.h b/drivers/staging/lustre/lustre/include/lustre_mds.h
index a16eb8b..95d27dd 100644
--- a/drivers/staging/lustre/lustre/include/lustre_mds.h
+++ b/drivers/staging/lustre/lustre/include/lustre_mds.h
@@ -62,12 +62,6 @@ struct mds_group_info {
 #define MDD_OBD_NAME     "mdd_obd"
 #define MDD_OBD_UUID     "mdd_obd_uuid"
 
-static inline int md_should_create(__u64 flags)
-{
-       return !(flags & MDS_OPEN_DELAY_CREATE ||
-	       !(flags & FMODE_WRITE));
-}
-
 /* these are local flags, used only on the client, private */
 #define M_CHECK_STALE	   0200000000
 
-- 
2.1.4

[lustre-devel] [PATCH] Staging: lustre: lustre_mds: Remove unused md_should_create

[Simmons, James A.]

>From: lustre-devel [mailto:lustre-devel-bounces at lists.lustre.org] On Behalf Of Shraddha Barke
>Sent: Saturday, November 07, 2015 4:44 AM
>To: Greg Kroah-Hartman; lustre-devel at lists.lustre.org
>Subject: [lustre-devel] [PATCH] Staging: lustre: lustre_mds: Remove unused md_should_create
>
>md_should_create has been defined in header file but not used.
>Thus remove it.
>
>Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
>---
> drivers/staging/lustre/lustre/include/lustre_mds.h | 6 ------>
 >1 file changed, 6 deletions(-)

Lustre_mds.h is one of those dysfunctional headers used by client and server code. With the porting
of some patches and a little rearranging this file could go away.  I'm working out a plan for the pushing
of the patches and should have it ready in a few days. Basically a lot of work went into cleaning up
the CLIO client code since the performance was really bad from all the abstraction. You can read 
about it at https://jira.hpdd.intel.com/browse/LU-5880. That work needs very badly merged to  the
upstream client. 

[lustre-devel] [PATCH] Staging: lustre: lustre_mds: Remove unused md_should_create

[Shraddha Barke]

On Tue, 10 Nov 2015, Simmons, James A. wrote:

>> From: lustre-devel [mailto:lustre-devel-bounces at lists.lustre.org] On Behalf Of Shraddha Barke
>> Sent: Saturday, November 07, 2015 4:44 AM
>> To: Greg Kroah-Hartman; lustre-devel at lists.lustre.org
>> Subject: [lustre-devel] [PATCH] Staging: lustre: lustre_mds: Remove unused md_should_create
>>
>> md_should_create has been defined in header file but not used.
>> Thus remove it.
>>
>> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
>> ---
>> drivers/staging/lustre/lustre/include/lustre_mds.h | 6 ------>
> >1 file changed, 6 deletions(-)
>
> Lustre_mds.h is one of those dysfunctional headers used by client and server code. With the porting
> of some patches and a little rearranging this file could go away.  I'm working out a plan for the pushing
> of the patches and should have it ready in a few days. Basically a lot of work went into cleaning up
> the CLIO client code since the performance was really bad from all the abstraction. You can read
> about it at https://jira.hpdd.intel.com/browse/LU-5880. That work needs very badly merged to  the
> upstream client.

Yes, I'll work on this and send patches.

Kind Regards,

Shraddha
>
>