All of lore.kernel.org
 help / color / mirror / Atom feed
From: Irina Tirdea <irina.tirdea@intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Bastien Nocera <hadess@hadess.net>,
	Aleksei Mamlin <mamlinav@gmail.com>,
	Karsten Merker <merker@debian.org>,
	linux-input@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Octavian Purdila <octavian.purdila@intel.com>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Irina Tirdea <irina.tirdea@intel.com>
Subject: [PATCH v11 5/8] Input: goodix - use goodix_i2c_write_u8 instead of i2c_master_send
Date: Thu, 19 Nov 2015 14:26:38 +0200	[thread overview]
Message-ID: <1447936001-21420-6-git-send-email-irina.tirdea@intel.com> (raw)
In-Reply-To: <1447936001-21420-1-git-send-email-irina.tirdea@intel.com>

Use goodix_i2c_write_u8 instead of i2c_master_send to simplify code.

Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
Tested-by: Bastien Nocera <hadess@hadess.net>
Tested-by: Aleksei Mamlin <mamlinav@gmail.com>
---
 drivers/input/touchscreen/goodix.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
index 0fd472d..9b7f2ad 100644
--- a/drivers/input/touchscreen/goodix.c
+++ b/drivers/input/touchscreen/goodix.c
@@ -275,16 +275,11 @@ static void goodix_process_events(struct goodix_ts_data *ts)
  */
 static irqreturn_t goodix_ts_irq_handler(int irq, void *dev_id)
 {
-	static const u8 end_cmd[] = {
-		GOODIX_READ_COOR_ADDR >> 8,
-		GOODIX_READ_COOR_ADDR & 0xff,
-		0
-	};
 	struct goodix_ts_data *ts = dev_id;
 
 	goodix_process_events(ts);
 
-	if (i2c_master_send(ts->client, end_cmd, sizeof(end_cmd)) < 0)
+	if (goodix_i2c_write_u8(ts->client, GOODIX_READ_COOR_ADDR, 0) < 0)
 		dev_err(&ts->client->dev, "I2C write end_cmd error\n");
 
 	return IRQ_HANDLED;
-- 
1.9.1


  parent reply	other threads:[~2015-11-19 12:28 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-19 12:26 [PATCH v11 0/8] Goodix touchscreen enhancements Irina Tirdea
2015-11-19 12:26 ` [PATCH v11 1/8] Input: goodix - use actual config length for each device type Irina Tirdea
2015-11-19 12:26 ` [PATCH v11 2/8] Input: goodix - reset device at init Irina Tirdea
2015-11-19 15:25   ` Bastien Nocera
2015-11-19 15:36     ` Tirdea, Irina
2015-11-19 15:36       ` Tirdea, Irina
2015-11-20 15:41   ` Rob Herring
2015-11-23 16:31   ` Bastien Nocera
2015-12-08 12:04   ` Aleksei Mamlin
2015-12-08 12:04     ` Aleksei Mamlin
2015-11-19 12:26 ` [PATCH v11 3/8] Input: goodix - write configuration data to device Irina Tirdea
2015-11-19 18:20   ` Dmitry Torokhov
2015-11-20 13:13     ` Tirdea, Irina
2015-11-23 16:32   ` Bastien Nocera
2015-12-08 12:09   ` Aleksei Mamlin
2015-11-19 12:26 ` [PATCH v11 4/8] Input: goodix - add power management support Irina Tirdea
2015-11-19 18:24   ` Dmitry Torokhov
2015-11-19 18:24     ` Dmitry Torokhov
2015-11-19 22:18     ` Rafael J. Wysocki
2015-11-19 22:31       ` Dmitry Torokhov
2015-11-23 16:33   ` Bastien Nocera
2015-11-19 12:26 ` Irina Tirdea [this message]
2015-11-19 12:26 ` [PATCH v11 6/8] Input: goodix - add support for ESD Irina Tirdea
2015-11-20 15:44   ` Rob Herring
2015-11-20 15:44     ` Rob Herring
2015-11-20 17:20     ` Dmitry Torokhov
2015-11-20 17:20       ` Dmitry Torokhov
2015-11-27 17:24     ` Tirdea, Irina
2015-11-27 17:28       ` Dmitry Torokhov
2015-11-27 17:28         ` Dmitry Torokhov
2015-11-23 16:33   ` Bastien Nocera
2015-11-19 12:26 ` [PATCH v11 7/8] Input: goodix - add sysfs interface to dump config Irina Tirdea
2015-11-19 12:26 ` [PATCH v11 8/8] Input: goodix - add runtime power management support Irina Tirdea
2015-11-23 16:35   ` Bastien Nocera
2015-12-18  1:13 ` [PATCH v11 0/8] Goodix touchscreen enhancements Dmitry Torokhov
2016-01-05 20:03   ` Karsten Merker
2016-01-05 22:07     ` Dmitry Torokhov
2016-01-06  7:00       ` Karsten Merker
2016-01-06 19:08         ` Karsten Merker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447936001-21420-6-git-send-email-irina.tirdea@intel.com \
    --to=irina.tirdea@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hadess@hadess.net \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mamlinav@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=merker@debian.org \
    --cc=octavian.purdila@intel.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.