From: "Tirdea, Irina" <irina.tirdea@intel.com> To: Bastien Nocera <hadess@hadess.net>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Aleksei Mamlin <mamlinav@gmail.com>, "Karsten Merker" <merker@debian.org>, "linux-input@vger.kernel.org" <linux-input@vger.kernel.org> Cc: Mark Rutland <mark.rutland@arm.com>, Rob Herring <robh+dt@kernel.org>, "Purdila, Octavian" <octavian.purdila@intel.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org> Subject: RE: [PATCH v11 2/8] Input: goodix - reset device at init Date: Thu, 19 Nov 2015 15:36:12 +0000 [thread overview] Message-ID: <1F3AC3675D538145B1661F571FE1805F2F11F7FD@irsmsx105.ger.corp.intel.com> (raw) In-Reply-To: <1447946703.24088.73.camel@hadess.net> [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1656 bytes --] > -----Original Message----- > From: Bastien Nocera [mailto:hadess@hadess.net] > Sent: 19 November, 2015 17:25 > To: Tirdea, Irina; Dmitry Torokhov; Aleksei Mamlin; Karsten Merker; linux-input@vger.kernel.org > Cc: Mark Rutland; Rob Herring; Purdila, Octavian; linux-kernel@vger.kernel.org; devicetree@vger.kernel.org > Subject: Re: [PATCH v11 2/8] Input: goodix - reset device at init > > On Thu, 2015-11-19 at 14:26 +0200, Irina Tirdea wrote: > > After power on, it is recommended that the driver resets the device. > > The reset procedure timing is described in the datasheet and is used > > at device init (before writing device configuration) and > > for power management. It is a sequence of setting the interrupt > > and reset pins high/low at specific timing intervals. This procedure > > also includes setting the slave address to the one specified in the > > ACPI/device tree. > > This fails on a 4.3 kernel with an ACPI device (WinBook TW100): > Goodix-TS: probe of i2c-GDIX1001:00 failed with error -16 > > Can you please document which upstream commit is necessary to make this > behave properly? > You need the patch that fixes the GPIO API [1] so that devm_gpiod_get_optional works properly (I mentioned that in the cover letter). This patch just got merged in the gpio tree, so it will take a while until it will be merged in the main kernel tree or input tree. Thanks, Irina [1] https://lkml.org/lkml/2015/11/11/465 > I'll test again with a newer kernel. > > Cheers ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
WARNING: multiple messages have this Message-ID (diff)
From: "Tirdea, Irina" <irina.tirdea-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> To: Bastien Nocera <hadess-0MeiytkfxGOsTnJN9+BGXg@public.gmane.org>, Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Karsten Merker <merker-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>, "linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, "Purdila, Octavian" <octavian.purdila-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: RE: [PATCH v11 2/8] Input: goodix - reset device at init Date: Thu, 19 Nov 2015 15:36:12 +0000 [thread overview] Message-ID: <1F3AC3675D538145B1661F571FE1805F2F11F7FD@irsmsx105.ger.corp.intel.com> (raw) In-Reply-To: <1447946703.24088.73.camel-0MeiytkfxGOsTnJN9+BGXg@public.gmane.org> > -----Original Message----- > From: Bastien Nocera [mailto:hadess@hadess.net] > Sent: 19 November, 2015 17:25 > To: Tirdea, Irina; Dmitry Torokhov; Aleksei Mamlin; Karsten Merker; linux-input@vger.kernel.org > Cc: Mark Rutland; Rob Herring; Purdila, Octavian; linux-kernel@vger.kernel.org; devicetree@vger.kernel.org > Subject: Re: [PATCH v11 2/8] Input: goodix - reset device at init > > On Thu, 2015-11-19 at 14:26 +0200, Irina Tirdea wrote: > > After power on, it is recommended that the driver resets the device. > > The reset procedure timing is described in the datasheet and is used > > at device init (before writing device configuration) and > > for power management. It is a sequence of setting the interrupt > > and reset pins high/low at specific timing intervals. This procedure > > also includes setting the slave address to the one specified in the > > ACPI/device tree. > > This fails on a 4.3 kernel with an ACPI device (WinBook TW100): > Goodix-TS: probe of i2c-GDIX1001:00 failed with error -16 > > Can you please document which upstream commit is necessary to make this > behave properly? > You need the patch that fixes the GPIO API [1] so that devm_gpiod_get_optional works properly (I mentioned that in the cover letter). This patch just got merged in the gpio tree, so it will take a while until it will be merged in the main kernel tree or input tree. Thanks, Irina [1] https://lkml.org/lkml/2015/11/11/465 > I'll test again with a newer kernel. > > Cheers
next prev parent reply other threads:[~2015-11-19 15:36 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-11-19 12:26 [PATCH v11 0/8] Goodix touchscreen enhancements Irina Tirdea 2015-11-19 12:26 ` [PATCH v11 1/8] Input: goodix - use actual config length for each device type Irina Tirdea 2015-11-19 12:26 ` [PATCH v11 2/8] Input: goodix - reset device at init Irina Tirdea 2015-11-19 15:25 ` Bastien Nocera 2015-11-19 15:36 ` Tirdea, Irina [this message] 2015-11-19 15:36 ` Tirdea, Irina 2015-11-20 15:41 ` Rob Herring 2015-11-23 16:31 ` Bastien Nocera 2015-12-08 12:04 ` Aleksei Mamlin 2015-12-08 12:04 ` Aleksei Mamlin 2015-11-19 12:26 ` [PATCH v11 3/8] Input: goodix - write configuration data to device Irina Tirdea 2015-11-19 18:20 ` Dmitry Torokhov 2015-11-20 13:13 ` Tirdea, Irina 2015-11-23 16:32 ` Bastien Nocera 2015-12-08 12:09 ` Aleksei Mamlin 2015-11-19 12:26 ` [PATCH v11 4/8] Input: goodix - add power management support Irina Tirdea 2015-11-19 18:24 ` Dmitry Torokhov 2015-11-19 18:24 ` Dmitry Torokhov 2015-11-19 22:18 ` Rafael J. Wysocki 2015-11-19 22:31 ` Dmitry Torokhov 2015-11-23 16:33 ` Bastien Nocera 2015-11-19 12:26 ` [PATCH v11 5/8] Input: goodix - use goodix_i2c_write_u8 instead of i2c_master_send Irina Tirdea 2015-11-19 12:26 ` [PATCH v11 6/8] Input: goodix - add support for ESD Irina Tirdea 2015-11-20 15:44 ` Rob Herring 2015-11-20 15:44 ` Rob Herring 2015-11-20 17:20 ` Dmitry Torokhov 2015-11-20 17:20 ` Dmitry Torokhov 2015-11-27 17:24 ` Tirdea, Irina 2015-11-27 17:28 ` Dmitry Torokhov 2015-11-27 17:28 ` Dmitry Torokhov 2015-11-23 16:33 ` Bastien Nocera 2015-11-19 12:26 ` [PATCH v11 7/8] Input: goodix - add sysfs interface to dump config Irina Tirdea 2015-11-19 12:26 ` [PATCH v11 8/8] Input: goodix - add runtime power management support Irina Tirdea 2015-11-23 16:35 ` Bastien Nocera 2015-12-18 1:13 ` [PATCH v11 0/8] Goodix touchscreen enhancements Dmitry Torokhov 2016-01-05 20:03 ` Karsten Merker 2016-01-05 22:07 ` Dmitry Torokhov 2016-01-06 7:00 ` Karsten Merker 2016-01-06 19:08 ` Karsten Merker
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1F3AC3675D538145B1661F571FE1805F2F11F7FD@irsmsx105.ger.corp.intel.com \ --to=irina.tirdea@intel.com \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.torokhov@gmail.com \ --cc=hadess@hadess.net \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mamlinav@gmail.com \ --cc=mark.rutland@arm.com \ --cc=merker@debian.org \ --cc=octavian.purdila@intel.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.