* [PATCH] xen/arm: use masking operation instead of test_bit for MCSF bits
@ 2015-11-19 12:46 Julien Grall
2015-11-24 16:51 ` Ian Campbell
0 siblings, 1 reply; 2+ messages in thread
From: Julien Grall @ 2015-11-19 12:46 UTC (permalink / raw)
To: xen-devel; +Cc: Julien Grall, ian.campbell, stefano.stabellini
This is a follow of commit 90f2e2a307fc6a6258c39cc87b3b2bf9441c0fa7 "use
masking operation instead of test_bit for MCSF bits" where the ARM
changes were missing.
Signed-off-by: Julien Grall <julien.grall@citrix.com>
---
xen/arch/arm/domain.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 880d0a6..1b0f9eb 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -327,7 +327,7 @@ void hypercall_cancel_continuation(void)
struct cpu_user_regs *regs = guest_cpu_user_regs();
struct mc_state *mcs = ¤t->mc_state;
- if ( test_bit(_MCSF_in_multicall, &mcs->flags) )
+ if ( mcs->flags & MCSF_in_multicall )
{
__clear_bit(_MCSF_call_preempted, &mcs->flags);
}
@@ -352,7 +352,7 @@ unsigned long hypercall_create_continuation(
va_start(args, format);
- if ( test_bit(_MCSF_in_multicall, &mcs->flags) )
+ if ( mcs->flags & MCSF_in_multicall )
{
__set_bit(_MCSF_call_preempted, &mcs->flags);
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xen/arm: use masking operation instead of test_bit for MCSF bits
2015-11-19 12:46 [PATCH] xen/arm: use masking operation instead of test_bit for MCSF bits Julien Grall
@ 2015-11-24 16:51 ` Ian Campbell
0 siblings, 0 replies; 2+ messages in thread
From: Ian Campbell @ 2015-11-24 16:51 UTC (permalink / raw)
To: Julien Grall, xen-devel; +Cc: stefano.stabellini
On Thu, 2015-11-19 at 12:46 +0000, Julien Grall wrote:
> This is a follow of commit 90f2e2a307fc6a6258c39cc87b3b2bf9441c0fa7 "use
> masking operation instead of test_bit for MCSF bits" where the ARM
> changes were missing.
>
> Signed-off-by: Julien Grall <julien.grall@citrix.com>
Acked + applied.
> ---
> xen/arch/arm/domain.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 880d0a6..1b0f9eb 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -327,7 +327,7 @@ void hypercall_cancel_continuation(void)
> struct cpu_user_regs *regs = guest_cpu_user_regs();
> struct mc_state *mcs = ¤t->mc_state;
>
> - if ( test_bit(_MCSF_in_multicall, &mcs->flags) )
> + if ( mcs->flags & MCSF_in_multicall )
> {
> __clear_bit(_MCSF_call_preempted, &mcs->flags);
> }
> @@ -352,7 +352,7 @@ unsigned long hypercall_create_continuation(
>
> va_start(args, format);
>
> - if ( test_bit(_MCSF_in_multicall, &mcs->flags) )
> + if ( mcs->flags & MCSF_in_multicall )
> {
> __set_bit(_MCSF_call_preempted, &mcs->flags);
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-24 16:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-19 12:46 [PATCH] xen/arm: use masking operation instead of test_bit for MCSF bits Julien Grall
2015-11-24 16:51 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.