All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: kernel@stlinux.com, maxime.coquelin@st.com, ohad@wizery.com,
	devicetree@vger.kernel.org, Nathan_Lynch@mentor.com,
	f.fainelli@gmail.com, ludovic.barre@st.com, s-anna@ti.com,
	Lee Jones <lee.jones@linaro.org>
Subject: [RESEND v4 2/6] remoteproc: debugfs: Add ability to boot remote processor using debugfs
Date: Tue, 24 Nov 2015 13:14:18 +0000	[thread overview]
Message-ID: <1448370862-19120-3-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1448370862-19120-1-git-send-email-lee.jones@linaro.org>

This functionality is especially useful during the testing phase.  When
used in conjunction with Mailbox's Test Framework we can trivially conduct
end-to-end testing i.e. boot co-processor, send and receive messages to
the co-processor, then shut it down again (repeat as required).

Signed-off-by: Ludovic Barre <ludovic.barre@st.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/remoteproc/remoteproc_debugfs.c | 34 +++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/remoteproc_debugfs.c
index 9d30809..8113c18 100644
--- a/drivers/remoteproc/remoteproc_debugfs.c
+++ b/drivers/remoteproc/remoteproc_debugfs.c
@@ -88,8 +88,42 @@ static ssize_t rproc_state_read(struct file *filp, char __user *userbuf,
 	return simple_read_from_buffer(userbuf, count, ppos, buf, i);
 }
 
+static ssize_t rproc_state_write(struct file *filp, const char __user *userbuf,
+				 size_t count, loff_t *ppos)
+{
+	struct rproc *rproc = filp->private_data;
+	char buf[10];
+	int ret;
+
+	if (count > sizeof(buf))
+		return count;
+
+	ret = copy_from_user(buf, userbuf, count);
+	if (ret)
+		return -EFAULT;
+
+	if (buf[count - 1] == '\n')
+		buf[count - 1] = '\0';
+
+	if (!strncmp(buf, "start", count)) {
+		ret = rproc_boot(rproc);
+		if (ret) {
+			dev_err(&rproc->dev, "Boot failed: %d\n", ret);
+			return ret;
+		}
+	} else if (!strncmp(buf, "stop", count)) {
+		rproc_shutdown(rproc);
+	} else {
+		dev_err(&rproc->dev, "Unrecognised option: %s\n", buf);
+		return -EINVAL;
+	}
+
+	return count;
+}
+
 static const struct file_operations rproc_state_ops = {
 	.read = rproc_state_read,
+	.write = rproc_state_write,
 	.open = simple_open,
 	.llseek	= generic_file_llseek,
 };
-- 
1.9.1


WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND v4 2/6] remoteproc: debugfs: Add ability to boot remote processor using debugfs
Date: Tue, 24 Nov 2015 13:14:18 +0000	[thread overview]
Message-ID: <1448370862-19120-3-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1448370862-19120-1-git-send-email-lee.jones@linaro.org>

This functionality is especially useful during the testing phase.  When
used in conjunction with Mailbox's Test Framework we can trivially conduct
end-to-end testing i.e. boot co-processor, send and receive messages to
the co-processor, then shut it down again (repeat as required).

Signed-off-by: Ludovic Barre <ludovic.barre@st.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/remoteproc/remoteproc_debugfs.c | 34 +++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/remoteproc_debugfs.c
index 9d30809..8113c18 100644
--- a/drivers/remoteproc/remoteproc_debugfs.c
+++ b/drivers/remoteproc/remoteproc_debugfs.c
@@ -88,8 +88,42 @@ static ssize_t rproc_state_read(struct file *filp, char __user *userbuf,
 	return simple_read_from_buffer(userbuf, count, ppos, buf, i);
 }
 
+static ssize_t rproc_state_write(struct file *filp, const char __user *userbuf,
+				 size_t count, loff_t *ppos)
+{
+	struct rproc *rproc = filp->private_data;
+	char buf[10];
+	int ret;
+
+	if (count > sizeof(buf))
+		return count;
+
+	ret = copy_from_user(buf, userbuf, count);
+	if (ret)
+		return -EFAULT;
+
+	if (buf[count - 1] == '\n')
+		buf[count - 1] = '\0';
+
+	if (!strncmp(buf, "start", count)) {
+		ret = rproc_boot(rproc);
+		if (ret) {
+			dev_err(&rproc->dev, "Boot failed: %d\n", ret);
+			return ret;
+		}
+	} else if (!strncmp(buf, "stop", count)) {
+		rproc_shutdown(rproc);
+	} else {
+		dev_err(&rproc->dev, "Unrecognised option: %s\n", buf);
+		return -EINVAL;
+	}
+
+	return count;
+}
+
 static const struct file_operations rproc_state_ops = {
 	.read = rproc_state_read,
+	.write = rproc_state_write,
 	.open = simple_open,
 	.llseek	= generic_file_llseek,
 };
-- 
1.9.1

  parent reply	other threads:[~2015-11-24 13:16 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-24 13:14 [RESEND v4 0/6] remoteproc: Add driver for STMicroelectronics platforms Lee Jones
2015-11-24 13:14 ` Lee Jones
2015-11-24 13:14 ` Lee Jones
2015-11-24 13:14 ` [RESEND v4 1/6] remoteproc: dt: Provide bindings for ST's Remote Processor Controller driver Lee Jones
2015-11-24 13:14   ` Lee Jones
2015-11-24 13:14   ` Lee Jones
2015-11-25  0:07   ` Rob Herring
2015-11-25  0:07     ` Rob Herring
2015-12-28 18:33   ` Bjorn Andersson
2015-12-28 18:33     ` Bjorn Andersson
2015-12-28 18:33     ` Bjorn Andersson
2015-11-24 13:14 ` Lee Jones [this message]
2015-11-24 13:14   ` [RESEND v4 2/6] remoteproc: debugfs: Add ability to boot remote processor using debugfs Lee Jones
2015-11-27 17:00   ` Bjorn Andersson
2015-11-27 17:00     ` Bjorn Andersson
2015-11-27 17:00     ` Bjorn Andersson
2015-12-03 12:26     ` Lee Jones
2015-12-03 12:26       ` Lee Jones
2015-12-03 12:26       ` Lee Jones
2015-12-03 12:49       ` Arnd Bergmann
2015-12-03 12:49         ` Arnd Bergmann
2015-12-03 13:03         ` Lee Jones
2015-12-03 13:03           ` Lee Jones
2015-12-03 13:19           ` Arnd Bergmann
2015-12-03 13:19             ` Arnd Bergmann
2015-12-03 17:28             ` Lee Jones
2015-12-03 17:28               ` Lee Jones
2015-12-03 17:28               ` Lee Jones
2015-12-03 21:12               ` Arnd Bergmann
2015-12-03 21:12                 ` Arnd Bergmann
2015-12-03 21:22                 ` Bjorn Andersson
2015-12-03 21:22                   ` Bjorn Andersson
2015-12-03 21:22                   ` Bjorn Andersson
2015-12-04  8:24                 ` Lee Jones
2015-12-04  8:24                   ` Lee Jones
2015-12-28 18:38                   ` Bjorn Andersson
2015-12-28 18:38                     ` Bjorn Andersson
2015-12-28 18:38                     ` Bjorn Andersson
2016-01-12 10:53                     ` Lee Jones
2016-01-12 10:53                       ` Lee Jones
2016-01-12 10:53                       ` Lee Jones
2015-11-24 13:14 ` [RESEND v4 3/6] remoteproc: Supply controller driver for ST's Remote Processors Lee Jones
2015-11-24 13:14   ` Lee Jones
2015-12-28 18:33   ` Bjorn Andersson
2015-12-28 18:33     ` Bjorn Andersson
2015-12-28 18:33     ` Bjorn Andersson
2015-11-24 13:14 ` [RESEND v4 4/6] MAINTAINERS: Add ST's Remote Processor Driver to ARM/STI ARCHITECTURE Lee Jones
2015-11-24 13:14   ` Lee Jones
2015-11-24 13:14 ` [RESEND v4 5/6] ARM: STiH407: Add nodes for RemoteProc Lee Jones
2015-11-24 13:14   ` Lee Jones
2015-11-24 13:14 ` [RESEND v4 6/6] ARM: STiH407: Move over to using the 'reserved-memory' API for obtaining DMA memory Lee Jones
2015-11-24 13:14   ` Lee Jones
2015-11-26  8:45 ` [RESEND v4 0/6] remoteproc: Add driver for STMicroelectronics platforms Ohad Ben-Cohen
2015-11-26  8:45   ` Ohad Ben-Cohen
2015-11-26  9:10   ` Lee Jones
2015-11-26  9:10     ` Lee Jones
2015-11-26  9:10     ` Lee Jones
2015-11-26  9:32     ` Ohad Ben-Cohen
2015-11-26  9:32       ` Ohad Ben-Cohen
2015-11-26  9:32       ` Ohad Ben-Cohen
2015-12-28 18:41       ` Bjorn Andersson
2015-12-28 18:41         ` Bjorn Andersson
2015-12-28 18:41         ` Bjorn Andersson
2015-12-29  8:23         ` Ohad Ben-Cohen
2015-12-29  8:23           ` Ohad Ben-Cohen
2015-12-29  8:23           ` Ohad Ben-Cohen
2016-01-12 12:30           ` Lee Jones
2016-01-12 12:30             ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1448370862-19120-3-git-send-email-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=Nathan_Lynch@mentor.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=kernel@stlinux.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.barre@st.com \
    --cc=maxime.coquelin@st.com \
    --cc=ohad@wizery.com \
    --cc=s-anna@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.