* [PATCH 1/1] staging: coding style cleanups for staging/panel driver
@ 2015-12-18 9:18 Bijosh T
2015-12-18 12:54 ` Willy Tarreau
2015-12-18 16:01 ` Greg KH
0 siblings, 2 replies; 7+ messages in thread
From: Bijosh T @ 2015-12-18 9:18 UTC (permalink / raw)
To: gregkh; +Cc: willy, devel, linux-kernel, Bijosh T
From: Bijosh T <bijosh.thyks@gmail.com>
This patch fixes coding style errors for staging/panel driver.
Signed-off-by: Bijosh T <bijosh.thyks@gmail.com>
---
drivers/staging/panel/panel.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index 79ac192..04d86f3 100644
--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -947,7 +947,8 @@ static void lcd_clear_fast_s(void)
lcd_send_serial(0x5F); /* R/W=W, RS=1 */
lcd_send_serial(' ' & 0x0F);
lcd_send_serial((' ' >> 4) & 0x0F);
- usleep_range(40, 100); /* the shortest data takes at least 40 us */
+ /* the shortest data takes at least 40 us */
+ usleep_range(40, 100);
}
spin_unlock_irq(&pprt_lock);
@@ -1788,7 +1789,7 @@ static void phys_scan_contacts(void)
gndmask = PNL_PINPUT(r_str(pprt)) & scan_mask_i;
/* grounded inputs are signals 40-44 */
- phys_read |= (pmask_t) gndmask << 40;
+ phys_read |= (pmask_t)gndmask << 40;
if (bitmask != gndmask) {
/*
@@ -1804,7 +1805,7 @@ static void phys_scan_contacts(void)
w_dtr(pprt, oldval & ~bitval); /* enable this output */
bitmask = PNL_PINPUT(r_str(pprt)) & ~gndmask;
- phys_read |= (pmask_t) bitmask << (5 * bit);
+ phys_read |= (pmask_t)bitmask << (5 * bit);
}
w_dtr(pprt, oldval); /* disable all outputs */
}
--
2.5.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 1/1] staging: coding style cleanups for staging/panel driver
2015-12-18 9:18 [PATCH 1/1] staging: coding style cleanups for staging/panel driver Bijosh T
@ 2015-12-18 12:54 ` Willy Tarreau
2015-12-18 16:01 ` Greg KH
1 sibling, 0 replies; 7+ messages in thread
From: Willy Tarreau @ 2015-12-18 12:54 UTC (permalink / raw)
To: Bijosh T; +Cc: gregkh, willy, devel, linux-kernel
On Fri, Dec 18, 2015 at 02:48:58PM +0530, Bijosh T wrote:
> From: Bijosh T <bijosh.thyks@gmail.com>
>
> This patch fixes coding style errors for staging/panel driver.
>
> Signed-off-by: Bijosh T <bijosh.thyks@gmail.com>
Acked-by: Willy Tarreau <w@1wt.eu>
Thanks Bijosh,
Willy
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] staging: coding style cleanups for staging/panel driver
2015-12-18 9:18 [PATCH 1/1] staging: coding style cleanups for staging/panel driver Bijosh T
2015-12-18 12:54 ` Willy Tarreau
@ 2015-12-18 16:01 ` Greg KH
2015-12-19 6:25 ` Sudip Mukherjee
1 sibling, 1 reply; 7+ messages in thread
From: Greg KH @ 2015-12-18 16:01 UTC (permalink / raw)
To: Bijosh T; +Cc: devel, linux-kernel, willy
On Fri, Dec 18, 2015 at 02:48:58PM +0530, Bijosh T wrote:
> From: Bijosh T <bijosh.thyks@gmail.com>
>
> This patch fixes coding style errors for staging/panel driver.
>
> Signed-off-by: Bijosh T <bijosh.thyks@gmail.com>
I need a "full" name here, not just "T" as a last name, as odds are it's
a bit longer than just that one character...
Please fix up and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] staging: coding style cleanups for staging/panel driver
2015-12-18 16:01 ` Greg KH
@ 2015-12-19 6:25 ` Sudip Mukherjee
2015-12-19 7:02 ` Willy Tarreau
0 siblings, 1 reply; 7+ messages in thread
From: Sudip Mukherjee @ 2015-12-19 6:25 UTC (permalink / raw)
To: Bijosh T; +Cc: Greg KH, devel, linux-kernel, willy
On Fri, Dec 18, 2015 at 08:01:58AM -0800, Greg KH wrote:
> On Fri, Dec 18, 2015 at 02:48:58PM +0530, Bijosh T wrote:
> > From: Bijosh T <bijosh.thyks@gmail.com>
> >
> > This patch fixes coding style errors for staging/panel driver.
> >
> > Signed-off-by: Bijosh T <bijosh.thyks@gmail.com>
>
> I need a "full" name here, not just "T" as a last name, as odds are it's
> a bit longer than just that one character...
>
> Please fix up and resend.
While you are resending please also mention which coding style error you
have fixed.
regards
sudip
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] staging: coding style cleanups for staging/panel driver
2015-12-19 6:25 ` Sudip Mukherjee
@ 2015-12-19 7:02 ` Willy Tarreau
0 siblings, 0 replies; 7+ messages in thread
From: Willy Tarreau @ 2015-12-19 7:02 UTC (permalink / raw)
To: Sudip Mukherjee; +Cc: Bijosh T, Greg KH, devel, linux-kernel
On Sat, Dec 19, 2015 at 11:55:13AM +0530, Sudip Mukherjee wrote:
> On Fri, Dec 18, 2015 at 08:01:58AM -0800, Greg KH wrote:
> > On Fri, Dec 18, 2015 at 02:48:58PM +0530, Bijosh T wrote:
> > > From: Bijosh T <bijosh.thyks@gmail.com>
> > >
> > > This patch fixes coding style errors for staging/panel driver.
> > >
> > > Signed-off-by: Bijosh T <bijosh.thyks@gmail.com>
> >
> > I need a "full" name here, not just "T" as a last name, as odds are it's
> > a bit longer than just that one character...
> >
> > Please fix up and resend.
>
> While you are resending please also mention which coding style error you
> have fixed.
Well, they are so minor (mostly spaces) that anyone interested should
read the patch.
Willy
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/1] staging: coding style cleanups for staging/panel driver
@ 2015-12-18 19:20 Bijosh Thykkoottathil
2016-01-29 6:21 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Bijosh Thykkoottathil @ 2015-12-18 19:20 UTC (permalink / raw)
To: gregkh; +Cc: willy, devel, linux-kernel, Bijosh Thykkoottathil
From: Bijosh Thykkoottathil <bijosh.thyks@gmail.com>
This patch fixes coding style errors for staging/panel driver.
Signed-off-by: Bijosh Thykkoottathil <bijosh.thyks@gmail.com>
---
drivers/staging/panel/panel.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index 79ac192..04d86f3 100644
--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -947,7 +947,8 @@ static void lcd_clear_fast_s(void)
lcd_send_serial(0x5F); /* R/W=W, RS=1 */
lcd_send_serial(' ' & 0x0F);
lcd_send_serial((' ' >> 4) & 0x0F);
- usleep_range(40, 100); /* the shortest data takes at least 40 us */
+ /* the shortest data takes at least 40 us */
+ usleep_range(40, 100);
}
spin_unlock_irq(&pprt_lock);
@@ -1788,7 +1789,7 @@ static void phys_scan_contacts(void)
gndmask = PNL_PINPUT(r_str(pprt)) & scan_mask_i;
/* grounded inputs are signals 40-44 */
- phys_read |= (pmask_t) gndmask << 40;
+ phys_read |= (pmask_t)gndmask << 40;
if (bitmask != gndmask) {
/*
@@ -1804,7 +1805,7 @@ static void phys_scan_contacts(void)
w_dtr(pprt, oldval & ~bitval); /* enable this output */
bitmask = PNL_PINPUT(r_str(pprt)) & ~gndmask;
- phys_read |= (pmask_t) bitmask << (5 * bit);
+ phys_read |= (pmask_t)bitmask << (5 * bit);
}
w_dtr(pprt, oldval); /* disable all outputs */
}
--
2.5.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 1/1] staging: coding style cleanups for staging/panel driver
2015-12-18 19:20 Bijosh Thykkoottathil
@ 2016-01-29 6:21 ` Greg KH
0 siblings, 0 replies; 7+ messages in thread
From: Greg KH @ 2016-01-29 6:21 UTC (permalink / raw)
To: Bijosh Thykkoottathil; +Cc: devel, linux-kernel, willy
On Sat, Dec 19, 2015 at 12:50:56AM +0530, Bijosh Thykkoottathil wrote:
> From: Bijosh Thykkoottathil <bijosh.thyks@gmail.com>
>
> This patch fixes coding style errors for staging/panel driver.
>
> Signed-off-by: Bijosh Thykkoottathil <bijosh.thyks@gmail.com>
> ---
> drivers/staging/panel/panel.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
Someone sent this change before you, sorry :(
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-01-29 6:21 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-18 9:18 [PATCH 1/1] staging: coding style cleanups for staging/panel driver Bijosh T
2015-12-18 12:54 ` Willy Tarreau
2015-12-18 16:01 ` Greg KH
2015-12-19 6:25 ` Sudip Mukherjee
2015-12-19 7:02 ` Willy Tarreau
2015-12-18 19:20 Bijosh Thykkoottathil
2016-01-29 6:21 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.