From: "Shevchenko, Andriy" <andriy.shevchenko@intel.com>
To: "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"anton.wuerfel@fau.de" <anton.wuerfel@fau.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mail@maciej.szmigiero.name" <mail@maciej.szmigiero.name>,
"desmondl@broadcom.com" <desmondl@broadcom.com>,
"Zha, Qipeng" <qipeng.zha@intel.com>,
"heikki.krogerus@linux.intel.com"
<heikki.krogerus@linux.intel.com>,
"long.wanglong@huawei.com" <long.wanglong@huawei.com>,
"soeren.grunewald@desy.de" <soeren.grunewald@desy.de>,
"deller@gmx.de" <deller@gmx.de>,
"jslaby@suse.com" <jslaby@suse.com>,
"phillip.raffeck@fau.de" <phillip.raffeck@fau.de>,
"paul.burton@imgtec.com" <paul.burton@imgtec.com>,
"hpeter@gmail.com" <hpeter@gmail.com>,
"ralf@linux-mips.org" <ralf@linux-mips.org>,
"linux-kernel@i4.cs.fau.de" <linux-kernel@i4.cs.fau.de>,
"mans@mansr.com" <mans@mansr.com>,
"adam.lee@canonical.com" <adam.lee@canonical.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"jejb@parisc-linux.org" <jejb@par
Subject: Re: [PATCH v2 10/11] tty: serial: 8250: Replace printk by pr_*
Date: Fri, 18 Dec 2015 12:42:08 +0000 [thread overview]
Message-ID: <1450442546.30729.217.camel@intel.com> (raw)
In-Reply-To: <1450441926.30729.208.camel@linux.intel.com>
T24gRnJpLCAyMDE1LTEyLTE4IGF0IDE0OjMyICswMjAwLCBBbmR5IFNoZXZjaGVua28gd3JvdGU6
DQo+IE9uIEZyaSwgMjAxNS0xMi0xOCBhdCAxMjoyMiArMDEwMCwgQW50b24gV3VlcmZlbCB3cm90
ZToNCj4gDQo+IA0KPiA+IMKgVGhpcyBjb21lcyB3aXRoIGEgc2xpZ2h0IGNoYW5nZSBpbiBiZWhh
dmlvdXIgYXMNCj4gPiBwcl9kZWJ1ZyBpcyBjb25maWd1cmFibGUgdmlhIENPTkZJR19EWU5BTUlD
X0RFQlVHLCB3aGVyZWFzDQo+ID4gcHJpbnRrKEtFUk5fREVCVUcgLi4uKSBpcyBub3QuDQo+IA0K
PiAtLS0gYS9kcml2ZXJzL3R0eS9zZXJpYWwvODI1MC84MjUwX3BucC5jDQo+ID4gKysrIGIvZHJp
dmVycy90dHkvc2VyaWFsLzgyNTAvODI1MF9wbnAuYw0KPiA+IEBAIC00NjUsOSArNDY1LDkgQEAg
c2VyaWFsX3BucF9wcm9iZShzdHJ1Y3QgcG5wX2RldiAqZGV2LCBjb25zdA0KPiA+IHN0cnVjdCBw
bnBfZGV2aWNlX2lkICpkZXZfaWQpDQoNCk9uZSBtb3JlIHRoaW5nIGp1c3Qgbm90aWNlZCB0aGF0
IGlzIC0+cHJvYmUoKSBmdW5jdGlvbiB3aGVyZSB5b3UgaGF2ZQ0Kc3RydWN0IGRldmljZSBkZWZp
bmVkLCBpdCBtaWdodCBiZSB3b3J0aCB0byBjaGFuZ2UgdG8gZGV2XyogbWFjcm9zDQppbnN0ZWFk
IG9mIHByXyBhdCB0aGUgc2FtZSB0aW1lIGZvciBzb21lIGZ1bmN0aW9ucy4NCg0KU28sIGhlcmUg
aXQgd291bGQgYmUgZGV2X2RiZygmZGV2LT5kZXYsIOKApikgSSBzdXBwb3NlLg0KDQoNCi0tIA0K
QW5keSBTaGV2Y2hlbmtvIDxhbmRyaXkuc2hldmNoZW5rb0BpbnRlbC5jb20+DQpJbnRlbCBGaW5s
YW5kIE95DQotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0KSW50ZWwgRmlubGFuZCBPeQpSZWdpc3RlcmVkIEFkZHJlc3M6
IFBMIDI4MSwgMDAxODEgSGVsc2lua2kgCkJ1c2luZXNzIElkZW50aXR5IENvZGU6IDAzNTc2MDYg
LSA0IApEb21pY2lsZWQgaW4gSGVsc2lua2kgCgpUaGlzIGUtbWFpbCBhbmQgYW55IGF0dGFjaG1l
bnRzIG1heSBjb250YWluIGNvbmZpZGVudGlhbCBtYXRlcmlhbCBmb3IKdGhlIHNvbGUgdXNlIG9m
IHRoZSBpbnRlbmRlZCByZWNpcGllbnQocykuIEFueSByZXZpZXcgb3IgZGlzdHJpYnV0aW9uCmJ5
IG90aGVycyBpcyBzdHJpY3RseSBwcm9oaWJpdGVkLiBJZiB5b3UgYXJlIG5vdCB0aGUgaW50ZW5k
ZWQKcmVjaXBpZW50LCBwbGVhc2UgY29udGFjdCB0aGUgc2VuZGVyIGFuZCBkZWxldGUgYWxsIGNv
cGllcy4K
WARNING: multiple messages have this Message-ID (diff)
From: "Shevchenko, Andriy" <andriy.shevchenko@intel.com>
To: "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"anton.wuerfel@fau.de" <anton.wuerfel@fau.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mail@maciej.szmigiero.name" <mail@maciej.szmigiero.name>,
"desmondl@broadcom.com" <desmondl@broadcom.com>,
"Zha, Qipeng" <qipeng.zha@intel.com>,
"heikki.krogerus@linux.intel.com"
<heikki.krogerus@linux.intel.com>,
"long.wanglong@huawei.com" <long.wanglong@huawei.com>,
"soeren.grunewald@desy.de" <soeren.grunewald@desy.de>,
"deller@gmx.de" <deller@gmx.de>,
"jslaby@suse.com" <jslaby@suse.com>,
"phillip.raffeck@fau.de" <phillip.raffeck@fau.de>,
"paul.burton@imgtec.com" <paul.burton@imgtec.com>,
"hpeter@gmail.com" <hpeter@gmail.com>,
"ralf@linux-mips.org" <ralf@linux-mips.org>,
"linux-kernel@i4.cs.fau.de" <linux-kernel@i4.cs.fau.de>,
"mans@mansr.com" <mans@mansr.com>,
"adam.lee@canonical.com" <adam.lee@canonical.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"jejb@parisc-linux.org" <jejb@parisc-linux.org>,
"linux-parisc@vger.kernel.org" <linux-parisc@vger.kernel.org>,
"peter@hurleysoftware.com" <peter@hurleysoftware.com>,
"matt.redfearn@imgtec.com" <matt.redfearn@imgtec.com>,
"k.kozlowski@samsung.com" <k.kozlowski@samsung.com>
Subject: Re: [PATCH v2 10/11] tty: serial: 8250: Replace printk by pr_*
Date: Fri, 18 Dec 2015 12:42:08 +0000 [thread overview]
Message-ID: <1450442546.30729.217.camel@intel.com> (raw)
In-Reply-To: <1450441926.30729.208.camel@linux.intel.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1397 bytes --]
On Fri, 2015-12-18 at 14:32 +0200, Andy Shevchenko wrote:
> On Fri, 2015-12-18 at 12:22 +0100, Anton Wuerfel wrote:
>
>
> > Â This comes with a slight change in behaviour as
> > pr_debug is configurable via CONFIG_DYNAMIC_DEBUG, whereas
> > printk(KERN_DEBUG ...) is not.
>
> --- a/drivers/tty/serial/8250/8250_pnp.c
> > +++ b/drivers/tty/serial/8250/8250_pnp.c
> > @@ -465,9 +465,9 @@ serial_pnp_probe(struct pnp_dev *dev, const
> > struct pnp_device_id *dev_id)
One more thing just noticed that is ->probe() function where you have
struct device defined, it might be worth to change to dev_* macros
instead of pr_ at the same time for some functions.
So, here it would be dev_dbg(&dev->dev, …) I suppose.
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
WARNING: multiple messages have this Message-ID (diff)
From: "Shevchenko, Andriy" <andriy.shevchenko@intel.com>
To: "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"anton.wuerfel@fau.de" <anton.wuerfel@fau.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mail@maciej.szmigiero.name" <mail@maciej.szmigiero.name>,
"desmondl@broadcom.com" <desmondl@broadcom.com>,
"Zha, Qipeng" <qipeng.zha@intel.com>,
"heikki.krogerus@linux.intel.com"
<heikki.krogerus@linux.intel.com>,
"long.wanglong@huawei.com" <long.wanglong@huawei.com>,
"soeren.grunewald@desy.de" <soeren.grunewald@desy.de>,
"deller@gmx.de" <deller@gmx.de>,
"jslaby@suse.com" <jslaby@suse.com>,
"phillip.raffeck@fau.de" <phillip.raffeck@fau.de>,
"paul.burton@imgtec.com" <paul.burton@imgtec.com>,
"hpeter@gmail.com" <hpeter@gmail.com>,
"ralf@linux-mips.org" <ralf@linux-mips.org>,
"linux-kernel@i4.cs.fau.de" <linux-kernel@i4.cs.fau.de>,
"mans@mansr.com" <mans@mansr.com>,
"adam.lee@canonical.com" <adam.lee@canonical.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"jejb@parisc-linux.org" <jejb@par>
Subject: Re: [PATCH v2 10/11] tty: serial: 8250: Replace printk by pr_*
Date: Fri, 18 Dec 2015 12:42:08 +0000 [thread overview]
Message-ID: <1450442546.30729.217.camel@intel.com> (raw)
In-Reply-To: <1450441926.30729.208.camel@linux.intel.com>
On Fri, 2015-12-18 at 14:32 +0200, Andy Shevchenko wrote:
> On Fri, 2015-12-18 at 12:22 +0100, Anton Wuerfel wrote:
>
>
> > This comes with a slight change in behaviour as
> > pr_debug is configurable via CONFIG_DYNAMIC_DEBUG, whereas
> > printk(KERN_DEBUG ...) is not.
>
> --- a/drivers/tty/serial/8250/8250_pnp.c
> > +++ b/drivers/tty/serial/8250/8250_pnp.c
> > @@ -465,9 +465,9 @@ serial_pnp_probe(struct pnp_dev *dev, const
> > struct pnp_device_id *dev_id)
One more thing just noticed that is ->probe() function where you have
struct device defined, it might be worth to change to dev_* macros
instead of pr_ at the same time for some functions.
So, here it would be dev_dbg(&dev->dev, …) I suppose.
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
next prev parent reply other threads:[~2015-12-18 12:42 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 11:21 [PATCH v2 00/11] tty: serial: 8250: Fix checkpatch warnings Anton Wuerfel
2015-12-18 11:21 ` Anton Wuerfel
2015-12-18 11:21 ` Anton Wuerfel
2015-12-18 11:21 ` [PATCH v2 01/11] tty: serial: 8250: Fix whitespace errors Anton Wuerfel
2015-12-18 11:21 ` Anton Wuerfel
2015-12-18 11:21 ` Anton Wuerfel
2015-12-18 15:11 ` Peter Hurley
2015-12-18 15:11 ` Peter Hurley
2015-12-18 15:11 ` Peter Hurley
2015-12-18 11:21 ` [PATCH v2 02/11] tty: serial: 8250: Replace spaces with tabs Anton Wuerfel
2015-12-18 11:21 ` Anton Wuerfel
2015-12-18 11:21 ` Anton Wuerfel
2015-12-18 15:12 ` Peter Hurley
2015-12-18 15:12 ` Peter Hurley
2015-12-18 15:12 ` Peter Hurley
2015-12-18 11:21 ` [PATCH v2 03/11] tty: serial: 8250: Fix braces after struct Anton Wuerfel
2015-12-18 11:21 ` Anton Wuerfel
2015-12-18 11:21 ` Anton Wuerfel
2015-12-18 15:12 ` Peter Hurley
2015-12-18 15:12 ` Peter Hurley
2015-12-18 15:12 ` Peter Hurley
2015-12-18 11:21 ` [PATCH v2 04/11] tty: serial: 8250: Fix multiline comment style Anton Wuerfel
2015-12-18 11:21 ` Anton Wuerfel
2015-12-18 11:21 ` Anton Wuerfel
2015-12-18 15:33 ` Peter Hurley
2015-12-18 15:33 ` Peter Hurley
2015-12-18 15:33 ` Peter Hurley
2015-12-18 11:21 ` [PATCH v2 05/11] tty: serial: 8250: Remove else after return Anton Wuerfel
2015-12-18 11:21 ` Anton Wuerfel
2015-12-18 11:21 ` Anton Wuerfel
2015-12-18 15:37 ` Peter Hurley
2015-12-18 15:37 ` Peter Hurley
2015-12-18 15:37 ` Peter Hurley
2015-12-18 11:21 ` [PATCH v2 06/11] tty: serial: 8250: Move EXPORT_SYMBOL to function Anton Wuerfel
2015-12-18 11:21 ` Anton Wuerfel
2015-12-18 11:21 ` Anton Wuerfel
2015-12-18 15:38 ` Peter Hurley
2015-12-18 15:38 ` Peter Hurley
2015-12-18 15:38 ` Peter Hurley
2015-12-18 15:41 ` Peter Hurley
2015-12-18 15:41 ` Peter Hurley
2015-12-18 15:41 ` Peter Hurley
2015-12-18 11:21 ` [PATCH v2 07/11] tty: serial: 8250: Fix line continuation warning Anton Wuerfel
2015-12-18 11:21 ` Anton Wuerfel
2015-12-18 11:21 ` Anton Wuerfel
2015-12-18 15:41 ` Peter Hurley
2015-12-18 15:41 ` Peter Hurley
2015-12-18 15:41 ` Peter Hurley
2015-12-18 11:22 ` [PATCH v2 08/11] tty: serial: 8250: Add parentheses to macro Anton Wuerfel
2015-12-18 11:22 ` Anton Wuerfel
2015-12-18 11:22 ` Anton Wuerfel
2015-12-18 15:43 ` Peter Hurley
2015-12-18 15:43 ` Peter Hurley
2015-12-18 15:43 ` Peter Hurley
2015-12-18 11:22 ` [PATCH v2 09/11] tty: serial: 8250: Fix multi-line strings Anton Wuerfel
2015-12-18 11:22 ` Anton Wuerfel
2015-12-18 11:22 ` Anton Wuerfel
2015-12-18 15:45 ` Peter Hurley
2015-12-18 15:45 ` Peter Hurley
2015-12-18 15:45 ` Peter Hurley
2015-12-18 11:22 ` [PATCH v2 10/11] tty: serial: 8250: Replace printk by pr_* Anton Wuerfel
2015-12-18 11:22 ` Anton Wuerfel
2015-12-18 11:22 ` Anton Wuerfel
2015-12-18 12:32 ` Andy Shevchenko
2015-12-18 12:32 ` Andy Shevchenko
2015-12-18 12:32 ` Andy Shevchenko
2015-12-18 12:42 ` Shevchenko, Andriy [this message]
2015-12-18 12:42 ` Shevchenko, Andriy
2015-12-18 12:42 ` Shevchenko, Andriy
2015-12-18 15:10 ` Peter Hurley
2015-12-18 15:10 ` Peter Hurley
2015-12-18 15:10 ` Peter Hurley
2015-12-18 11:22 ` [PATCH v2 11/11] tty: serial: 8250: Fix indentation warnings Anton Wuerfel
2015-12-18 11:22 ` Anton Wuerfel
2015-12-18 11:22 ` Anton Wuerfel
2015-12-18 15:46 ` Peter Hurley
2015-12-18 15:46 ` Peter Hurley
2015-12-18 15:46 ` Peter Hurley
2015-12-18 15:17 ` [PATCH v2 00/11] tty: serial: 8250: Fix checkpatch warnings Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450442546.30729.217.camel@intel.com \
--to=andriy.shevchenko@intel.com \
--cc=adam.lee@canonical.com \
--cc=anton.wuerfel@fau.de \
--cc=deller@gmx.de \
--cc=desmondl@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hpeter@gmail.com \
--cc=jejb@par \
--cc=jslaby@suse.com \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=long.wanglong@huawei.com \
--cc=mail@maciej.szmigiero.name \
--cc=mans@mansr.com \
--cc=paul.burton@imgtec.com \
--cc=phillip.raffeck@fau.de \
--cc=qipeng.zha@intel.com \
--cc=ralf@linux-mips.org \
--cc=soeren.grunewald@desy.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.