* [PATCH] mwifiex: fix the incorrect WARN_ON during suspend
@ 2016-04-07 21:37 Vishal Thanki
2016-04-14 13:04 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Vishal Thanki @ 2016-04-07 21:37 UTC (permalink / raw)
To: akarwar, nishants, afenkart, linux-wireless; +Cc: Vishal Thanki
During system suspend, there is a kernel WARNING issued if there
is a pending command present. By marking the wait queue disabled
after calling the command completion routine fixes it.
Signed-off-by: Vishal Thanki <vishalthanki@gmail.com>
---
drivers/net/wireless/marvell/mwifiex/cmdevt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/cmdevt.c b/drivers/net/wireless/marvell/mwifiex/cmdevt.c
index a12adee..6f047064 100644
--- a/drivers/net/wireless/marvell/mwifiex/cmdevt.c
+++ b/drivers/net/wireless/marvell/mwifiex/cmdevt.c
@@ -1009,9 +1009,9 @@ mwifiex_cancel_all_pending_cmd(struct mwifiex_adapter *adapter)
spin_lock_irqsave(&adapter->mwifiex_cmd_lock, cmd_flags);
/* Cancel current cmd */
if ((adapter->curr_cmd) && (adapter->curr_cmd->wait_q_enabled)) {
- adapter->curr_cmd->wait_q_enabled = false;
adapter->cmd_wait_q.status = -1;
mwifiex_complete_cmd(adapter, adapter->curr_cmd);
+ adapter->curr_cmd->wait_q_enabled = false;
/* no recycle probably wait for response */
}
/* Cancel all pending command */
--
2.4.11
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: mwifiex: fix the incorrect WARN_ON during suspend
2016-04-07 21:37 [PATCH] mwifiex: fix the incorrect WARN_ON during suspend Vishal Thanki
@ 2016-04-14 13:04 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2016-04-14 13:04 UTC (permalink / raw)
To: Vishal Thanki; +Cc: akarwar, nishants, afenkart, linux-wireless, Vishal Thanki
> During system suspend, there is a kernel WARNING issued if there
> is a pending command present. By marking the wait queue disabled
> after calling the command completion routine fixes it.
>
> Signed-off-by: Vishal Thanki <vishalthanki@gmail.com>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-14 13:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-07 21:37 [PATCH] mwifiex: fix the incorrect WARN_ON during suspend Vishal Thanki
2016-04-14 13:04 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.