All of lore.kernel.org
 help / color / mirror / Atom feed
* Patch "USB: iowarrior: fix oops with malicious USB descriptors" has been added to the 4.5-stable tree
@ 2016-04-09 23:45 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2016-04-09 23:45 UTC (permalink / raw)
  To: jwboyer, gregkh, ralf; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    USB: iowarrior: fix oops with malicious USB descriptors

to the 4.5-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     usb-iowarrior-fix-oops-with-malicious-usb-descriptors.patch
and it can be found in the queue-4.5 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 4ec0ef3a82125efc36173062a50624550a900ae0 Mon Sep 17 00:00:00 2001
From: Josh Boyer <jwboyer@fedoraproject.org>
Date: Mon, 14 Mar 2016 10:42:38 -0400
Subject: USB: iowarrior: fix oops with malicious USB descriptors

From: Josh Boyer <jwboyer@fedoraproject.org>

commit 4ec0ef3a82125efc36173062a50624550a900ae0 upstream.

The iowarrior driver expects at least one valid endpoint.  If given
malicious descriptors that specify 0 for the number of endpoints,
it will crash in the probe function.  Ensure there is at least
one endpoint on the interface before using it.

The full report of this issue can be found here:
http://seclists.org/bugtraq/2016/Mar/87

Reported-by: Ralf Spenneberg <ralf@spenneberg.net>
Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/usb/misc/iowarrior.c |    6 ++++++
 1 file changed, 6 insertions(+)

--- a/drivers/usb/misc/iowarrior.c
+++ b/drivers/usb/misc/iowarrior.c
@@ -787,6 +787,12 @@ static int iowarrior_probe(struct usb_in
 	iface_desc = interface->cur_altsetting;
 	dev->product_id = le16_to_cpu(udev->descriptor.idProduct);
 
+	if (iface_desc->desc.bNumEndpoints < 1) {
+		dev_err(&interface->dev, "Invalid number of endpoints\n");
+		retval = -EINVAL;
+		goto error;
+	}
+
 	/* set up the endpoint information */
 	for (i = 0; i < iface_desc->desc.bNumEndpoints; ++i) {
 		endpoint = &iface_desc->endpoint[i].desc;


Patches currently in stable-queue which might be from jwboyer@fedoraproject.org are

queue-4.5/usb-serial-ftdi_sio-add-support-for-icp-das-i-756xu-devices.patch
queue-4.5/input-powermate-fix-oops-with-malicious-usb-descriptors.patch
queue-4.5/perf-tools-fix-python-extension-build.patch
queue-4.5/usb-iowarrior-fix-oops-with-malicious-usb-descriptors.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-04-09 23:46 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-09 23:45 Patch "USB: iowarrior: fix oops with malicious USB descriptors" has been added to the 4.5-stable tree gregkh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.